Matthew Khouzam [Thu, 17 Dec 2015 17:24:19 +0000 (12:24 -0500)] 
ctf: fix modifier order of @Nullable annotation
Change-Id: Ib5f40b243b6ecae25fda50dd09ef7c8df16e36f7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62951
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Marc-Andre Laperle [Thu, 17 Dec 2015 23:12:14 +0000 (18:12 -0500)] 
Fix main shell not active using Xvfb
There seems to be problems on some system where the main shell is not in
focus initially. This was seen using Xvfb and Xephyr on some occasions.
Change-Id: Ib6dda93e856deb96cf865dce6253b48c99171184
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62979
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Thu, 16 Jul 2015 01:31:57 +0000 (21:31 -0400)]
tmf.ctf: Accelerate ByteArrayDefintion parsing
Make BADs no longer need to generate definitions uselessly.
This patch yields a 15-50% acceleration in Synchronization benchmarks,
a 5% acceleration in the Kernel Analysis benchmark, and an average event
size reduction of 33%.
Change-Id: Ie581abaecf1d8b188de9f1acc3010fe3f7a65d7a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/52024
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Mon, 13 Jul 2015 14:39:19 +0000 (10:39 -0400)]
ctf: Collapse if statement in StructDefinition
Change-Id: I2736507e0ebbee70a172930cd4315c89872eb001
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51857
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:50:53 +0000 (18:50 -0500)] 
Remove all "AllTests" suites
tycho-surefire-plugin's default configuration is to look for @Tests
in classes that start or end with "Test", or end with "TestCase".
We can make use of this and avoid all the nested AllTests.java suites
found in every single test package in the tree. This also avoids
the need for most custom configuration in each test plugin's pom.xml.
To run a complete test plugin from within Eclipse, one can still
right-click on the plugin itself, and choose
Run As -> Junit Plug-in Test.
(Doing this before this patch would actually run all tests twice!)
Note: this breaks the suites in the "alltests" plugin, but those could
be brought back by using something like ClasspathSuite, if desired.
Change-Id: Ibf960df37c5d3c98dc0e0dd722d7c9fe5c0b9d4f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59442
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 17 Dec 2015 17:25:06 +0000 (12:25 -0500)] 
tmf: Fix GTK bug when setting top item after changing tree font
Change-Id: If2658c1bdcd98f6a34ce31a76af0dc57c959de2c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62953
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 17 Dec 2015 19:12:44 +0000 (14:12 -0500)]
analysis: Make SystemCallLatencyTableAnalysisTest more stable
Even if the jobs are finished, the table is not necessarily filled yet.
The update could be pending as a event in the UI thread queue, etc. We
can wait until cells are filled instead.
Also export the package so that it can be used elsewhere, (alltests
stress test for example).
Change-Id: I8177c7e6b7e487d59b248e0279c6bcd8da43b515
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62959
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 11 Dec 2015 20:57:01 +0000 (15:57 -0500)]
tmf: Support vertical zoom in time graph with Shift+Ctrl+Mouse Wheel
Change-Id: Ie5486855cd29c95ee3b0d7caad0ceac6c184d725
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62534
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-by: Hudson CI
Patrick Tasse [Wed, 16 Dec 2015 21:56:56 +0000 (16:56 -0500)]
tmf: Bug 484422: Fix inconsistent vertical zoom
In GTK3, after changing the tree font, the tree item bounds are not
updated until the tree has been painted. The alignment of tree items
should be done after a paint event has occurred.
Change-Id: I47617b881d3f0f981bdacf3ddda572c296dffaf7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62876
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Patrick Tasse [Fri, 11 Dec 2015 20:16:15 +0000 (15:16 -0500)]
doc: Update user guide for time graph markers and vertical zoom
Change-Id: Id4e16737c46492efebb643b75455855ee619e3e1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62531
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 2 Dec 2015 21:04:59 +0000 (16:04 -0500)]
ctf: make CtfTmfEvent expose packet context attributes
This patch allows acces to the packet context of an event from that
event.
Change-Id: I8409c8fbcb7766a2d7be4104159a7d7de6aa188d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61817
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 16 Dec 2015 03:16:11 +0000 (22:16 -0500)]
ctf: expose stream in CtfTmfEvent
This allows one to access the stream number. It may lead to improved UX later.
The stream ID can allow analyses to know which stream an event is coming
from. If a trace has a control channel and a data channel, this will
allow the events to be easily filtered into the appropriate views.
Change-Id: Iba9de10d9f1f633deed6df81c0d849acf5a3aceb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62779
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 2 Dec 2015 21:01:14 +0000 (16:01 -0500)]
ctf: Make packet descriptor information available to event
This allows the event to know what the packet context is for
its parent packet. This is especially useful if one puts non-
LTTng information in the packet such as the source gpu.
Change-Id: I21ff283c1032e5a3157408b304b2611d1113d4f7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61816
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 2 Dec 2015 21:07:40 +0000 (16:07 -0500)]
ctf: Expose map of attributes in Packet Descriptor
The motivation is to allow accessing custom fields in CTF
packet contexts. It decouples the CTF parser from LTTng a bit.
This breaks an unused api.
Change-Id: I2bead35a7e080d4e3ab325395629c44eea455cfc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61815
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 2 Dec 2015 20:41:59 +0000 (15:41 -0500)]
ctf: make SIPIE enums store both key and value
By adding the getStringValue and getIntegerValue,
instead of getValue, we have more information available.
This is useful for enums so we can look up the string
name but also sort it easier.
Change-Id: Icfa095a0a8c2b8924809c389dbfe53055c3b63be
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61814
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Tue, 15 Dec 2015 20:12:00 +0000 (15:12 -0500)]
ctf: Introduce ICTFStream
This allows a CTFStream to be shared while not being modifyiable.
Change-Id: I4bf4985abd5221ebfa543d0a7ff0cfeda0874fce
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62767
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 16 Dec 2015 03:35:31 +0000 (22:35 -0500)]
Disable overlay scrollbars when running tests to prevent crash
When running tests, the Eclipse launcher is not used which means
that the code that usually disables the overlay scrollbars is not
executed. The overlay scrollbars under GTK2 are unstable and can
cause crash. Specifically, a crash was frequently seen in
tmf.ui.swtbot.tests on Ubuntu.
Change-Id: I130d7fd95affa4f7eb68d2c2d1e0b0134e84ee07
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62780
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Matthew Khouzam [Mon, 13 Jul 2015 14:30:37 +0000 (10:30 -0400)]
ctf: make HashMap child a Map and extract lookupStructScope
The map is self explanatory. The method extraction improves readibility
in my opinion
Change-Id: I9fb23c3223641d80e2f70a18142c3d4b968f0dab
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/51854
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Marc-Andre Laperle [Tue, 15 Dec 2015 06:11:43 +0000 (01:11 -0500)]
tmf: Remove an annotation temporarily to work around Sonarqube bug
There is a Sonarqube bug with type annotations and arrays, see
https://groups.google.com/forum/#!topic/sonarqube/VTsAYxhGRiA
and
https://github.com/SonarSource/sonar-java/pull/537
By removing the @NonNull, it brings back a warning but makes the
Sonarqube build work again.
Change-Id: I6a03295432c7c452b4dca9018d4c17ba4b991980
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62684
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Patrick Tasse [Mon, 14 Dec 2015 15:55:14 +0000 (10:55 -0500)]
tmf: Keep usage of ViewerSorter in navigatorContent extension point
Reverting the change to TmfViewerSorter from commit
e707a55.
Platform UI doesn't support ViewerComparator in the
org.eclipse.ui.navigator.navigatorContent extension point in the
navigatorContent/commonSorter element (refer to Bug 484248).
This causes a ClassCastException and prevents the TMF project model
elements from being sorted properly.
Change-Id: I3d63032763dc435b594c3f9e8df04d0cb6b38609
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62640
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 14 Dec 2015 03:34:10 +0000 (22:34 -0500)]
releng: Fix alltests failure on Mac
The alltests plugin was failing on Mac because it tried to run 0 tests
on the UI thread but it needs to start on the first thread
(-XstartOnFirstThread). We can just set it to not un on the UI thread.
There is no need for the UI thread when running 0 tests.
Change-Id: I1e260f96e1ec51e256e8280262bcbd3c83a92de3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62574
Reviewed-by: Hudson CI
Marc-Andre Laperle [Mon, 14 Dec 2015 03:03:48 +0000 (22:03 -0500)]
tmf: FilterColorEditorTest on Mac
On Mac, RGB values that are captured with ImageHelper are affected by
monitor color profiles. To account for this, we can draw the expected
color in a simple shell and use that color as expected value instead.
Also, switching to the Filter mode in the table is not instantaneous,
we need to wait until it's done before capturing the next image.
Change-Id: I930570027ba53f3dbdcecb5925a8e67c24c239b2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62573
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Thu, 10 Dec 2015 20:34:16 +0000 (15:34 -0500)] 
tmf : Fix the xml condition multiple problem
This patch initiates the number of state values involved in a comparison
only when the xml element is <condition>. Without this fix, conditions
like OR or AND with more than two operands fail because we were
validating that the maximum number of state values was actually two.
Since the XSD validates that already the condition is removed in this
patch and the allocation of the state value list is done only when the
element is <condition>. In other cases, the list is instantiated to an
empty list.
This patch also add a test with a condition with three operands in
TmfXmlConditionTest to validate this case.
Change-Id: I6e99f770b35f3359a5617bc01b8a53bc77df637e
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62425
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Fri, 11 Dec 2015 19:53:23 +0000 (14:53 -0500)]
tmf: Fix existing trace not being reopened when it as a short path (Win)
This fixes the TestTraceOffsetting test.
On Windows, the temporary path can look like this:
java.io.tmpdir=C:\Users\MARC-A~1\AppData\Local\Temp\ Which is a "short
path". When used in comparison with full, canonical paths, it fails.
In the context of this bug, because the comparison failed, it ended up
creating a second trace for the same location then the test could not
find the proper editor because the title contained a '(2)'.
Change-Id: I41def2180ff910e25489415c9de513212d2f2ea2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62529
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Fri, 11 Dec 2015 18:22:34 +0000 (13:22 -0500)]
ctf: Fix InvalidPathException in CtfTmfTraceValidateTest on Windows
The path beeing passed to Paths.get was not a format supported (/C:/)
Change-Id: I80eb54ae3198381d91ab19c55c991004721d06dc
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62521
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Fri, 11 Dec 2015 17:37:09 +0000 (12:37 -0500)]
ctf: Fixed leaked file handle when calling CTFTraceReader.update
If an instance of CTFStreamInputReader already existed in a
CTFTraceReader, it was not getting closed after checking whether or not
it existed. This was causing a test failure on Windows in
CTFTraceGrowingTest.
Change-Id: Ia064d3270882515b32834456771a108970ce8f8e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62515
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Thu, 19 Nov 2015 23:44:35 +0000 (18:44 -0500)]
tmf: Bug 479675: Fix for index not being properly deleted on Windows
Change-Id: Idc97913cf34658452fef95f6e3ba502a57fc13ab
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60858
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Patrick Tasse [Thu, 10 Dec 2015 22:17:08 +0000 (17:17 -0500)]
doc: Update developer guide for time graph markers
Change-Id: I9d8b97e397b94359b8bf2f881f253bf8b19bd1a6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62434
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Tue, 8 Dec 2015 14:48:36 +0000 (09:48 -0500)]
tmf: Add vertical zooming support to time graph viewer and combo
Vertical zoom is triggered with Ctrl+"+" and Ctrl+"-". Reset is
triggered by Ctrl+"0".
Ctrl+"=" is equivalent to Ctrl+"+" for vertical zoom-in, and "=" is now
equivalent to "+" for horizontal zoom-in also.
The font of the time graph control is changed along with the zooming,
and the views with post-draw handling to draw labels on time graph items
are modified to use a new method which centers the text vertically.
Change-Id: Ic75c1ebe7e937c612b64346e2814894c500f964f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62359
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 8 Dec 2015 19:24:16 +0000 (14:24 -0500)]
Replace usage of ViewerSorter with ViewerComparator
The former has been deprecated in 4.6, it's now recommended to use
ViewerComparator and .setComparator() instead.
Change-Id: Ib7b447a74756b2b4524924f76b93ec0d64f71ed1
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/62262
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Mon, 7 Dec 2015 17:48:31 +0000 (12:48 -0500)]
lttng: Add SWTBot tests for Resources view and time graph markers
Change-Id: Ida3d7c7bed355f8032797d8074db3a9d8551eed2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62138
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Thu, 10 Dec 2015 15:33:05 +0000 (10:33 -0500)]
ctf: Delete and regenerate trace for tests in LttngKernelTraceGenerator
Later, this can be improved to be conditionally done only if the trace
generator version has changed.
Change-Id: I4d43f388d89d6bafba6c492a93e3d89c9ed9ed22
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62385
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 8 Dec 2015 19:35:03 +0000 (14:35 -0500)]
Use maven-enforcer-plugin to enforce minimum versions
<prerequisites> tags are not inherited by children. We can use
maven-enforcer-plugin to really check the Maven version.
See http://stackoverflow.com/q/
18055009/
4227853 .
It's not really clear if <prerequisites> is really deprecated
or not, but "mvn versions" complains if it is not present, so
we can at least leave it in the top-level pom.
While at it we can also configure it to check for the minimum
Java version the project needs (1.8).
Change-Id: I607c33e3fecf39d932ae7a44d58b85ce20336dc7
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/62280
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Sun, 29 Nov 2015 04:45:42 +0000 (23:45 -0500)]
Fix latest batch of null warnings
2f79cfb was about fixing the errors that cropped up with the new
version of JDT. This latest patch fixes the related warnings.
It introduces external @NonNull annotations to the following
methods in Guava's Multimap:
get()
keySet()
values()
The last two follow the same reasoning as the corresponding Map
methods. The first one, get(), may seem surprising. But Multimap's
get() is really @NonNull, it will at most return an empty Collection
if there are no values in the map matching the passed key.
Change-Id: Ie8dccff9491a8c0200b503ad76fd44092eb975e2
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/61929
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Tue, 3 Nov 2015 22:57:04 +0000 (17:57 -0500)]
analysis: Fix IndexOutOfBoundsException in ResourcesView
This can happen if a new IRQ or SoftIRQ attribute is created
concurrently with a zoom thread that has already queried the state
system for a full state that does not include the new attribute.
The zoom thread can then provide the full state to the ResourcesView to
get the event list of an IRQ or SoftIRQ entry that did not exist at the
time that the full state was created.
Change-Id: I1c5f8a8332f44b44f1954b01c3503a844dedc22e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59616
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Mon, 7 Dec 2015 17:46:51 +0000 (12:46 -0500)]
lttng: Keep tracing project between tests in KernelTest
This avoids having to wait for the same synthetic-trace to finishing
indexing for every test method.
Change-Id: Ib4e75dde2391ab3609d13923d0ebd5628d8477e9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62137
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Thu, 3 Dec 2015 18:33:13 +0000 (13:33 -0500)]
tmf: Fix duplicate trace check in TmfOpenTraceHelper
If the provided path was a convoluted path which resolved to the same
path as an existing trace location of the same name, it was incorrectly
considered a different trace and renamed with a numbered suffix.
Change-Id: Ic802cd5ffd83c5a29e422dfddbb0463aca1b372a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/62136
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Fri, 4 Dec 2015 23:01:44 +0000 (18:01 -0500)]
analysis: test SystemCallLatencyAnalysis
This test opens a trace, then opens the system call view to ensure
that the table is properly populated.
Change-Id: Id38c61ab64703cbe0333d00f1980073f0f339bda
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62042
Reviewed-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 3 Dec 2015 21:41:08 +0000 (16:41 -0500)] 
control: add swtbot test for testing load and save feature
Change-Id: I26068880a63c9a69a03d4b923ff05a1cfb679587
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61921
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Mon, 30 Nov 2015 12:22:18 +0000 (07:22 -0500)]
control: Add initial SWTBot tests for control view
Change-Id: Ibc3fdf3eaa00474d4b54ca799860c18143a2ecc8
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61900
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:50:17 +0000 (18:50 -0500)]
lttng: Don't call PlatformUI.getWorkbench() if the workbench is not running
Workaround for Bug 480948.
Change-Id: Ib461f802f496bbfe5ad1ecef7fdea85ffd674eee
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59294
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Fri, 4 Dec 2015 20:28:46 +0000 (15:28 -0500)]
analysis: Test SystemCallLatencyTableView
This series of unit tests tests the underlying widget with no analysis
or trace.
Change-Id: If30a333117691fb42545bc16b70b4a9e20c26237
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62033
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 8 Dec 2015 12:28:10 +0000 (07:28 -0500)]
control: Bug 483560: Refresh UI once after adding all children events
This will redraw the tree only once after all children event components
are added for channels, ust and kernel provider. Before this change the
UI was redrawn after each event.
Change-Id: If48ac0740be8884bcf52bb7f3da4a15859a3639f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62200
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 9 Dec 2015 16:25:36 +0000 (11:25 -0500)]
Add @since to doRun in AbstractTimeGraphView's ZoomThread
Change-Id: I214ae12c966bf6736c18cf66920158082accf1b7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62324
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Fri, 4 Dec 2015 20:29:39 +0000 (15:29 -0500)]
analysis: Allow SegementStoreContentProvider to accept Collection<ISegment>
This will allow easier testing. This also would also make the code easier to
re-use by removing part of the dependencies on segments.
Change-Id: I3d77a647306cae0c496ce894f5d326ddf1fd4e3b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62031
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 2 Dec 2015 23:46:04 +0000 (18:46 -0500)]
analysis: add statistics core tests for segments
Change-Id: Ie2ac17401f7f1e155c694ad26fd8ea2cb9ce792e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61835
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 2 Dec 2015 22:15:55 +0000 (17:15 -0500)]
analysis: add standard deviation to the segment store statistics
This patch will be useful for extracting more key metrics and flagging
outlyer segments.
Some reminders:
The standard deviation is the square root of the variance. The variance
is the sum of squared elements divided by the cardinality of a list. To
calculate the standard deviation incrementally, we keep an accumulator
of all the squares of a latency. This is then divided when needed by the
number of elements (segments) and square rooted.
Also, this patch calculates an online mean with less rounding errors.
Change-Id: Ia918f08f2351d7086bd05aac1ad645cfff13eb58
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61824
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 3 Dec 2015 22:08:43 +0000 (17:08 -0500)]
analysis: introduce os linux swtbot tests
Change-Id: Ib82f829852d75ebacf87e1bd60a91d788efff831
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61926
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Fri, 4 Dec 2015 20:32:37 +0000 (15:32 -0500)]
analysis: expose GetTableViewer in AbstractSegmentStoreTableView
This allows for easier testing.
Change-Id: I3ff2e08e2acd4887b25e805e080b74fc7509207a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62032
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Sun, 6 Dec 2015 02:16:45 +0000 (21:16 -0500)]
tmf: fix ctf validation tests due to missing traces
Certain test were not executed because trace files where not found.
This problem was introduced when the test traces repository was created
Change-Id: I81a88870615ef3188d7f50de41535e5dff76ff71
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62063
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Marc-Andre Laperle [Mon, 7 Dec 2015 22:10:17 +0000 (17:10 -0500)]
lttng: Make ControlFlowViewTest more robust
Added a condition to wait on. Added the concept of the view being dirty
so that we know if the view is ready or not. This required some rework
of the zoom thread methods to make it less error prone in keeping the
dirty flag consistent.
Change-Id: Ib73d84363e90aae1ca046c101f2086e3840b5bc2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62154
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Jean-Christian Kouame [Mon, 30 Nov 2015 23:35:47 +0000 (18:35 -0500)]
tmf : Add test suite for the XML conditions
Change-Id: I2a338f8b61cd920a7b3eb528be00aef696d6776b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61673
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Mon, 30 Nov 2015 17:56:48 +0000 (12:56 -0500)]
tmf : Add comparison between two state values in the XML core
Previously, it was only possible to compare a state value to a constant.
Now, we can compare directly two state values. With that, it is possible
to query and compare two state values already stored in the state
system. For now, only the "equal" operator is supported.
Change-Id: Iebbcb90c2c0603c5ec1191530e25dd3b0a1cf853
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61671
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:50:39 +0000 (18:50 -0500)]
Fix some null warnings
Change-Id: Ib0290125def1e0ea58bcf81c2075ef99db3f1f1a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59428
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Mon, 30 Nov 2015 12:13:37 +0000 (07:13 -0500)]
control: add service test cases for load and save commands
Change-Id: I3455c2c9df7cb43bca9fe0905d418bbe66ad0c38
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61554
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 30 Nov 2015 21:51:44 +0000 (16:51 -0500)]
ctf: Add lost events to synthetic LTTng kernel trace generator
The trace generator now creates packets with lost events pseudo-randomly
approximately once out of 10 times the number of channels.
The trace generator also now sets the content size of the last packet of
each channel so that the total number of events (including lost events)
is exactly the number of requested trace events.
Change-Id: Ie804e5650d5a4186225b5dfcc75526b0fe9c2704
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61599
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 30 Nov 2015 20:56:19 +0000 (15:56 -0500)]
ctf: Fix lost events timestamp in CTFPacketReader
The lost events should be inserted after the last event in the packet,
not before the first event in the packet.
This was a regression where the changes to CTFStreamInputPacketReader
from https://git.eclipse.org/r/50683 were not ported to CTFPacketReader.
Change-Id: I055887b02212bd43052d36fbbd0dde3ca36edb6e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61598
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Fri, 4 Dec 2015 18:03:55 +0000 (13:03 -0500)]
tmf : use of StringBuilder.append() instead of String operator +
Change-Id: I062c411af568289f5c17a279953703d720109119
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62015
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 16 Nov 2015 20:45:37 +0000 (15:45 -0500)]
tmf : remove occurrences of literals in FilterTreeLabelProvider.java
Change-Id: Ic30315e1bed6f360ec4760341ddee873891e43ee
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60555
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Sun, 6 Dec 2015 21:59:35 +0000 (16:59 -0500)]
common: Annotate String.split
This can't return null or null elements. Also cannot accept null
parameter. Fixes a warning in LTTngControlService.
Change-Id: Idb605e95fd20abfe8ecf73037bcc2a7b2e17dd70
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62075
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Marc-Andre Laperle [Sun, 6 Dec 2015 22:34:36 +0000 (17:34 -0500)]
common: Annotate Element.getAttribute
It cannot return null. It returns an empty String when the attribute is
not present. Fixes a warning in XmlViewInfo
Change-Id: Ia4b3ee9ccc2990597cbba16c2d0d1e3349a78bec
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62078
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Marc-Andre Laperle [Sun, 6 Dec 2015 22:23:48 +0000 (17:23 -0500)]
common: Annotate some Class.get*Name methods
This fixes a warning in AlgorithmManager. getName and getSimpleName
cannot return null whereas getCanonicalName can (anonymous, local
classes).
Change-Id: I2ee6ff668a93b47617389d2a3a25157af7184349
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62077
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Marc-Andre Laperle [Sun, 6 Dec 2015 22:09:18 +0000 (17:09 -0500)]
common: Annotate RandomAccessFile.readUTF
It can't return null. Fixes a warning in TmfUml2SDTestTrace
Change-Id: I7698d58639dc2099bed60c5f37c28a249d5fb22c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62076
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Jean-Christian Kouame [Mon, 30 Nov 2015 23:14:18 +0000 (18:14 -0500)]
tmf: Use prioritized List instead of Set in XmlStateProvider
This allows to have a kind of priority between the event handlers. It
helps to improve dependency between the event handlers. Now, when
receiving an event E, it is possible that the result of a handler X
depends of the change made by a handler Y on the same event.
Change-Id: I33592e907d4c2f024a46cc365f0bbe796e940049
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61672
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 27 Nov 2015 22:36:24 +0000 (17:36 -0500)]
ss: Avoid concatenating nonliterals in TmfStateInterval#toString()
Change-Id: Ia5a18114a73418ad677b7d8b3a606c2f67af36b2
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60557
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Thu, 26 Nov 2015 12:20:45 +0000 (07:20 -0500)]
remote: provide output listener for command execution
This listener interface will allow users of the ICommandShell to provide
2 callback methods to get intermediate results for the standard and
error output. Useful for long lasting command executions.
Change-Id: Ibc90bfd679226eee7ef34f170b63abd819bb75e5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61586
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Sun, 29 Nov 2015 03:36:40 +0000 (22:36 -0500)]
Fix new errors due to automatic annotation of Class<T> types
The null analysis now automatically assumes that generic class types
(the "T" in Class<T>) are always @NonNull. See bug 477719.
This clears a bunch of warnings we had due to using Something.class
as parameters. Great!
However, this introduces a new problem. When a generic type parameter
is used both as parameter and as return value, and the client specifies
an annotation on the parameter during a call, the default behaviour is
to assume this annotation on the return type too.
In some cases this assumption is correct:
List<@NonNull String>.get() returns a @NonNull String
But in some others it is not:
Map<@NonNull K, @NonNull V>.get() should *NOT* return a @NonNull V.
Now some methods of the form:
V something(Class<V> type);
also follow this pattern, and the "automatic" @NonNull applied to V
also gets applies to the return value. In some (most?) cases this is
incorrect, and we have to supply external annotations to change the
return value to @Nullable. Just like we did for Map.get().
See bug 483143 for more information.
The return values of the following methods are now annotated as
@Nullable:
Class.getAnnotation()
DsfServicesTracker.getService()
IRemoteConnection.getService()
IRemoteConnectionType.getService()
and related null-checks were added.
Change-Id: I2c60835160a46e88ff293a5fd68774021c2b00a9
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/61521
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 1 Dec 2015 17:06:33 +0000 (12:06 -0500)]
ctf: preserve byte order if explicitly set in a typedef
Change-Id: I904cd931da955f17b7cafa285f48d60c0c0358a1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61684
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 1 Dec 2015 22:44:08 +0000 (17:44 -0500)]
ctf: do not assume endianness of integers for singletons
Change-Id: I59ff6253564a05122da5b702e04b1f291f1b54fb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61709
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 1 Dec 2015 16:23:33 +0000 (11:23 -0500)]
common: Annotate ByteOrder#getNativeOrder
Change-Id: I6c64addc87111f2974bc0b97a527ebd8fd3f6b1f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61683
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 1 Dec 2015 16:22:53 +0000 (11:22 -0500)]
ctf: remove some null warnings in TmfTraceManagerTest
Change-Id: I403f87cfbaa018831f497d2374675ba224cc027d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61682
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Bernd Hufmann [Fri, 27 Nov 2015 20:36:28 +0000 (15:36 -0500)]
ust: Add initial SwtBot test for memory usage view
Change-Id: Ied9bb9b8539e3a15cc8facc6678f486c2e092558
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61504
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Tue, 24 Nov 2015 23:42:19 +0000 (18:42 -0500)]
common: Annotate some methods in ByteBuffer
Change-Id: Ib27143f9129b5be40a3bf996397c250509c24f40
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61206
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 30 Nov 2015 23:41:35 +0000 (18:41 -0500)]
pcap: Fix unused caching field
A field was meant to cache a map but was never set.
Change-Id: I9a7ff2c234a5af6d106ce8ade12936ff6a5bf1dd
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61602
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Thu, 19 Nov 2015 22:24:04 +0000 (17:24 -0500)]
tmf: Fix FontEventEditorTest on Mac
On Mac, the Preferences menu item is under the application name.
For some reason, we can't access the application menu so we use the
keyboard shortcut. This commits create a helper method in SWTBotUtils so
that this problem doesn't occur again when a new test wants to open the
preference window.
Change-Id: Ib4a76cd6d0f1b70965f83eaf4920aa55cf81835a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60857
Reviewed-by: Hudson CI
Marc-Andre Laperle [Tue, 24 Nov 2015 22:51:53 +0000 (17:51 -0500)]
tmf: Skip TestTraceOffsetting on Mac OS X 10.11.1 because of bug 481611
This is a work around for now, until 481611 is fixed.
Change-Id: Ifb95491107d20941a554f37f20728186a18c6760
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61201
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Fri, 27 Nov 2015 18:43:13 +0000 (13:43 -0500)]
control: add test for correct command line for adding context for UST
Change-Id: Idbd428f88dda62730a29d088c7852770ebe54c11
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61492
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Fri, 27 Nov 2015 18:41:48 +0000 (13:41 -0500)]
control: partly revert commit
0e7ea8ac and use clone in handlers
The patch that will be reverted here used copy constructors instead
of clone. However, using copy constructors the class type gets lost
in certain cases and this will cause different errors to happen.
For example, add context on a UST channel will send the command with
-k instead of -u. This is because a instanceof check for
ChannelCommandParameter fails since the object to check is a
CommandParameter instance and not ChannelCommandParameter.
I'll add a subsequent patch with a unit test for the add context case.
Change-Id: I01177bc1fad7eb100b204997b4572bf14cb5be61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61491
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:51:18 +0000 (18:51 -0500)]
Remove overloads of NonNullUtils#checkNotNull()
New errors have cropped up with the latest integration build. It seems
JDT is now stricter with regards to annotated generic types vs.
un-annotated ones (where before un-annotated was similar to @Nullable,
now we don't we away with it that easily).
Variants of checkNotNull() method that used to help the compiler now
seem to do more harm than good. Just deferring to the basic "T" one
fixes the new errors. Perhaps this should have been the ideal approach
all along?
Change-Id: If998d5554b5d85ac785d21365dfeeae5d6a48bb8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60650
Reviewed-by: Hudson CI
Alexandre Montplaisir [Tue, 24 Nov 2015 23:51:13 +0000 (18:51 -0500)]
tmf: Replace usage of SubProgressMonitor with SubMonitor
SubProgressMonitor is now deprecated, replace its usage with the
recommended SubMonitor instead. This fixes the staging target.
Change-Id: I9ae99c1e8da2da5a98c90ea2f45fbd0207d3b734
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60823
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 26 Nov 2015 16:19:55 +0000 (11:19 -0500)]
tmf: Fix for time-alignment bug
SashForm.setWeights() fails and throws runtime exceptions if
the sum of the passed values is 0 or if one of the values is
negative.
In some cases that include switching to a not-yet-initialized
Resource View, this situation could happen. Simply ignore sash
resize for invalid arguments. No need to time-sync an uninitialized
view anyway.
Change-Id: I3b7724795529ee91ae903ba3551491b5e0a7a645
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59881
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:51:00 +0000 (18:51 -0500)]
ss: Implement ISegment#getLength() as a default method
Change-Id: I0ab887f8bcecdebc1e66773ef50b63af3125090b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59880
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:50:31 +0000 (18:50 -0500)]
common: Add a checkNotNullContents() for arrays
For Collections we can easily go through a Stream and back
to call checkNotNullContents(Stream<T>), for arrays it's slightly
more complicated, so we might as well define a new method
specifically for arrays.
Also add some "tests" (not actual runnable tests, but just snippets
of code that should compile) to make sure the annotations are working
correctly.
Change-Id: I2d18ba912076ea98cfca3628e7c8d6077209f74b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59427
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:50:06 +0000 (18:50 -0500)]
common: Introduce a generic Stream flattener utility
This can be used to flatten data structures like trees, without
having to mess with recursive functions or visitor objects.
Change-Id: I3a30484a26f9112c624705c03e49529f5abac26e
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59293
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Fri, 27 Nov 2015 12:19:46 +0000 (07:19 -0500)]
ust: fix NPE in memory usage view caused by misplaced closing bracket
Change-Id: I64f1f1f9a087b1da2e44db3f0615b57a771b70ce
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61447
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Wed, 18 Nov 2015 21:24:01 +0000 (16:24 -0500)]
tmf : Remove of unused import
This commit removes the import of TmfXmlReadAndWriteModelFactory in
TmfXmlReadOnlyModelFactory.
Change-Id: Id4dafff6df5dc4c7fdc74dfcf84dc74de5ddd8f7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60752
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:22:40 +0000 (17:22 -0500)]
tmf : Use of Activator.logError() instead of System.out.println()
Change-Id: Ibe562bc26d1fbd150ff40134a1b900e3750dd7ed
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61080
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:38:25 +0000 (17:38 -0500)]
tmf : Remove inefficient new String(String) constructor
Change-Id: I1b55c12a6345f6198beafd750ec666611b6fd54b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61084
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:54:42 +0000 (17:54 -0500)]
lttng : Remove inefficient new String(String) constructor
Change-Id: I924a7b75f1fa22b1b45c3bb93b5bafa5b177f7b0
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61088
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jonathan Rajotte [Thu, 26 Nov 2015 22:50:01 +0000 (17:50 -0500)] 
tmf: log error before displaying message
Otherwise the error is logged only after the dialog is closed.
This is not a problem for normal use but for automated tests it can be
tricky since we can stop the test before closing the dialog and still look for
errors.
Change-Id: I1579fa166af2fbe5cd55fdb82b92d976171deaf6
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/61066
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 26 Nov 2015 16:08:02 +0000 (11:08 -0500)]
tmf: Fix missing dispose of traces in TmfTraceTest and TmfExperimentTest
Change-Id: Iaae97ccb2b953327c35a651dc86b654a87a5de7e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61351
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Tue, 24 Nov 2015 23:27:50 +0000 (18:27 -0500)]
tmf: Bug 477508: Fix wrong event count and ranks in TmfXmlTraceStub
The stub implementation of getNext() was increasing the context rank
twice per event. This would cause a wrong event count in the trace.
The processing of the 'set_aspects' dummy event was also causing the
context rank to be incremented twice. The XML Schema Definition is
changed to extract 'set_aspects' into its own element. The trace stub
now first parses the trace with a custom XML trace definition that only
processes the single 'set_aspects' event, then reinitializes the trace
with a custom XML trace definition that processes 'event' events.
Change-Id: Id1cf2251e364f892ab37511f0a5d99f2bcc2b5c6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61205
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 24 Nov 2015 23:13:14 +0000 (18:13 -0500)]
tmf: Fix unprocessed custom event content
If the custom event content is read before the event timestamp, it could
be undefined as the event data hasn't be processed yet. This can happen
in test code.
Change-Id: Idab415eb8015f1a7035bee11582d0baad89cad5b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61204
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Tue, 24 Nov 2015 04:27:46 +0000 (23:27 -0500)]
tmf: Try to make the shell fully visible in SWTBot at start
In certain environments, the workbench shell can be positioned at random
locations. Depending on the size of the display, it is possible that the
shell is not fully visible. This patch adds logic to the start of SWTBot
tests so that if the top shell is not fully visible, it will try to move
it in within the display bounds. If the shell cannot fit the display, it
will be positioned at the top-left corner of the display.
To be able to apply this to all test, a new utility method was
introduced, SWTBotUtils.initialize. More common code that is applicable
to all SWTBot tests could be moved there in the future.
This fix is important to some tests that can depend on whether of not
some controls get painted. For example, a drag listener is only added on
a sash when it gets first painted. If it is never painted,
TmfAlignTimeAxisTest fails when trying to drag this sash to verify the
proper behavior of time alignment.
Change-Id: Ic67739e204fcb0a4b567914e8b6078c286d56bd3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61094
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 24 Nov 2015 23:51:24 +0000 (18:51 -0500)]
lttng: Add a Binary Callsite aspect to the debug-info analysis
If the binary is not available at analysis time, we can still display
the binary file and offset information, which comes from the trace.
This information is also re-used by the source callsite.
Change-Id: I40993abedf7057fe6b27cb5c9e787f23e2331f13
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60843
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 23 Nov 2015 23:23:02 +0000 (18:23 -0500)]
Exclude Sonar rules that are not working with jdt.annotation
Since we have moved to jdt.annotation 2.0, a few Sonar rules (FindBugs)
do not work properly and report false positives. This resulted in
around 460 false issues in Sonar. We can disable those rules for now
until the problem is resolved. A bug report was filled at the FindBugs
project:
http://sourceforge.net/p/findbugs/bugs/1425/
The exclusions are done in the pom.xml so that any Sonar server can
benefit from this fix.
Change-Id: I31db810bc8a38d96870d94d5192139e6d74527b6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61292
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:46:55 +0000 (16:46 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Replace the use of StringBuilder with new String()
Change-Id: I64f00a6ef52c3348b361079f0507910b5525f621
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61075
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 22:52:34 +0000 (17:52 -0500)]
lttng : Remove inefficient new String(String) constructor
Change-Id: I964e7798a852e43674ee4eb1d7ad21574dc7bd0f
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61087
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:35:09 +0000 (16:35 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Change-Id: I0e55afcbb0bc7d8b22dcbc68185971dd043c5249
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61073
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 23 Nov 2015 21:40:54 +0000 (16:40 -0500)]
tmf : Avoid concatenating nonliterals in a StringBuilder
Change-Id: I78d9c69e192aab744b110909f050b556baa929d9
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61074
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
This page took 0.05014 seconds and 5 git commands to generate.
projects / deliverable / tracecompass.git / log
