Update tracepoint comments

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename TP_LOGLEVEL to tp_loglevel

Within the loglevel enumeration, the entries are not separated by a
comma. To match the style used for TP_FIELDS() ctf_*() entries, use
lower-case, which denotes that these entries must not be separated by
commas.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement tracepoint loglevel macros

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Handle sessiond application refusal with delayed retry

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix 32-bit compile type size warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Send bitness upon registration

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

USt test: fix 32-bit type warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix 32-bit type warning

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing patient_write.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ustctl: do not free object on release_object

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Do not install share.h (cleanup)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Do not install usterr-signal-safe

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove core.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Extend align.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement error.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused ARRAY_SIZE macro

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement __rb_same_type

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement lttng_ust_get_cpu()

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Cleanup: remove debug output

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust-tracepoint-event: fix probe creation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Compile fix following moved headers

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement ust-tracepoint-events under MIT license

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement tracepoint event reset header

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix tracepoint event related build errors

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Basic tracepoint event implementation

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement jhash from public domain source, apply LGPL license

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

More compile fixes

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix lib ring buffer compile errors

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix configure

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing extern to tracepoint.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Installed headers relicensing and cleanup

- Move all locally-used code outside of include/lttng.
- All headers included in applications for tracing are relicensed
  to MIT license, except for lttng/core.h and
  lttng/usterr-signal-safe.h, which both purposefully only contain
  trivial declarations are static inline functions/macros of 10 lines or
  less. They are therefore OK to include into non-GPL applications
  without being considered as derivative work under the terms of the
  LGPLv2.1 license.
- Update version number support.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

clock.h: ensure all functions are trivial (10 lines or less)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove old marker header files

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

usterr-signal-safe.h: ensure all macros are trivial (10 lines max)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement tracepoint-internal.h as LGPLv2.1 (not exported)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Relicense tests probe headers/tp.c files to MIT-style license

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove all LGPL-licensed headers

Remove all headers licensed under LGPLv2.1 for upcoming reimplementation
under the BSD-style MIT license.

Even though technically most of the content of these headers fall under
the exceptions of the LGPL:

"When a "work that uses the Library" uses material from a header file
that is part of the Library, the object code for the work may be a
derivative work of the Library even though the source code is not.
Whether this is true is especially significant if the work can be
linked without the Library, or if the work is itself a library.  The
threshold for this to be true is not precisely defined by law.

  If such an object file uses only numerical parameters, data
structure layouts and accessors, and small macros and small inline
functions (ten lines or less in length), then the use of the object
file is unrestricted, regardless of whether it is legally a derivative
work.  (Executables containing this object code plus portions of the
Library will still fall under Section 6.)"

Our intent is to make sure applications can include these headers
without having to be considered derived code.

Therefore, the license of align.h, bug.h, ringbuffer-abi.h and
ringbuffer-config.h, ust-abi.h, ust-events.h, vatomic.h are changed to
MIT license (I, Mathieu Desnoyers, am the sole author of these files and
agree to these changes).

I am removing tracepoint-event.h, tracepoint-internal.h,
tracepoint-types.h, tracepoint.h, ust-tracepoint-event-reset.h and
ust-tracepoint-event.h because those might be considered derived work
from Ftrace.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint: evaluate arguments within test block

> On Thu, 2011-11-17 at 04:55 +0100, Eric Dumazet wrote:
> > The general admitted claim of a tracepoint being on x86 a single
> > instruction :
> >
> > jmp +0
> >
> > Is not always true.
> >
> > For example in mm/slub.c, kmem_cache_alloc()
> >
> > void *ret = slab_alloc(s, gfpflags, NUMA_NO_NODE, _RET_IP_);
> > trace_kmem_cache_alloc(_RET_IP_, ret, s->objsize, s->size, gfpflags);
> > return ret;
> >
> > We can check compiler output and see that 4 extra instructions were
> > added because s->objsize & s->size are evaluated.
> >
> > I noticed this in a perf session, because these 4 extra instructions
> > added some noticeable latency/cost.
> >
> > c10e26a4:       8b 5d d8                mov    -0x28(%ebp),%ebx
> > c10e26a7:       85 db                   test   %ebx,%ebx
> > c10e26a9:       75 6d                   jne    c10e2718   (doing the memset())
> > c10e26ab:       8b 76 0c                mov    0xc(%esi),%esi   // extra 1
> > c10e26ae:       8b 5d 04                mov    0x4(%ebp),%ebx   // extra 2
> > c10e26b1:       89 75 f0                mov    %esi,-0x10(%ebp) // extra 3
> > c10e26b4:       89 5d ec                mov    %ebx,-0x14(%ebp) // extra 4
> > c10e26b7:       e9 00 00 00 00          jmp    c10e26bc
> > c10e26bc:       8b 45 d8                mov    -0x28(%ebp),%eax
> > c10e26bf:       83 c4 28                add    $0x28,%esp
> > c10e26c2:       5b                      pop    %ebx
> > c10e26c3:       5e                      pop    %esi
> > c10e26c4:       5f                      pop    %edi
> > c10e26c5:       c9                      leave
> >
> >
> > A fix would be to not declare an inline function but a macro...
> >
> > #define trace_kmem_cache_alloc(...) \
> >     if (static_branch(&__tracepoint_kmem_cache_alloc.key)) \
> >             __DO_TRACE(&__tracepoint_kmem_cache_alloc,      \
> >                     ...
> >
> > Anyone has some clever idea how to make this possible ?

Do this by moving the test into the tracepoint() macro.

Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove console output that should be turned into debug

But no debug log facility for this library which is included in
sessiond (yet).

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Document LGPL TRACEPOINT_CREATE_PROBES restrictions

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

tracepoint: support TP_ARGS(void)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix multiple probe generation into one single C file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove run from makefile

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add demo program

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Allow release object to have -1 sock param

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

initiate lttng-ust-comm printout cleanup

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix fork handling, where child shares shm with parent

Consider that consumer does most of the finalize/flush, so we don't need
to perform them in teardown.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Remove unused libringbuffer/ring_buffer_abi.c

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update comment

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint API change: combine TP_PROTO and TP_VARS into TP_ARGS, remove _NOARGS macros

New API for tracepoints, combining the TP_PROTO and TP_VARS arguments
into a single "TP_ARGS" macro. It takes up to 10 parameters (from 0 to
10). The "_NOARGS" special-case is not needed anymore: it can be
achieved simply by passing an empty TP_ARGS:

  TP_ARGS(),

to the standard tracepoint event declarations.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoints: add provider mismatch check

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint API change: rename TRACEPOINT_SYSTEM to TRACEPOINT_PROVIDER

Eliminates the confusion between the first TRACEPOINT_EVENT "provider"
argument and the "TRACEPOINT_SYSTEM", which need to be the same thing.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Merge branch 'master' of git.lttng.org:/home/git/lttng-ust

tracepoint API change: rename TP_ARGS to TP_VARS

In preparation of folding of both TP_PROTO and TP_ARGS into TP_ARGS.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

lttng-ust-comm: relicense to LGPLv2.1

This internal communication library is used by both lttng-sessiond and
lttng-ust. lttng-ust is LGPLv2.1, so we need to make this library
LGPLv2.1 to ensure licensing is respected.

However, we now keep this library internal to liblttng-ust and
liblttng-ust-ctl. It is not installed into the system anymore. Only the
lttng-sessiond (or another GPLv2-compatible session daemon) is meant to
control liblttng-ust through the GPLv2 liblttng-ust-ctl control library.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <david.goulet@polymtl.ca>
Signed-off-by: Julien Desfossez <julien.desfossez@polymtl.ca>

Do not install liblttng-ust-comm and ust-comm.h

Only used internally by liblttng-ust-ctl and liblttng-ust.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix metadata tp listing filtering

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Don't list metadata tracepoint

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add delay parameter to hello test program

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Define ltt_transport_list as static

Fix uninitialized state at constructor execution.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Clean unused vars. warnings

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing core.c file

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement ustctl_tracepoint_list/list_get

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Implement LTTNG_UST_TRACEPOINT_LIST

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

update char limit comment in tracepoint

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move libringbuffer and comm connect messages to debug level

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Tracepoint API change: add provider field

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

init private data

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move struct ltt_channel to shm for consumer flush

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix problem with including libringbuffer/smp.h in make-dist

"make dist" currently produces a tarball that is missing
librinbuffer/smp.h, resulting in a build failure when an attempt to
compile the tarball is make.  This patch addresses the issue by properly
including the file in Makefile.am.

Signed-off-by: Gregory Haskins <gregory.haskins@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix shadow channel struct callback override in consumer

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Allow consumer to flush buffers, fix alignment bug

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

flush buffer returns void

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Zero out callback pointers in consumer process

They cannot be used anyway.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Allow flush buffer for inactive producer (flush mode)

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update flush buffer: allow consumer to do it directly

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

fix make dist: adding missing headers to makefiles

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix make dist: check if java lib should be built in toplevel makefile too

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Fix make dist dep for tests/hello

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing headers to install to makefile.am

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add missing header

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

install processor.h, needed by core.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add check for libuuid to configure.ac

libuuid is needed by the ring-buffer library.

Signed-off-by: Alexandre Montplaisir <alexandre.montplaisir@polymtl.ca>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename ust.pc.in to lttng-ust.pc.in

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update local comm socket path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update lttng-sessiond communication socket path

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename UST.class to LTTNG_UST.class

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename package to lttng-ust

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

library mass rename: add lttng- prefix

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update readme

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move include/ust/ to include/lttng/

Keep all lttng project files under the same toplevel directory.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add lttng_ust_ prefix before objd_unref

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Add lttng_ust prefix before struct obj and struct objd_ops

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename ltt_events_exit to lttng_ust_events_exit

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Update to use caa_likely/caa_unlikely from urcu 0.6.6

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename struct lib_ring_buffer* to struct lttng_ust_lib_ring_buffer*

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Rename shm_handle to lttng_ust_shm_handle

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

Move lttng_ust_object_data et lttng_ust_channel_attr to -abi.h

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

rename object_data to lttng_ust_object_data

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

futex error should be a warning

* Matthew Khouzam (matthew.khouzam@ericsson.com) wrote:
> Hi tracing warlords,
> I am testing UST 2.0 on ubuntu Lucid Lynx, and I got the following
> message while running a program:
> libust[22376/22377]: Error: Linux kernels 2.6.33 to 3.0 (with the
> exception of stable versions) do not support FUTEX_WAKE on read-only
> memory mappings correctly. Please upgrade your kernel (fix is commit
> 9ea71503a8ed9184d2d0b8ccc4d269d05f7940ae in Linux kernel mainline).
> LTTng-UST will use polling mode fallback. (in wait_for_sessiond() at
> lttng-ust-comm.c:564)
>
> I think since there is a fallback, and this is not a showstopper just an
> irritation that it should be a warning.

Reported-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>