Mathieu Rail [Sun, 30 Mar 2014 23:03:32 +0000 (19:03 -0400)]
TMF: Implement analysis requirements for config element helpers
Change-Id: I4c467ecba03c9fa5ef886cf328d60ec9249b8841
Signed-off-by: Mathieu Rail <contact@mathieurail.com>
Reviewed-on: https://git.eclipse.org/r/24286
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Guilliano Molaire [Wed, 23 Apr 2014 16:51:11 +0000 (12:51 -0400)]
TMF: Possibility to generate a session configuration from a ISessionInfo
With this feature we are able to generate a XML session configuration which
can be used to recreate a trace session on the target side.
Change-Id: I9786f322842b5166376f67d522907fa6bdc84edb
Signed-off-by: Guilliano Molaire <guilliamo-jaime.molaire@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/23425
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
François Rajotte [Fri, 25 Apr 2014 21:56:22 +0000 (17:56 -0400)]
TMF: speed up XML view entry start and end time queries
Change-Id: I6ad6a2484cd569fe0d1ce8a6f7449aba924f4578
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/25598
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Geneviève Bastien [Tue, 22 Apr 2014 19:53:30 +0000 (15:53 -0400)]
LTTng: Remove dependency to LttngKernelTrace in Lttng Kernel analysis module
The helper's appliesToTraceType and the analysis's canExecute methods already
verify if a trace has the necessary requirements to be able to execute the
analysis and it shouldn't matter if it's not the same class.
Also added a unit test that tests the execution of the analysis itself.
Change-Id: Ifeb9ce54165c2ad2d8b8258c3f465a18433c4969
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/25381
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Florian Wininger [Thu, 24 Apr 2014 17:30:29 +0000 (13:30 -0400)]
tmf: HTNode coding style improvement.
Change-Id: I9f298cdff2d583a738d7926ad5ba2b0fcd07bd9d
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/25512
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 24 Apr 2014 02:03:55 +0000 (22:03 -0400)]
lttng: Use SWTBot test runner to capture screenshots on failure
Change-Id: I19315bc959bea3d2aa708be1cb6c0183ca7d9dd5
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25454
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jeff Johnston [Fri, 25 Apr 2014 19:18:48 +0000 (15:18 -0400)]
Remove old 2011 license stuff from all feature.properties files
- tycho adds the license info automatically to the feature.properties
files that end up in the output jar files
Change-Id: Ic6d32db0c2cea75c06fb811674ec82b2026d5943
Reviewed-on: https://git.eclipse.org/r/25585
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
Andrew Ferrazzutti [Fri, 25 Apr 2014 14:05:37 +0000 (10:05 -0400)]
Change tabs to spaces; elim trailing whitespace.
To comply with Sonar style requirements, replace all tab characters
with four whitespace characters/spaces, and remove all trailing
whitespace. Perform this change to all Java and XML files.
Also replace tabs with "\t" in test strings that require tabs,
and edit STPIndenterTest so that it doesn't rely on indented comments.
Change-Id: I48c3c5449a58fe5310967d998a05df1a28fbcbb0
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/25561
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
Matthew Khouzam [Fri, 25 Apr 2014 17:30:35 +0000 (13:30 -0400)]
ctf: java 8 compliance of javadoc
Change-Id: I9ad7d732f606365bcdef1608b7c98c6577558e25
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25579
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Thu, 10 Apr 2014 20:01:09 +0000 (16:01 -0400)]
tracing rcp: update versions to 1.0
Change-Id: If166123d8505ae09cdc34b563930edcb381821e4
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24859
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 25 Apr 2014 19:35:32 +0000 (15:35 -0400)]
Revert "TMF: Add an analysis requirement helper"
This reverts commit
13df50ce83e1c57b7d3750a9da8e055b6be3f1d2.
Change-Id: I0919eca8a998457166e0105185a73779dab622f7
Reviewed-on: https://git.eclipse.org/r/25588
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Guilliano Molaire [Mon, 21 Apr 2014 15:07:29 +0000 (11:07 -0400)]
TMF: Add an analysis requirement helper
The helper can get lists of requirement values from one or several analysis
requirement providers.
Change-Id: I16287dd1bbaf99a7f15767ef7d044a81e48457dc
Signed-off-by: Guilliano Molaire <guilliamo-jaime.molaire@polymtl.ca>
Signed-off-by: Mathieu Rail <contact@mathieurail.com>
Reviewed-on: https://git.eclipse.org/r/24285
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bernd Hufmann [Thu, 10 Apr 2014 20:00:08 +0000 (16:00 -0400)]
releng: add LTTng RCP features to Linux Tools update sites
This will allow users to base a customized RCP on the standard tracing
RCP.
Also update lisence information and update site reference in the
RCP features and plug-ins.
Change-Id: I0927095a6818f7a4079c0be05dd7c19e0b22a557
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24858
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 21 Apr 2014 21:03:14 +0000 (17:03 -0400)]
tmf: Split the state system in a separate plugin
TMF will depend on this new plugin, but it will allow the state
system infrastructure to be used outside of TMF.
No need for a new feature though, since this is not a user-visible
feature (the TMF feature will include this new plugin).
Change-Id: Ie69b15fef325a126cf9606bb0f2250771861f74f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25332
Marc-Andre Laperle [Fri, 25 Apr 2014 14:30:29 +0000 (10:30 -0400)]
ctf: Don't include all test traces in jar
Change-Id: Icb6a85f897ec2fe0aa8c3a116edd5ae9a76cb8a3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25563
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Fri, 25 Apr 2014 02:55:53 +0000 (22:55 -0400)]
ctf: make MetadataPacketHeader more inline with coding style
This fixes some sonar warnings
Change-Id: I67b401823d28cedf84d164af8ffe8a6fa01b6afe
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25531
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Wed, 23 Apr 2014 11:45:41 +0000 (07:45 -0400)]
lttng: clear CPU Usage view when closing a trace (bug 433191)
Change-Id: Ifc0b82606992e32d465d5e0a09abcb27d62e27fa
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25401
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 22 Apr 2014 19:57:28 +0000 (15:57 -0400)]
lttng: Dispose CpuUsageView properly (bug 433212)
Change-Id: Icf14fd5ae9ab9121171216d1b476df209b0a7c9e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25380
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jeff Johnston [Thu, 24 Apr 2014 19:20:30 +0000 (15:20 -0400)]
Replace feature licenses with new 2014 license.
Change-Id: Ib5471ff3a6f4dc66fd6e42038574b42a0d62d612
Reviewed-on: https://git.eclipse.org/r/25515
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
Matthew Khouzam [Fri, 25 Apr 2014 02:48:17 +0000 (22:48 -0400)]
Revert "ctf: make MetadataPacketHeader more inline with coding style"
This reverts commit
2ce5d7294581df7698ccd84f86ebd4d5ab11b392.
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Wed, 23 Apr 2014 23:13:10 +0000 (19:13 -0400)]
lttng: Add test suite to run all SWTBot tests
Also fix a refresh problem that occured while
running the new suite.
Change-Id: If21127aaee72acffd533203c6fd5e2fce3274330
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25453
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 17 Apr 2014 19:25:14 +0000 (15:25 -0400)]
lttng: Don't call parse event unless necessary
Getting the even content will slow down parsing with lazy loaded
events and should only be done as needed.
Change-Id: Id7b3e39b5ad05459769a8679c5347413721ff9ba
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25235
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Fri, 25 Apr 2014 02:05:08 +0000 (22:05 -0400)]
ctf: make MetadataPacketHeader more inline with coding style
Change-Id: Icafec1945eeb7edbe579a2fc05b20f4f0da7176e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Florian Wininger [Mon, 10 Mar 2014 19:42:47 +0000 (15:42 -0400)]
TMF: Introduce the XML state system view for data driven outputs
Change-Id: I3ecf738e918be7b52075706f85c3f842c737b712
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/23161
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Tue, 22 Apr 2014 13:23:09 +0000 (09:23 -0400)]
tmf: Implement toString() for project model elements
Helps debugging.
Change-Id: Ic63193345bf4c48ef5b2fa3328f37a1115f9a18b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/25351
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 17 Apr 2014 14:32:54 +0000 (10:32 -0400)]
tmf: Fix another TimeRangeException in TmfStateStatistics
The exception occurs when the requested range is completely out of the
range of the state system, for example with an experiment containing two
traces that do not intersect.
Also changed exception handling so that StateSystemDisposedException is
ignored, and runtime exceptions are not caught.
Change-Id: Icbe242c7c875ebe7873b0ce88b09499444bc8e00
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/25212
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Florian Wininger [Thu, 10 Apr 2014 22:36:31 +0000 (18:36 -0400)]
tmf : Add Leaf nodes to the History Tree
This patch allows the use of leaf nodes in the History Tree. A leaf node
cannot contain children, so we can save 50 x (int + long) = 600 bytes
for each node (64k).
Note that this patch changes the on-disk file format of the history tree.
FILE_VERSION is bumped accordingly.
Change-Id: I4d99727a23fcdfbdd911fd27c621354864ebfde1
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24791
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Marc-Andre Laperle [Mon, 21 Apr 2014 21:55:45 +0000 (17:55 -0400)]
[tmf] NPE when renaming a trace with no trace type when inside an experiment
Bug: 433161
Change-Id: If56a288d9b4d16df9dd827a4b016e4970eff2cc2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25330
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Tue, 15 Apr 2014 04:19:11 +0000 (00:19 -0400)]
lttng: Add filtering textbox to the event selection composites
Change-Id: I9de3eb026841b4fb7a85ba14305c569e7e9a24aa
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25019
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 23 Apr 2014 18:06:25 +0000 (14:06 -0400)]
lttng: Work around UI thread sleeping forever on Mac in tests
bug: 415992
Change-Id: I43ff1961eb02c9978a9650d39fcbff9d018e9ccd
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25443
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 23 Apr 2014 05:28:47 +0000 (01:28 -0400)]
tmf: Wait until shell is active in swtbot test
Change-Id: Ia7a4a14048ae919717cf17ea3ec095ea212c7b1e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25385
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Fri, 11 Apr 2014 21:16:59 +0000 (17:16 -0400)]
tmf: Experiment performance benchmark
Change-Id: Id1994474b2cf479e00d5482e1aa2c170e5ce4ba2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24885
Tested-by: Hudson CI
Geneviève Bastien [Mon, 10 Mar 2014 19:38:44 +0000 (15:38 -0400)]
TMF: Add an XML model factory and classes for read-only state system components
Factory for XML model element used in a read-only context. The state attributes
will not be added to the state system.
Change-Id: Ibfb5a35ecbc723ecc12c47c6461a389d5290e918
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23160
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Mon, 21 Apr 2014 14:21:13 +0000 (10:21 -0400)]
tmf: Fix deadlock in analysis module
Deadlock occurred when renaming a trace while its analyses are ongoing.
The refresh of supplementary folders is now done outside of the analysis
synchronization lock.
It is not necessary to trigger the refresh when cancel() is called,
since it will be triggered when the analysis execution is completed
(whether it was cancelled or not).
Change-Id: Id65fe9d57fadab1d17096d7e20bb15f43d30f1c7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/25323
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Wed, 23 Apr 2014 17:31:53 +0000 (13:31 -0400)]
tmf: Temporarily disable hanging tests
Change-Id: I88abd2b8a4e411a361592fb8e6239b942e164286
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25432
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Tue, 22 Apr 2014 12:37:38 +0000 (08:37 -0400)]
lttng-tmf: Update dependecies to new tmf.ctf feature
Change-Id: I3a9e8d544cfbc988704d15e891cdd92e736bebb6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/25344
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Tue, 22 Apr 2014 16:57:41 +0000 (12:57 -0400)]
tmf: Fix NullPointerException in ControlFlowView
This could happen if the state system is disposed while the BuildThread
is running.
Change-Id: I30f443eca7ef809f4abacc4ddc5e155576c500d5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/25376
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 17 Apr 2014 20:10:35 +0000 (16:10 -0400)]
tmf: Add non-null annotations to TmfTraceClosedSignal
Small change to fix #418028, until we move the whole package to
NonNullByDefault.
Change-Id: I2533604e84a484d9c9315bcb6cb6a9eaeb21f2fe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25237
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 15 Apr 2014 21:32:17 +0000 (17:32 -0400)]
lttng: Harmonize the compiler settings among all plugins
Change-Id: I6136f619223781be3acd5b52ec4f4f47a0b3e5ce
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25093
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Tue, 15 Apr 2014 20:59:01 +0000 (16:59 -0400)]
lttng: Add script to copy the project settings from tmf.core
This will help keep consistent project setttings across plugins.
Change-Id: I20ebb8efdecf0c93d02cdb0f192fca387173b3b4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25092
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 17 Apr 2014 14:37:45 +0000 (10:37 -0400)]
tmf: Fix IOException drag and dropping trace on open experiment
The editors must be closed before deleting supplementary files.
Change-Id: I538c77dd1da3b2ccfb99986ce225e9b6a2c46f7a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/25213
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Fri, 11 Apr 2014 20:04:58 +0000 (16:04 -0400)]
TMF: Add a unit test helper to execute protected methods
This new class contains a method to call the protected executeAnalysis of
TmfAbstractAnalysisModule to be able to test the analysis execution simply,
without having to go through an Eclipse job and needing different threads.
Change-Id: I8043f956d405b4bf7f81787e028f67601a4c3fa0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24897
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 26 Mar 2014 16:40:00 +0000 (12:40 -0400)]
TMF: Refresh only the supplementary files for the current trace
The method has been moved to the TmfTraceManager
Also corrected a typo in a constant name.
Change-Id: Ieaa83c525defad09499458ab48a45ef14b2baa0a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23939
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Patrick Tasse [Fri, 11 Apr 2014 21:01:56 +0000 (17:01 -0400)]
tmf: Fix Select Traces command does not refresh trace type
The trace type for an experiment trace in the Properties view did not
appear until restart.
Change-Id: I426403cca68ad650637c9d625198ce80948fb977
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24883
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Guilliano Molaire [Tue, 15 Apr 2014 19:35:36 +0000 (15:35 -0400)]
TMF: Add an interface for strings regarding a session configuration
Creation of the lttng2.core.session package with the strings that will be used
for session configuration generation. We also externalized the bundle for the
kernel and ust plugin.
Change-Id: If51a4805064ed701a2bbf31a7f327406410f71a6
Signed-off-by: Guilliano Molaire <guilliamo-jaime.molaire@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/23422
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Alexandre Montplaisir [Wed, 16 Apr 2014 22:27:54 +0000 (18:27 -0400)]
ctf: Do not call System.gc() in CTFTrace.close()
This call is used to workaround a bug/limitation of MappedByteBuffer
(see JDK-
4724038). But CTFTrace.close() is called quite often
(for example, once per trace when closing an experiment), so it is not
the best place to call System.gc(). Instead, only call it when we are
about to delete/rename a trace.
Change-Id: Ib9b346dd04df4f64289ac9db0b976e6b70ff2551
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25174
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Mon, 17 Feb 2014 15:32:00 +0000 (10:32 -0500)]
lttng: Add a view for the CPU usage analysis
This view contains a tree viewer to show all threads spending time on the CPU
in the time range, and an XY chart viewer to display the total CPU of all
threads and the CPU usage of the currently selected from the tree viewer.
Change-Id: Id96fa1005623601539fad10e28949691b70ea1df
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/22522
Tested-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Wed, 16 Apr 2014 21:46:31 +0000 (17:46 -0400)]
tmf: Increase the delay in SignalThrottlerTest
This test started failing spuriously on Hudson recently, but the
delays were a bit aggressive. Increase them a bit to give the
test more chance to pass.
Change-Id: I07b6933bcedbb8e095dced0fb57e582b8ba8adff
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25171
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 11 Apr 2014 15:43:47 +0000 (11:43 -0400)]
tmf: Make CtfTmfTrace AutoCloseable
While we won't be able to make ITmfTrace closeable anytime soon (every
time you get a local reference to a trace, it'd expect you to close()
it, which is not what we want), CtfTmfTrace can benefit a bit from it,
as it helps pointing out some tests that are causing resource leaks.
Change-Id: Iaa163799390e01c9d4e996e2be1c5f160382aacd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25091
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 10 Apr 2014 22:53:21 +0000 (18:53 -0400)]
ctf: Make CTFTrace and its reader classes AutoCloseable
Basically just replace their dipose() method with close(). This
small change allows us to benefit from the compiler warnings for
when a resource is allocated locally in a method but never disposed.
Which then allows to find leaks. Many leaks ! Many tests were leaking
CTFTraceReaders and the like, but the biggest offender is probably the
validation methods in LttngKernelTrace and LttngUstTrace: trying to
validate a non-CTF trace could potentially leak a number of file
descriptors equal to the number of files in that trace(!)
Change-Id: I7e54416b608992a14a7bfd3cd29ffb8dc3cee898
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24986
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 8 Apr 2014 21:56:38 +0000 (17:56 -0400)]
tmf: Split "CTF adaptor" into separate plugins/feature
This allows using TMF without CTF, for more flexibility and
better separation of dependencies.
Change-Id: I5d84ebcf92014601eb293b95085ef1a046e7188e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24752
Tested-by: Hudson CI
François Rajotte [Fri, 22 Feb 2013 19:34:38 +0000 (08:34 +1300)]
LTTng: CPU usage analysis from the LTTng kernel trace
This analysis creates a new state system to save the total time spent on each
CPU by the different threads. It then uses it, along with the LTTng kernel
state system to compute CPU usage statistics in a time range.
Change-Id: Ia60e95c3bace646477aef06d58bdb7ed64c32bd4
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/21633
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Mathieu Rail [Fri, 14 Feb 2014 19:47:26 +0000 (14:47 -0500)]
TMF: Add an API to query analyses to obtain their requirements
Change-Id: I764291e0ca5281550a16d61a9aa8dbf5ca05d390
Signed-off-by: Mathieu Rail <contact@mathieurail.com>
Signed-off-by: Guilliano Molaire <guilliamo-jaime.molaire@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/22389
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Tue, 15 Apr 2014 02:30:17 +0000 (22:30 -0400)]
TMF: Remove dependency on CTF for analysis unit tests
A new trace stub is added to allow running the test analysis
with a second trace type.
Change-Id: I64298d41c08254031eccf4637369233a5c3ce7bf
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/25018
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Florian Wininger [Mon, 14 Apr 2014 18:06:15 +0000 (14:06 -0400)]
tmf: allow intervals with variable size
Remove the fix data size of a HTInterval in HTNode.
Change-Id: I116053884328318379a72643e7c4bf64b3b912c0
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/24795
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Patrick Tasse [Fri, 11 Apr 2014 21:14:10 +0000 (17:14 -0400)]
tmf: Fix drag and drop to experiment unnecessarily prompts for rename
When dropping a trace to an experiment in the same project, name
collision occured and the user was prompted for rename.
Change-Id: I0db0d81610a7afbb1df762838bf2129db510c962
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24884
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 26 Mar 2014 17:39:43 +0000 (13:39 -0400)]
ctf/tmf: allow multiple traces to be open with name clashing events
This is a problem not yet encountered but that will be a showstopper.
If you have two traces with event definitions that have the same name
but different payloads the second one will override the first.
This means that if I have two traces with events that are named "bob"
and we have a state provider for each that looks up different fields
in "bob", one will no longer return the correct values and exceptions
will be thrown everywhere.
Change-Id: I05f9bc0fbbd67374fcf3680d75fcb769c4f32a3a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23285
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 10 Apr 2014 20:39:45 +0000 (16:39 -0400)]
ctf: Use Antlr 3.5.2 for parser generation only
This change keeps the Antlr rutime at the same version (3.2)
but upgrades to 3.5.2 at the parser generation time (maven)
so that it builds with Java 8.
Change-Id: If9969034777534671d9ec23b19495ce2cf341fdb
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24821
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Florian Wininger [Fri, 11 Apr 2014 18:59:43 +0000 (14:59 -0400)]
tmf : queryHistoryRange performance fix
This patch removes unnecessary loops for small resolutions,
which increases the performance.
Benchmark :
Before :
Query resolution
1022444670: 0.245
Query resolution
102244467: 1.167
Query resolution
10224446: 3.390s
Query resolution
1022444: 4.028s
Query resolution 102244: 4.285s
Query resolution 10224: 5.451s
Query resolution 1022: 10.970s
Query resolution 102: 37.396s
Query resolution 10: 306.308s
After :
Query resolution
1022444670: 0.278s
Query resolution
102244467: 1.138s
Query resolution
10224446: 3.373s
Query resolution
1022444: 3.976s
Query resolution 102244: 4.329s
Query resolution 10224: 5.309s
Query resolution 1022: 8.001s
Query resolution 102: 8.145s
Query resolution 10: 8.231s
Reference :
Performance with queryHistoryRange without resolution : 8.414s
Change-Id: I6022dc6c562d994310f9419c362dd1f06a414036
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/21155
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Wed, 9 Apr 2014 18:46:25 +0000 (14:46 -0400)]
TMF: Moved the "Import XML file" under the custom parsers
And changed the text of this menu item.
Change-Id: Ie49a2a65664ee5341b9d4da275050412415a02fb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24737
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Roland Grunberg [Thu, 10 Apr 2014 19:25:51 +0000 (15:25 -0400)]
Temporarily revert to previous update sites.
Change-Id: I3473e08891b74d3aaa235234482ef4986a633528
Reviewed-on: https://git.eclipse.org/r/24812
Tested-by: Hudson CI
Reviewed-by: Roland Grunberg <rgrunber@redhat.com>
Tested-by: Roland Grunberg <rgrunber@redhat.com>
Marc-Andre Laperle [Wed, 9 Apr 2014 20:00:05 +0000 (16:00 -0400)]
lttng: Updates to target definitions
- Use eclipse.platform instead of SDK since we don't need JDT, PDE, etc
This doesn't work for the 3.8 and 4.2 target because the
org.eclipse.platform.ide product fails to start (missing splash
screen?).
- Use cdt.dsf.gdb feature only since we don't need anything else from
CDT
- Depend on Kepler's jdt.annotation package in the 4.4 target, to make
sure we get 1.1.0 instead of 2.0.0 (the latter requires Java 8).
- Add license feature (to export RCP from inside Eclipse)
- Use latest Orbit repo
Change-Id: Ia5535cd054fccf2089c333828b331342d0fb434f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24744
Patrick Tasse [Tue, 8 Apr 2014 20:35:45 +0000 (16:35 -0400)]
tmf: Fix TimeRangeException in TmfStateStatistics
Change-Id: I300a1ef9dcfdf32abc99bbcbec2d80999b51d0ba
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24670
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 3 Apr 2014 17:39:04 +0000 (13:39 -0400)]
tmf: Fold AlphaNumAttritbute class into the main one
Initially it was planned to allow for different types of attributes,
which could have children whose name could only be numbers, or
sequences of alphanumerical characters.
In the end, it was too complicated to expose this functionality in
StateSystem's API, so to remain as generic as possible, all attributes
are of type "alphanumerical".
The separate class is now unneeded. This also simplifies synchronizing
the container of sub-attributes (which should fix bug #431706).
Change-Id: I626bd07de660131ef6432cb10b0e783201c24782
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24275
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 8 Apr 2014 21:15:34 +0000 (17:15 -0400)]
tmf: Fix IndexOOB exception in HT node with concurrent read/write
Similar to bug #432191, but with the History Tree backend. It's possible
for an attribute to be created, sent to the backend, and written to a
node, all while a query is ongoing. (That's a race condition where you
race a Formula 1 against a turtle, but the turtle somehow arrives first).
Simply ignore those new attributes, since their value at time 't' would be
null anyway.
Change-Id: I072a08e84795a321c3b2bb393d9880ac4ba13a6a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24674
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 28 Mar 2014 20:35:55 +0000 (16:35 -0400)]
tmf: Add Guava dependency
This allows usage of some Guava goodies, namely additional
Collections (MultiMap etc.), the convenience methods (Lists.*),
and the ImmutableCollection versions.
Change-Id: I85c4fb32e7d5db368c35f17109563caedb2c9d73
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24587
Tested-by: Hudson CI
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Tue, 8 Apr 2014 18:38:15 +0000 (14:38 -0400)]
TMF: Fix IndexOutOfBoundException when querying state system
Fixes bug 432191 where the size of the stateInfo array may be smaller than
the ongoingStateInfo when the method is called. We use the size we know is the
smallest to avoid this exception to be thrown.
Change-Id: I1494940726b952ffe94560a7bed6e5764ff3d8f9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24661
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Patrick Tasse [Wed, 2 Apr 2014 20:58:54 +0000 (16:58 -0400)]
tmf: Refactor bookmarks file handling
The interfaces used to set or get the bookmarks file from an editor or
experiment are removed as they are not necessary. The bookmarks file is
the file in the FileEditorInput of an opened trace editor.
A convenience method is added in the trace manager to get the editor
file for an opened trace.
Change-Id: Ia4bd1999a4015b0251f867d46d0bd2d732a8c4bd
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24355
Tested-by: Hudson CI
Patrick Tasse [Mon, 7 Apr 2014 19:54:39 +0000 (15:54 -0400)]
tmf: Fix linked property inadvertently removed by
35b4320
Change-Id: Iecb9aff2965b0572e8854bd937dcd4926a0b6b11
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24584
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Fri, 4 Apr 2014 18:49:01 +0000 (14:49 -0400)]
tmf: Bug 424964: Drag and dropping a linked trace doesn't create a link
Unless the DROP_LINK operation is specifically requested by the user
(e.g. by holding Alt key), the source resource type (linked or not) is
now maintained during the drag and drop operation.
The handling is also changed to allow drag and drop of a resource in a
Tracing project that is not part of the tracing model (e.g. a file or
folder that is outside of the Traces and Experiments sub-trees).
A possible NullPointerException is fixed when the link creation fails.
Change-Id: I3b80ee508bfecb4023a1b52b2befdda7003d3794
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24475
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 28 Mar 2014 21:01:00 +0000 (17:01 -0400)]
tmf: Beautify TmfExperimentContext's API
Instead of exposing arrays and letting callers change the arrays as
they please, provider getter and setter methods for each operation.
Change-Id: Ideb685697925d3fc8f0c7ba086be29af276c7d1e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24125
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Mon, 7 Apr 2014 13:08:07 +0000 (09:08 -0400)]
tmf rcp: Disallow opening trace viewer with the same workspace
Change-Id: I1edac96b395ed9bfd8b87246940626e39e83ade2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24544
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 26 Mar 2014 20:45:36 +0000 (16:45 -0400)]
tmf: Add source location to trace properties
The source location property is added and contains an URI indicating the
original source for a trace.
The source location URI depends on the method used to add the trace to a
Tracing project:
- Import wizard
- Batch Import wizard
- Open Trace File command
- Open Trace Directory command
- Drag and Drop from workspace
- Drag and Drop from external source
file:/<path>/<file>
file:/<path>/<folder>/
- Import Trace Package wizard
jar:file:/<path>/<archive>!/<path>/<file>
jar:file:/<path>/<archive>!/<path>/<folder>/
- Import action in LTTng Control view
sftp://<host>:<port>/<path>/<file>
sftp://<host>:<port>/<path>/<folder>/
Change-Id: I6bc4dc52bbbddd03d6f33ac4fc3d194cc1bded74
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24268
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Florian Wininger [Mon, 10 Mar 2014 19:35:19 +0000 (15:35 -0400)]
TMF: Add XML state system view definition to the XSD
Change-Id: I3cad7bd42b2b263837b62392b5169781c5f9b26a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Florian Wininger <florian.wininger@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/23159
Tested-by: Hudson CI
Patrick Tasse [Wed, 26 Mar 2014 14:43:43 +0000 (10:43 -0400)]
tmf: Add Open With menu for trace elements in project explorer
The menu item is only available when the trace resource is a file.
Change-Id: I6951764fe5e357467020938c3f3802621e591aef
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23926
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Mon, 10 Mar 2014 19:31:13 +0000 (15:31 -0400)]
TMF: Add support for XML-defined analysis outputs
Change-Id: Ifb1436b79a342e3ce169616f65ad293bf5eae1a6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23158
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Mon, 10 Mar 2014 19:10:17 +0000 (15:10 -0400)]
TMF: Refactor XML model code, using factories to re-use element parsers
The same XML syntax (and thus parsing) can be used for many XML components'
element, like state providers and views, but the behavior of each component
may be different. We use a factory to define create the classes with the
various behaviors.
Change-Id: Iec5d54155b93a79b1ebc5ffeb8eaffef5e6569ca
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23157
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 27 Mar 2014 19:53:52 +0000 (15:53 -0400)]
tmf: Replace event matching API to use Collection
instead of straight arrays. This is more flexible, and indicates
that there is no notion of ordering of the traces. Had to replace
one instance of List.get(i) with a map of traces.
Change-Id: Ia25d79b4735b0acb5d4c56975e5e384ad39ad583
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/24078
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Patrick Tasse [Fri, 28 Mar 2014 21:25:17 +0000 (17:25 -0400)]
tmf: Fix batch import doesn't respect user-chosen trace name on copy
When the user changes the trace display name in the batch import wizard
(for example to resolve a name conflict), this name is not used when
importing if the copy option is selected and the trace is a folder.
This prevents the trace type to be set correctly on a single trace
import, and prevents name-conflicted traces to be imported properly.
Change-Id: I3dd04ca5deeaf5d4f9327ef13e7c1fdd5dcd2b62
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24122
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Tue, 25 Mar 2014 17:58:14 +0000 (13:58 -0400)]
tmf: Avoid unnecessary trace type selection during drag & drop
In some cases of drag & drop the trace type id of the target resource is
already known (set during the copy/link of the source resource, or if
the source is a trace in the same project).
In that case the trace type id should be used for refreshing the trace
type of the target element, instead of selecting the trace type by
validating the trace against all known trace types.
Change-Id: Iffa7b3c90034d7ce23b81e31d7e5632f74de189c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23881
Tested-by: Hudson CI
Patrick Tasse [Thu, 27 Mar 2014 20:38:25 +0000 (16:38 -0400)]
tmf: Fix empty trace properties when trace name has regex special chars
The trace properties (e.g. CTF environment variables) are empty when the
trace name contains regex special characters such as '(' ')' because
this causes failure of a replace of the trace name in the prefix of the
property descriptor key.
Change-Id: Ie682ee91f14249d32b26dd60d8c9511004c1ab1f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24027
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Thu, 20 Mar 2014 15:03:50 +0000 (11:03 -0400)]
ctf: mini benchmark for performance regressions
Change-Id: I951e3abe0f51e7e267411d416e0bccd83f8327c7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23662
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Mon, 31 Mar 2014 16:15:07 +0000 (12:15 -0400)]
TMF: Validate new trace type before setting it
Also change the return type of TraceTypeHelper#validate to return an IStatus
instead. This patch fixes bug #431646
Change-Id: I893ade44645f92dfe231cb603e16e6fbf17209eb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/24208
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Marc-Andre Laperle [Wed, 19 Mar 2014 05:54:05 +0000 (01:54 -0400)]
lttng: Convert CreateSessionDialog to a TitleAreaDialog
This allows to display an error message as the fields are modified.
Change-Id: I0974265872e1648e8a7c7ca7a7d89cf36b260394
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23592
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Thu, 27 Mar 2014 23:00:42 +0000 (19:00 -0400)]
lttng: Speed up the lttng.ui tests by reducing a delay
waitForJobs checks every second if the job manager is idle.
I could check more frequently. With this change, the test
runs in 90 secs instead of 240 secs.
Change-Id: I97900a9bd5b511db5309180724eef982d0fb1f57
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/24035
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Xavier Raynaud [Fri, 28 Mar 2014 11:34:52 +0000 (12:34 +0100)]
[TMF] Increase visibility of some package protected methods
Therefore, these methods can be used in subclasses and/or from other packages.
Change-Id: Ie5ef3408dfc8add0d4da8279c18a7c6391381250
Signed-off-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-on: https://git.eclipse.org/r/24057
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Patrick Tasse [Fri, 28 Mar 2014 19:19:30 +0000 (15:19 -0400)]
tmf: Fix NPE when dropping trace with unknown trace type
NullPointerException occurs when drag and dropping a trace with unknown
trace type to an experiment, or from another project to the traces
folder, but as a link.
Change-Id: I5060ac7315a3be1eb37779d933a12fdfa2f42cb2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24095
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Patrick Tasse [Thu, 27 Mar 2014 18:17:37 +0000 (14:17 -0400)]
tmf: Fix trace properties not shown when location URI has encoded chars
The trace properties (e.g. CTF environment variables) are not shown when
the trace element's location URI contains encoded characters (e.g.
space=%20), because the trace path uses the decoded characters and
therefore does not match the trace element's location.
The patch also modifies the output of the 'location' property to show
the unencoded URI string.
Change-Id: Ida0c56096b88690058eccfc5e408222fd461f7b7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24022
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Francis Giraldeau [Tue, 25 Mar 2014 16:00:48 +0000 (12:00 -0400)]
TMF: Add get parent to state system
It is possible to get the children of an attribute. This patch add also
required methods to query the parent attributes.
* Add getParent() method to Attribute, AttributeTree and StateSystem
* Add unit test to check the functionality
* Provides the required documentation
Change-Id: I635326068c2a298b32952599e09b2426b2e1fbb0
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/24026
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Patrick Tasse [Mon, 24 Mar 2014 17:34:10 +0000 (13:34 -0400)]
tmf: Fix time graph combo freezing when expanding parent of many items
When expanding an item in the time graph combo, the expanded state of
every child item needs to be synched between the tree and the time
graph, due to inconsistent behavior between platforms. When the parent
has hundreds of child items, this can take several seconds due to the
inefficient searching for the item corresponding to a time graph entry
in both the tree and the time graph, for getting and setting the
expanded state.
For the tree, instead of gettting the expanded state of each item from
the tree viewer using the model element, the set of expanded elements
is retrieved once and the expanded state can be deduced by the presence
or absence of a model element in this set. Furthermore the synching of
expanded state is only performed for child items that have children
themselves.
For the time graph, the item model is changed to use a map from time
graph entry to time graph item, which greatly reduced the time necessary
to find the item corresponding to an entry. The expanded item index is
also stored directly in the item which avoids the need to iterate to
find an expanded time graph entry's index.
Change-Id: Icefc393be8a5e2ee1a98b98a2c6b126da7490035
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23817
Tested-by: Hudson CI
Patrick Tasse [Fri, 14 Mar 2014 20:37:30 +0000 (16:37 -0400)]
tmf: Improve time graph combo responsiveness
- Optimize computation of visible expanded items list and prevent
unnecessary recomputation.
- Optimize alignment of tree and time graph item heights and only align
currently visible items.
- Remove the paint listener used to align item heights and add a common
method to simultaneously align the top index and the item heights when
necessary.
Change-Id: I4aedb6ca5973f867288a8334d92c53e688b775fe
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/23413
Tested-by: Hudson CI
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Fri, 21 Mar 2014 20:20:15 +0000 (16:20 -0400)]
tmf: Fix potential memory leak by dispose histogram data model.
It removes the references to trace objects.
Change-Id: I58f7793d79c4c6dc766eef119f29ed1d0c2063ed
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23736
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Xavier Raynaud [Fri, 21 Mar 2014 00:32:50 +0000 (01:32 +0100)]
add key shortcut for zoom control
Change-Id: I0d6aef31b8ad27d073708883d44e614c0cc7f345
Reviewed-on: https://git.eclipse.org/r/23687
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Marc-Andre Laperle [Wed, 19 Mar 2014 04:56:33 +0000 (00:56 -0400)]
lttng: Move createSession parameters into SessionInfo class
Change-Id: Iaa45647fcfa69fd3e62fdb56baf68070b27cad27
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23591
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 21 Mar 2014 13:37:10 +0000 (09:37 -0400)]
tmf: Use ConcurrentHashMap in TmfStatisticsTreeNode
Since multiple threads can update the statistics when using
experiments with more than one trace the tree node structure needs
to thread-safe. Using a ConcurrentHashMap instead of a regular HashMap
avoids ConcurrentModificationException for the current way this class
is used in TMF.
Change-Id: I38127466066660f82fb9cddd1465cb5e62c114c6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23719
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Thu, 20 Mar 2014 18:17:14 +0000 (14:17 -0400)]
tmf: dispose viewer in TmfStateSystemExplorer when view is closed
By doing that the viewer is deregistered as signal handler.
Change-Id: I2766d32053c11cd7c8bb14d45bf7f5a479bdaa88
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23670
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Bernd Hufmann [Fri, 21 Mar 2014 20:22:58 +0000 (16:22 -0400)]
tmf: fix memory leak in TmfTrace by clearing analysis modules map.
Change-Id: I54d6078d2c2e447263f4fede6978f781ef37cc31
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23737
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Mon, 17 Mar 2014 20:56:00 +0000 (16:56 -0400)]
tmf: add test to check if views are populated in a given perspective
Test tracing perspective
Test kernel perspective
Fix perspective id
Change-Id: Ia671ad54215899fb5a5d578cc592f33669088065
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23510
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
IP-Clean: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Geneviève Bastien [Tue, 18 Mar 2014 19:47:31 +0000 (15:47 -0400)]
TMF: fix bug in XML getChildElements to return only the children of a node
The getElementsByTagName() method used returns all sub elements with the given
tag under the calling element. The returned nodes are not just the children,
but also the grand-children and grand-grand-children. We want only the
children.
Change-Id: If9ea54ec738580320684533c7fe1a094295b9761
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/23561
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 12 Mar 2014 20:32:05 +0000 (16:32 -0400)]
ctf: move ArrayDefinition.isString to be part of the declaration
Multiple definitions of the same ArrayDeclaration will all return the
same value. The method makes more sense to be in ArrayDeclaration.
Change-Id: I245dba73c7f726ed9a792a6e443e0fe4cbec0e6a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/23283
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
IP-Clean: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
This page took 0.047204 seconds and 5 git commands to generate.