Fix clone of CtfTmfTimestamp in CtfTmfEvent.

Change-Id: I7e118cf0c9b82990ed9628acf66c004eab37f0b7

Fix seek by ratio in CTF

Change-Id: Ie7165f379608bf0eadda387c49b5d1e38eeb1963
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/7369
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: Simplify StreamInputPacketReader

- Make all internal structures final, initialize them in
  the constructor.
- Remove all the public getters and setters for those, they
  are only used internally.
- Replace a couple more null checks by "instanceof" checks.
  (previously, if a field name was present but not of the
  right type, it would throw a ClassCastException)

Change-Id: If4376a6310b48737a45892399dbb935e647ef0d8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7241
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: some updates to the statistics

- Changes the statistics node reset behavior to avoid useless
operations;
- Removes unused messages;
- Updates some javadoc;

Change-Id: I5af35217a711cdce06807929c4621dfb88cd2fa1
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7333
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

tmf: Refactor the statistics

Manage the viewer input directly in the viewer rather than in the view.

Change-Id: I2ed5ee303036d384939d5a2a121e30462c9c9fb7
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7332
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Fix reload of the same trace for statistics

Fixes bug 387639

Avoids deleting the statistics tree if the global request gets
canceled.

Change-Id: I596930b2b08ea796bd82c920d836c90a86cafe09
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7308
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

Fix context location after first event seek.

Change-Id: I84205cede4cf7d3a4f561b61cbcbf0812fece512
Reviewed-on: https://git.eclipse.org/r/7353
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix NPE with traces that are time scaled.

Change-Id: I733ccd4e29c42fb3239c25f5e8dc6f7959000e13
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/7337
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Add time scaling support

Useful if your clock is not == 1.0 ghz

Change-Id: Ie81bfa6b4379d5cbe5b88abae22618bc5a08dc3f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/7104
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Updated Enum handling for a CTFTmfEventField

This change provides a way to extract the Enum long value and Enum
value name from the CTF EnumDefinition and store it in a
CtfTmfEventField object. Before this change the CtfTmfEventField
only contained the Enum value name.

For this change, the class Pair<A,B> which was part of the legacy
LTTng core is now integrated in TMF core.

Added JUnit tests for Pair class.

Change-Id: I948d3b9bdde83d5eda7c8397c1b9494e15f7706a
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7326
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Updates statistics test cases

Change-Id: I5c40b27da713dd67e5e39abdc09f0c7cafe016fa
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7306
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Add unit tests for the state system stack-attributes

Since the reference LTTng kernel handler does not make use
of stack attributes, this part of the code should be covered
by stand-alone unit tests.

Change-Id: I5888a450dc104229970f41e9aa5a7cf0bf45633d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7289
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Correctly use null values for empty stacks

When removing the last element of a stack attribute, the
popAttribute() method would leave the stack-attribute (which
represents the depth of the stack) with a state value of 0.

We expect a null value for empty stacks, and the integer
representation of a null value is -1. This would make it
impossible to re-use an attribute stack after it was completely
emptied once.

This patch fixes this by correctly assigning a null value when
emptying a stack.

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Change-Id: If2d4edc8a0bee55f007a4dcbffefe44f513f567d
Reviewed-on: https://git.eclipse.org/r/7288
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add a convenience method to query stack attributes

Change-Id: Iad7ecdfd5580e819837f69c444583b805f0864e4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7287
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Return the removed value in GSS's popAttribute()

When calling IStateSystemBuilder.popAttribute(), it will now
return the state value that was popped from the stack. This
can help with sanity checks, dealing with lost events, etc.

Change-Id: I2853bd2fa17d40193ea336080a64f60818aa9242
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7286
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

Fix previous commit

Commit 1ff9cea was actually a rebased Patch Set #1 on
https://git.eclipse.org/r/#/c/7134/

This small patch adds the delta that was part of Patch Set #2,
which is the correct one.

Change-Id: I17a374e4a7e8e29a05f19466cfd4b6b380a5afdc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Drop the legacy LTTng 0.x plugins

Here comes the axe!

LTTng 0.x has been unsupported upstream for more than 2 years now.
The plugins themselves haven't received any new development since
then.

We plan to drop support for LTTng 0.x in Linux Tools 2.0. It will
remain supported in the Linux Tools 1.x branch.

This will open the door for some future improvements that were
impossible to make with this codebase still around. For example,
immutable timestamps in the framework.

Change-Id: I176f6e03012cb7e4a11e4dd6fd450272b015ca36
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7134

tmf: Use tabs in statistics view for each traces

When an experiment/trace is selected, the statistics view creates a
global viewer and a specific viewer for each trace contained in the
experiment. These viewers are placed in tabs and shown in the
statistics view. Also, a factory is now used to create a viewer based
on his definition in the plug-in.xml from the trace type. An
extension point element has been added to the trace type extension
point to provide custom statistics viewer.

Fixes bug 387217 on bugs.eclipse.org

Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Change-Id: I8d380e8c28cba855b5361069200e50ab0cbca7f3
Reviewed-on: https://git.eclipse.org/r/7042
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Fix compilation error in legacy LTTng

Change-Id: Ie32d799ef382276b52221697e912b96bf1a0d86b
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7258

ctf: Handle absence of stream and event IDs

As per the CTF spec, a trace could define no stream_id field
in its packet headers. In such a case, the parser should assign
it ID 0.

Similarly, if only one event type is present, the event id field
is optional, and 0 should be used if it's not explicitely set.

Partially fixes bug #387039

Change-Id: I38dcdbdefc6c18a16b2ad8fb9ad6135303da208f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7203
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

tmf: Un-deprecate CtfLocation's constructor

The new recommended constructor adds an "index" parameter.
However I think it's worth keeping the previous one, and have
it use a default value of 0.

Change-Id: I21d33c99471d0e4622a3334085b27c223e5b76f2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7224
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

tmf: Fix visibility warning with TmfRequestExecutor

TmfDataProvider.fExecutor is protected, but TmfRequestExecutor
is not part of the public API. This means any class from another
plugin extending TmfDataProvider couldn't access the fExecutor.

Solve this by making the fExecutor field private, and supplying
protected access methods.

Change-Id: Ia3df1247fe2a6c98c87048bb17c9bc3529abfd47
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7223
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

tmf: Generalization of the statistics view

The creation of the statistics view is now based on the type of the
trace selected and his plugin definition. Thus, it is easier to provide
a new implementation of the statistics for a different kind of trace.

Change-Id: If105007a5f349565c14cdf6e5e084a4ab5d227b3
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7041
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>

Fix JUnit test failing after previous merge

Change-Id: Ie35a0947b90c95405ab3c887b4a8577a37097c60
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7188

Temporary fix API version for Kepler

The version in the master branch is correctly set to '1.2', the upcoming
version for that branch.

Since there are major API changes in the lttng-kepler branch and that
there is no '1.2' baseline yet, the API tool insists on a '2.0' version
being provided for these files.

The issue will be resolved LT 1.2 is released and we merge the master
branch in lttng-kepler: at that point everything should fall in place
as we have to undo these fixes to get rid of the API errors.

Change-Id: I3164f7d4facbd909540abb3dca66b3ba7627145a
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7174
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Merge branch 'master' into lttng-kepler

Conflicts:
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedDataRequest.java
lttng/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/internal/tmf/core/request/TmfCoalescedEventRequest.java

Fix a sporadic distribution problem in the TMF coalesced requests

When a data/event provider receives a set of requests during the
processing of a signal, it will do its best to coalesce these requests
in order to minimize the number of physical accesses that need to be
performed on the back-end traces.

The coalesced request, itself being a request, also has a data type. By
default, its data type is determined by the first sub-request coalesced
by the data/event provider. Afterwards, when it receives data from the
back-end, it dispatches the data/events to the appropriate sub-request.

This works fine for homogeneous experiments (same trace/event types).
However, when dealing with heterogeneous traces or even with different
event types during a given session, the coalesced event type, being
determined by the first sub-request, can in fact hide the data/events
for sub-requests whose data type is not an extension of the base type.

This fix forces the data type of the coalesced request to ITmfEvent
therefore ensuring that the data meant for the sub-requests is not
inadvertently filtered out.

Change-Id: I2862f7ca30d38c968968dd6cd41f6cc04bbcd9a4
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7171
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Add a generic 'lost events' event to TMF

Change-Id: Ic7d1189e3bca397a4bb7a775e7b1757dfde00926
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>
Reviewed-on: https://git.eclipse.org/r/7100

Update Sonar version in LTTng pom.xml

Change-Id: Ia6b451f22ce8418e3f1726f8f42125ce87d4023c
Reviewed-on: https://git.eclipse.org/r/7141
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

ctf: BitBuffer improvements

Minor performance improvements. Simplified the API a bit:
Removed the 'index' parameter from the public API in read()
and put() methods. All reads/writes can be done from the
current position, and this position can be set with position().

Updated the tests accordingly.

Change-Id: I24b30f2a2e5d79be1b873795ebd4183b70551907
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7076
Reviewed-by: Philippe Proulx <eeppeliteloop@gmail.com>

Merge branch 'master' into lttng-kepler

Added destination parameter for LTTng specific releng site

With this commit it is possible to specify the destination directory
of the LTTng update site when building profile lttngPackage from
Maven command line. Use "-DlttngPackageDestination=<path>"

Change-Id: I89224d438dbea373655ff3b5d4c94150caa854bb
Reviewed-on: https://git.eclipse.org/r/7133
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

ctf: Fix lost events in a more elegant way

- Read the stream context packet once instead of at each load
  of the packet.
- Clean up code.
- Change the API to handle seeks to a specific event in a timestamp.
- Update test cases.

Change-Id: I0dddf56645bc0b8a69256ac947f3a806d1cfedf3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7075
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Fix Statistics JUnit test

New implementation of TMF statistics feature shows 3 columns
instead of 2. This has been updated.

Change-Id: I6fef4cae9a95e63a15e71129152f3127221b77b6
Reviewed-on: https://git.eclipse.org/r/7121
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

lttng: Fix off-by-one in the check for new attributes

In some places, we want to check if a get*AndAdd() call just
created an attribute, or re-used an existing one. The correct
way to check for this is if (quark == ss.getNbAttributes() - 1).
The -1 was missing.

Since this test comes relatively often, also add a specific method
to the interface, so it makes the code clearer.

Change-Id: Idc3f9a508cd670914236bce603e1d5202787a46c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7103
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Fold IStateSystemQuerier2 back into IStateSystemQuerier

Let's make use of the API break to re-simplify those interfaces.
Also dropped one of the range query methods, it is covered by
the new one.

Change-Id: If473d55983604b0cb52182009d1e79d4b9809eb7
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7102
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Add a column in the statistics view

Bug 383246: Add a column for statistics only in the visible window

Change-Id: Ic619c3297f815052e6c90fee7bc87097986fe6ef
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/6984
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

Merge branch 'master' into lttng-kepler

tmf: Fold StateHistorySystem back into StateSystem

At first, a distinction was made to differentiate state systems
that would have a history backend, and those that would not.
In practice, history-less systems are never used, and wouldn't
even work since some recent refactoring.

If we ever need to implement a history-less statesystem, it would be
cleaner to simply use a dummy backend which discards all the
intervals, and returns null or similar on all past queries.

Change-Id: I5c04f9514236878f6f53190f862347a5b19308f4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7070

Partially revert commit "Drop unused dependencies from tmf..."

Added missing Required-Bundle org.eclipse.ui.navigator.resources
to TMF UI MANIFEST.MF.

Change-Id: I715a500b3383f628253d481dffb26f4ad4a970f8
Reviewed-on: https://git.eclipse.org/r/7098
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

lttng: Handle the statedump events

Back when the state provider was first developed, LTTng did
not support the statedump (dummy events that show the current
state of all the running processes).

This support was added to upstream LTTng since then, so the
TMF viewer should make good use of this information!

Change-Id: I194fa8f31051b5755ed35e1594d33e47dcceec7a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7032
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Handle state changes ending after the trace ends

Since it's possible to add states ending in the future, we
have to handle the case where a state would end past the
trace's end time (and the history's end time). We simply
discard it in this case.

Change-Id: Ic0c525aece776cb4e742d8829e420d50570b36a0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7077
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Drop unused dependencies from tmf,lttng2,ctf packages

Change-Id: I7d17f254f5e4a5073501ede6bd723db6f9f75dfa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7022

lttng: Change external dependencies to imported packages

The external dependencies for ctf and lttng2 (RSE and Antlr) were
set as "required bundles". This means the exact plugin must be
present in the current installation when building the workspace
from within Eclipse.

This commit changes those to Imported Packages, which relaxes the
origin of the package. This allows distribution-installed plugins
to fulfill the build dependency.

Change-Id: Ie20d19959d819fc834dc045ec0520285fae2cf2d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/7021

tmf: formatting of tmf.ui.statistics

- Remove trailing whitespaces;
- Replace tabs for spaces;
- Remove html tags;
- Format blocks;
- Correct warnings.

Change-Id: I560b7d9c66e2ed23c3850ecf9e74ccc4ffaf8779
Signed-off-by: Mathieu Denis <mathieu.denis@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/7005
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix the fallout of the generics-removal in legacy LTTng

Change-Id: If21e98b5fa81eaeced24d1bcd507103e923546b4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6970
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

tmf: Drop generics from ITmfTrace and TmfExperiment

Most of the generics are redundant now that we have interfaces.
In this case, the ITmfEvent type is always implied.

Lots of lines affected, but most of it is just removing the
stuff in brackets.

Fixes bug #382905

Change-Id: Ic857457d3ecea6ba4e369c79e9b24255572bfa77
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6969

tmf: Bump plugins version to 2.0 for Kepler branch

Since 1.2 is not yet released, we have to fake all the existing
"@since 1.2" methods to "@since 2.0".

When we merge this branch back into master (which should be after
the 1.2 release), these should be reverted to "@since 1.2".

Change-Id: I5b74bd4c021424aecdf62014147b2ef4ff0d0b6b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6968
Reviewed-by: Mathieu Denis <mathieu.denis55@gmail.com>

tmf: Also bump the version number in pom.xml's

Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Update master branch against the 1.1 baseline

With a baseline installation updated with Linux Tools 1.1, one can now
track which APIs were actually part of 1.1, and which ones should require
bumps to 1.2/2.0.

Some protected fields in CtfTmfEventField were actually not part of 1.1,
so this adjusts their annotations and plugin versions correctly.

v2: Bump the test plugins too.

Change-Id: Id9155fe95594b4844e82e550ab0ca8563a74cdb0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6994
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

Fix more compiler/javadoc warnings as per new project specific settings

See also bug 385535 for the set of settings.

Change-Id: I76b5e8a78113908379cb9d73bbbbfae6bf1006a6
Reviewed-on: https://git.eclipse.org/r/7006
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

ctf: Fix remaining warnings the CTF plugins

Change-Id: If61709478cde0258e86761be8060e3ede0ca7f0e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6992
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>

Fix TMF Core JUnit tests

Change-Id: I30595c0a1d190421649d079235c27fa3fbb26932
Reviewed-on: https://git.eclipse.org/r/6987
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Correctly print HTInterval in its toString()

The ASCII value of '[' would get added to the start time,
instead of doing the expected string concatenation.

Changed the whole thing to use a StringBuilder instead.

Change-Id: Iea7f2b409c7c177a4a0b35494294fca7258835a1
Reported-by: Patrick Tassé <patrick.tasse@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6985
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>

Fix another pile of Javadoc warnings

Change-Id: I324c129736499c3cc4892898f9a0121e47fb7ac7
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>

Fix a pile of Javadoc warnings

Change-Id: I5f8cec0642346b863f058d56d56406a1e8b7fd77
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>

Use project-specific Save Actions settings

The actions to execute on Save are:
- Remove trailing whitespaces on all lines
- Always use braces for control blocks (if, for, etc.)

Other save actions could be interesting, but they can be tracked
with compiler warnings instead.

refs bug #385535

v2: Removed the "Make private fields final if possible" option

Change-Id: If97f311a934739957586c76b83ce0538d733456d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6906

Use project-specific formatter settings

The settings are the same as the Eclipse default settings, except:
- Use Spaces only for indentation
- Disable qualified invocations wrapping
  (so we don't get myClass\n.get())

refs bug #385535

Change-Id: I773dbea89d24916cb82ca8ad93f2ee05ba8181dd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6905

Genericized CTF parser and events handling.

Add support for enums in trace fields.
Add support for broken end timestamped traces. (experimental)
Add support for variant free id/timestamp pairings (non-lttng)
Add support for non-CPU based traces (dsp/gpu/fpga...)

Change-Id: I2e49f798ae5e2fefda0316631dbbb74609ba36aa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6951

Fix issues with CTF parser.

* When an enum is declared in a different scope than it is defined in.
* When there is no stream ID the trace does not generate NPEs.
* When there is no clock offset, a 0 offset is created. (not often)

Change-Id: Ie0e0e09168aa2d91ac52d49e94bc10e1e9ba691f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6949
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf: Add missing javadoc in tmf.core.signal

Change-Id: I562a1b1de353ec5ccd9107afdea5fb6c3aa67475
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6867

tmf: Fix some javadoc warnings in tmf.core

Change-Id: I580d39a0eb71dc4cc81fd0c7cdd9626504aefcba
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6866

tmf: Enable project-specific compiler settings

refs bug #385535

Change-Id: Ifcb0abfe34cf70d5f0379040acd4db53224a4073
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6865
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

lttng: Fix most compiler warnings as per the new settings

Change-Id: I056b02cd61daa38e8d19f2e36a49f3015bc08263
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6864
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>

lttng: Enable project-specific compiler settings

refs bug #385535

Change-Id: Ic5b5fdb6e418566d6b0a67cc9145c2ed336d8526
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6863

ctf: Enable project-specific compiler settings

refs bug #385535

Change-Id: Ie7df540057dd3be916d9f1a53240dd90bb0a73aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6862

lttng: Add CPU field in control flow view tooltip

References bug #385656

Change-Id: I101d05b4d4150e2b071e9f9005d5a475d106f8af
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/6903
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix negative timestamp seek bug.

Change-Id: Ic0e77da05419261ff082103d0e232723b51a3be1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6871
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Mathieu Denis <mathieu.denis55@gmail.com>

Fix trace and experiment seeking performance bug

Change-Id: I6c59ac7ba52d80ab4bab597da93ea7adb950158d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/6817
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix for bug 385432: Missed events in coalesced requests.

In addition to commit 04e0f4e84ffe07a23975f3d6e06849681f3afedf

Change-Id: If53b5b322ef819d25f3fcf2ed7a3d542db124794
Reviewed-on: https://git.eclipse.org/r/6869
Reviewed-by: Francois Chouinard <fchouinard@gmail.com>
IP-Clean: Francois Chouinard <fchouinard@gmail.com>
Tested-by: Francois Chouinard <fchouinard@gmail.com>

Fix for bug 385437: Control Flow view's "Previous event" button skips
over state transition.

Change-Id: Id78590a2cf5c1398ee10d3894b56436db4732081
Reviewed-on: https://git.eclipse.org/r/6868
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Merge "tmf: Update the ctfadaptor tests for the new formatting"

Merge "lttng: Drop the current node arrays in the the event handler"

Add test cases for Bug385432

Change-Id: I29602c425b71a81fa51633b4317b062266c8a56b
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>

tmf: Update the ctfadaptor tests for the new formatting

Since 9dc3ba9, the .toString() method for integer CTF fields
will correctly format the value as per the formatting info
in the metadata.

Some unit tests have to be updated to cope with the new values,
for octal and hex integers.

Change-Id: I0aa8e7c919bbc8227cf7d9c5cc286561b172ece6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

lttng: Drop the current node arrays in the the event handler

Since we now use "common locations" shortcuts for commonly used
attributes in the tree, we don't really save much by caching
the quarks for all CPUs and all current running threads. This
was initally done as a performance optimization.

This commit drops the current*Nodes arrays that were populated
as new CPUs were seen while reading the trace. We will now get
the "current" pointers by doing standard state system queries.

If there is a performance impact, it's unnoticeable. I think it's
worth keeping this file as easy to understand as possible, since
it's often used as example for building an event handler.

Change-Id: Iedb3a13da837f3676c72f3c91edbd2e6960879a1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix for bug 385432: Missed events in coalesced requests.

Change-Id: I71eb6782113043c41ad275a0dabb8969dbd6978d

Fix for bug 385419: Streaming issues with legacy LTTng traces.

Fix test project dependencies.

Change-Id: Ia493a73c46d51fedc003696977fa92e5e89cc078
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>

Fix for Bug383047

Change-Id: Ib311436f740c382d4d828713a4f2d762d63c326d
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>

Merge "lttng: Correctly validate traces of kernel type"

Merge "Fix for bug 385323: HistogramView should normalize more timestamps."

lttng: Correctly validate traces of kernel type

Fixes bug #385340

Change-Id: I29d72d78076fb63c18d636a7d0471522c1eb2dd2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Normalize current event timestamp (Bug3984982)

Change-Id: If0fa17f9203ffb234514f86353c065c894fdac8b
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>

Fix for bug 384402: Import trace validation check ignored.

Change-Id: Ic46c2c3588287b6ee5ce99c45f9e32af4fb82453

Fix for bug 385323: HistogramView should normalize more timestamps.

Change-Id: I79f4781f79b8b4b056841c67fc8cd9e0409fad90

Final fix for Bug384878

Change-Id: I21f95490799461eb8ac161fea48e527dbba27892
Signed-off-by: Francois Chouinard <fchouinard@gmail.com>

Fix for bug 385222: Canvas border hides histogram data.

Change-Id: I837170b70f0d3737746ac882004ac893d7589039

Fix for bug 384501: Partial statistics when opening view during
indexing.

Change-Id: I33a4a0f706c61b078c6e3ac5eed9b22e9d3639fc

Merge "Fix for bug 384417: Incorrect range displayed in histogram tool tip."

Merge "Fix for bug 384406: Delete trace propagation not working in Windows."

tmf: Print CTF integer fields in the correct base

We have the information about the base of integers in CTF, so
we should use this information to print the field correctly,
at least for standard bases (2, 8, 10, 16).

Fixes bug #384983

Change-Id: I66882dd8d5e15473fb3690311c4c170bb22dc8a0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix for bug 384417: Incorrect range displayed in histogram tool tip.

Change-Id: Id0c40656476118844eb34863a885b5bd015fe2da

tmf: Use macro-style definitions for CTF field types

The annotations will have to be updated to "@since 1.2"
if this doesn't make the 1.1 release.

Change-Id: I3a66cef0394bb3dd5f3b1e074ad55579c1a8730f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

tmf: Javadoc update in CtfTmfEventField

...and other aesthetics changes. That file sure got ugly over time!

Change-Id: I8e171bd065634ac93e3582533eca8837b2058460
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix for bug 384406: Delete trace propagation not working in Windows.

Change-Id: I3800cce187a50206577e2899500d59d23fa64973

Fix lost events to work after multiple reloads

Change-Id: If086a2c99d6276b8b4b19b55124526f3ee468f70
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Fix for bug 384637: NullPointerException in ControlFlowView on disposed
experiment during state system build.

Change-Id: I26b66db4650404ea06fa1586cf348b0aefd78656

Merge "tmf: Close the state history files before deleting them"

Merge "tmf: Do not broadcast signal if request is cancelled"