Marc-Andre Laperle [Thu, 11 Sep 2014 14:52:28 +0000 (10:52 -0400)]
tmf: Do not use Display.sleep in tests
Similar to bug 415992 and change 25443. The display needs to be woken up
because it's possible to get in a state where nothing will wake up the UI
thread (events, messages), especially if the tests are being run unattended.
Instead of using the highly implementation-dependent solution of doing a
Display.asyncExec (which only works on Mac, not Windows), we can simply not put
the display to sleep and just have the thread sleep. This is safer because
Display.sleep by definition should not wake up until an event is received which
we cannot guarantee will happen.
Change-Id: Ib2282bcd71c9376d7bbdb084c094892146410ff7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33257
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Fri, 11 Jul 2014 17:08:06 +0000 (13:08 -0400)]
tmf: Invalid thread access when deleting trace or trace folder
Bug: 439449
Change-Id: Id2f7b940a0afcd35bb0baca710b15ebb5d156298
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/29828
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Thu, 11 Sep 2014 14:38:38 +0000 (10:38 -0400)]
lttng: Delete suppl. files *after* the trace has been disposed in a test
That way the file handle won't be still opened when trying to delete
the suppl. folder (Windows).
Change-Id: I6e43442d715389fd3ba5265a96d9de534701f7d8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33255
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Wed, 27 Aug 2014 18:50:12 +0000 (14:50 -0400)]
tmf: Adapted ExportToText feature to new events table column API
Change-Id: I11d9e500fb19c368233047c153205b2a9fba807d
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32496
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Thu, 11 Sep 2014 20:53:56 +0000 (16:53 -0400)]
tmf: Also check if the trace type exists in select traces dialog
Change-Id: I26734465a54bc1d6ca865e035ce3259dbf956521
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33282
Tested-by: Hudson CI
Marc-Andre Laperle [Wed, 10 Sep 2014 17:43:19 +0000 (13:43 -0400)]
tmf: Fix untyped traces being shown in the select traces dialog
Bug: 443737
Change-Id: Ifc1902341a4673a268ac0d540346a50cb5e5c9cc
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33202
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Sat, 6 Sep 2014 02:59:36 +0000 (22:59 -0400)]
tmf: Fix a test when running from alltests plugin
Change-Id: I9649c0e6f384b6b5c075898ccc541e941a7a2b1e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32965
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Wed, 10 Sep 2014 21:07:52 +0000 (17:07 -0400)]
tmf: Fix NullPointerException drawing time graph arrows
Change-Id: Ic3fd6c9646a4d6a62c6421ab5392fe0d4f4b152c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33213
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 9 Sep 2014 22:32:08 +0000 (18:32 -0400)]
tmf: Improve SS Explorer filter button description
Change the filter button's tooltip in the State System Explorer from
"Display Only Change" to "Only Display Changes at Selected Timestamp".
This is more representative of what this option does.
Refs bug #419515.
Change-Id: I457627d2ff60b2efee9f8f962a00e883b0a8e63c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33153
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Marc-Andre Laperle [Tue, 9 Sep 2014 15:17:05 +0000 (11:17 -0400)]
rcp: Update version number to 1.1.0
Change-Id: I59a0f93f1255bf09cd7f51c30ce1e05e9f8345d3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33123
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33138
Marc-Andre Laperle [Thu, 4 Sep 2014 21:01:47 +0000 (17:01 -0400)]
lttng: Increment the version numbers to at least SR1 numbers
Change-Id: I3169329580cf77e01dbf0fee55fce2ce2f7aa229
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32887
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexander Kurtakov [Wed, 10 Sep 2014 12:22:41 +0000 (15:22 +0300)]
tmf: Javadoc fixes.
Mostly typos.
Change-Id: If150c1c7644e6846a4b56a0e8efd153aab90cddc
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reviewed-on: https://git.eclipse.org/r/33178
Marc-Andre Laperle [Mon, 8 Sep 2014 21:06:31 +0000 (17:06 -0400)]
tmf: Fix a few other cases of not using toOSString
Bug: 443646
Change-Id: Ibffd262432e5b231132a5738717016f8556ac2ae
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33077
Tested-by: Hudson CI
Marc-Andre Laperle [Tue, 9 Sep 2014 21:49:35 +0000 (17:49 -0400)]
tmf: Fix IllegalArgumentException when importing from the root directory
Bug: 443651
Change-Id: I5fb050a4c35f27c4393f30ba0b9836cc656e76de
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33152
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
(cherry picked from commit
47d1ed9b786018f2f5da5c86a1fa2d4386fd8c9f)
Reviewed-on: https://git.eclipse.org/r/33154
Alexandre Montplaisir [Mon, 8 Sep 2014 22:47:52 +0000 (18:47 -0400)]
tmf: Use the class name if no ID is specified for analysis modules
Since there is no abstract method or other compile-time check, we can't
expect all modules to know they have to specify an ID. If they don't, we'll
infer one from the full class name instead of filling the log with errors.
Change-Id: Id1f83dcb782573aa87b2128a3864a85c4cdcffd3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/33084
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bernd Hufmann [Mon, 8 Sep 2014 16:24:07 +0000 (12:24 -0400)]
[lttng control] Fix snapshot command output parsing (Bug 443519)
Change-Id: Icb2915486ad1c9c4e26ba8c3ef7f5f6a9a5c9dad
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/33060
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Tue, 9 Sep 2014 18:29:38 +0000 (14:29 -0400)]
gdb: Improve GDB trace file validation
Change-Id: Ia09daf6816a3638a2c061e940112ad264c3b44b5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33136
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Marc-Andre Laperle [Tue, 2 Sep 2014 15:06:58 +0000 (11:06 -0400)]
lttng: Increase number of iterations in benchmarks
Change-Id: I09625d783f070cb5b671c3ceb23e2af113391c49
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32962
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Patrick Tasse [Mon, 8 Sep 2014 21:48:49 +0000 (17:48 -0400)]
tmf: Catch ParseSyntaxException in custom text parser wizard
Change-Id: I1ac66cacbc5d1d26ff06dbbe4920d31702cf3704
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33081
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Fri, 5 Sep 2014 18:53:07 +0000 (14:53 -0400)]
lttng: Add a testing feature that contains all tests
Change-Id: I1389c99321c7b9f9e8016e58baa365fc17c523ad
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32956
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 21 Aug 2014 22:32:51 +0000 (18:32 -0400)]
tmf: Improve synchronization in TmfRequestExecutor
If the TmfRequestExecutor is overwhelmed by event requests, it can
freeze the UI thread for long amounts of time and lead to a pretty
bad user experience. (An easy way to test this is to select an entry
with lots of state changes in the CFV, and hold down the right or left
arrow key.)
This patch:
- Makes it use Queue.offer() instead of .add(). This avoids spewing
exceptions in the console once the queues are full.
- Actually cancels the requests if the offer() fails. Before, even
though they would not be put in the queue, they would still exist
and still wait to execute.
- Drastically reduces the size of the request queues. If we are in a
case where the handler receives requests faster than it can process
them, instead of giving the user false hope that we will process them
in a reasonable time, just cancel them so that the UI can go back to
being responsive faster (see bufferbloat).
The "correct" fix would be to make sure on the request sender's side that
we don't send to many requests, and correctly cancel obsolete ones.
But independently of the sender's implementation, this patch makes the
executor degrade more gracefully.
Change-Id: I0072d54bb7a403773fd4288a42bfb73c4614189b
Reported-by: Simon Marchi <simon.marchi@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/32115
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Thu, 4 Sep 2014 17:51:13 +0000 (13:51 -0400)]
tmf: Support tool tip for arrows in time graph
The tool tip will show the time link event information of the closest
arrow to the mouse position, provided that it is within 5 pixels.
Holding the Shift key will disable the arrow tool tip so that the tool
tip can show the information of the underlying state.
Change-Id: I5f4daaea130817a16dd5d222b262cb0ec9aee76b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32875
Tested-by: Hudson CI
Generoso Pagano [Wed, 27 Aug 2014 13:31:10 +0000 (15:31 +0200)]
TMF: added support for process filter in the TimeGraphFilterDialog.
On top of the filter dialog a text field enables filtering over the
tree of process names.
A node of the tree is shown if:
- the node matches with the search pattern
- one of the children of the node matches with the search pattern
- one of the parents of the node matches with the search pattern
The buttons check-all and check-subtree check only the visible items.
The button uncheck-subtree unchecks all the children (the hidden
children too, since it makes no sense a checked child with an unchecked
parent).
The button uncheck-all unchecks everything, except the hidden roots
(and corresponding subtrees).
Change-Id: I517f3333bb7b6da9fd14eaaac90e7b914671479e
Signed-off-by: Generoso Pagano <generoso.pagano@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32404
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Mon, 8 Sep 2014 17:51:08 +0000 (13:51 -0400)]
tmf: Fix some NLS Message strings
Change-Id: I41b3e8ce64b9fca5150681f487786826a2ce968c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33062
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Patrick Tasse [Fri, 29 Aug 2014 19:08:37 +0000 (15:08 -0400)]
tmf: Resolve trace type name conflicts on custom parser import
Change-Id: Id2ee9c86a88c29fbc86638556fb9b83df06d70e7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32573
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Fri, 29 Aug 2014 17:59:12 +0000 (13:59 -0400)]
tmf: Make default (built-in) custom parsers uneditable
Change-Id: Ia96451ffca8dafa29d176401dc23450e975e1b70
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32572
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 25 Aug 2014 20:30:07 +0000 (16:30 -0400)]
tmf: Support category in custom parser wizards
Change-Id: I9655a997bdcec4659a5189eeaf1e812d86e3a3d0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32280
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 25 Aug 2014 18:07:07 +0000 (14:07 -0400)]
tmf: Support custom parser category in utils, properties and commands
Change-Id: I0b865646d14000259d8f19f9c6a9630ed9a516ef
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32279
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Fri, 22 Aug 2014 20:02:24 +0000 (16:02 -0400)]
tmf: Add category to custom parser definition
Change-Id: I882676278acca7398e4adee5c4f485bb20cda083
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32278
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Thu, 4 Sep 2014 18:04:49 +0000 (14:04 -0400)]
TMF: Move synchronization supplementary files to a folder
This way, analysis on experiments can put synchronization-related supplementary
files in this folder and they will be preserved once the traces are updated
after synchronization. By default, the synchronization file was preserved, but
all other supplementary files were deleted. Now the entire folder is preserved.
Change-Id: I64e4a8fff2a20e39e0b642260704492ef8cd2416
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/32871
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Marc-Andre Laperle [Sat, 6 Sep 2014 20:21:38 +0000 (16:21 -0400)]
ctf: Fix checksum on case sensitive file systems (md5->MD5)
Change-Id: Ib55ceaf1de9cdfd5c16cb6c1266f4b4fadf2e051
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32992
Tested-by: Hudson CI
Marc-Andre Laperle [Sat, 6 Sep 2014 02:57:31 +0000 (22:57 -0400)]
ctf: Fix skipping tmf.ctf.swtbot when traces are unavailable
Change-Id: Ia08646391b1553dd039e977128c209be0faf4902
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32964
Tested-by: Hudson CI
Marc-Andre Laperle [Sat, 6 Sep 2014 01:06:43 +0000 (21:06 -0400)]
ctf: Fix skipping ctf.core.tests when traces are unavailable
Change-Id: I3fd1ddd2f08af03827f227533e86ce200884f286
Reviewed-on: https://git.eclipse.org/r/32963
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Thu, 4 Sep 2014 18:12:11 +0000 (14:12 -0400)]
ctf: Fix NPE when running CTF Platform-less
Change-Id: I1281750ccfd32015974eec0ef4ef29f984921a29
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32873
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Tue, 2 Sep 2014 17:43:46 +0000 (13:43 -0400)]
TMF: Add documentation for XML XY charts
Change-Id: Ib58d7e21ec199055440dd340d9f55150132143ec
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/32727
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Fri, 5 Sep 2014 12:23:40 +0000 (08:23 -0400)]
lttng-control: Support tcp4 string in session path (Bug 443403)
Change-Id: I4d13ce8d806ed92b3d99407bdc4ece5fcfbb308e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32923
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Fri, 5 Sep 2014 13:12:03 +0000 (09:12 -0400)]
ctf: Check that test traces exist before verifying checksum
Change-Id: I13858eb2eb5f2890716b503634a54fdf5a007551
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32928
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Thu, 4 Sep 2014 18:36:50 +0000 (14:36 -0400)]
lttng-control: fix null string in OpenCommandScriptDialog
Change-Id: Ifb668b85bfc99e68e93018827191bf303b12e222
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32877
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Wed, 3 Sep 2014 22:06:28 +0000 (18:06 -0400)]
lttng: Use checksums to detect corrupt test traces
This also means that we don't have to delete the downloaded files every
time we clean.
Also increase the timeout for smaller traces.
Change-Id: I9807371434b1e1c5b226c444f577b44bc663c1de
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32825
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Wed, 3 Sep 2014 18:31:27 +0000 (14:31 -0400)]
ctf: Fix a test on Windows
Change-Id: I6f355ca654243ac5c612afb7651b73f91f5fded3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32812
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Thu, 28 Aug 2014 03:15:58 +0000 (23:15 -0400)]
ctf: Provide a utility for "safe" mapping of a ByteBuffer
This works around a bug on Windows which prevents deleting a file after it
was mapped. See http://bugs.java.com/view_bug.do?bug_id=
4715154
Running TraceSeekBenchmark, I noticed a 10% decreased in performance (3.8s vs 3.4s) on Windows. On Linux, the difference is negligible (2.41s vs 2.40).
Change-Id: Ie590709df4149708a37257ee3bc3d3d017f31c21
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32448
Tested-by: Hudson CI
Marc-Andre Laperle [Tue, 2 Sep 2014 00:11:22 +0000 (20:11 -0400)]
ctf: Fix leak in CTFIteratorManager
Change-Id: I8fc12259b00b0b8e631e8a30590b38f8bcc0892b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32672
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 28 Aug 2014 19:24:30 +0000 (15:24 -0400)]
ctf: make CtfStreamInput not hold onto any resources
Change-Id: I61cb09c4c325479115084c54bba03d4746cd6610
Reviewed-on: https://git.eclipse.org/r/32553
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Fri, 29 Aug 2014 19:47:33 +0000 (15:47 -0400)]
TMF: Add benchmarks for timestamp transforms
Change-Id: I4b1e2c220473f1c9b7eba5002cbcdbfe4e5c56d8
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32575
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Wed, 27 Aug 2014 14:13:48 +0000 (10:13 -0400)]
tmf: lttngControl: Support 64 bit probe address and offset
Change-Id: I7506d0d7e57f9dd30bee014f5d59ac2061cb0052
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32406
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Simon Marchi [Fri, 22 Aug 2014 02:23:56 +0000 (22:23 -0400)]
Remove empty listener
This seems useless to me.
Change-Id: Ib5693687f49a36cb3d912f0c90c66d23c5dba11e
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/32117
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 27 Aug 2014 22:18:04 +0000 (18:18 -0400)]
tmf: Fix custom text parser wizard preview highlighting
- Does not match correctly when preview input has \r delimiters
- Throws PatternSyntaxException if pattern is invalid with many root
lines and at least one root line match in preview text
- Does not highlight the root line match if last line in preview text
Change-Id: Idc278df111edf93c37af53212a53a76d727c9d72
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32443
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Thu, 28 Aug 2014 19:49:01 +0000 (15:49 -0400)]
tmf: Use location OS string for validation path during drag and drop
The location URI path is not compatible with java.nio.file.Path in
Windows OS.
Change-Id: I80cf09ab54d8d3fffee23b6b3f692de15810eb56
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32510
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jonathan Rajotte Julien [Fri, 22 Aug 2014 21:10:42 +0000 (17:10 -0400)]
tmf: lttngControl: Fix remote import on remote snapshot session
Change-Id: Ic1e6f8724cd852a3b371f4eac3d8fd5a64f2f01a
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32183
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Thu, 21 Aug 2014 20:35:14 +0000 (16:35 -0400)]
tmf: Fix time unit of time stamp in TmfTrace.createTimestamp()
Change-Id: If0dc752f3d09dd447a70967909a68e68f6beaddc
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/32113
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 27 Aug 2014 16:40:39 +0000 (12:40 -0400)]
TMF: Move the fully incremental synchronization algorithm to internal
Change-Id: I789ca08ec74dcc18801f4389d80f21da5b06c0ad
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/32423
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 27 Aug 2014 16:24:22 +0000 (12:24 -0400)]
TMF: Do not synchronize traces once the algorithm fails
This way, we keep the last known good synchronization formula instead of
calculating the failed formula.
Change-Id: Idb02d598ea5d97f923adc3c79e70f51cfee1e46f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/32422
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Francis Giraldeau [Fri, 15 Aug 2014 18:51:57 +0000 (14:51 -0400)]
TMF: Correct bug when synchronizing more than 2 traces
Previously, when synchronizing more than 2 traces, it would return false
results when not all traces had a path to all others. Some timestamp transforms
need composition to be accurate wrt the reference trace
Change-Id: Ie71c4063970af5db1b1476d72351639342a149d8
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/31776
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 22 Aug 2014 21:34:54 +0000 (17:34 -0400)]
tmf: Update pcap developer guide following
5bbb3ba
Change-Id: I1f46043e180dea1f73e2bdc21e7e83e0059436a8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/32186
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Wed, 20 Aug 2014 21:13:47 +0000 (17:13 -0400)]
tmf: lttngControl: mi: Component and CreateSession tests
Change-Id: I34d0f08bebc08810c99e67a7002a67283bc96c56
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32019
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Wed, 13 Aug 2014 14:48:01 +0000 (10:48 -0400)]
tmf: lttngControl: basic mi test suite
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Change-Id: I9b5ab24a94cbd34db7c5d086c105eda0f4fc20f3
Reviewed-on: https://git.eclipse.org/r/31861
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Fri, 15 Aug 2014 21:37:37 +0000 (17:37 -0400)]
tmf: lttngControl: new enum TraceChannelOutputType
Change-Id: Ia2e77d9043f1cdbd08a4fdfcf265700b2bba194e
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31787
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Mon, 11 Aug 2014 17:07:35 +0000 (13:07 -0400)]
tmf: lttngControl: show error output first when handling error
This make sure that event in machine interface mode the error are
positioned first and are visible. Mi generate a lot of data and can
saturate the information dialog.
This also cut the need to do after execution checkup and error processing into the
new MI service Controller. If in the future post processing is necessary
one could override the function and do the post-processing.
Change-Id: I96f4f1a97745ed6048a180bfde3681ebc1ac0351
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31395
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Mon, 11 Aug 2014 14:55:50 +0000 (10:55 -0400)]
tmf: lttngControl: mi: support snapshot information
Change-Id: Idac3ad8e3b4166734d6580c7e791e312cd0d6ca0
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31394
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Mon, 11 Aug 2014 13:22:14 +0000 (09:22 -0400)]
tmf: lttngControl: mi: handle error via errorOutput
Change-Id: Ic54b1dae3013b445ca5f47732a8a22f11f1b0389
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31393
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Wed, 6 Aug 2014 22:06:31 +0000 (18:06 -0400)]
tmf: lttngControl: mi: support session creation
Change-Id: Ieaef13801acd1741dfdcc837abb96db4f55d371b
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31392
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Tue, 5 Aug 2014 20:58:44 +0000 (16:58 -0400)]
tmf: lttngControl: mi: support of domain, channel and event listing
Change-Id: Ia99caf1588c63160e7212d7efb7a61536bec617e
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31069
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Mon, 11 Aug 2014 17:32:50 +0000 (13:32 -0400)]
tmf: lttngControl: TraceLogLvl: add valueOfString utility
Change-Id: Ie0046d483c0bd47115bf0fe05660c13cbcc66ff1
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31391
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Tue, 5 Aug 2014 20:28:37 +0000 (16:28 -0400)]
tmf: lttngControl: mi: add machine interface related messages
Fix style issues at the same time.
Change-Id: I0fc3649d1145e0116bbdf6a3c655343fae8ef604
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31068
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Tue, 5 Aug 2014 20:11:49 +0000 (16:11 -0400)]
tmf: lttngControl: ProbeEventInfo: add constructor from EventInfo
Fix style issues at the same time
Change-Id: Ie329b9b4c0224785251d39b27b59c31d2397d137
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31067
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Tue, 5 Aug 2014 20:05:44 +0000 (16:05 -0400)]
tmf: lttngControl: TraceEventType: valueOfString utility function
Fix style issues at the same time.
Change-Id: I98624dbfb80e5f6104bea9fb35ec5c8fe91fe2c3
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31065
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Jonathan Rajotte Julien [Mon, 4 Aug 2014 17:18:51 +0000 (13:18 -0400)]
tmf: lttngControl: model: add TraceDomainType enum
Change-Id: I1e5e64f8e650705c2284b4ec193a5d0680de4f30
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30993
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Mon, 4 Aug 2014 15:21:42 +0000 (11:21 -0400)]
tmf: lttngControl: use utility function to find State
Fix some style issues at the same time.
Change-Id: Ia502cff3b0e226333ca2f5311c0c63f9f24be589
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30978
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Mon, 4 Aug 2014 15:20:46 +0000 (11:20 -0400)]
tmf: lttngControl: BufferType: mi support + utility function
Change-Id: I26f2f965067f9da8aebdca3c4d841956751fc0a8
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30977
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Fri, 15 Aug 2014 17:57:21 +0000 (13:57 -0400)]
tmf: lttngControl: TraceEnablement: mi support + utility function
Change-Id: Ib2cdddaaf37fa3ef0c8fa4ccfaa6d79ef4ee3714
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30976
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Mon, 4 Aug 2014 15:18:20 +0000 (11:18 -0400)]
tmf: lttngControl: LogLevelType: mi support + utility function
Change-Id: I6614b61ffa3f21caeaea1a0b03801dda237624a2
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30975
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte Julien [Thu, 31 Jul 2014 17:13:30 +0000 (13:13 -0400)]
tmf: lttngControl: mi: basic listing support
Change-Id: I8ca572f88d5fff69c27c4f1f345187b3d71b5d0b
Signed-off-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30822
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Mon, 25 Aug 2014 14:21:43 +0000 (10:21 -0400)]
pcap: fix bug with importing from control view in windows
The path to import in windows was /c:/bla/blabla which causes a crash
in PcapTrace that uses java.nio.file.Path. This patch ensures that
the remote import passes a valid path string.
Change-Id: I3d51bb9e3229e08f327c0d385452acb8c169f6ba
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32240
Tested-by: Hudson CI
Bernd Hufmann [Fri, 22 Aug 2014 15:03:04 +0000 (11:03 -0400)]
tmf: allow for list of validation patterns for text trace
Change-Id: I34846b45e6b7e64edd7f1c18958089b508405278
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32166
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Mon, 25 Aug 2014 19:51:49 +0000 (15:51 -0400)]
lttng: Fix lttng.control upgrade from 3.0.0 to 3.x.0
Change-Id: Ie2f419e7bb461c4dfb73f5ea01d68ced261b765f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32269
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Fri, 22 Aug 2014 12:21:05 +0000 (08:21 -0400)]
pcap: remove stream list analysis for experiments
The Stream List View doesn't support experiments right now. Also, the
analysis is per trace and not per experiment. The Stream List View
needs to be updated to fill the view with stream lists coming from
each child pcap trace.
Change-Id: Id0cb112ba64ba2d7aa5385ee2f9d2821d301b5cb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32144
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 20 Aug 2014 03:08:08 +0000 (23:08 -0400)]
ctf: improve unit tests
There were several recent changes introduced
to the ctf parser without fixing the test suite.
This patch brings the tests up to date and coverage up to 78%
Change-Id: I38b0f09d4005934d7a05d8cc3384ee7767bbd321
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31936
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 9 Jul 2014 19:29:04 +0000 (15:29 -0400)]
ctf: replace HashMaps with ArrayLists for EventDeclaration storage
Parser no longer supports events with IDs larger than Integer.MAX_VALUE
Change-Id: I088943c5a041f16638cb89b832ab79f8ef9c1d76
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/25924
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 8 Aug 2014 18:04:55 +0000 (14:04 -0400)]
tmf: Introduce ITmfEventTableColumns and its extension point
Instead of accidentally specifying the whole event table, trace types
can now only define the columns they want. This allows more (most)
trace types to use the default TmfEventsTable, which in turn allows more
trace types to be "aggregated" together in one table when put together
in the same experiment.
The previous "eventsTableType" extension remains there,
1) for compatibility purposes, but also
2) for trace types that do very specific things with their event
table and need to override the default one (ie, GdbTrace).
If a trace type provides both extension points, we'll first try to give
it its event table (ignoring the ITmfEventTableColumns info), and if we
can't because we're within an experiment for instance, then we'll fallback
to just use the columns.
Change-Id: Ie0c7fc9af62dc79aa3add8a605e02455e0df30c4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/31407
Tested-by: Hudson CI
Patrick Tasse [Fri, 15 Aug 2014 19:55:22 +0000 (15:55 -0400)]
tmf: Sort items in Select Trace Type menu
Categories sub-menus appear first, sorted alphabetically.
Uncategorized trace types appear last, sorted alphabetically.
Trace types in category sub-menus are not sorted and appear in the order
they are defined in their respective plug-in extension.
Change-Id: I87fe46b3c3a1e1d8ee490ef902d8244dde7801d2
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31778
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 14 Aug 2014 21:21:24 +0000 (17:21 -0400)]
pcap: Cleanup protocol enums
- Convert the Layer interface to an enum, merge with PcapProtocol
- Rework TmfPcapProtocol to not use .name() and .valueOf().
Change-Id: I3f61acf97ccdfbd9469a1f40fc3e9d74857e7afd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/31915
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 18 Aug 2014 18:13:27 +0000 (14:13 -0400)]
pcap: Rename Protocol to PcapProtocol
"Protocol" is a bit generic and can clash with many other types
of "protocols". Similarly, rename TmfProtocol to TmfPcapProtocol.
Change-Id: Id97624ccd37375065cf8df0e61aee98172872466
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/31914
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Mon, 18 Aug 2014 17:30:57 +0000 (13:30 -0400)]
tmf: display name of custom parser in properties view
Change-Id: I8e2f9baf01fc9570d7d200d19ee299a3d14f709a
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31850
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 13 Aug 2014 19:52:27 +0000 (15:52 -0400)]
ctf: make id conversions in event headers safer
Change-Id: I4fcfb986f5e1ff0010fcd4b6692075c3dbfd175e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31569
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 15 Aug 2014 18:49:13 +0000 (14:49 -0400)]
pcap: Make all the packages internal
The Pcap plugins are quite new and experimental, it's a bit early
to commit to a final API right now. Keep them internal for the
moment.
Change-Id: I4d01e2a9e493e20d1cc8d5b3065f5021f2632ddf
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/31775
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Fri, 15 Aug 2014 18:05:19 +0000 (14:05 -0400)]
tmf: Support + and - keys for histogram zoom
Change-Id: I9b4edffb70743a7421fd6040d8b1525da59cebe1
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31773
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 13 Aug 2014 03:21:51 +0000 (23:21 -0400)]
tmf: enable swtbot pcap tests
Change-Id: I21ee396f3edd2e24a6610751ee47df982acdfacc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Vincent Perot <vincent.perot@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31492
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 13 Aug 2014 03:18:39 +0000 (23:18 -0400)]
tmf: initial pcap smoke test
Change-Id: I9ec28d72d98620ccc7b16d94f4ad9798b744aa89
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Vincent Perot <vincent.perot@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31491
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 13 Aug 2014 03:18:06 +0000 (23:18 -0400)]
pcap: make test export packages
Change-Id: I084ed468ab6d6d5cfcae75e53a65dd88f2c08bf5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Vincent Perot <vincent.perot@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31490
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Thu, 14 Aug 2014 18:49:30 +0000 (14:49 -0400)]
lttng: user guide for new behaviour of opening of unrecognized traces
Change-Id: I8a79348950b034dfeb21a36b20a3d2ba5f30d7a7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31729
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Fri, 15 Aug 2014 13:33:30 +0000 (09:33 -0400)]
TMF: Move timestamp transform to internal to avoid API breakage later
The original timestamp transforms have been deprecated. The factory makes them
obsolete anyway.
Change-Id: I83d7fe9d2d78c93850e281d56d8201ea0f0b9177
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/31760
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 13 Aug 2014 02:18:17 +0000 (22:18 -0400)]
tmf: initial pcap swtbot test
This test will verify that all the views are correctly spawned.
Change-Id: I30717970c4b1d453aef872bb34d5a2eb541f42ac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Vincent Perot <vincent.perot@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31488
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 13 Aug 2014 01:45:54 +0000 (21:45 -0400)]
pcap: initial swtbot project
copy pasted from kernel ui swtbot. Will contain pcap specific tests.
Change-Id: Ic5bb371e99d156c6e6c509a5ee15c9020dc0f5ac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Vincent Perot <vincent.perot@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31487
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 15 Aug 2014 11:54:03 +0000 (07:54 -0400)]
tmf: Use custom parser constants of TmfTraceType evereywhere
Change-Id: I165c289d5fa3394deee47b631dec45a202987bdc
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31748
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 13 Aug 2014 23:11:54 +0000 (19:11 -0400)]
pcap: Convert filePath to java.nio.file.Path
The new Java 7 API for handling file paths is quite versatile,
and much more robust (cross-platform, etc.) than dealing with
simple Strings.
One note: I removed the check to verify that the files end in
".cap" or ".pcap". While it would still have been possible to
do with Path.toString(), on Unix typically the file contents
indicates the type, not the extension.
Change-Id: I327272dd99b298ccd61c1e53d4ded4ed79885d1c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/31596
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Vincent Perot <vincent.perot@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 13 Aug 2014 21:20:34 +0000 (17:20 -0400)]
pcap: Fix null warning in ProtocolConversion
Rework the ProtocolConversion utility class to switch/case
through the existing values, instead of relying on
non-null-annotated methods.
Also updated the documentation.
Change-Id: I9de733029de08e976acca313a8ad4601d3db0a8b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Vincent Perot <vincent.perot@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/31588
Tested-by: Hudson CI
Andrew Ferrazzutti [Thu, 14 Aug 2014 15:32:05 +0000 (11:32 -0400)]
Lttng: Attempt to resolve SWTBot test failure.
ImportAndReadKernelSmokeTest.test() sometimes fails
on openTrace() due to not being able to find the editor
view for the trace. Attempt to suppress this error by
having the workbench bot wait for the editor.
Change-Id: I60e6fc90efa49913d4b90b13c9445fcbc44c2277
Signed-off-by: Andrew Ferrazzutti <aferrazz@redhat.com>
Reviewed-on: https://git.eclipse.org/r/31681
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Wed, 6 Aug 2014 18:24:03 +0000 (14:24 -0400)]
tmf: open files without trace type with eclipse default editors
Also, the navigator content label was changed to delegate the
icon selection for files without trace types to the platform.
This allows users to double-click on any file and it will open with
either as a trace type or as a file in the default editor.
Change-Id: I362dd31c4394bb00fea8ff33bc4843f799ffb3de
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31134
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 14 Aug 2014 15:24:17 +0000 (11:24 -0400)]
rcp: add pcap feature to tracing rcp
Change-Id: I4518f97372c4f8481684f3673d090577611aede5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31679
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 13 Aug 2014 19:28:28 +0000 (15:28 -0400)]
pcap: Add feature plug-in
This patch includes
* Integrated in lttng/pom.xml
* Updates for the releng on Linux Tools level and LTTng level.
* Updated version numbers for PCAP to 1.0.0 (not starting at 3.1.0)
* Exported icons in tmf.pcap.ui
* Updated plug-in dependencies
Change-Id: Ie6319a453350193a99050edc4a7b396b771d0b9d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31563
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
This page took 0.046501 seconds and 5 git commands to generate.