Elena Oat [Wed, 19 Mar 2014 12:50:11 +0000 (14:50 +0200)]
Staging: rtl8188eu: Fix warning of braces are not necessary.
This patch fixes the warning of "braces are not necessary for single
statement blocks" in file rtw_ieee80211.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:49:44 +0000 (14:49 +0200)]
Staging: rtl8188eu: Fix warning of space prohibited.
This patch fixes the warning of "space prohibited before semicolon" in
file rtw_efuse.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:49:11 +0000 (14:49 +0200)]
Staging: rtl8188eu: Fix warning of braces not necessary.
This small patch fixes the warning of "braces are
necessary for any arm of this statement" in file rtw_efuse.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:48:44 +0000 (14:48 +0200)]
Staging: rtl8188eu: Fix warnings of no space before tabs.
This patch fixes the warning of "please, no space before tabs" in file
rtw_efuse.c. I have also modified the style of the comments for
readability.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Wed, 19 Mar 2014 12:47:52 +0000 (14:47 +0200)]
Staging: rtl8188eu: Fix warning of space prohibited.
This small patch fixes the warning of "space prohibited before
semicolon" in file rtw_debug.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chi Pham [Tue, 18 Mar 2014 22:10:50 +0000 (23:10 +0100)]
staging: rtl8188eu: Reduced nesting and improved coding style.
Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 23:35:47 +0000 (01:35 +0200)]
staging:lustre:lnet: lib-types.h Fix open brace '{' err.
Fix checkpatch.pl issues with open brace '{' following
struct go on the same line in lib-types.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 22:41:47 +0000 (00:41 +0200)]
staging:lustre:lnet: lib-types.h Fix unnecessary space func. pointer name.
Fix checkpatch.pl issues with
unnecessary space after function pointer name in lib-types.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Tue, 18 Mar 2014 21:12:38 +0000 (23:12 +0200)]
staging: lustre: add an extra line
Add an extra line break between the variable
declaration and the rest of the code
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 22:33:41 +0000 (00:33 +0200)]
Staging: rtl8188eu: Fix warnings of no space before tabs.
This patch fixes the warnings of "please, no space before tabs" in the
file rtw_mlme.c. I have also modified the comment style and removed some
unnecessary tabs.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 20:59:47 +0000 (22:59 +0200)]
Staging: rtl8188eu: Fix warnings of space prohibited.
This patch fixes the warnings of "space prohibited between function name
and open parenthesis" in file rtw_mlme.c.
While at it, I have also removed unneccessary tabs. Also one comment
that didn't make sense was removed.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Acked-by: Luis R. Rodriguez <mcgrof@do-not-panic.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 20:09:21 +0000 (22:09 +0200)]
Staging: rtl8188eu: Fix warning of braces {} are not necessary.
This patch fixes the warning of "braces {} are not necessary for single
statement blocks" in file rtw_mlme.c. I have removed the else statement
in one case, as it didn't have any value.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:08 +0000 (19:25 +0000)]
staging: vt6656: s_uGetRTSCTSRsvTime fix return.
Always returns to __le16 type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:07 +0000 (19:25 +0000)]
staging: vt6656: vnt_rxtx_rsvtime_le16 fix return.
Always returns to __le16 type.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:06 +0000 (19:25 +0000)]
staging: vt6656: s_uGetDataDuration use __le16.
s_uGetDataDuration always returns to __le16 type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:05 +0000 (19:25 +0000)]
staging: vt6656: Correct return type s_uGetRTSCTSDuration.
s_uGetRTSCTSDuration always returns in __le16 type
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:04 +0000 (19:25 +0000)]
staging: vt6656: rxtx endian correct return duration
All duration base types are __le16 correct back to cpu
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:03 +0000 (19:25 +0000)]
staging: vt6656: vnt_time_stamp_off fix return to __le16
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:02 +0000 (19:25 +0000)]
staging: vt6656: struct vnt_tx_short_buf_head correct base types
Both variables duration and time_stamp_off are __le16 types
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:01 +0000 (19:25 +0000)]
staging: vt6656: rxtx Replace wTimeStampOff* variables
Fix base type to __le16 and remove camel case.
Camel case changes
wTimeStampOff* -> time_stamp_off*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:25:00 +0000 (19:25 +0000)]
staging: vt6656: rxtx Replace wCTSTxRrvTime_ba
Replace with cts_rrv_time_ba with __le16 base.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:59 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wCTSDuration*
Fix base type to __le16 and remove camel case.
Camel case changes
wCTSDuration* -> cts_duration*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:58 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wTxRrvTime*
Fix base type to __le16 and remove camel case.
Camel case changes
wTxRrvTime* -> rrv_time*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:57 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wRTSTxRrvTime*
Fix base type to __le16 and remove camel case.
Camel case changes
wRTSTxRrvTime* -> rts_rrv_time*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:56 +0000 (19:24 +0000)]
staging: vt6656: rxtx: Replace wRTSDuration* variables
Fix base type to __le16 and remove camel case.
Camel case changes
wRTSDuration* -> rts_duration*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Tue, 18 Mar 2014 19:24:55 +0000 (19:24 +0000)]
staging: vt6656: rxtx Replace wDuration* variables.
Fix base type to __le16 and remove camel case.
Camel case changes
wDuration* -> duration*
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Mar 2014 15:10:52 +0000 (11:10 -0400)]
staging: dgap: re-factor some more code for 80+ lines
This patch fixes more 80+ char lines as reported by checkpatch
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Mar 2014 15:10:51 +0000 (11:10 -0400)]
staging: dgap: get rid of DGAP_LOCK and DGAP_UNLOCK macros
This patch replaces the DGAP_LOCK and DGAP_UNLOCK macros with
spin_lock_irqsave spin_unlock_irqrestore.
Signed-off-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mark Hounschell [Wed, 19 Mar 2014 15:10:50 +0000 (11:10 -0400)]
staging: dgap: re-factor some code for 80+ lines as reported by checkpatch
This patch re-factors some code to fix some 80+ lines as reported by checkpatch.
This patch was suggested and authored by Dan Carpenter. A test case for this
patch has been written and used to show the patch to be correct.
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mark Hounschell <markh@compro.net>
Tested-by: Mark Hounschell <markh@compro.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Wed, 19 Mar 2014 08:20:33 +0000 (09:20 +0100)]
staging: wlags49_h2: Correct comment style in wl_netdev.c
Code is using C99 code style, so change them to kernel style
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Wed, 19 Mar 2014 08:20:32 +0000 (09:20 +0100)]
staging: wlags49_h2: remove commented code in wl_netdev.c
Remove unused code under C99 comment style
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Maret [Wed, 19 Mar 2014 08:20:31 +0000 (09:20 +0100)]
staging: wlags49_h2: reindent wl_netdev.c
As the file is using a mix between space and tab,
and space instead of tab, use Lindent to fix the file
Signed-off-by: Mathieu Maret <mathieu.maret@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Wed, 19 Mar 2014 04:24:31 +0000 (23:24 -0500)]
Staging: comedi: proc: title block update
Follow up patch for "STAGING: comedi: style and checkpatch fixes".
Removes the file name in the comment block per suggestions.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gary Rookard [Tue, 18 Mar 2014 20:17:28 +0000 (16:17 -0400)]
Staging: bcm: CmHost: moved and removed declarations and tmp bracing.
Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppressors in the form of extra tmp bracing added to the case labels.
They aid during construction time, but are not intended to remain.
In this scenario there are declarations occupying space only
reserved for statements. If these tmp braces were to be removed
before the declarations in question were reassigned to there
proper place in the funtion, compile time errors would result.
So, having that said, I moved the declarations,
UINT uiSearchRuleIndex = 0; and ULONG ulSFID;,
and also deleted the duplicates thereof from
the switch/case statement.
Removed temporary bracing from case labels.
Removed new lines as needed.
Properly indented case breaks.
Added /* FALLTHROUGH */ comments to switch/case.
Signed-off-by: Gary Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Masood Mehmood [Tue, 18 Mar 2014 20:40:14 +0000 (13:40 -0700)]
staging: dgap: Fixed sparse error: same symbol redeclared with different type
sparse reported dgap_do_fep_load is redeclared with different type. while
fixing, I noticed __user attribute is used incorrectly in declaration.
There is no need to define __user for firware->data.
Replaced the __user with 'const uchar *' from function dgap_do_fep_load and
did the same for function dgap_do_bios_load
patch generated against: next-
20140318
Signed-off-by: Masood Mehmood <ody.guru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Silvio F [Tue, 18 Mar 2014 21:13:10 +0000 (22:13 +0100)]
staging: unisys: kmalloc/memset to kzalloc conversation
This patch solves the Coccinelle warning: "kzalloc should be used
instead of kmalloc/memset"
This patch is a fixup for
linux-next:
97a84f1203786985856a0d4b49b1d7cc387238ce
"Staging: unisys: Replace kmalloc/memset with kzalloc"
The ALLOC_CMDRSP #define is after transformation to kzalloc only a
rename for kzalloc and was completly removed.
Signed-off-by: Silvio F <silvio.fricke@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Richard Weinberger [Tue, 18 Mar 2014 23:07:05 +0000 (00:07 +0100)]
staging/xillybus: Handle OOM in xillybus_init()
alloc_workqueue() can fail and returns NULL in case of
OOM.
Handle this case and undo class_create().
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mikhail Boiko [Tue, 18 Mar 2014 21:59:46 +0000 (23:59 +0200)]
staging: line6: Fix coding style problem
Fix style issue for eudyptula challenge
Signed-off-by: Mikhail Boiko <mm.boiko@yandex.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 18 Mar 2014 19:35:16 +0000 (01:05 +0530)]
Staging:
ced1401: Fix no new typedef warning in ced_ioctl.h
This patch fixes following checkpatch.pl warnings:
WARNING:do not add new typedefs.All the related files have been modified.
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Tue, 18 Mar 2014 19:36:35 +0000 (01:06 +0530)]
Staging:
ced1401: Fix typedef warnings in ced_ioctl.h
This patch fixes following checkpatch.pl warnings:
WARNING:do not add new typedefs.
In this patch i have also renamed TransferDesc to transfer_area_desc in order to clearly indicate
that it describes the transfer area.
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Keerthimai Janarthanan [Tue, 18 Mar 2014 19:08:59 +0000 (00:38 +0530)]
staging: usbip: Fix quoted string split across lines.
Fix quoted string split across lines.
Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 19:13:29 +0000 (21:13 +0200)]
staging/octeon:ethernet-rgmii.c: Fix line over 80 characters.
checkpatch.pl issues with line over
80 characters in ethernet-rgmii.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Daeseok Youn [Tue, 18 Mar 2014 00:45:40 +0000 (09:45 +0900)]
staging: cxt1e1: remove unneeded mkret() calls
The mkret() change a value of error from positive to
negative. This patch is modified to return negative value
when it failed. It doesn't need to call with function
for changing from positive to negative.
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Michael Welling [Tue, 18 Mar 2014 07:14:20 +0000 (02:14 -0500)]
STAGING: comedi: style and checkpatch fixes
Updates block comment per Documentation/CodingStyle.
Also updated due to checkpatch warnings about qouted string
after Lindent modified the spacing slightly.
Signed-off-by: Michael Welling <mwelling@ieee.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 18:22:18 +0000 (20:22 +0200)]
Staging: rtl8188eu: Fix warning of printk() should include KERN_ facility level.
This patch fixes the warning of "printk() should include KERN_ facility
level" in file rtw_debug.c.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elena Oat [Tue, 18 Mar 2014 17:16:49 +0000 (19:16 +0200)]
Staging: rtl8188eu: Fix warning of unchecked sscanf return value.
This patch fixes the warning "unchecked sscanf return value" in file
rtw_mp.c. Zero is returned in case sscanf fails or if less than expected
items are read and assigned successfully. I have decided to return zero,
because in previous conditional statements zero was returned in case of
failure.
While at it, I have also fixed the warning of line over 80
characters.
Signed-off-by: Elena Oat <oat.elena@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Tue, 18 Mar 2014 18:45:59 +0000 (20:45 +0200)]
staging/speakup:speakup_dectlk.c Fix line over 80 characters.
checkpatch.pl issues with line over
80 characters in speakup_dectlk.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Georgiana Rodica Chelu [Tue, 18 Mar 2014 15:26:57 +0000 (17:26 +0200)]
staging: luster: do not combine value 0 with |
There is no point in combining a variable
that is 0 with other things with |
The semantic patch used:
@@
expression x,e,e1;
statement S;
@@
if (x == 0) {
<... when != x = e1
when != while(...) S
when != for(...;...;...) S
- x |= e
+ x = e
...>
}
Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Mon, 17 Mar 2014 22:25:56 +0000 (00:25 +0200)]
staging: addac: adt7316.c: Fix line over 80 characters
Fix checkpatch.pl issues with line over 80 characters in adt7316.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 13:21:52 +0000 (15:21 +0200)]
staging: rtl8192e: Fix quoted string split across lines
Fix checkpatch.pl issues with quoted string split across lines in
dot11d.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andreea-Cristina Bernat [Sun, 16 Mar 2014 20:21:41 +0000 (22:21 +0200)]
Staging: lirc: Fix warning: assignment of bool to 0/1
This patch solves the warning "Assignment of bool to 0/1"
Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Tue, 18 Mar 2014 15:05:56 +0000 (17:05 +0200)]
staging: slicoss: free IO remapping on failure
Make sure iounmap is always called after ioremap when module loading
fails. Also remove a call to release_mem_region because that region is
never reserved in the first place.
Fixes the following issue reported by Coccinelle:
drivers/staging/slicoss/slicoss.c:3727:1-7: ERROR: missing iounmap; ioremap on line 3661 and execution via conditional on line 3677
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 13:42:32 +0000 (15:42 +0200)]
staging: rtl8712: Fix multiple spaces after return type
Fix checkpatch.pl issues with multiple spaces after return type in
drv_types.h
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Mon, 17 Mar 2014 23:39:25 +0000 (01:39 +0200)]
staging/rtl8712/osdep_service.h Fix line over 80 characters.
Fix checkpatch.pl issues with
line over 80 characters in osdep_service.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 12 Mar 2014 16:51:13 +0000 (22:21 +0530)]
staging:ozwpan:Fix sparse warning of cast to restricted __le16
This patch fixes the following sparse warnings:
drivers/staging/ozwpan/ozusbsvc1.c:391:36: warning: cast to restricted __le16
drivers/staging/ozwpan/ozusbsvc1.c:393:33: warning: cast to restricted __le16
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Wed, 12 Mar 2014 16:50:32 +0000 (22:20 +0530)]
staging:ozwpan:Fix sparse warning of incorrect argument type
This patch fixes the following sparse warning:
drivers/staging/ozwpan/ozusbsvc1.c:208:50: warning: incorrect type in argument 6 (different base types)
drivers/staging/ozwpan/ozusbsvc1.c:208:50: expected unsigned short [unsigned] [usertype] windex
drivers/staging/ozwpan/ozusbsvc1.c:208:50: got restricted __le16 [usertype] wIndex
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Wed, 12 Mar 2014 19:30:32 +0000 (21:30 +0200)]
staging: rts5208: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in rtsx_card.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Sun, 16 Mar 2014 15:32:28 +0000 (17:32 +0200)]
staging/silicom/bypasslib/bp_ioctl.h Fix do not add new typedefs.
Fix checkpatch.pl issues with do not add
new typedefs in bp_ioctl.h
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:31 +0000 (19:45 -0400)]
staging: bcm: Remove unneeded boolean comparisons and reflow lines
Removes needless boolean TRUE and false comparisons and reflows some lines to
eliminate over 80 character if statments.
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:30 +0000 (19:45 -0400)]
staging: bcm: Fix space before semicolon
Fixes several checkpatch
WARNING: space prohibited before semicolon
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:29 +0000 (19:45 -0400)]
staging: bcm: Fix lines over 80 characters
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:28 +0000 (19:45 -0400)]
staging: bcm: Cleanup unneeded boolean comparisons
Cleans up a few needless comparisons with booleans and cleans up an
interupt handler to take advantage of earlier bailout shortcircuit.
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:27 +0000 (19:45 -0400)]
staging: bcm: Cleanup CreateInterruptUrb() and StartInterruptUrb()
Fixes checkpatch.pl warnings and errors:
ERROR: that open brace { should be on the previous line
+ if (!psIntfAdapter->psInterruptUrb)
+ {
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot allocate interrupt urb");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot allocate interrupt urb");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot allocate interrupt urb");
^
WARNING: line over 80 characters
+ psIntfAdapter->ulInterruptData;
WARNING: line over 80 characters
+ sizeof(psIntfAdapter->ulInterruptData);
WARNING: line over 80 characters
+ psIntfAdapter->sIntrIn.int_in_endpointAddr);
WARNING: line over 80 characters
+ psIntfAdapter->psInterruptUrb->transfer_buffer,
WARNING: line over 80 characters
+ psIntfAdapter->psInterruptUrb->transfer_buffer_length,
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt Interval: %d\n",
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt Interval: %d\n",
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt Interval: %d\n",
^
ERROR: that open brace { should be on the previous line
+ if( false == psIntfAdapter->psAdapter->device_removed &&
+ false == psIntfAdapter->psAdapter->bEndPointHalted &&
+ false == psIntfAdapter->bSuspended &&
+ false == psIntfAdapter->bPreparingForBusSuspend &&
+ false == psIntfAdapter->psAdapter->StopAllXaction)
+ {
ERROR: space prohibited after that open parenthesis '('
+ if( false == psIntfAdapter->psAdapter->device_removed &&
ERROR: space required before the open parenthesis '('
+ if( false == psIntfAdapter->psAdapter->device_removed &&
WARNING: line over 80 characters
+ status = usb_submit_urb(psIntfAdapter->psInterruptUrb, GFP_ATOMIC);
ERROR: that open brace { should be on the previous line
+ if (status)
+ {
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot send int urb %d\n", status);
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot send int urb %d\n", status);
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Cannot send int urb %d\n", status);
^
ERROR: that open brace { should be on the previous line
+ if(status == -EPIPE)
+ {
ERROR: space required before the open parenthesis '('
+ if(status == -EPIPE)
WARNING: line over 80 characters
+ psIntfAdapter->psAdapter->bEndPointHalted = TRUE ;
WARNING: space prohibited before semicolon
+ psIntfAdapter->psAdapter->bEndPointHalted = TRUE ;
WARNING: line over 80 characters
+ wake_up(&psIntfAdapter->psAdapter->tx_packet_wait_queue);
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:26 +0000 (19:45 -0400)]
staging: bcm: Cleanup switch statement
Fixes checkpatch.pl warnings and errors:
ERROR: switch and case should be at the same indent
+ switch (status) {
[...]
+ case STATUS_SUCCESS:
[...]
+ case -ENOENT :
[...]
+ case -EINPROGRESS:
[...]
+ case -EPIPE:
[...]
+ case -ECONNRESET: //URB got unlinked.
+ case -ESHUTDOWN: // hardware gone. this is the serious problem.
[...]
+ case -ENODEV : //Device got removed
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
[...]
+ default:
ERROR: that open brace { should be on the previous line
+ if ( urb->actual_length )
+ {
ERROR: space prohibited after that open parenthesis '('
+ if ( urb->actual_length )
ERROR: space prohibited before that close parenthesis ')'
+ if ( urb->actual_length )
ERROR: that open brace { should be on the previous line
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF)
+ {
ERROR: space required before the open parenthesis '('
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF)
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "Got USIM interrupt");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "Got USIM interrupt");
^
ERROR: that open brace { should be on the previous line
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF00)
+ {
ERROR: space required before the open parenthesis '('
+ if(psIntfAdapter->ulInterruptData[1] & 0xFF00)
WARNING: line over 80 characters
+ (psIntfAdapter->ulInterruptData[1] & 0xFF00) >> 8);
WARNING: space prohibited between function name and open parenthesis '('
+ atomic_set (&Adapter->uiMBupdate, TRUE);
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "TX mailbox contains %d",
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL, "TX mailbox contains %d",
^
+ atomic_read(&Adapter->CurrNumFreeTxDesc));
ERROR: that open brace { should be on the previous line
+ if(psIntfAdapter->ulInterruptData[1] >> 16)
+ {
ERROR: space required before the open parenthesis '('
+ if(psIntfAdapter->ulInterruptData[1] >> 16)
ERROR: spaces required around that '=' (ctx:VxE)
+ Adapter->CurrNumRecvDescs=
^
WARNING: line over 80 characters
+ (psIntfAdapter->ulInterruptData[1] >> 16);
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"RX mailbox contains %d",
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"RX mailbox contains %d",
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"RX mailbox contains %d",
^
ERROR: that open brace { should be on the previous line
+ if(Adapter->fw_download_done &&
+ !Adapter->downloadDDR &&
+ atomic_read(&Adapter->CurrNumFreeTxDesc))
+ {
ERROR: space required before the open parenthesis '('
+ if(Adapter->fw_download_done &&
ERROR: spaces required around that '+=' (ctx:WxV)
+ psIntfAdapter->psAdapter->downloadDDR +=1;
^
ERROR: that open brace { should be on the previous line
+ if(false == Adapter->waiting_to_fw_download_done)
+ {
ERROR: space required before the open parenthesis '('
+ if(false == Adapter->waiting_to_fw_download_done)
ERROR: that open brace { should be on the previous line
+ if(!atomic_read(&Adapter->TxPktAvail))
+ {
ERROR: space required before the open parenthesis '('
+ if(!atomic_read(&Adapter->TxPktAvail))
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Firing interrupt in URB");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Firing interrupt in URB");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Firing interrupt in URB");
^
ERROR: space prohibited before that ':' (ctx:WxE)
+ case -ENOENT :
^
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"URB has got disconnected ....");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"URB has got disconnected ....");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"URB has got disconnected ....");
^
WARNING: space prohibited before semicolon
+ return ;
WARNING: line over 80 characters
+ //This situation may happened when URBunlink is used. for detail check usb_unlink_urb documentation.
ERROR: do not use C99 // comments
+ //This situation may happened when URBunlink is used. for detail check usb_unlink_urb documentation.
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Impossibe condition has occurred... something very bad is going on");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Impossibe condition has occurred... something very bad is going on");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Impossibe condition has occurred... something very bad is going on");
^
WARNING: space prohibited before semicolon
+ break ;
ERROR: do not use C99 // comments
+ //return;
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt IN endPoint has got halted/stalled...need to clear this");
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt IN endPoint has got halted/stalled...need to clear this");
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"Interrupt IN endPoint has got halted/stalled...need to clear this");
^
WARNING: space prohibited before semicolon
+ Adapter->bEndPointHalted = TRUE ;
WARNING: space prohibited before semicolon
+ urb->status = STATUS_SUCCESS ;
ERROR: do not use C99 // comments
+ case -ECONNRESET: //URB got unlinked.
WARNING: line over 80 characters
+ case -ESHUTDOWN: // hardware gone. this is the serious problem.
ERROR: do not use C99 // comments
+ case -ESHUTDOWN: // hardware gone. this is the serious problem.
WARNING: line over 80 characters
+ //Occurs only when something happens with the host controller device
ERROR: code indent should use tabs where possible
+^I ^I^I^I^I^I^I//Occurs only when something happens with the host controller device$
WARNING: please, no space before tabs
+^I ^I^I^I^I^I^I//Occurs only when something happens with the host controller device$
ERROR: do not use C99 // comments
+ //Occurs only when something happens with the host controller device
ERROR: do not use C99 // comments
+ case -ENODEV : //Device got removed
ERROR: space prohibited before that ':' (ctx:WxW)
+ case -ENODEV : //Device got removed
^
WARNING: line over 80 characters
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
ERROR: do not use C99 // comments
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
ERROR: space prohibited before that ':' (ctx:WxW)
+ case -EINVAL : //Some thing very bad happened with the URB. No description is available.
^
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);
ERROR: code indent should use tabs where possible
+^I ^IBCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);$
WARNING: please, no space before tabs
+^I ^IBCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);$
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, INTF_INIT, DBG_LVL_ALL,"interrupt urb error %d", status);
^
WARNING: space prohibited before semicolon
+ urb->status = STATUS_SUCCESS ;
WARNING: space prohibited before semicolon
+ break ;
ERROR: do not use C99 // comments
+ //return;
ERROR: spaces required around that ':' (ctx:VxE)
+ default:
^
WARNING: line over 80 characters
+ //This is required to check what is the defaults conditions when it occurs..
ERROR: do not use C99 // comments
+ //This is required to check what is the defaults conditions when it occurs..
WARNING: line over 80 characters
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, NEXT_SEND, DBG_LVL_ALL,"GOT DEFAULT INTERRUPT URB STATUS :%d..Please Analyze it...", status);
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, NEXT_SEND, DBG_LVL_ALL,"GOT DEFAULT INTERRUPT URB STATUS :%d..Please Analyze it...", status);
^
ERROR: space required after that ',' (ctx:VxV)
+ BCM_DEBUG_PRINT(Adapter,DBG_TYPE_TX, NEXT_SEND, DBG_LVL_ALL,"GOT DEFAULT INTERRUPT URB STATUS :%d..Please Analyze it...", status);
^
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:25 +0000 (19:45 -0400)]
staging: bcm: Cleanup real_int_callback()
Fixes checkpatch.pl warnings and errors and removes some dead code.
Checkpath warnings and errors fixed:
WARNING: line over 80 characters
WARNING: space prohibited before semicolon
ERROR: that open brace { should be on the previous line
ERROR: space required before the open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jade Bilkey [Mon, 17 Mar 2014 23:45:24 +0000 (19:45 -0400)]
staging: bcm: Fix checkpatch errors
This patch fixes the following checkpatch errors:
ERROR: space prohibited after that '&' (ctx:WxW)
+ memcpy((PVOID) & pstHostMibs->
^
ERROR: space prohibited after that '&' (ctx:WxW)
+ (PVOID) & Adapter->
^
ERROR: space prohibited after that '&' (ctx:WxW)
+ memcpy((PVOID) & pstHostMibs->astSFtable[nSfIndex],
^
ERROR: space prohibited after that '&' (ctx:WxW)
+ (PVOID) & Adapter->PackInfo[nSfIndex],
^
Signed-off-by: Jade Bilkey <herself@thefumon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tugce Sirin [Mon, 17 Mar 2014 14:02:13 +0000 (16:02 +0200)]
Staging: wlan-ng: Fix quoted string split across lines
This patch fixes checkpatch.pl warning quoted string split across lines
in wlan-ng driver.
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tugce Sirin [Mon, 17 Mar 2014 14:02:05 +0000 (16:02 +0200)]
Staging: wlan-ng: Fix prefer netdev_info to printk
This patch fixes checkpatch.pl error prefer netdev_info to printk in
wlan-ng driver.
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tugce Sirin [Mon, 17 Mar 2014 14:01:51 +0000 (16:01 +0200)]
Staging: wlan-ng: Fix prefer netdev_err to printk
This patch fixes checkpatch.pl error prefer netdev_error to printk in
wlan-ng driver.
Signed-off-by: Tugce Sirin <ztugcesirin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Sun, 9 Mar 2014 18:36:21 +0000 (20:36 +0200)]
Staging: winbond: Fix printk() should include KERN_ facility level in wb35rx.c
Fix checkpatch.pl issues with printk() should include
KERN_ facility level in wb35rx.c
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 9 Mar 2014 18:11:07 +0000 (20:11 +0200)]
staging:imx-drm: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in imx-hdmi.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Mon, 17 Mar 2014 21:55:53 +0000 (23:55 +0200)]
staging: imx-drm: imx-ldb.c Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in imx-ldb.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Monam Agarwal [Sun, 16 Mar 2014 10:08:39 +0000 (15:38 +0530)]
Staging: gdm724x: Fix unchecked sscanf values in gdm_lte.c
This patch fixes following checkpatch.pl warning:
WARNING: unchecked sscanf value in gdm_lte.c
Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 14:59:43 +0000 (16:59 +0200)]
staging: rtl8821ae: Fix no space before tabs.
Fix checkpatch.pl issues with no space before tabs in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sun, 16 Mar 2014 18:25:00 +0000 (23:55 +0530)]
staging:rtl8821ae: Fix sparse warnings of cast truncates bits from constant value
This patch fixes the following sparse warnings:
drivers/staging/rtl8821ae/rtl8821ae/phy.c:444:39: warning: cast truncates bits from constant value (
ffffff01 becomes 1)
drivers/staging/rtl8821ae/rtl8821ae/phy.c:445:39: warning: cast truncates bits from constant value (
ffffff01 becomes 1)
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 14:51:56 +0000 (16:51 +0200)]
staging: rtl8821ae: Fix quoted string split across lines
Fix checkpatch.pl issues with quoted string split across lines in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 14:44:10 +0000 (16:44 +0200)]
staging: rtl8821ae: Fix space required before the open parenthesis '('
Fix checkpatch.pl issues with space required before the open parenthesis
'(' error in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 14:40:07 +0000 (16:40 +0200)]
staging: rtl8821ae: Fix do not use C99 // comments
Fix checkpatch.pl issues with do not use C99 // comments in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 14:22:06 +0000 (16:22 +0200)]
staging: rtl8821ae: Fix unnecessary whitespace before a quoted newline
Fix checkpatch.pl issues with unnecessary whitespace before a quoted
newline in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 16 Mar 2014 14:16:38 +0000 (16:16 +0200)]
staging: rtl8821ae: Fix code indent should use tabs where possible
Fix checkpatch.pl issues with code indent should use tabs where possible in base.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Sun, 9 Mar 2014 14:30:57 +0000 (16:30 +0200)]
drivers/staging/serqt_usb2:serqt_usb2.c Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80
characters in serqt_usb2.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jelena Bjelja [Sun, 16 Mar 2014 14:08:48 +0000 (15:08 +0100)]
staging: wlags49_h2: Fix sparse warning for static declaration
Fix the following sparse warning:
drivers/staging/wlags49_h2/wl_netdev.c:533:6: warning: symbol 'wl_poll'
was not declared. Should it be static?
Signed-off-by: Jelena Bjelja <jelena.bjelja.ing@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Keerthimai Janarthanan [Tue, 18 Mar 2014 08:40:13 +0000 (14:10 +0530)]
staging: speakup: Prefer pr_err instead of printk(KERN_ERR)
Prefer pr_err instead of printk(KERN_ERR)
Signed-off-by: Keerthimai Janarthanan <keerthimaipb@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:47 +0000 (17:50 +0100)]
staging: rtl8192u: Convert from printk into netdev_err or netdev_info
Convert from printk functions into netdev_err or netdev_info in
ieee80211/dot11d.c
Fix checkpatch.pl warning:
WARNING: printk() should include KERN_ facility level
WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:46 +0000 (17:50 +0100)]
staging: rtl8192u: Move export_symbol below its function
Move export_symbol below its function in ieee80211/dot11d.c
Fix checkpatch.pl warning:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:45 +0000 (17:50 +0100)]
staging: rtl8192u: fix coding style in function definition
Remove innecessary spaces and indentation errors in function definition
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:44 +0000 (17:50 +0100)]
staging: rtl8192u: Add whitespace in ieee80211/dot11d.c
Add whitespace in ieee80211/dot11d.c and fix coding style these lines
when It is necessary
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:43 +0000 (17:50 +0100)]
staging: rtl8192u: Delete unnecesary braces in ieee80211/dot11d.c
Delete unnecesary braces and fix coding style these lines when It is
necessary in ieee80211/dot11d.c
Fix checkpatch.pl errors:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:42 +0000 (17:50 +0100)]
staging: rtl8192u: Move open brace on the previous line
Move open brace on the previous line and fix coding style in
these lines when It is necessary in ieee80211/dot11d.c
Fix checkpatch.pl errors:
ERROR: that open brace { should be on the previous line
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:41 +0000 (17:50 +0100)]
staging: rtl8192u: Clean-up comment line style in ieee80211/dot11d.c
Convert style of comments from C99-style to C89 and fix coding style in
these lines when It is necessary.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ana Rey [Tue, 18 Mar 2014 16:50:40 +0000 (17:50 +0100)]
staging: rtl8192u: Delete commented code in ieee80211/dot11d.c
Delete all commented code in ieee80211/dot11d.c that are not necessary.
Signed-off-by: Ana Rey <anarey@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Sun, 16 Mar 2014 22:37:56 +0000 (04:07 +0530)]
staging:rtl8192u: drop explicit externs
This patch removes use of explicit extern specifier and quietens the
sparse warnings:
drivers/staging/rtl8192u/r8192U_dm.c:159:1: warning: function 'init_hal_dm' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:179:13: warning: function 'deinit_hal_dm' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:245:17: warning: function 'hal_dm_watchdog' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:278:13: warning: function 'init_rate_adaptive' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:878:17: warning: function 'dm_txpower_trackingcallback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1609:13: warning: function 'dm_cck_txpower_adjust' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1776:13: warning: function 'dm_change_dynamic_initgain_thresh' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1846:1: warning: function 'dm_change_fsync_setting' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:1863:1: warning: function 'dm_change_rxpath_selection_setting' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:2543:13: warning: function 'dm_init_edca_turbo' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:2663:13: warning: function 'DM_CTSToSelfSetting' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:2782:17: warning: function 'dm_rf_pathcheck_workitemcallback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:3142:13: warning: function 'dm_fsync_timer_callback' with external linkage has definition
drivers/staging/rtl8192u/r8192U_dm.c:3481:13: warning: function 'dm_shadow_init' with external linkage has definition
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Sun, 16 Mar 2014 05:27:54 +0000 (07:27 +0200)]
staging: media: omap24xx: tcm825x.c Fix that open brace { should be on the previous line
The patch fixes the following checkpatch.pl errors:
ERROR: that open brace { should be on the previous line.
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chi Pham [Sun, 9 Mar 2014 13:55:14 +0000 (14:55 +0100)]
staging:media: Removed assignments from if statements.
The following coccinelle script found the match:
@simple@
expression E1, E2;
statement S1, S2;
@@
+ E1 = E2;
if (
- (E1 = E2)
+ E1
)
S1 else S2
@left@
expression E0, E1, E2;
statement S0, S1;
@@
- if ((E1 = E2) < E0)
+ E1 = E2;
+ if (E1 < E0)
S1
Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Mon, 17 Mar 2014 13:58:44 +0000 (19:28 +0530)]
staging: vt6656: Fix sparse warnings
This patch fixes the following sparse warnings:
drivers/staging/vt6656/aes_ccmp.c:272:32: warning: restricted __le16 degrades to integer
drivers/staging/vt6656/aes_ccmp.c:274:32: warning: restricted __le16 degrades to integer
drivers/staging/vt6656/aes_ccmp.c:282:32: warning: restricted __le16 degrades to integer
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Himangi Saraogi [Mon, 17 Mar 2014 09:23:10 +0000 (14:53 +0530)]
staging:vt6655: Fix sparse warnings of using plain integer as NULL pointer
This patch fixes the following sparse warnings:
drivers/staging/vt6655/wmgr.c:970:42: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:971:41: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:972:38: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:973:43: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:4110:37: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:4111:41: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:4112:34: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:4113:30: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:4114:35: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:4123:32: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:1815:41: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:1816:34: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:1817:30: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:1818:35: warning: Using plain integer as NULL pointer
drivers/staging/vt6655/wmgr.c:2075:63: warning: Using plain integer as NULL pointer
The following coccinelle script was used to achieve this:
@rule1@
expression *x;
@@
(
- x = 0;
+ x = NULL;
|
- (x == 0)
+ (x == NULL)
|
- (x != 0)
+ (x != NULL)
)
Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chi Pham [Sun, 9 Mar 2014 11:51:19 +0000 (12:51 +0100)]
staging:lustre: Removed assignments from if statements.
Fixed some minor checkpatch warnings such as whitespace.
Coccinelle was used for this patch (NOTE: some of the changes were made by hand). The script is not complete (semantically) and might raise some checkpatch warnings in terms of indentation depending on existing code.
*** IFASSIGNMENT.COCCI START ***
/* Coccinelle script to handle assignments in if statements
* For compound statements, can so far only handle statements with the
* assignment on either extreme */
/* This rule is for simple cases
* e.g. just an assignment in if, possibly with unary operator */
@simple@
expression E1, E2;
statement S1, S2;
@@
+ E1 = E2;
if (
- (E1 = E2)
+ E1
)
S1 else S2
/* This rule is for compound statements where the assignment is on the right.*/
@right@
expression E, E1, E2;
statement S1, S2;
@@
(
/* and */
- if (E && (E1 = E2))
+ if (E) {
+ E1 = E2;
+ if (E1)
S1 else S2
+ } else S2
|
- if (E && (E1 = E2))
+ if (E) {
+ E1 = E2;
+ if (E1)
S1
+ }
/* or */
|
- if (E || (E1 = E2))
+ if (!E) {
+ E1 = E2;
+ if (E1)
S1 else S2
+ }
+ else S1
|
- if (E || (E1 = E2))
+ if (!E) {
+ E1 = E2;
+ if (E1) S1
+ } else
S1
/* not equal */
|
- if (E != (E1 = E2))
+ E1 = E2;
+ if (E != E1)
S1 else S2
|
- if (E != (E1 = E2))
+ E1 = E2;
+ if (E != E1)
S1
/* equal */
|
- if (E == (E1 = E2))
+ E1 = E2;
+ if (E == E1)
S1 else S2
|
- if (E == (E1 = E2))
+ E1 = E2;
+ if (E == E1)
S1
/* greater than */
|
- if (E > (E1 = E2))
+ E1 = E2;
+ if (E > E1)
S1 else S2
|
- if (E > (E1 = E2))
+ E1 = E2;
+ if (E > E1)
S1
/* less than */
|
- if (E < (E1 = E2))
+ E1 = E2;
+ if (E < E1)
S1 else S2
|
- if (E < (E1 = E2))
+ E1 = E2;
+ if (E < E1)
S1
/* lesser than or equal to */
|
- if (E <= (E1 = E2))
+ E1 = E2;
+ if (E <= E1)
S1 else S2
|
- if (E <= (E1 = E2))
+ E1 = E2;
+ if (E <= E1)
S1
/* greater than or equal to */
|
- if (E >= (E1 = E2))
+ E1 = E2;
+ if (E >= E1)
S1 else S2
|
- if (E >= (E1 = E2))
+ E1 = E2;
+ if (E >= E1)
S1
)
/* This rule is for compound statements where the assignment is on the left.*/
@left@
expression E, E1, E2;
statement S1, S2;
@@
(
/* and */
- if ((E1 = E2) && E)
+ E1 = E2;
+ if (E1 && E)
S1 else S2
|
- if ((E1 = E2) && E)
+ E1 = E2;
+ if (E1 && E)
S1
|
/* or */
- if ((E1 = E2) || E)
+ E1 = E2;
+ if (E1 || E)
S1
|
- if ((E1 = E2) || E)
+ E1 = E2;
+ if (E1 || E)
S1 else S2
|
/* not equal */
- if ((E1 = E2) != E)
+ E1 = E2;
+ if (E1 != E)
S1
|
- if ((E1 = E2) != E)
+ E1 = E2;
+ if (E1 != E)
S1 else S2
|
/* equal */
- if ((E1 = E2) == E)
+ E1 = E2;
+ if (E1 == E)
S1
|
- if ((E1 = E2) == E)
+ E1 = E2;
+ if (E1 == E)
S1 else S2
|
/* greater */
- if ((E1 = E2) > E)
+ E1 = E2;
+ if (E1 > E)
S1
|
- if ((E1 = E2) > E)
+ E1 = E2;
+ if (E1 > E)
S1 else S2
|
/* less */
- if ((E1 = E2) < E)
+ E1 = E2;
+ if (E1 < E)
S1
|
- if ((E1 = E2) < E)
+ E1 = E2;
+ if (E1 < E)
S1 else S2
/* lesser than or equal to */
- if ((E1 = E2) <= E)
+ E1 = E2;
+ if (E1 <= E)
S1
|
- if ((E1 = E2) <= E)
+ E1 = E2;
+ if (E1 <= E)
S1 else S2
/* greater than or equal to */
- if ((E1 = E2) >= E)
+ E1 = E2;
+ if (E1 >= E)
S1
|
- if ((E1 = E2) >= E)
+ E1 = E2;
+ if (E1 >= E)
S1 else S2
)
*** IFASSIGNMENT.COCCI END ***
Signed-off-by: Chi Pham <fempsci@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Aybuke Ozdemir [Sun, 9 Mar 2014 10:33:21 +0000 (12:33 +0200)]
drivers/staging/dgrp:dgrp_tty.c: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80
characters in dgrp_tty.c
Signed-off-by: Aybuke Ozdemir <aybuke.147@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kristina Martšenko [Sun, 9 Mar 2014 10:01:46 +0000 (12:01 +0200)]
staging: nokia_h4p: move firmware macros to firmware part
As the TODO file suggests, move firmware file macros from the header
file to the file that deals with firmware. In the process also move
MODULE_FIRMWARE() instances to the same file. Remove the relevant item
from the TODO file.
Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Gulsah Kose [Sun, 9 Mar 2014 19:13:54 +0000 (21:13 +0200)]
staging: nokia_h4p: Fix line over 80 characters.
Fix checkpatch.pl issues with line over 80 characters in nokia_core.c
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This page took 0.047771 seconds and 5 git commands to generate.