Malcolm Priestley [Sat, 12 Sep 2015 18:10:38 +0000 (19:10 +0100)]
staging: vt6655: Move code in device_get_pci_info
Function always returns true and now only a few lines move
to vt6655_probe.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:37 +0000 (19:10 +0100)]
staging: vt6655: device_get_pci_info pcid already assigned.
pcid has already been assigned earlier in vt6655_probe.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:36 +0000 (19:10 +0100)]
staging: vt6655: device_get_pci_info remove call to set
a call to PCI_COMMAND is used to set master.
However, a call to pci_set_master earlier in function which
does the same thing.
So remove the calls and variable b.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:35 +0000 (19:10 +0100)]
staging: vt6655: device_get_pci_info remove variable cis_addr.
cis_addr is never used remove its call to pci_resource_start.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:34 +0000 (19:10 +0100)]
staging: vt6655: device_get_pci_info remove unused pci_read_config_*
These values are read from pci but never used.
Removing variables byRevId, SubSystemID, SubVendorID and pci_cmd.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:33 +0000 (19:10 +0100)]
staging: vt6655: remove and move vt6655_init_info
move code to vt6655_probe.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:32 +0000 (19:10 +0100)]
staging: vt6655: vt6655_init_info remove memset.
vnt_private is allocated with kzalloc so is already zero.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:31 +0000 (19:10 +0100)]
staging: vt6655: remove unused multicast_limit.
multicast_limit is assigned a vale that is never used.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:30 +0000 (19:10 +0100)]
staging: vt6655: Remove typedef struct __chip_info_tbl
Only two values that are assigned from this table.
DEVICE_FLAGS_TX_ALIGN and the value of io_size which is used
as the size of ioremap which is 256.
Remove all variables, DEVICE_FLAGS_TX_ALIGN check, apply io_size value
and chip_info_table.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:29 +0000 (19:10 +0100)]
staging: vt6655: remove get_chip_name and info message.
This prints "VIA Networking Solomon-A/B/G Wireless LAN Adapter"
which has already printed once in vt6655_probe.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Malcolm Priestley [Sat, 12 Sep 2015 18:10:28 +0000 (19:10 +0100)]
staging: vt6655: vt6655_probe remove PCI debug info
Remove unnecessary debug PCI info that can be obtained
by lspci.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sun, 13 Sep 2015 03:46:10 +0000 (09:16 +0530)]
Staging: rtl8192u: Remove unnecessary printk
This patch removes the commented printk inside else block as
it is not needed.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anjali Menon [Sun, 13 Sep 2015 10:52:00 +0000 (16:22 +0530)]
staging: dgnc: Fixed line over 80 characters long
This is a patch that fixes line over 80 characters coding style
warning detected by checkpatch.pl.
WARNING: line over 80 characters
Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Samuel Dominguez Lorenzo [Sun, 13 Sep 2015 15:18:33 +0000 (16:18 +0100)]
staging: rtl8712: usb_ops_linux: fixed a comparison coding style issue
Fixed a coding style issue where a comparison had the constant on the
left side of the test instead of being on the right side of it.
Signed-off-by: Samuel Dominguez Lorenzo <yysamueldominguez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Julia Lawall [Sun, 13 Sep 2015 12:15:06 +0000 (14:15 +0200)]
staging: lustre: drop null test before destroy functions
Remove unneeded NULL test.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x;
@@
-if (x != NULL)
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
@@
expression x;
@@
-if (x != NULL) {
\(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
x = NULL;
-}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Sat, 12 Sep 2015 16:20:03 +0000 (19:20 +0300)]
staging: lustre: fix TRAILING_STATEMENTS checkpatch errors
Move trailing statements to be on the next line to fix the
TRAILING_STATEMENTS checkpatch error.
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mike Rapoport [Sat, 12 Sep 2015 16:20:02 +0000 (19:20 +0300)]
staging: lustre: fix switch-case identation errors
Re-indent switch-case statements to fix SWITCH_CASE_INDENT_LEVEL errors
reported by checkpatch.pl
Signed-off-by: Mike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sun, 13 Sep 2015 17:16:06 +0000 (22:46 +0530)]
Staging: ft1000: use usleep_range()
This patch fixes checkpatch.pl warning
WARNING : msleep < 20ms can sleep for up to 20ms; see
Documentation/timers/timers-howto.txt
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Sat, 12 Sep 2015 09:34:35 +0000 (15:04 +0530)]
Staging: ft1000: ft1000-usb: Use USB API functions rather than constants
Introduce the use of the function usb_endpoint_is_bulk_in().
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:28 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_mgmt_tx
This patch replaces WILC_WFI_mgmt_tx with mgmt_tx to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:27 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_mgmt_tx_cancel_wait
This patch replaces WILC_WFI_mgmt_tx_cancel_wait with
mgmt_tx_cancel_wait to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:26 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_cancel_remain_on_channel
This patch replaces WILC_WFI_cancel_remain_on_channel with
cancel_remain_on_channel to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:25 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_remain_on_channel
This patch replaces WILC_WFI_remain_on_channel with remain_on_channel
to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:24 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_flush_pmksa
This patch replaces WILC_WFI_flush_pmksa with flush_pmksa to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:23 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_del_pmksa
This patch replaces WILC_WFI_del_pmksa with del_pmksa to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:22 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_set_pmksa
This patch replaces WILC_WFI_set_pmksa with set_pmksa to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:21 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_set_wiphy_params
This patch replaces WILC_WFI_set_wiphy_params with set_wiphy_params to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:20 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_change_bss
This patch replaces WILC_WFI_change_bss with change_bss to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:19 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_dump_station
This patch replaces WILC_WFI_dump_station with dump_station to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:18 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_get_station
This patch replaces WILC_WFI_get_station with get_station to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:17 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_change_station
This patch replaces WILC_WFI_change_station with change_station to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:16 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_del_station
This patch replaces WILC_WFI_del_station with del_station to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:15 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_add_station
This patch replaces WILC_WFI_add_station with add_station to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:14 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_stop_ap
This patch replaces WILC_WFI_stop_ap with stop_ap to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:13 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_change_beacon
This patch replaces WILC_WFI_change_beacon with change_beacon to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:12 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_start_ap
This patch replaces WILC_WFI_start_ap with start_ap to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:11 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_change_virt_intf
This patch replaces WILC_WFI_change_virt_intf with change_virtual_intf
to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:10 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_del_virt_intf
This patch replaces WILC_WFI_del_virt_intf with del_virtual_intf to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:09 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_add_virt_intf
This patch replaces WILC_WFI_add_virt_intf with add_virtual_intf to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:08 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_set_default_key
This patch replaces WILC_WFI_set_default_key with set_default_key to
avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:07 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_get_key
This patch replaces WILC_WFI_get_key with get_key to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:06 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_del_key
This patch replaces WILC_WFI_del_key with del_key to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:05 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_add_key
This patch replaces WILC_WFI_add_key with add_key to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:04 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_disconnect
This patch replaces WILC_WFI_disconnect with disconnect to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:03 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_CfgConnect
This patch replaces WILC_WFI_CfgConnect with connect to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:02 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_CfgScan
This patch replaces WILC_WFI_CfgScan with scan to avoid CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Sep 2015 03:24:01 +0000 (12:24 +0900)]
staging: wilc1000: rename WILC_WFI_CfgSetChannel
This patch replaces WILC_WFI_CfgSetChannel with set_channel to avoid
CamelCase.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Axel Lin [Sat, 12 Sep 2015 14:02:12 +0000 (22:02 +0800)]
staging: wilc1000: Add terminating entry for wilc_sdio_ids
The sdio_device_id table is supposed to be zero-terminated.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 11 Sep 2015 12:58:53 +0000 (18:28 +0530)]
staging: fbtft: change log level
Reduce the log level of some of the pr_* calls and remove 2 pr_debug
calls which just prints "init" and "exit".
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 11 Sep 2015 12:58:52 +0000 (18:28 +0530)]
staging: fbtft: start using pr_fmt
Instead of defining DRVNAME and using it in all calls to pr_* family of
macros lets start using pr_fmt.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Fri, 11 Sep 2015 12:58:51 +0000 (18:28 +0530)]
staging: fbtft: use dev_*
Use dev_* family of macros where we have a reference of a device.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:59 +0000 (10:40 +0530)]
Staging: rtl8188eu: os_dep: osdep_service.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:58 +0000 (10:40 +0530)]
Staging: rtl8188eu: os_dep: mlme_linux.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:57 +0000 (10:40 +0530)]
Staging: rtl8188eu: os_dep: recv_linux.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:56 +0000 (10:40 +0530)]
Staging: rtl8188eu: hal: rtl8188eu_xmit.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:55 +0000 (10:40 +0530)]
Staging: rtl8188eu: hal: Hal8188ERateAdaptive.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:54 +0000 (10:40 +0530)]
Staging: rtl8188eu: hal: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:26 +0000 (11:09 +0530)]
Staging: lustre: obdclass: genops.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:25 +0000 (11:09 +0530)]
Staging: lustre: obdclass: obd_config.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:24 +0000 (11:09 +0530)]
Staging: lustre: libcfs: libcfs_mem.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:39:23 +0000 (11:09 +0530)]
Staging: lustre: libcfs: libcfs_lock.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:53 +0000 (10:40 +0530)]
Staging: rtl8188eu: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 05:10:52 +0000 (10:40 +0530)]
Staging: rtl8188eu: core: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:28 +0000 (11:32 +0530)]
Staging: speakup: kobjects.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:27 +0000 (11:32 +0530)]
Staging: speakup: serialio.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:26 +0000 (11:32 +0530)]
Staging: speakup: devsynth.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Fri, 11 Sep 2015 06:02:29 +0000 (11:32 +0530)]
Staging: speakup: varhandlers.c: Remove explicit NULL comparison
Remove explicit NULL comparison and write it in its simpler form.
Replacement done with coccinelle:
@replace_rule@
expression e;
@@
-e == NULL
+ !e
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:32:41 +0000 (22:02 +0530)]
Staging: comedi: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:33 +0000 (23:16 -0800)]
Staging: rtl8192u: space prohibited before close parenthesis
This is a style change to remove whitespace before close parentheses in
ieee80211_softmac_wx.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:28 +0000 (23:16 -0800)]
Staging: rtl8192u: space required after close braces
This is a style change to insert spaces before closed braces in
ieee80211_softmac_wx.c
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:21 +0000 (23:16 -0800)]
Staging: rtl8192u: space required before open braces
This is a change to add spaces before open braces to
ieee80211_softmac_wx.c.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mike dupuis [Thu, 10 Sep 2015 07:16:13 +0000 (23:16 -0800)]
Staging: rtl8192u: Space not allowed after &
This is a change to ieee80211_softmac_wx.c to remove spaces after unary
& operators.
Signed-off-by: Mike Dupuis <mike.dupuis.0@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:32:58 +0000 (09:02 +0530)]
Staging: rtl8192u: ieee80211: ieee80211_softmac.c: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h>
instead of <asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:32:59 +0000 (09:02 +0530)]
Staging: rtl8192u: ieee80211: ieee80211_module.c: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h>
instead of <asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:32:57 +0000 (09:02 +0530)]
Staging: rtl8192u: ieee80211: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h> instead of
<asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alexander Kuleshov [Fri, 11 Sep 2015 18:22:15 +0000 (00:22 +0600)]
staging/dgap: Use strpbrk() instead of dgap_sindex()
The <linux/string.h> provides strpbrk() function that does
the same that the dgap_sindex(). Let's use already defined
function instead of writing custom.
Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Junesung Lee [Sat, 12 Sep 2015 00:58:47 +0000 (09:58 +0900)]
staging: android: fix typo
'syncrhronization' is wrong spell. 'synchronization' is correct.
Signed-off-by: Junesung Lee <junesoung412@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 10 Sep 2015 11:54:59 +0000 (17:24 +0530)]
staging: dgap: remove unused variable
These variables were assigned some values but they were never used.
Removed them but kept one call to ioread8() as it might affect the
hardware.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Thu, 10 Sep 2015 11:54:58 +0000 (17:24 +0530)]
staging: dgap: fix possible NULL dereference
The return pointer from dgap_getword() is used in strcmp() where it is
dereferenced. But dgap_getword() can return NULL.
Lets put a check there and return 0 as error.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sakshi Vaid [Thu, 10 Sep 2015 17:05:10 +0000 (22:35 +0530)]
staging: lustre: lustre: obdclass: Fixed space checkpatch
Removed the space between function name and open parenthesis '('.
Signed-off-by: Sakshi Vaid <sakshivaid95@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:32:40 +0000 (22:02 +0530)]
Staging: lustre: ptlrpc: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:30:31 +0000 (22:00 +0530)]
Staging: lustre: libcfs: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Wed, 9 Sep 2015 22:57:10 +0000 (15:57 -0700)]
staging/rtl8712 : Remove duplicated BIT() definitions
The BIT() macro is already defined in bitops.h,
remove duplicate definitions.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Wed, 9 Sep 2015 22:57:08 +0000 (15:57 -0700)]
staging/rtl8712 : Remove unused macro definitions.
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anish Bhatt [Wed, 9 Sep 2015 22:57:07 +0000 (15:57 -0700)]
staging/rtl8188eu : Remove unused macro definitions.
WLAN_ETHHDR_LEN/WLAN_ETHADDR_LEN/WLAN_ADDR_LEN
are unused, duplicate or unnecessary, remove.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:30:29 +0000 (22:00 +0530)]
Staging: iio: addac: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro.
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:30:30 +0000 (22:00 +0530)]
Staging: iio: meter: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 16:32:39 +0000 (22:02 +0530)]
Staging: iio: cdc: Prefer using the BIT macro
This patch replaces bit shifting on 1 with the BIT(x) macro
This was done with coccinelle:
@@ int g; @@
-(1 << g)
+BIT(g)
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Fri, 11 Sep 2015 03:04:20 +0000 (12:04 +0900)]
staging: wilc1000: coreconfigurator.c: remove unused functions
This patch removes following unused funtions which will not be used anymore.
ascii_hex_to_dec
get_hex_char
extract_mac_addr
create_mac_addr
conv_ip_to_int
conv_int_to_ip
get_wid_type
get_type
CreateConfigPacket
ConfigWaitResponse
ConfigProvideResponse
ConfigPktReceived
ParseWriteResponse
CreatePacketHeader
ParseResponse
ProcessBinWid
ProcessAdrWid
ProcessStrWid
ProcessIPwid
ProcessIntWid
ProcessShortWid
ProcessCharWid
As a result, four global variable causes defined but not used compile warnings.
So just remove unused varialbs g_seqno, g_wid_num, Res_Len and g_oper_mode.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 10 Sep 2015 09:26:29 +0000 (18:26 +0900)]
staging: wilc1000: remove unused enum
This patch removes a unused enum tenuFrameClass.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 09:26:28 +0000 (18:26 +0900)]
staging: wilc1000: remove unused global variables
This patch removes the followings from the driver because they are in
debugging purpose but not used anymore.
- int_clrd
- int_rcvdU
- int_rcvdB
- android_wifi_priv_cmd structure
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 09:26:27 +0000 (18:26 +0900)]
staging: wilc1000: remove firmware definition
This patch removes the firmware definitions, STA_FIRMWARE, AP_FIRMWARE, and
P2P_CONCURRENCY_FIRMWARE from the linux_wlan.c file because they are
defined in the Makefile.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 09:26:26 +0000 (18:26 +0900)]
staging: wilc1000: remove STATIC_MACADDRESS
This patch removes unused definition, STATIC_MACADDRESS from the
linux_wlan.c file.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Thu, 10 Sep 2015 03:33:01 +0000 (09:03 +0530)]
Staging: wilc1000: Replace "#include <asm/uaccess>" with "#include <linux/uaccess>"
Fix checkpatch.pl warning "Use #include <linux/uaccess.h>
instead of <asm/uaccess.h>"
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 10 Sep 2015 03:03:05 +0000 (12:03 +0900)]
staging: wilc1000: delete wilc_memory.c and wilc_memory.h
The macro WILC_MALLOC is not used in the driver anymore, so just
delete files.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Glen Lee [Thu, 10 Sep 2015 03:03:04 +0000 (12:03 +0900)]
staging: wilc1000: remove kmalloc wrapper
This patch calls kmalloc() directly. No need to wrap kmalloc().
All is not holding a spin lock or in interrupt context. So use GFP_KERNEL
flag for kmalloc.
Signed-off-by: Glen Lee <glen.lee@atmel.com>
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tony Cho [Thu, 10 Sep 2015 02:59:11 +0000 (11:59 +0900)]
staging: wilc1000: remove BROKEN status
This patch removes BROKEN status from the Kconfig.
Signed-off-by: Tony Cho <tony.cho@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Shraddha Barke [Mon, 7 Sep 2015 14:28:23 +0000 (19:58 +0530)]
Staging: comedi: addi_apci_3120: Remove unnecessary if
Remove the if condition, as the code inside the if condition is
commented and does not have any FIXME or TODO comment.
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Raphaël Beamonte [Sun, 6 Sep 2015 02:15:12 +0000 (22:15 -0400)]
staging: rtl8192u: r8192U_core: fix use ether_addr_copy() over memcpy() code style issue
Prefer ether_addr_copy() over memcpy() if the Ethernet addresses
are __aligned(2)
The values used are stored as dev_addr in net_device (declared in
include/linux/netdevice.h) and sa_data in sockaddr (declared in
include/linux/socket.h). Both these elements are u16 aligned as
shown by using pahole (position must be a multiple of sizeof(u16)):
unsigned char * dev_addr; /* 888 8 */
char sa_data[14]; /* 2 14 */
It is thus safe to use ether_addr_copy() instead of memcpy() for
that call, as it is already done in multiple files in the Linux
kernel sources:
drivers/net/ethernet/broadcom/genet/bcmgenet.c
drivers/net/ethernet/brocade/bna/bnad.c
drivers/net/ethernet/emulex/benet/be_main.c
drivers/net/ethernet/ezchip/nps_enet.c
drivers/net/ethernet/ibm/ibmveth.c
drivers/net/ethernet/intel/fm10k/fm10k_netdev.c
drivers/net/ethernet/intel/i40e/i40e_main.c
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/usb/lan78xx.c
net/8021q/vlan_dev.c
net/batman-adv/soft-interface.c
net/dsa/slave.c
Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sudip Mukherjee [Mon, 7 Sep 2015 12:38:22 +0000 (18:08 +0530)]
staging: gdm72xx: NULL comparison style
checkpatch complains if NULL comparison is done as if (var == NULL)
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This page took 0.044007 seconds and 5 git commands to generate.