David Goulet [Wed, 30 Jan 2013 16:08:54 +0000 (11:08 -0500)]
Fix: change health poll update to entry/exit calls
It adds a better semantic to the code flow. Furthermore, the current
counter of the health state is now validated raising an assert() if the
value is unexepected.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 29 Jan 2013 17:38:03 +0000 (12:38 -0500)]
Fix: support duplicate health type
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 25 Jan 2013 18:22:13 +0000 (13:22 -0500)]
Clarify README about the GNU gold linker requirement
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 25 Jan 2013 17:12:07 +0000 (12:12 -0500)]
Cleanup: use LTTNG_PACKED in lttng-kernel.h
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 25 Jan 2013 17:11:07 +0000 (12:11 -0500)]
Cleanup: use LTTNG_HIDDEN in src/common
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 25 Jan 2013 17:07:29 +0000 (12:07 -0500)]
Cleanup: use LTTNG_HIDDEN in lttng-ctl filter lib
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 25 Jan 2013 17:02:06 +0000 (12:02 -0500)]
Add LTTNG_HIDDEN macro for hidden attribute
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 24 Jan 2013 23:43:48 +0000 (18:43 -0500)]
Symbol prefixing: in-house copy of hash table
Will ensure we don't clash with the real version in liburcu cds. It's
especially important since those symbols are exported globally by
liblttng-ctl.
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 24 Jan 2013 23:34:44 +0000 (18:34 -0500)]
Fix: add missing unistd.h for fdatasync in compat-fcntl.c
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Thu, 24 Jan 2013 23:33:41 +0000 (18:33 -0500)]
Namespace lttngctl filter flex/bison symbols
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 24 Jan 2013 19:29:49 +0000 (14:29 -0500)]
Cleanup unused health state reference
The old health state structure are not used anymore since we now rely on
TLS health state.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 24 Jan 2013 19:20:23 +0000 (14:20 -0500)]
Fix: health subsystem issues with shared code
TLS memory is not used for health state of each thread. This commit
probably fixes bug428 as well.
The health_init/exit are renamed to health_register/unregister.
Fixes #411
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 23 Jan 2013 18:44:12 +0000 (13:44 -0500)]
Use utils mkdir recursive in runas.c
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 23 Jan 2013 18:38:53 +0000 (13:38 -0500)]
relayd: Create output directory in main()
If specified with -o, --output, the directory is created in the main()
so if an error occurs the execution is stopped.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 23 Jan 2013 17:32:54 +0000 (12:32 -0500)]
Use utils family function in relayd
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 23 Jan 2013 17:25:24 +0000 (12:25 -0500)]
Add mkdir_recursive function to libcommon utils
David Goulet [Tue, 22 Jan 2013 20:28:36 +0000 (15:28 -0500)]
Fix: poll max size should be checked during resize
This was detected using cppcheck:
[src/common/compat/compat-poll.c:204]: (error) Uninitialized variable:
new_size
So, the check was always made over an uninitialized variable on the
stack. Fortunately, worst case scenario, new_size is set to the maximum
allowed or kept untouched.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 20:19:08 +0000 (15:19 -0500)]
Fix: wrong variable type for read() return value
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 20:15:08 +0000 (15:15 -0500)]
cppcheck: don't check NULL pointer before freeing them
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 20:09:23 +0000 (15:09 -0500)]
cppcheck: Simplify empty string test without using strlen()
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 19:57:24 +0000 (14:57 -0500)]
Use default value for metadata file name
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 19:09:21 +0000 (14:09 -0500)]
Remove UST abi cast on channel attribute
This clears out a TODO in the code.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 17:13:13 +0000 (12:13 -0500)]
Fix: add missing rcu lock for UST lookup
Trace UST channel and event were not protected by RCU lock when calling
their find function. Furthermore, the event lookup was not protected at
all during and after the lookup.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 16:52:57 +0000 (11:52 -0500)]
Remove unused variables in trace-kernel/ust.c
In trace-kernel.c, the path is not used anymore on channel creation.
Same goes for trace-ust.c for session creation, the domain pointer is
not used.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 16:50:52 +0000 (11:50 -0500)]
Remove unused kernel session variable in event.c
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 16:38:11 +0000 (11:38 -0500)]
Add safety assert() in session daemon
Note here that a test has been removed which tested the NULL parameter
of the session_destroy() call where now we assert if there is a NULL
pointer. It's a code flow error if a NULL pointer gets to this call so
the test becomes irrelevant.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 22 Jan 2013 16:40:13 +0000 (11:40 -0500)]
Fix: add missing rcu read side lock
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 20:49:45 +0000 (15:49 -0500)]
Add an allocation function for ust stream
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 20:20:52 +0000 (15:20 -0500)]
Rename ltt_ust_stream to ust_app_stream
This data structure only have sense on the application registry side.
The tracing registry does not directly handle stream anymore. This patch
also move it from trace-ust.h to ust-app.h.
No code was changed nor any behaviors altered.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 17:03:55 +0000 (12:03 -0500)]
Move stream name creation to fct create_ust_stream
This is for two reasons. First, to avoid for the caller to create the
stream name. Second, on snprintf() error, we can't continue so put back
the reserved FDs and return an error.
We do that name creation now *before* the stream is created on the
application side so we don't have to release that object on error.
Only after that the stream is added to the list and the channel count
updated. This makes more sense and better handle the error path. Also,
this patch removes a XXX: statement which are always not cool on
production software :).
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 16:59:00 +0000 (11:59 -0500)]
Fix: UST returns -LTTNG_UST_ERR_NOENT and not -ENOENT
On stream creation, it's an UST error code and not the errno one.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 16:38:19 +0000 (11:38 -0500)]
Fix: add missing fd put on stream creation error
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 16:25:09 +0000 (11:25 -0500)]
Add a create_ust_stream function in ust-app.c
This helps by having a single callsite for ustctl_create_stream and
removes the need for the caller to handle FD reservation. On success,
the function sets the returned handle to the given stream.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 16:24:29 +0000 (11:24 -0500)]
Fix: change function name for better meaning
Mostly to avoid confusion in the future for patches, reviews and
contributors.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 21 Jan 2013 15:50:44 +0000 (10:50 -0500)]
Fix: improve error handling for UST stream creation
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Mon, 14 Jan 2013 16:45:49 +0000 (16:45 +0000)]
Extras: Fixed inconsistent use of space and tabs in lttng.i.in.
Python 3 does not allow mixing spaces and tabs. This eliminates the
error encountered when importing the lttng module in a Python 3
interpreter.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Mon, 14 Jan 2013 16:45:48 +0000 (16:45 +0000)]
Extras: Redefined PyInt_AsSsize_T to PyLong_AsSsize_t.
Python 3 merges PyInt and PyLong types. This fixes the undefined symbol
error encountered when using the bindings with Python 3.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Mon, 14 Jan 2013 16:45:47 +0000 (16:45 +0000)]
Extras: Fix the undefined reference to md build error.
Removed scripted modifications to lttng_wrap.c during Python binding
generation.
This adds back the "md" warning of SWIG. See the upstream bug still
waiting to merged upstream: sourceforge.net/p/swig/bugs/1246/
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Jérémie Galarneau [Mon, 14 Jan 2013 16:45:46 +0000 (16:45 +0000)]
Extras: Added lttng.pyc to make clean
This is for Python bindings.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 16 Jan 2013 20:19:35 +0000 (15:19 -0500)]
Refactor ust-app create session
This function was basically a mess for returned values. A valid pointer
that could be a created or already existing session, NULL on error or -1
on disconnect error...
Now, it returns 0 on success or a negative errno code. It populates the
ust app session pointer parameter given by the caller and sets to 1, if
available, the is_created parameter if we did in fact create a new
session.
The motivation behind that was to be able to know if the session was
created or not so we could do a cleanup aftwerwards if any error on the
code path requires wipping the session object. This patch uses that for
the case of a create channel failure just after the session creation. It
now wipes the session if it was created.
Furthermore, this has been error prone in the past by forgetting to
handle the -1 error value being in a pointer variable.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 16 Jan 2013 19:15:42 +0000 (14:15 -0500)]
Fix: remove duplicate set ust event filter
Signed-off-by: David Goulet <dgoulet@efficios.com>
Samuel Martin [Sat, 12 Jan 2013 08:23:57 +0000 (09:23 +0100)]
Make sync_file_range() usage optional
Under uClibc, sync_file_range() is not available under all
architectures, so we fall back to fdatasync() in this case.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 14 Jan 2013 20:36:17 +0000 (15:36 -0500)]
Destroy created kernel channel on enable all error
If we had to create a channel for an enable all tracepoint call (-a -k)
and the enable fails, destroy the created kernel channel.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 14 Jan 2013 19:41:38 +0000 (14:41 -0500)]
Add internal kernel channel destroy function
The internal representation of a kernel channel in the session daemon
now has a session pointer that points to the associated session. This is
needed so when we destroy a channel, we can update the channel count of
the session if available.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 11 Jan 2013 20:12:12 +0000 (15:12 -0500)]
Add pidfile creation for lttng-sessiond
This also adds a pidfile function to common/utils.c so it could be used
by the all binaries needing this feature.
Fixes #276
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Fri, 11 Jan 2013 20:11:39 +0000 (15:11 -0500)]
Extras: fix checkpatch.pl to use 4 spaces for a tab
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Mon, 7 Jan 2013 22:12:42 +0000 (17:12 -0500)]
Extras: Add a checkpatch git pre-commit hook
This commit add the checkpatch-hook script that can be installed in git
hooks folder in order to detect style issue before commiting any staged
changes.
The .checkpatch.conf file contains the appropriate options conforming to
the coding style used in the lttng-tools tree.
Also included in this commit is an install script to automatically
install the hook in the git local repo.
To override the pre-commit hook check, one can use the
`git commit --no-verify` command.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Mon, 7 Jan 2013 22:12:41 +0000 (17:12 -0500)]
Extras: Change TYPE of braces around single statement
Change the TYPE of the "braces {} are not necessary for single statement
blocks" warning from BRACES to BRACES_SINGLE_STMT in order to correctly
ignore this particular warning and continue to warn for other BRACES
warnings.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Mon, 7 Jan 2013 22:12:40 +0000 (17:12 -0500)]
Extras: Add the checkpatch coding style script
Taken from the Linux Kernel tree in scripts/checkpatch.pl.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 10 Jan 2013 17:07:35 +0000 (12:07 -0500)]
Fix: update next_net_seq_num after sending header
Increment the sequence number after we are sure that the relayd has
received correctly the data header. If an error occurs when sending the
header, the data won't be extracted from the buffers thus keeping this
sequence number untouched.
Furthermore, after sending the header, if the relayd dies, this value
won't matter much and if there is an error on the stream when reading
the trace data, the stream will be deleted thus closed on the relayd
making this value useless.
It's important to note that this sequence number is updated on the
relayd side if the full expected data packet was received. So,
incrementing the value after the transmission of the header is not
changing anything in terms of value coherency. The point is to have a
semantic of when read and used successfully (transmission to relayd),
let's update it.
In that code flow, the stream's lock is acquired so no need to
read/update it atomically. I've also added a comments to better
understand the purpose of this variable and how to use it.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 10 Jan 2013 15:18:31 +0000 (10:18 -0500)]
Fix: wrong loop continuation in metadata thread
The validation of the endpoint status can change the metadata hash table
meaning stream(s) can be removed from it and the poll set. After that,
continuing the for loop was making the thread use possible invalid file
descriptor that were not in the hash table anymore trigerring the lookup
assert of the node just after the for loop.
The very important part here is that when the metadata ht changes, we
MUST go back to the poll wait() to synchronize the subset of fd we are
looking at.
Reported-by: Jesus Garcia <jesus.garcia@ericsson.com>
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 9 Jan 2013 22:06:38 +0000 (17:06 -0500)]
Fix: lttng create session memleaks
The uri_parse() function call was leaking copy(ies) of lttng_uri
structure.
Fixes #420
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 9 Jan 2013 15:14:15 +0000 (10:14 -0500)]
Fix: remove unused session id map
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 9 Jan 2013 15:03:38 +0000 (10:03 -0500)]
Fix: wrong session id used on relayd lookup
The relayd session id might not be unique with multiple relayd so the
lookup could choose the wrong relayd for the given sessiond session id.
Fixes #419
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 7 Jan 2013 22:44:03 +0000 (17:44 -0500)]
Fix: don't do custom lookup to relayd stream ht
Use the function made for stream lookup for all lookup calling site. The
function had to move up so to be visible.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Yannick Brosseau [Thu, 20 Dec 2012 19:31:06 +0000 (14:31 -0500)]
Add pkg-config for liblttng-ctl
Signed-off-by: Yannick Brosseau <yannick.brosseau@gmail.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Andrew Gabbasov [Mon, 10 Dec 2012 19:37:03 +0000 (13:37 -0600)]
Add kernel modules loading for new probes
New probes introduced by commit
b87700e318c27267890cbd6fb5e50b687279131b
in lttng-modules.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 7 Jan 2013 19:37:16 +0000 (14:37 -0500)]
Fix: add missing UST abi header for make dist
Reported-by: Samuel Martin <smartin@aldebaran-robotics.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 7 Jan 2013 18:45:29 +0000 (13:45 -0500)]
Fix: add missing rcu read side lock/unlock
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 18:53:18 +0000 (13:53 -0500)]
Update version to v2.1.0
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 19:13:07 +0000 (14:13 -0500)]
Fix: lttng create URI parsing and check
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 18:06:50 +0000 (13:06 -0500)]
Fix: missing scripts for make dist
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 17:17:11 +0000 (12:17 -0500)]
Add disable-event to man page and clarify enable-event
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 15:51:41 +0000 (10:51 -0500)]
Fix: update to latest UST abi
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 01:56:04 +0000 (20:56 -0500)]
Fix: bad check of accept() return value
Also fix a missing ret = -1 assignment. Although, the chances are
unlikely to hit a positive ret value that does not match the structure
size, better safe than sorry.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 01:37:14 +0000 (20:37 -0500)]
Fix: missing mutex lock if relayd was not created
Also add missing ret = -1 assignment on error in error path when adding
a relayd socket in the consumer.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 01:21:54 +0000 (20:21 -0500)]
Fix: return error if sendmsg fails on relayd
Also, remove a FIXME that was refering to something that disapeared
(data_size).
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Thu, 20 Dec 2012 00:58:30 +0000 (19:58 -0500)]
Fix: variable usage for data pending and add comments
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 23:49:37 +0000 (18:49 -0500)]
Fix: print ret value on ust_app start/stop error
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 23:30:37 +0000 (18:30 -0500)]
Fix: compare write() return value to size
Now also check if the ret value of a write() operation is not equal to
the given size.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 23:25:49 +0000 (18:25 -0500)]
Fix: handle orderly shutdown from transport layer
Print a debug statement if a shutdown is detected or else an error. The
transport layer will print the perror in case of an error.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 23:11:12 +0000 (18:11 -0500)]
Fix: change perror to debug statement
Most of the changes here remove a double PERROR which is done by the
transport layer. So we notify in the debug message to understand where
the transport error was.
Also, don't print an error if the relayd is not found. This is possible
if the relayd dies so an error here is useless to the common user but
useful as a debug statement.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 22:54:25 +0000 (17:54 -0500)]
Fix: don't print EPIPE error which can happen
Anytime a relayd is killed, writing on a closed fd is totally possible
so the PERROR of an EPIPE error is useless as an error but we do print
it as a dbg message now.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 22:51:25 +0000 (17:51 -0500)]
Fix: handle shutdown on recv reply in relayd
Print a meaningful error when the recvmsg for the reply gets an orderly
shutdown or an error.
Return a negative value each time since this means that we have to stop
everything for that socket and clean up.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 20:36:59 +0000 (15:36 -0500)]
Fix: Off by one in seq num for data pending command
Like the close stream command, the next sequence number of the stream
needs to be used minus 1 for the data pending or else we are off by one
on the relayd during the check since 4 data packets for instance means a
prev_seq value of 4 but a last_next_seq_num of 5 hence creating an off
by one for the data pending check.
Furthermore, the check was actually wrong on the relayd side. Having a
previous sequence number lower than the last one seen does NOT mean that
the data is not pending so the check needed was actually equal or
greater.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Wed, 19 Dec 2012 19:13:24 +0000 (14:13 -0500)]
Fix: wrong check on session started on stop command
This is problematic for application that lives longer than the tracing
session so the make check unfortunately did not catch this problem since
we either kill the applications before the stop or wait for them to die.
I will quote a colleague of mine on IRC after discovering this:
14:14 < cbab> moar tests!
:)
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 21:50:59 +0000 (16:50 -0500)]
Fix: for librelayd, fix negative reply ret code
Trying to negate a uint32_t is kind of difficult so set ret to -1 and
print the actuall host byte order ret code as an error.
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Tue, 18 Dec 2012 21:31:18 +0000 (16:31 -0500)]
run-report: Add filtering, health and streaming tests
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Tue, 18 Dec 2012 21:31:17 +0000 (16:31 -0500)]
run-report: Allow tests to spawn and control their own sessiond
The run-report script can spawn a sessiond if the 'daemon' key value is
set to 'True' in the test description dictionary. If the 'daemon' key is
set to 'False', the TEST_NO_SESSIOND environment variable is set so no
sessiond can be spawned in the tests. This variable is also set when the
run-report spawn its own sessiond.
This behavior has the unfortunate side-effect of restricting any kind of
spawning and control of the sessiond via the tests.
Fix this issue by allowing the tests to spawn their own sessiond. We
need to pass an additional env dictionary to the TestWorker in order to
spawn the test with the proper environment variables set.
To indicate that a test will spawn and manage its own sessiond, the
'daemon' key value should be set to the "test" string.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Tue, 18 Dec 2012 21:31:16 +0000 (16:31 -0500)]
run-report: Fix CPU usage stats computation
The CPU usage statistics are computed by grepping the top command
output. The top output format as since changed so the CPU usage
statistics were not properly computed.
Fix this by adjusting to the new top command output format.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Tue, 18 Dec 2012 21:31:15 +0000 (16:31 -0500)]
run-report: Restore SIGPIPE default handler in subprocess calls
Python override the SIGPIPE default handler because it prefers to check
every write and raise an IOError exception rather than taking SIGPIPE
[1].
This behavior has the unfortunate side-effect of polluting stdout with
broken pipe messages on shell pipelines invocations (e.g. echo foo |
grep something | etc.) in shell scripts spawned via subprocess.Popen().
This commit fix the polluting of stdout by restoring the default SIGPIPE
handler on subprocess calls.
[1] - http://bugs.python.org/issue1652
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Christian Babeux [Tue, 18 Dec 2012 21:31:14 +0000 (16:31 -0500)]
run-report: Use libtool wrapper to spawn the sessiond for tests
The run-report script was using the sessiond binary generated via
libtool under the ".libs/" folder. When using this binary, the consumerd
used when starting the sessiond is the one installed system-wide (if
any). This could lead to tests failures if no consumer are installed in
the system or any version mismatch occurs.
This commit fix this by using the consumerd that was built with libtool
in the local source tree.
Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 21:19:34 +0000 (16:19 -0500)]
Fix: sessiond write() to handle EINTR
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 21:04:19 +0000 (16:04 -0500)]
Fix: change ERR/PERROR statement to DBG
Most of the explanation is added as comments in the code.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 20:38:25 +0000 (15:38 -0500)]
Fix: DBG statement in relayd
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 20:30:25 +0000 (15:30 -0500)]
Fix: handle EINTR for every read()
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 20:21:33 +0000 (15:21 -0500)]
Fix: handle consumer data pipe read error
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 20:18:27 +0000 (15:18 -0500)]
Fix: don't print usage when listing fails
Fixes #414
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 19:50:51 +0000 (14:50 -0500)]
Fix: possible invalid free in kernel thread
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 19:02:14 +0000 (14:02 -0500)]
Fix: flag metadata stream on quiescent control cmd
For the relayd, when doing a quiescent control command, we have to flag
the corresponding metadata stream or else it will simply stay alive
until a close stream and always returning that data is inflight at the
end data pending command.
Add a stream id to the relayd command so the relayd can identify which
stream to flag.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 00:04:13 +0000 (19:04 -0500)]
Fix: prioritize control socket communication in relayd
Add the LTTNG_POLL_GET_PREV_FD for the relayd listener thread that needs
to access the previous valid fd during a poll loop.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 17 Dec 2012 20:46:28 +0000 (15:46 -0500)]
Fix: poll and epoll fd set reallocation
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
Mathieu Desnoyers [Mon, 17 Dec 2012 23:32:27 +0000 (18:32 -0500)]
Fix: cppcheck linter cleanups
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 17:09:09 +0000 (12:09 -0500)]
Fix: add missing goto pending if data is inflight
There was only a detection for data NOT inflight and for data inflight,
if a relayd was found, was simply exiting the loop and return no data
pending.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 17:05:24 +0000 (12:05 -0500)]
Fix: remove ua_sess->started assert on stop trace
It's totally possible that a start failed for a specific app but the
started flag is set for the global session making a stop trace possible
on a failed started session.
The assert is no longer valid since this code flow is possible.
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Tue, 18 Dec 2012 13:59:07 +0000 (08:59 -0500)]
Fix: remove bash quote when starting relayd in tests
Signed-off-by: David Goulet <dgoulet@efficios.com>
Julien Desfossez [Mon, 17 Dec 2012 17:13:38 +0000 (12:13 -0500)]
Set classes of traffic in high_throughput_limits
This patch creates 2 classes for the bandwidth limited test instead of
one. The intent is to have multiple queues in the kernel instead of just
one. That way we can prioritize the control port over the data port and
make sure it gets its share of the bandwidth.
With this update, the control port gets 1/10th of the limit and the data
get the remaining 9/10th. If unused, the data connection can borrow the
remaining bandwidth.
Signed-off-by: Julien Desfossez <jdesfossez@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 17 Dec 2012 17:37:42 +0000 (12:37 -0500)]
Fix: use the poll wait ret value when iterating on fd(s)
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 17 Dec 2012 17:19:56 +0000 (12:19 -0500)]
Fix: force the poll() return value to be nb_fd
With poll(), we have to iterate over all fd in the pollset since it is
handled in user space where we don't have to with epoll.o
This is a first patch to fix the fact that we should iterate over the
number of fd the lttng_poll_wait() call returns which is for epoll the
number of returned events and with poll the whole set of fd.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: David Goulet <dgoulet@efficios.com>
David Goulet [Mon, 17 Dec 2012 16:30:24 +0000 (11:30 -0500)]
Fix: add missing pollset reset in relayd listener thread
Signed-off-by: David Goulet <dgoulet@efficios.com>
This page took 0.04519 seconds and 5 git commands to generate.