deliverable/tracecompass.git
9 years agotmf remote: use System.arraycopy instead of manually coppy array.
Bernd Hufmann [Fri, 27 Mar 2015 16:46:00 +0000 (12:46 -0400)] 
tmf remote: use System.arraycopy instead of manually coppy array.

Change-Id: If697e6208f1abd387a8678a3c7f30561dc6f62d5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44775
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf remote: collapse if-statement in preference page
Bernd Hufmann [Fri, 27 Mar 2015 15:32:20 +0000 (11:32 -0400)] 
tmf remote: collapse if-statement in preference page

Change-Id: I1938160a044d9e7560dfee75772a64418ee3b01e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44774
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf remote: comply with naming convention in RemoteSystemProxyFactory
Bernd Hufmann [Fri, 27 Mar 2015 15:16:14 +0000 (11:16 -0400)] 
tmf remote: comply with naming convention in RemoteSystemProxyFactory

Change-Id: I164204b2849272a777cf05291bd0fbf9137b3c61
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44772
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf remote: fix modifier order warnings
Bernd Hufmann [Fri, 27 Mar 2015 15:27:09 +0000 (11:27 -0400)] 
tmf remote: fix modifier order warnings

Change-Id: Ifa919b9e6f3a76947718447f0f4d3bc40d6e4317
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44773
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf-remote: Add java doc to messages
Bernd Hufmann [Fri, 27 Mar 2015 15:11:55 +0000 (11:11 -0400)] 
tmf-remote: Add java doc to messages

Change-Id: Idca9609b93aacd0dc38ec575ecefb21cdab87c07
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44771
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf-remote: fix dead variable storage warning in preference page
Bernd Hufmann [Fri, 27 Mar 2015 14:39:50 +0000 (10:39 -0400)] 
tmf-remote: fix dead variable storage warning in preference page

Change-Id: Ia075cdc566d19ef38a246147d620d0717e4b4791
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44770
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf-remote: fix dead variable storage warning
Bernd Hufmann [Fri, 27 Mar 2015 14:28:00 +0000 (10:28 -0400)] 
tmf-remote: fix dead variable storage warning

Change-Id: I32e815d954b4c2e83c01e6317f34d9af5cce46c6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44769
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf remote: Allow plugin customization for alternative profile location
Bernd Hufmann [Mon, 23 Mar 2015 20:23:04 +0000 (16:23 -0400)] 
tmf remote: Allow plugin customization for alternative profile location

Change-Id: Iec0f44f5a2ddd85d20cb8bb1e8f808939afb6280
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44531
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf remote: Bug 460847: SWTBot tests for remote fetching of traces
Marc-Andre Laperle [Mon, 23 Mar 2015 16:45:30 +0000 (12:45 -0400)] 
tmf remote: Bug 460847: SWTBot tests for remote fetching of traces

Change-Id: I562080bf651f8ccbbfccd711fc4eb3d0a6e71993
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44529
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf remote: Bug 460847: Add Junits for XML reader/writer of remote fetch
Marc-Andre Laperle [Mon, 23 Mar 2015 19:16:37 +0000 (15:16 -0400)] 
tmf remote: Bug 460847: Add Junits for XML reader/writer of remote fetch

Change-Id: If1789368077c103eb88d6ec96668502da431f60b
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44530
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoswtbot: check syntax highlighting with filter bar
Matthew Khouzam [Tue, 24 Mar 2015 13:26:00 +0000 (09:26 -0400)] 
swtbot: check syntax highlighting with filter bar

This test will take a screen grab of the cell being highlighted
and compare it before and after highlighting.

Change-Id: Iae5fe05cc965b19aa5dec775c26e1b637901982b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44540
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoswtbot: Introducing ImageHelper
Matthew Khouzam [Wed, 25 Mar 2015 19:58:57 +0000 (15:58 -0400)] 
swtbot: Introducing ImageHelper

The ImageHelper is a way to compare screenshots quickly and efficiently.
It has many helpers made to aid in comparisson. Each pixel is queried as
an RGB, the image can give the following info:

* its dimensions and place in the screen
* its pixels
* all the pixel values of a query (for sampling)
* a row of the image
* a column of the image

Change-Id: Id7a4c168cad18448a4d0d5c14ef395e05b6f018b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44635
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf.ui: clean up SelectTracesWizardPage
Matthew Khouzam [Tue, 24 Mar 2015 18:00:40 +0000 (14:00 -0400)] 
tmf.ui: clean up SelectTracesWizardPage

Remove notion of vector
No longer locally supply provided array

Change-Id: I6958faa73d7747dc5c0471fe60af0a7773be243e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44518
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoanalysis: combine nested ifs in TmfAbstractAnalysisModule
Matthew Khouzam [Tue, 24 Mar 2015 15:30:01 +0000 (11:30 -0400)] 
analysis: combine nested ifs in TmfAbstractAnalysisModule

Change-Id: I79a930305c599202b69bddd066ca5e22b88ada58
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44480
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoFix a few file handles not being closed
Marc-Andre Laperle [Thu, 26 Mar 2015 04:18:42 +0000 (00:18 -0400)] 
Fix a few file handles not being closed

This could lead to test failures on Windows and potentially the import
from archive could fail in real world scenarios.

Change-Id: I96ca34bfcaeced704f4d6fe7c6478c2ba19b988d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44646
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoAdd some missing test plugins to testing feature
Bernd Hufmann [Thu, 26 Mar 2015 16:43:26 +0000 (12:43 -0400)] 
Add some missing test plugins to testing feature

Change-Id: I0bee49e6f558987aa2325e89f54f76261ef5c39e
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44704
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf remote: Bug 460847: Add remote fetch wizard and operations
Bernd Hufmann [Tue, 24 Mar 2015 17:51:01 +0000 (13:51 -0400)] 
tmf remote: Bug 460847: Add remote fetch wizard and operations

Change-Id: I630035d8581c6bb6e473fc4672e3f03078da500b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Patrick Tasse <Patrick.Tasse@gmail.com>
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44528
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agoremote: add non null checks
Matthew Khouzam [Thu, 26 Mar 2015 02:25:16 +0000 (22:25 -0400)] 
remote: add non null checks

Change-Id: I536548d1c8a7f8c481e6828d4298050896277514
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44643
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf remote: Bug 460847: Add profile preference for remote fetching
Patrick Tasse [Tue, 24 Mar 2015 17:44:19 +0000 (13:44 -0400)] 
tmf remote: Bug 460847: Add profile preference for remote fetching

Change-Id: I53cea25df04ec323a73ab2caeca2b77b7fb7d78b
Signed-off-by: Patrick Tasse <Patrick.Tasse@gmail.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44527
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoTMF: Add the possibility to specify a content provider for time graphs
Geneviève Bastien [Mon, 9 Feb 2015 03:28:02 +0000 (22:28 -0500)] 
TMF: Add the possibility to specify a content provider for time graphs

This gives more flexibility to manage time graph entries instead of
building the list only once when the trace is loaded.

For example, a view like the Critical Path View where the list of
entries depend on the selection from another view can be managed using a
content provider.

Change-Id: I5de7b5c16ba3b60c26f7d0d4a69289f6ddb8441b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41476
Reviewed-by: Hudson CI
9 years agotmf: Make ITimeGraphContentProvider extend ITreeContentProvider
Patrick Tasse [Sat, 14 Mar 2015 16:56:48 +0000 (12:56 -0400)] 
tmf: Make ITimeGraphContentProvider extend ITreeContentProvider

This will allow the same provider to be used for the time graph viewer
and tree viewer in a time graph combo.

A default implementation is provided that accepts an ITimeGraphEntry
array or list as input element.

Change-Id: Icd8ac8b89e4b46c91c0474616578c375475e7e9a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43853
Reviewed-by: Hudson CI
9 years agotmf-remote: Bug 460847: add model for remote fetching of traces
Marc-Andre Laperle [Tue, 24 Mar 2015 17:36:01 +0000 (13:36 -0400)] 
tmf-remote: Bug 460847: add model for remote fetching of traces

Change-Id: I9d9ef176ac72ee93edf62df1797309b6d843b430
Signed-off-by: Marc-Andre Laperle <Marc-Andre.Laperle@ericsson.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Patrick Tasse <Patrick.Tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44526
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agocontrol: display file rotation properties (Bug: 459483)
Bernd Hufmann [Mon, 9 Feb 2015 16:17:58 +0000 (11:17 -0500)] 
control: display file rotation properties (Bug: 459483)

Change-Id: I7f15d718de92fbd60357600ecd3c49b68fd727a3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/41535
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf.ui: merge nested if statement
Matthew Khouzam [Tue, 24 Mar 2015 16:36:30 +0000 (12:36 -0400)] 
tmf.ui: merge nested if statement

Change-Id: I42d9ef509d0be765118eca25e90668c99e5a07f5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44507
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf.core: CustomXmlTrace combine if statements
Matthew Khouzam [Tue, 24 Mar 2015 15:34:07 +0000 (11:34 -0400)] 
tmf.core: CustomXmlTrace combine if statements

Change-Id: Id159d52caef5f762788d2081e9f62100579c8b40
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44482
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoss: Expose method to get an attribute's path as a string array
Alexandre Montplaisir [Tue, 24 Mar 2015 22:26:55 +0000 (18:26 -0400)] 
ss: Expose method to get an attribute's path as a string array

Most attribute-creation methods use string arrays (or varargs
parameters), it'd be nice to be able to get the same array back.

Change-Id: I8948d0d2120e24be5ba0ed72d0cb951d278f4e14
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/44543
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agotmf.core: make tracer follow naming convention
Matthew Khouzam [Tue, 24 Mar 2015 18:28:14 +0000 (14:28 -0400)] 
tmf.core: make tracer follow naming convention

Also add javadoc

Change-Id: I9b166cd7a425aacf20ede4cac3105ffc21e4a164
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44522
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf.ui: Make InterruptedExceptions not get caught as Exceptions
Matthew Khouzam [Tue, 24 Mar 2015 17:53:23 +0000 (13:53 -0400)] 
tmf.ui: Make InterruptedExceptions not get caught as Exceptions

in TracePackageExportOperation only

Change-Id: I2405115af174e4619da655a4f4d7cf8930e09504
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44515
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf.ui: update names to follow code convention
Matthew Khouzam [Tue, 24 Mar 2015 19:22:37 +0000 (15:22 -0400)] 
tmf.ui: update names to follow code convention

Change-Id: Ic9601b72fd86e5ce1ef5b5324b50d13e9998d594
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44524
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf.ui: Nest ifs in ImportTraceWizardPage
Matthew Khouzam [Tue, 24 Mar 2015 17:50:51 +0000 (13:50 -0400)] 
tmf.ui: Nest ifs in ImportTraceWizardPage

Change-Id: I4123e43aa218fe39bb567b100b72e6862c9f77e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44514
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf.ui: use indexOf(char) instead of String in ExportTracePackageWizardPage
Matthew Khouzam [Tue, 24 Mar 2015 18:33:14 +0000 (14:33 -0400)] 
tmf.ui: use indexOf(char) instead of String in ExportTracePackageWizardPage

Change-Id: Ic215454ac0cd947086fc584b1aa7a827ca94078a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44523
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf: Rename time range signals
Alexandre Montplaisir [Thu, 12 Mar 2015 22:30:58 +0000 (18:30 -0400)] 
tmf: Rename time range signals

The meanings of TmfTimeSynchSignal and TmfRangeSynchSignal have changed
since those classes were first introduced. "TimeSynch" also refers to
a time range now. Rename those two signals to better reflect their
contemporary meanings:

TmfTimeSynchSignal -> TmfSelectionRangeUpdatedSignal
TmfRangeSynchSignal -> TmfWindowRangeUpdatedSignal

Change-Id: I05b2c9b8c6aaf30a07188c4695e117832aabb4b1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43761
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoBuild documentation index
Marc-Andre Laperle [Mon, 23 Mar 2015 20:33:39 +0000 (16:33 -0400)] 
Build documentation index

This speeds up the initial search in the Help. This is mostly useful for bigger
Eclipse installation therefore there is not that much of a difference in the
Trace Compass RCP.

Change-Id: I5edc0ae3350410f7916b8ba625768eaf2a3e6435
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44409
Reviewed-by: Hudson CI
9 years agoswtbot: fix colorsetting instability
Matthew Khouzam [Tue, 24 Mar 2015 17:29:53 +0000 (13:29 -0400)] 
swtbot: fix colorsetting instability

Waits for table to be populated before selecting event.
Reset colors after test.
Fix typo in comments.

Change-Id: I166681c827e311c9d7d2ee8aa35ce429679b1c37
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44510
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoFix some instability in custom parser SWTBot tests
Marc-Andre Laperle [Thu, 19 Mar 2015 23:49:23 +0000 (19:49 -0400)] 
Fix some instability in custom parser SWTBot tests

We need to wait until the XML files are written to disk after clicking on the
Finish button of the wizard. Otherwise, the content might be not be up to date
when we verify the content (assert) in the non-UI test thread.

From what I understand, SWTBotButton.click should be synchronous so all the
code in the UI thread should be done executing by the time it returns. But this
doesn't seem to be the case all the time. This will require more investigation
that might take quite some time so we can use this work around for now.

Change-Id: I9177b01f3ac425530aba454c26a97b5b7d31301d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44217
Reviewed-by: Hudson CI
9 years agoanalysis: combine nested ifs and merge exception handling
Matthew Khouzam [Tue, 24 Mar 2015 15:31:04 +0000 (11:31 -0400)] 
analysis: combine nested ifs and merge exception handling

Change-Id: I88cf8ffb36ac10e4bbfb0493e33bae1d9d54e1f2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44481
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoswtbot: add font change test
Matthew Khouzam [Mon, 23 Mar 2015 19:50:22 +0000 (15:50 -0400)] 
swtbot: add font change test

Test the raw viewer as the font picker is a native window.

Change-Id: Id2fb0f7492bce82ddc162ec2e4b48b66161e13e0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44406
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoctf: Remove redundant modifiers in CtfConstants
Matthew Khouzam [Tue, 24 Mar 2015 15:26:34 +0000 (11:26 -0400)] 
ctf: Remove redundant modifiers in CtfConstants

Change-Id: I207e1a9dff63d4fcadb7a7bfdb801ff82dc3847f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44478
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agocolors: add util helpers and collapse exceptions
Matthew Khouzam [Fri, 20 Mar 2015 15:24:23 +0000 (11:24 -0400)] 
colors: add util helpers and collapse exceptions

Change-Id: I0e95cfd2d3887a7ea320dc00d7c06400d6e92493
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44261
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agocolor: Make ColorSettingsXML not check type of filter.
Matthew Khouzam [Fri, 20 Mar 2015 15:11:51 +0000 (11:11 -0400)] 
color: Make ColorSettingsXML not check type of filter.

Change-Id: If1055568768499aaef9f29e56043ed5288b57992
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44254
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoctf: remove variant tag definition from declaration
Matthew Khouzam [Thu, 19 Mar 2015 15:24:31 +0000 (11:24 -0400)] 
ctf: remove variant tag definition from declaration

The tag definition of a variant was cached in the declaration.
This could create the possibility of a variant misreading the data.
The declaration is now more stateless and will not have these issues
pop up at a later date. Also this optimisation is no longer helpful
and consumes more memory.

Change-Id: I0136e936748ac5ea1e08d9b44caa0444fc6b6561
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44184
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf remote: rename messages constants
Bernd Hufmann [Mon, 23 Mar 2015 17:39:55 +0000 (13:39 -0400)] 
tmf remote: rename messages constants

Change-Id: Ib0c9ebbc3378c9a1e8466270cf6179b4f5453988
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44400
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf remote: Add unit tests for tmf.remote.core
Bernd Hufmann [Mon, 2 Mar 2015 21:16:31 +0000 (16:16 -0500)] 
tmf remote: Add unit tests for tmf.remote.core

Change-Id: Id865b2f29f91e5128bda87b7ffa50ac1672d2f04
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44207
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoswtbot: move column in trace editor test
Matthew Khouzam [Fri, 20 Mar 2015 21:53:43 +0000 (17:53 -0400)] 
swtbot: move column in trace editor test

Moves columns and checks if the setting is preserved.

Change-Id: I58167ae3353900eea3db492dbc767c0d93c16caf
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44287
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf: Use find() instead of matches() in TmfFilterMatchesNode
Patrick Tasse [Fri, 20 Mar 2015 18:55:39 +0000 (14:55 -0400)] 
tmf: Use find() instead of matches() in TmfFilterMatchesNode

This removes the need for a regex fix to add .* before and after, and
ensures the highlighting is always correct even for complex expressions.

Change-Id: I0fd19b0c396861b68292e458cb0f2f67202561c9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44278
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoos.linux: Add Linux-specific static definitions
Alexandre Montplaisir [Thu, 12 Mar 2015 18:31:24 +0000 (14:31 -0400)] 
os.linux: Add Linux-specific static definitions

And replace some magic numbers in KernelStateProvider with values
from this file.

It includes some LTTng-specific definitions, but since the statedump
events are handled in this plugin (and not in something lttng2.kernel)
it makes sense for now to put them there.

Change-Id: If47a13ca277a9da0220066b03024fca1f403beb4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43758
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
9 years agoss: Add @NonNull to attribute name-getting methods
Alexandre Montplaisir [Fri, 20 Mar 2015 19:09:09 +0000 (15:09 -0400)] 
ss: Add @NonNull to attribute name-getting methods

If the quark is valid, its name and full path can never be null.

This removes a check in AttributeTree that would return null on failure.
Instead, let it throw an ArrayOutOfBoundsException if the quark is
invalid, like many other methods in that class already do.

Change-Id: I384ff8be26f003d684c9f9170cba2d155ed3c08e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44281
Reviewed-by: Hudson CI
9 years agoFix the run configuration shipped with the alltests plugin
Alexandre Montplaisir [Thu, 26 Feb 2015 08:30:16 +0000 (03:30 -0500)] 
Fix the run configuration shipped with the alltests plugin

Change-Id: I8de5ecb56f39f60c1a29966ee56e2a25675eedeb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42723
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
9 years agoFix SDViewTest on Mac
Marc-Andre Laperle [Fri, 20 Mar 2015 23:24:44 +0000 (19:24 -0400)] 
Fix SDViewTest on Mac

The test should be expected command+F not Ctrl+F

Change-Id: I6650c63b02177cfb6f307cb48b539c004047c3e2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44293
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
9 years agotmf.ui: Add (Un)check(In)active buttons to TimeGraphFilterDialog
Christian Mansky [Tue, 10 Mar 2015 18:59:12 +0000 (19:59 +0100)] 
tmf.ui: Add (Un)check(In)active buttons to TimeGraphFilterDialog

Adds installable buttons to TimeGraphFilterDialog in order to provide
view specific filtering functionality. In this case check/uncheck
active/inactive buttons are added specific to the ControlFlowView.

Change-Id: Ibac317385527a61df09e82f0721eff19dcfcce83
Signed-off-by: Christian Mansky <christian.mansky@gmx.at>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43648
Reviewed-by: Hudson CI
9 years agoctf: Remove deprecated methods
Matthew Khouzam [Sat, 29 Nov 2014 16:52:54 +0000 (11:52 -0500)] 
ctf: Remove deprecated methods

Remove setByteBuffer from bitBuffer, it is an immutable field. (deprecated)
Remove getEvents and getEventType from CTFTrace (deprecated)

Change-Id: Ie181005874d380a0ed1197f09e108fc9f7a59272
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37317
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf: Fix event table item default colors and foreground positions
Patrick Tasse [Wed, 18 Mar 2015 17:53:52 +0000 (13:53 -0400)] 
tmf: Fix event table item default colors and foreground positions

The default system colors should be used whenever the default color
setting from the color setting manager is used. This no longer requires
special handling since if the color from the default color setting is
null. The current theme's system colors are not necessarily equal to
COLOR_LIST_BACKGROUND and COLOR_LIST_FOREGROUND.

The background needs to be drawn in the custom EraseItem listener if the
item background is different from the table's background (set to the
default system color as it is never changed), not when it is different
from COLOR_LIST_BACKGROUND (which may not be the default system color in
the current theme).

The text bounds and image bounds adjustments in the custom PaintItem
listener need to be set differently for Windows and Linux.

Change-Id: I06e6ed48e866ce7831ea3ad630d120a8cf228973
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44124
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf: Support nullable colors in ColorSetting
Patrick Tasse [Thu, 12 Mar 2015 17:40:26 +0000 (13:40 -0400)] 
tmf: Support nullable colors in ColorSetting

A null Color in a ColorSetting indicates that the default system color
should be used.

Change-Id: I01f129ac30ba4c6589229b19851e15cc93362622
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/44173
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoctf: make StreamInputPacketIndexEntries immutable
Matthew Khouzam [Thu, 20 Nov 2014 14:28:07 +0000 (09:28 -0500)] 
ctf: make StreamInputPacketIndexEntries immutable

Fix a long running "bug" of byte/bit inconsistency that
accidentally cancelled itself out before.

Change-Id: Ie8801ef951eb9619b3ef96e2826103203b7c371f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36774
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoAdd javadoc for TmfTimestampFormat.java
Matthew Khouzam [Wed, 18 Mar 2015 20:11:38 +0000 (16:11 -0400)] 
Add javadoc for TmfTimestampFormat.java

Change-Id: Ib6ee40c2563ed66a7cd6bcd99f8266432ea42209
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43626
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agotmf: Add font preferences for trace editor event table and raw text
Patrick Tasse [Mon, 16 Mar 2015 18:41:19 +0000 (14:41 -0400)] 
tmf: Add font preferences for trace editor event table and raw text

The font settings can be changed in Window > Preferences > General >
Appearance > Colors and Fonts > Tracing.

Change-Id: Icc95f2ad6df25552293e8ee1d75ab580cdc63af7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43965
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoFix running tests with 4.4 target with 4.5 installation
Marc-Andre Laperle [Mon, 16 Mar 2015 21:15:55 +0000 (17:15 -0400)] 
Fix running tests with 4.4 target with 4.5 installation

The plugin org.eclipse.pde.junit.runtime bundled with Eclipse 4.5 is now
incompatible with Eclipse 4.4 because it requires org.eclipse.core.runtime
version 3.11.0 as the minimum which is only in 4.5. The first build that has
this problem is 4.5-I20150224-0800.
Trying to run tests would result in this error:

org.osgi.framework.BundleException: Could not resolve module: org.eclipse.pde.junit.runtime [217]
  Unresolved requirement: Require-Bundle: org.eclipse.core.runtime; bundle-version="[3.11.0,4.0.0)"

Also, we can point to the 4.4.2 update site which is faster than pointing
to the composite update site, especially when building with Tycho (dependency
resolution).

Change-Id: I910216656496cf961e580a69c78d285548d57452
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43975
Reviewed-by: Hudson CI
9 years agotmf: Preserve trace editor column order per trace type
Patrick Tasse [Fri, 13 Mar 2015 19:45:30 +0000 (15:45 -0400)] 
tmf: Preserve trace editor column order per trace type

Save the column order when the trace editor is closed.

Load the column order when the trace editor is opened.

Clear the column order when a custom trace type is modified or deleted.

Change-Id: If8063e59f44b69b0eca306b8b54c8c807e65c838
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43826
Reviewed-by: Hudson CI
9 years agotmf: Perform cleanup when custom parser is modified or deleted
Patrick Tasse [Fri, 13 Mar 2015 19:38:06 +0000 (15:38 -0400)] 
tmf: Perform cleanup when custom parser is modified or deleted

All traces in all projects which have the modified or deleted custom
parser's trace type should be closed and have their supplementary files
deleted.

Change-Id: I872cefb7e0aa9e3d9e6370766bb6319cb256d503
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43825
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf: Highlight search and filter keywords in events table
Patrick Tasse [Mon, 9 Mar 2015 18:09:39 +0000 (14:09 -0400)] 
tmf: Highlight search and filter keywords in events table

Highlight in yellow background the search or filter keywords used in
column filters, based on the current header state.

Fixes a bug in Linux where colored rows would override the default
platform theme background forever (e.g. alternating colors).

Fixes a bug in Windows where the item background color would not be
shown under a table item's image transparency.

Fixes a bug in Windows where the item background color would not be
shown under a selected or hot (ie. under the cursor) table item.

Change-Id: I31847552613e3e5bdf8c0160d90acca833d76501
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43750
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoUse latest Mylyn and SWTBot from staging update site
Marc-Andre Laperle [Mon, 16 Mar 2015 19:54:50 +0000 (15:54 -0400)] 
Use latest Mylyn and SWTBot from staging update site

We should run the build against the versions that will be released in Mars.
Using the staging update site it the most future-proof way of doing this.

Change-Id: Ib261a6b26dd6b2a78cfd638903b14ef250c3ea52
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43970
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
9 years agotmf: add TMF remote to the update site
Bernd Hufmann [Mon, 16 Mar 2015 18:51:38 +0000 (14:51 -0400)] 
tmf: add TMF remote to the update site

Change-Id: I1d7f0fac7e8ffa127085dda7aa1ff22e720a9b9c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43966
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
9 years agoss: Harmonize order of parameters in backend constructors
Alexandre Montplaisir [Fri, 13 Mar 2015 22:25:19 +0000 (18:25 -0400)] 
ss: Harmonize order of parameters in backend constructors

Change-Id: I35a5ed569cf1f7cba750cdfd2a2ebd74853b5d57
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43835
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoss: Implement a factory for state system backends
Alexandre Montplaisir [Tue, 3 Mar 2015 22:34:17 +0000 (17:34 -0500)] 
ss: Implement a factory for state system backends

This allows moving all backend implementations to internal packages
(which fixes a problem where HistoryTreeBackend was leaking a HistoryTree
reference through an API method, which was already internal).

The creation methods for HistoryTree backends can be streamlined.

Change-Id: Ifd18a7f79e62632d8bad4af2804face738cd6d5f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43201
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoTMF: Change visibility of TmfEventMatching methods
Geneviève Bastien [Fri, 13 Feb 2015 16:02:06 +0000 (11:02 -0500)] 
TMF: Change visibility of TmfEventMatching methods

So that they match what was previously in the now gone class
TmfNetworkEventMatching.

Change-Id: I242cae29ca1da1306b20fffae331ba42bafa507c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/41840
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agolttng.control: Use LTTng's MI XSD file for validation
Alexandre Montplaisir [Tue, 20 Jan 2015 23:37:49 +0000 (18:37 -0500)] 
lttng.control: Use LTTng's MI XSD file for validation

Change-Id: Ie96ec464c09c4abe365cdf5c5f08ad0640cd1053
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/39997
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoos.linux: Make the priority of the KernelState available as an Aspect
Christian Mansky [Fri, 27 Feb 2015 09:57:11 +0000 (10:57 +0100)] 
os.linux: Make the priority of the KernelState available as an Aspect

Since bug 460635 points into the direction of using aspects for the
properties view, I think it makes sense to create a ThreadPriorityAspect
making the priority tracked in the KernelState vaialable as an aspect.

Change-Id: Icf3ed0a03fd9f6e993465bc1c155c185e058de54
Signed-off-by: Christian Mansky <christian.mansky@gmx.at>
Reviewed-on: https://git.eclipse.org/r/42884
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
9 years agolttng: Update control's session.xsd file to version 2.6
Alexandre Montplaisir [Fri, 23 Jan 2015 18:11:11 +0000 (13:11 -0500)] 
lttng: Update control's session.xsd file to version 2.6

Taken from lttng-tools's stable-2.6 branch.

Change-Id: I711e83bf83a11185201cace4a5ff77e52642a7f3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/40266
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoTMF: Check if state system is available before scheduling analysis
Geneviève Bastien [Mon, 15 Dec 2014 16:18:43 +0000 (11:18 -0500)] 
TMF: Check if state system is available before scheduling analysis

Adding tracing capabilities to analyses shows that an analysis is scheduled
a LOT of times just to get the state system. We should check the state system
is not null before scheduling.

Change-Id: Ic5b159566b0b84211e1b9506f4d0ecfa08df0dc6
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/38271
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agodoc: Rename documentation external tool builders
Patrick Tasse [Wed, 4 Mar 2015 19:30:13 +0000 (14:30 -0500)] 
doc: Rename documentation external tool builders

Rename those that referred to linuxtools instead of tracecompass, and
rename the others just to be consistent.

Change-Id: I10c00eea70c3a8c72f96ab58dacda3219461e046
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43197
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoTMF: Have IAnalysisModule#setTrace return boolean instead of throw exception
Geneviève Bastien [Tue, 10 Feb 2015 19:37:08 +0000 (14:37 -0500)] 
TMF: Have IAnalysisModule#setTrace return boolean instead of throw exception

In an eventual future where the appliesToTraceType will be deprecated, in favor
of using analysis requirements, the setTrace method returns a boolean to
express whether or not the trace was successfully set.

Consequence of this: the helpers can now explicitly return null if the trace
was not set correctly and the callers of the IAnalysisModuleHelper#newModule
must check nullness of the module.

Change-Id: Idb06b4a3b1741d345a3e3412feee84a98aa1fed0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/41568
Reviewed-by: Hudson CI
9 years agoTMF: Specify if an analysis applies differently to an experiment
Geneviève Bastien [Fri, 13 Jun 2014 19:11:56 +0000 (15:11 -0400)] 
TMF: Specify if an analysis applies differently to an experiment

Add a 'apply_experiment' to analysis extension for analysis who have different
results for experiments containing their trace types than for the individual
traces. The result of the experiment analysis is more than the aggregation of
the traces' analyses.

Change-Id: I18122a26bb680fb2b240c98a4757f1bcce71b525
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/38446
Reviewed-by: Hudson CI
9 years agoTMF: Cache average char width to speed up control flow drawing.
Francois Doray [Tue, 10 Mar 2015 15:33:34 +0000 (11:33 -0400)] 
TMF: Cache average char width to speed up control flow drawing.

Before this fix, calls to gc.getFontMetrics() represented more
than 40% of the time required to draw the control flow for some
traces
(http://secretaire.dorsal.polymtl.ca/~fdoray/tracing/screenshots/getFontMetrics.png)

With this fix, the method is called only once. Navigation is
much more fluid for traces that contain a lot of state changes.

This fix should also be applied to other similar presentation
providers.

Change-Id: I5dd7815f9ee52e24d6467250fea4e0859be202f6
Signed-off-by: Francois Doray <fdoray.eclipse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43182
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoctf: remove CtfTmfTimestamp.
Matthew Khouzam [Thu, 5 Mar 2015 21:44:18 +0000 (16:44 -0500)] 
ctf: remove CtfTmfTimestamp.

It does everything TmfNanoTimestamp does but not as well.

Change-Id: Ifba86f402fe0d7a26f7550ca30297108fcd8b753
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43265
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf: Add message to state system exceptions
Patrick Tasse [Mon, 16 Feb 2015 23:32:47 +0000 (18:32 -0500)] 
tmf: Add message to state system exceptions

Change-Id: Ic8e75aed32690dae72ba2f907d1fc8ebc170de1e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/41977
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
9 years agoFix references to linuxtools in comments, examples and unused code
Patrick Tasse [Wed, 4 Mar 2015 20:26:12 +0000 (15:26 -0500)] 
Fix references to linuxtools in comments, examples and unused code

Change-Id: I5b548aee558fe9e9499d1116796a0b4d9fab2b77
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43198
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoFix activator plug-in IDs
Patrick Tasse [Wed, 4 Mar 2015 19:18:40 +0000 (14:18 -0500)] 
Fix activator plug-in IDs

Make sure PLUGIN_ID constants match the manifest plug-in ID.

Remove duplicate GDB core plug-in activator.

Fix plug-in unit tests.

Change-Id: I078e4493da3e1dcb5ee95bff0e8f1a9456fadb1f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43193
Reviewed-by: Hudson CI
9 years agorcp: Rename plugin.xml element ids for Trace Compass
Patrick Tasse [Wed, 4 Mar 2015 19:52:10 +0000 (14:52 -0500)] 
rcp: Rename plugin.xml element ids for Trace Compass

Rename some menu and separator ids for uniqueness and consistency

Change-Id: I278d7eb1df59e52bc1d18e1446851b424057a941
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43196
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agolttng: Fix feature provider in feature.properties
Patrick Tasse [Wed, 4 Mar 2015 19:45:25 +0000 (14:45 -0500)] 
lttng: Fix feature provider in feature.properties

Change-Id: Iecff5881e8978dc830b99d3824c4aec291369818
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43195
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agoFix excluded documentation plugin ids in pom.xml
Patrick Tasse [Wed, 4 Mar 2015 19:48:43 +0000 (14:48 -0500)] 
Fix excluded documentation plugin ids in pom.xml

Change-Id: I1a4c427c0fb49b60004d75a5c1b48be0e7ce791c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43194
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
9 years agotmf: Mark TmfTraceUtils @NonNullByDefault
Alexandre Montplaisir [Fri, 13 Feb 2015 19:35:10 +0000 (14:35 -0500)] 
tmf: Mark TmfTraceUtils @NonNullByDefault

Change-Id: I5121586872f26e8ed3f3f790611a91d51b3f9b28
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41856
Reviewed-by: Hudson CI
9 years agotmf: TmfTraceManager improvements
Alexandre Montplaisir [Mon, 16 Feb 2015 22:29:32 +0000 (17:29 -0500)] 
tmf: TmfTraceManager improvements

Since the #getCurrentContext() can change at any time, but the
trace context object itself is immutable, it's safer to expose
the context rather than individual getters.

Many views gather all available timestamps in the following fashion
(assuming here we "expand" the calls to getCurrentContext()):

  selectionStart = tm.getCurrentContext().getSelectionStart();
  selectionEnd   = tm.getCurrentContext().getSelectionEnd();
  windowStart    = tm.getCurrentContext().getWindowRange().getStart();
  windowEnd      = tm.getCurrentContext().getWindowRange().getEnd();
  ...

If the context changes mid-way during these calls, the gathered time
ranges will be inconsistent. It'd be safer to extract the context
locally first.

Also updated the TmfTraceContext to return a TimeRange for the current
selection (it used to be a single timestamp, now we support a range).
This required updating the tests.

Change-Id: Ia44dc7157a2b98f320dcd92fd3856148dac4f47b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41986
Reviewed-by: Hudson CI
9 years agoFix performance tests by changing derby dependency to derby.core
Marc-Andre Laperle [Fri, 6 Mar 2015 23:39:37 +0000 (18:39 -0500)] 
Fix performance tests by changing derby dependency to derby.core

eclipse.test.performance now depends on apache.derby.core instead of
apache.derby so we need to update our targets.

Change-Id: I7dfd86ac52346f08ca7585f91a9a7a8a2a8a6d8d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43340
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
9 years agoUpgrade maven plugin versions
Marc-Andre Laperle [Sat, 28 Feb 2015 00:17:26 +0000 (19:17 -0500)] 
Upgrade maven plugin versions

Also add a few missing versions.
I used this command to check for updates:
mvn versions:display-plugin-updates -Djava.net.useSystemProxies | grep "\\->" | sort | uniq

Change-Id: Iffafb504054a9ec0abdfc756218309bc51da4b4c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42935
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
9 years agotmf: Remove extraneous constructors from TmfTimeRange
Alexandre Montplaisir [Mon, 16 Feb 2015 23:31:32 +0000 (18:31 -0500)] 
tmf: Remove extraneous constructors from TmfTimeRange

Now that time ranges are immutable, they have no need for a copy
constructor, you can just re-use the previous instance.

Change-Id: I70d0c5a24ffcd1b2081fda47a18eb3068671521d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41985

9 years agoTMF: Add some non null annotations to TmfTimeRange
Genevieve Bastien [Thu, 5 Feb 2015 18:57:01 +0000 (13:57 -0500)] 
TMF: Add some non null annotations to TmfTimeRange

And all the required changes and extra annotations to fix all the warnings

Change-Id: Ic6f58052550f5f4fcca119ecf6c6d3e2e16d3631
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/41240
Reviewed-by: Hudson CI
9 years agolttng: Fix internal package visibility
Patrick Tasse [Wed, 4 Mar 2015 19:47:37 +0000 (14:47 -0500)] 
lttng: Fix internal package visibility

Fixes an error when a test class refers to an internal core class in a Javadoc comment.

Change-Id: I89ac5b4ce10b7347c3e37afb033799ff52cf2a77
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43192
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
9 years agotmf: Fix class names in extension point schemas
Patrick Tasse [Wed, 4 Mar 2015 20:14:36 +0000 (15:14 -0500)] 
tmf: Fix class names in extension point schemas

Change-Id: Id41c74e10fba954901a1d131202cbddd9f986395
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43191
Reviewed-by: Hudson CI
9 years agotmf: Fix assertion messages in AbstractPerspectiveChecker
Patrick Tasse [Tue, 3 Mar 2015 23:03:41 +0000 (18:03 -0500)] 
tmf: Fix assertion messages in AbstractPerspectiveChecker

Change-Id: I5efa32ea36f0ccc821edba4af6244b7e4c99ad37
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/43116
Reviewed-by: Hudson CI
9 years agoBug 460386 clear SWTBot loggers before adding one
Matthew Khouzam [Thu, 19 Feb 2015 22:31:13 +0000 (17:31 -0500)] 
Bug 460386 clear SWTBot loggers before adding one

Change-Id: I51f3ed2fb2b5f4c68aea94634250c7526ed801af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/42245
Reviewed-by: Hudson CI
9 years agoMove CTFTraceCallsitePerformance test to performance tests
Matthew Khouzam [Thu, 20 Nov 2014 15:32:38 +0000 (10:32 -0500)] 
Move CTFTraceCallsitePerformance test to performance tests

Instrument it with Performance Meters.

Change-Id: Ibde3a72b96abc052fea8e357b0dcf915412e23d5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36780
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
9 years agoFix build against latest 4.5
Marc-Andre Laperle [Thu, 5 Mar 2015 22:10:30 +0000 (17:10 -0500)] 
Fix build against latest 4.5

This works around the new warnings but we might want to just drop support
for Eclipse 4.4 since CDT is not supporting it anyway.

Change-Id: Ia6afe62e97048d53ad03adafa590fddcc091ead3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43266
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
9 years agoctf: Don't throw runtime exceptions on invalid IntegerDeclaration attributes
Alexandre Montplaisir [Wed, 4 Mar 2015 16:13:51 +0000 (11:13 -0500)] 
ctf: Don't throw runtime exceptions on invalid IntegerDeclaration attributes

Instead of an IllegalArgumentException, we can check earlier in IOStructGen
if the arguments we are about to pass are valid, along with the other
existing checks.

While at it, remove the check to forbid signed integers to have a size greater
than 1. 1-bit-signed is a valid representation, see Bug 457951.

Change-Id: Idb26e362973104e709b1d613783077ab56b41b94
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43173
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
9 years agoAdd @Since to StateValues
Matthew Khouzam [Wed, 4 Mar 2015 22:52:17 +0000 (17:52 -0500)] 
Add @Since to StateValues

I am expecting more of these patches in the next week

Change-Id: Ia7467bdedd1c9b7b53ace8dc2e9512ecb520b170
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/43203
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
9 years agoos.linux: Add a new WAIT_UNKNOWN state
Alexandre Montplaisir [Thu, 26 Feb 2015 07:05:38 +0000 (02:05 -0500)] 
os.linux: Add a new WAIT_UNKNOWN state

The WAIT state resulting from the statedump events should be
handled slightly differently from, for example, the WAIT state
of a process being scheduled out at a sched_switch.

In the first case, we do not have any information in the trace
about *what* the process is actually waiting on. So it would
be interesting to differentiate it from a real WAIT_BLOCKED,
for which the user can follow the chain of dependencies.

With this patch, the statedump events set the processes to a new
WAIT_UNKNOWN state (and only if there is no prior status set),
different from the WAIT_BLOCKED used for active processes.

This should help a bit with the "everything-is-yellow" syndrome
that plagues your average CFV.

Thanks to Julien Desfossez for this suggestion.

Change-Id: I7d7bb1bfc1d314c822df5ee04bd8b33c6a0c7d36
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42722
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
9 years agoos.linux: Cleanup definition interfaces
Alexandre Montplaisir [Thu, 26 Feb 2015 06:56:58 +0000 (01:56 -0500)] 
os.linux: Cleanup definition interfaces

"public static final" is implied for variables defined in
interfaces, so none of these keywords are needed.

Change-Id: If1964702cc57925e3b886714880745614d0ccf99
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/42721
Reviewed-by: Hudson CI
9 years agotmf.ctf: Do not expose CtfIteratorManager publicly
Alexandre Montplaisir [Tue, 3 Mar 2015 22:10:13 +0000 (17:10 -0500)] 
tmf.ctf: Do not expose CtfIteratorManager publicly

The recent re-enabling of the API tools shows us that CtfTmfTrace
exposes the CtfIteratorManager type - which is internal - publicly.

We now get a hodgepodge of iterator methods in CtfTmfTrace, but
this is more or less unavoidable due to current constrains:
CTFTrace, CtfIterator and CtfIterator are internal, so cannot
be exposed publicly.

Change-Id: I2acf4727e78be238c149f2f93a8cf7bc19713f8e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43120
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
9 years agoAdd new @since 1.0 annotations
Alexandre Montplaisir [Mon, 2 Mar 2015 21:41:33 +0000 (16:41 -0500)] 
Add new @since 1.0 annotations

The API tool is a bit peculiar as to when it decides to run...
It's possible that some more annotations are needed.

Change-Id: If49b70cf359055f5531533b3f167981a0b15dffe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43119
Reviewed-by: Hudson CI
9 years agoAdd API tool nature and builder to all code plugins
Alexandre Montplaisir [Mon, 2 Mar 2015 21:35:51 +0000 (16:35 -0500)] 
Add API tool nature and builder to all code plugins

Now that we have a release (0.1.0) we can use as an API baseline,
we can re-enable in the API tooling in the master branch.

Change-Id: Ie187f365118d1891244c661698fe451af90c3a19
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43118
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
9 years agoRemove all existing @since annotations
Alexandre Montplaisir [Mon, 2 Mar 2015 22:10:17 +0000 (17:10 -0500)] 
Remove all existing @since annotations

Those are based off Linux Tools version numbers, so they need to
be removed before we can introduce new ones based on the Trace
Compass versions.

Change-Id: Ia0ea5eeb597f4cf5a3e6f10ee074e0621888bdee
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/43117
Reviewed-by: Hudson CI
This page took 0.046987 seconds and 5 git commands to generate.