Alexandre Montplaisir [Wed, 6 Mar 2013 20:04:04 +0000 (15:04 -0500)]
lttng: Add an in-depth test for full state system queries
Also add a small program/script in the 'headless' package to
regenerate those reference values easily, in case we need to
update the test values after we modify the kernel state provider.
Change-Id: I5cf66367a246ca78bb85f4cb3b3ad3c24ea6142e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10908
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Mon, 11 Mar 2013 21:45:47 +0000 (17:45 -0400)]
tmf: Replace state value types with an enum
Originally, we specified the low-level byte to write to the
history tree file in ITmfStateValue. Now that we have multiple
possible state backends, it's much more convenient to use an
enum in the framework, and define the type<->byte conversion
inside the History Tree only.
Change-Id: I8bd694672256c15737e41813b3146b2f929d8c78
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11065
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 13 Mar 2013 18:30:41 +0000 (14:30 -0400)]
gdb trace: Improve executable selection
Change-Id: Id7f05a0611b81ffa7802a77c70e2ea8b5bbe6db2
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11111
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 13 Mar 2013 17:18:35 +0000 (13:18 -0400)]
gdb trace: Fix shutdown deadlock
Change-Id: I16b822e3bf413d2dae86b95614fb12883d50240f
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11112
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 6 Mar 2013 19:13:05 +0000 (14:13 -0500)]
Introduce GDB Tracepoint Analysis feature
Change-Id: I0800687b8b55b381fb304b828f57b9cd330c0d4b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10946
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Tue, 12 Mar 2013 17:49:13 +0000 (13:49 -0400)]
lttng: add command execution timeout preference
Change-Id: Ia3b09ad1260517ead01c53dd21cfa97a0484ad03
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11086
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Mon, 11 Mar 2013 21:42:29 +0000 (17:42 -0400)]
Fix NullPointerException in TimeChartView
Change-Id: Icdf83a6ee5109a7684ff3450745c028f565dd420
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11063
Tested-by: Hudson CI
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Alexandre Montplaisir [Tue, 5 Mar 2013 19:20:20 +0000 (14:20 -0500)]
tmf: Don't access the attribute tree directly
but go through a new StateSystem.getAttributeTree() method that
wraps it. This way, a potential subclass only needs to override
that method to point to a different attribute tree.
Change-Id: I77b306f53095eb7b7423e10ee1ebb97c3ddaf6f5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10856
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 6 Mar 2013 18:34:17 +0000 (13:34 -0500)]
Update plug-in and feature descriptions
Change-Id: I6b68175455e2cb27eebcf65f97c2593090d11a61
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10901
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Wed, 6 Mar 2013 18:17:35 +0000 (13:17 -0500)]
lttng ui: fix handling of command output for verbose commands
When executing commands with preference verbose the command output
parsing of certain commands were not correct and caused
ExecutionExceptions in Eclipse even if the command was successfully
executed. This has been corrected with this commit. Also, this
commit contains JUnit tests to verify the updates.
Change-Id: I24196959a28093a292f599f93f6b78f6fd76c69e
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10864
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Tue, 5 Mar 2013 16:09:51 +0000 (11:09 -0500)]
lttng/tmf: update versions and dependencies
Change-Id: I8bce498a0ffa19cbdc097351a13fbee72b84ce4a
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10848
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Thu, 28 Feb 2013 21:04:19 +0000 (16:04 -0500)]
tmf: Move some code to copy/add/remove traces in UI
The "Copy trace", "Select traces..." and "Remove" functionnalities have
some code that can be reused by each other and future features. This
code has been moved to the model element's classes.
Change-Id: Id61914521f41d9c2b2c25fe1268e61be62c1d504
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/10751
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Fri, 1 Mar 2013 16:50:39 +0000 (11:50 -0500)]
tmf: Call parent before CtfTmfTrace specific initialization
Some features need to have resources initialized before the CtfTmfTrace
starts fetching its events.
Change-Id: If3d638263713064e8b4be4e651e4e0e33c734e4e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/10783
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 28 Feb 2013 23:01:27 +0000 (18:01 -0500)]
tmf: Add method to replace a statesystem's ongoing state
Replace the vestigial TransientState.changeOngoingStateInfo()
(which was never used so far) with a similar method that can
generate a current state from an array of intervals.
For now, this this potentially dangerous method is only exposed
to classes extending StateSystem.
This will be useful for the partial history, but also for anybody
wanting to do funky stuff with the state system.
Change-Id: Ieebe6dfceb57c1437d81fd9a97c6be10040afeb4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10760
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 28 Feb 2013 20:59:09 +0000 (15:59 -0500)]
tmf: Add a method to query an ongoing state's start time
We can already query a state system's current state value for
a given attribute. It's trivial to expose a method to also query
the start time of that state.
Change-Id: I4b2610709bb0af33b612514007787b20f941f490
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10757
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 28 Feb 2013 20:47:23 +0000 (15:47 -0500)]
tmf: Add a copy method to state system inputs
This is another requirement for partial histories. It is not a
real "clone" method, since we do not want to copy the assigned
state system at that moment, it's supposed to be assigned later
with another call to assignTargetStateSystem().
Change-Id: I744030084fc968b6426718c2fac5ace7f1a2c6dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10756
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 28 Feb 2013 20:30:54 +0000 (15:30 -0500)]
lttng: Do not cache attribute tree locations
As a requirement for partial histories, we cannot cache
commonly-used attribute tree locations in the state providers.
Since the partial history's inner state provider will not know
the cached values of the real one, we need to resolve them
every time.
This unfortunately hampers the performance of standard state
system constructions a bit.
Change-Id: I93e104ea1e4fe7159805ff54296d4cfc830444a3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10755
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Fri, 1 Mar 2013 22:04:56 +0000 (17:04 -0500)]
lttng: Don't throw irrelevant exceptions in state system tests
Some tests expect exceptions, so these have to keep the "throws"
clause. For everything else, handle the excpetion in a try/catch
which will fail() the test if they happen.
This makes it simpler to extend the test cases, since the throws
may or may not be relevant in the subclass.
Change-Id: If71b351ba22bd88377120833eb83e9b78717d579
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10795
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Fri, 1 Mar 2013 19:47:41 +0000 (14:47 -0500)]
Improved error handling for connection errors in LTTng control
Change-Id: I4c91fd06433a38a30903b82e762284de36486a26
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10784
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Thu, 28 Feb 2013 21:49:23 +0000 (16:49 -0500)]
Fix ResourceException in drag and drop to experiment from same project
Change-Id: Idf0945dd0c965b99360a4f4df7d8f3a31b371fcc
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10752
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Wed, 27 Feb 2013 15:42:28 +0000 (10:42 -0500)]
Remove unnecessary methods in LTTng Tracer Control model
In many classes of the LTTng Tracer Control model convenience
methods exists that don't require passing a progress monitor and
that just calls another methods to pass a NullProgressMontior
instance. This causes increased maintenance work and doesn't bring
much gain.
Change-Id: Iae4c38d994953ead656dffc7065f01168dbbc7a7
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10732
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
François Rajotte [Thu, 28 Feb 2013 16:12:35 +0000 (11:12 -0500)]
Change the TimeGraphCombo's filter to a blacklist rather than a whitelist
This should better support views that modify the list of entries dynamically.
Change-Id: I1a5e324d49a58e8444d4767542815c1e00836c64
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/10740
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 27 Feb 2013 22:01:55 +0000 (17:01 -0500)]
Update default filter behavior in TimeGraphCombo
Instead of storing all elements as non-filtered in the raw viewer filter
on setInput, set the list of non-filtered elements to null by default
and use this default null value to make the filter allow all elements.
Change-Id: Ida8e7ccb198bdde6b8dc736bdd24d510ae168a50
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10719
Tested-by: Hudson CI
Bernd Hufmann [Thu, 28 Feb 2013 13:12:48 +0000 (08:12 -0500)]
lttng: Add clear() call before add elements to list
In various LTTng Tracer Control core model classes, the relevant
array list is not cleared when the setter is being called. For
example, the method DomainInfo.setChannels(List chans) doesn't
clear the channel list before filling the channel list with the
new channels passed as parameter.
Change-Id: I0e5c8c4f0bd84a6de1c383131255b61c7ca94406
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10731
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 27 Feb 2013 19:13:49 +0000 (14:13 -0500)]
tmf: Update copyright headers in tmf.core
Using the copyright tool in Eclipse's Releng Tools.
Apparently we should only have 2 years on the (c) line: the
initial creation year and the year of the latest revision.
Change-Id: I0c684a187a823df800cb751094cf5f58f39de910
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10714
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Wed, 27 Feb 2013 19:15:35 +0000 (14:15 -0500)]
tmf: Update copyright headers in tmf.ui
Change-Id: I2acd0fe55407f36cd7ee0df0404050206216fd6c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10715
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 26 Feb 2013 21:17:38 +0000 (16:17 -0500)]
lttng: Update copyright headers
Change-Id: I438daa1aad7347388f54468f4b09d66ac4b1d192
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10713
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 26 Feb 2013 21:11:20 +0000 (16:11 -0500)]
ctf: Update copyright headers and add missing ones
Change-Id: I7b4166fae6a48d38fe4a6eecc3198fa9db1303ec
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10712
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Matthew Khouzam [Wed, 20 Feb 2013 22:59:50 +0000 (17:59 -0500)]
[CTF] Fix Struct toString fields in CtfTmfEventFields
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Change-Id: I33caa90a998c95cba2bf46cd77d042601b50ac3c
Reviewed-on: https://git.eclipse.org/r/10546
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Wed, 27 Feb 2013 21:10:58 +0000 (16:10 -0500)]
Add README files for ctf.parser and {lttng|tmf}.help
Those plugins require special steps to build, so if somebody
hasn't read the wiki page, they can refer to these files for
the instructions.
Change-Id: Ic34f0e89491076b2e133b94bb52652336445552f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10718
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 27 Feb 2013 18:58:24 +0000 (13:58 -0500)]
Update User Guide for support of LTTng Tools v2.1.0
Change-Id: Idd4e9534023cd9a63704b87614de9828a75a259c
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10633
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Tue, 26 Feb 2013 20:27:08 +0000 (15:27 -0500)]
Drag and drop enhancements
- Add support for DROP_LINK
- Add rename prompt on name collision with automatic name resolution
- Add support for unknown trace type icon
- Fix propagation of selected trace type to experiment traces
- Updated user guide
Change-Id: I1eb7c7bcbe5566a0fc507aef1554780515d62eb5
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10667
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Tue, 26 Feb 2013 19:14:39 +0000 (14:14 -0500)]
Use transparent color for unknown states in ControlFlow/Resources view
The TRANSPARENT value is used for unknown states (states embedded by the
view in between actual states due to the sampling). When many states
occur in the same pixel range, the pixel now takes the color of one of
the states within the pixel range. The selected state color for a pixel
can change with regards to the current widget size and time range. The
tool tip information may be computed for a transparent state which does
not match the visible color under the cursor. In that case the state
name "(multiple)" is displayed.
Change-Id: If9185f67826bdab450cecf6f70c8b25f9beda33d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10187
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Tue, 26 Feb 2013 19:22:09 +0000 (14:22 -0500)]
Add transparent events to time graph
The time graph presentation provider interface is updated to define two
new constants for the state table index. When TRANSPARENT value is
returned, only the event border will be drawn, the event body will
remain transparent (empty) to allow the pixel to take the color of the
next visible event on the same pixel. The INVISIBLE value is defined,
although the functionality was previously supported. When INVISIBLE
value is returned, the event is not drawn at all and neither are its
borders.
The Time Chart view is updated to use the INVISIBLE value to hide
filtered events.
Change-Id: Ide68c4237db60824094f1f16739341cbf5e69860
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10186
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Tue, 26 Feb 2013 19:20:58 +0000 (14:20 -0500)]
Fix merged event iterator
The merged event iterator was sometimes creating split events with
negative duration when a zoomed event was longer than an unzoomed event
starting at the same time, and when the requested iterator range was
smaller than the zoomed events range. The algorithm for the iterator is
reworked. Also, comments.
Change-Id: I6ef83d3e3b9b25d716978cba906e9bef0985b5bd
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10185
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 25 Feb 2013 22:59:14 +0000 (17:59 -0500)]
tmf: Add support for versioning state input plugins
As we have seen with the recent addition of WAIT_FOR_CPU and
WAIT_BLOCKED state, if the framework gets updated we need a
way to tell it to rebuild any existing (and now outdated)
state history file that can be present in the workspace.
This patch reuses the minor_version field which was present
in the history tree's file header, but wasn't used. We now
assign this int to represent the version of the specific
state input we're trying to build. If the version in the
framework and the version of the existing file don't match, it
will force a rebuild.
Since the initial value used is 0, it should keep working with
any currently-existing history files (until the framework's
handlers are modified).
Change-Id: Id321db30f2e124cf93c96205a0450cccad47a49f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10638
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Mon, 25 Feb 2013 18:17:45 +0000 (13:17 -0500)]
tmf: Remove deprecated HistoryTree constructor
Change-Id: I7826994d2071c14fd183d778df65c9f6e5879ef2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10637
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Mon, 25 Feb 2013 18:11:11 +0000 (13:11 -0500)]
tmf: Update comments in HistoryTree
Change-Id: Ic912058f261b042c88d772175b7d89f010b160cb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10636
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 14 Feb 2013 16:37:10 +0000 (11:37 -0500)]
tmf: Move timestamps to their own package
Eventually, for trace synchronization among other things, we
will need to use trace-specific timestamp factories. It will
be much better organized if timestamps have their own package
(they are not specific to events anyway).
The trace sync/timestamp factory rework is really big, and it
probably won't make Kepler. However, doing this move right now
will allow us to introduce timestamp factories and the such
post-Kepler, without breaking the 2.0 API.
Change-Id: Iffe4dc4758d9e0627f78aad6cbd9c6013097f800
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10496
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Mon, 25 Feb 2013 13:40:47 +0000 (08:40 -0500)]
Update to session creation procedure
- Removed --no-consumer and --disable-consumer option because these
options will be obsolete in LTTng Tools 2.2
- Updated commands and dialog boxes for this change
- Updated JUnit tests
Change-Id: Ic89c7af3df98c25ff777eebbe1a7e15785ec91ae
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10590
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Mon, 25 Feb 2013 13:47:30 +0000 (08:47 -0500)]
Update file headers in LTTng Control feature
Previously delivered features for LTTng Tools 2.1 support lack
the update of the file headers. This commit corrects that.
Change-Id: I4fb7d4731ab13ee4d905a0a3e94cd589cab95efe
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10617
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Mon, 18 Feb 2013 15:20:00 +0000 (10:20 -0500)]
TMF: Add supplementary folder to experiments
Just like traces, experiments can save information in supplementary
files on disk (see bug 400949).
* Added class TmfWithFolderElement that TmfTraceElement and
TmfExperimentElement extends
* TmfExperiment constructors are modified/added to receive a
IResource as parameter
* Call to constructors are modified in the .ui code to add the
resources
* Added calls to delete/copy/rename supplementary folder
Change-Id: Ic6996ca2c39bd3ea499521349f04bfc7c237b419
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/10435
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 21 Feb 2013 22:34:02 +0000 (17:34 -0500)]
tmf: Remove redundant null checks
If a final field is instantiated at declaration, it cannot
ever be null, so null checks are redundant in this case.
Change-Id: Iae8a3064bd209d931196ff256fde9db879ea20aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10577
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 21 Feb 2013 21:18:17 +0000 (16:18 -0500)]
ctf: Remove missing builder from the parser plugin
Probably an artifact that came from a copy-paste a long time ago...
Change-Id: I4ac82b709d15c101ce67b96c815bfa574eb84041
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10576
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 20 Feb 2013 21:48:27 +0000 (16:48 -0500)]
Update user guide for callsite and model lookup
Change-Id: If50ed7916a28e5cd126d7c525603e01e80150788
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10540
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 19 Feb 2013 20:19:39 +0000 (15:19 -0500)]
ctf: Build ANTLR-generated files with Maven
instead of keeping those huge and very very ugly files
in the git tree...
The sample script to build them manually has been moved to
the plugin's top-level directory and updated to the new paths.
Change-Id: If8ede7343d643470b50cdbb0110ce4bb80b648db
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10494
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 19 Feb 2013 13:15:37 +0000 (08:15 -0500)]
tmf: Tell Maven to clean the documentation too
Change-Id: Iee96f5717a666c45bc79fb32e861067bf286f39c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10469
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Simon Marchi [Tue, 19 Feb 2013 20:23:05 +0000 (15:23 -0500)]
Add or fix CTF types toString
* struct: add field names
* variant: print the current field
* enum: print value and container value
Change-Id: I45d9a2fd900a29cd2ef99f15d2d58d4d01151ee1
Reviewed-on: https://git.eclipse.org/r/10490
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Simon Marchi [Wed, 20 Feb 2013 16:05:10 +0000 (11:05 -0500)]
Fix EnumDefinition's "value" field assignments
Change-Id: I927f904fab8f60e6d762541a36164dcc93650edb
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/10524
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Tue, 19 Feb 2013 19:26:02 +0000 (14:26 -0500)]
Remove context clone and add trace ranks to experiment location
Change-Id: I97bf73d63e2788d66013e4c5cfb2057083ba5de4
Reviewed-on: https://git.eclipse.org/r/10460
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Tue, 19 Feb 2013 23:09:22 +0000 (18:09 -0500)]
Fix test case for local time zone
Change-Id: I2e9115810a48ddc1f685c844a8ae7e349d9b13db
Reviewed-on: https://git.eclipse.org/r/9545
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 8 Feb 2013 18:59:23 +0000 (13:59 -0500)]
Add Open Callsite action in events table for CTF events
- Create CtfTmfCallsite class
- Add interface to CtfTmfEvent to get callsite for an event
- Remove callsite from CtfTmfEvent content fields
- Add Open Callsite action to TmfEventsTable
- Fix search for callsite candidates in workspace
- Add dialog when more than one candidate are found
- Change action name for callsite and model to be consistent
- Fix capitalization of actions in events table
- Make CtfTmfEventFactory a final class with no public constructor
- Rename CtfCustomAttributes to CtfConstants and add context strings
Change-Id: I82523209ef960d37f7f0efa40684e7a92a593ebe
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/8374
Tested-by: Hudson CI
Geneviève Bastien [Fri, 15 Feb 2013 20:34:06 +0000 (15:34 -0500)]
TMF: Add support for StructDefinition fields to ctfadaptor
CTF supports recursive field definitions. So does TMF now.
* Added the CTFStructField class
* Updated the unit tests for this new class
Change-Id: I5e476da2a73f172ff946a1fff386e6fb48dff1bc
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/10401
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 11 Dec 2012 17:01:46 +0000 (12:01 -0500)]
lttng: Add an Eclipse builder for the doc plugin
Removed all committed .html and .xml documentation files
from the tree. Those can now be built either from Eclipse
(with right-click -> Run As -> Ant Build), or with Maven.
Splitted out the download-from-Eclipse-wiki task into a
separate target, which will only run manually.
Also did some small changes so that no user-editing of the
build file is required, except if you want to use a proxy
for the download.
Change-Id: I19d8d8e9c51aeda65dd26543ddade3a4d80e7803
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9165
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 29 Nov 2012 21:47:23 +0000 (16:47 -0500)]
tmf: Add a tmf.help plugin for the User Guide
Initial version taken from the current contents of the Eclipse
wiki, minus the outdated Statistics section.
This should build both with Maven and from Eclipse itself (although
it won't auto-build from Eclipse, one has to right-click the build.xml
file and choose "Run As -> Ant Build").
Change-Id: Ic9ed9205b9f84a0d932da84e1f0369a3226f8f71
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9169
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Wed, 13 Feb 2013 19:46:24 +0000 (14:46 -0500)]
lttng: Re-enable the kernel.core unit tests
Plugged them into the shared CTF test trace infrastructure,
and made them check if the trace exists before running the
tests. If the trace is not available, the tests are skipped.
Change-Id: I74847d62233551e2eef8910b7c7444e0c387e29c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10355
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Wed, 13 Feb 2013 20:37:37 +0000 (15:37 -0500)]
tmf: Re-enable the unit tests depending on CTF traces
And skip them if the traces are not available.
Also added a new exported test file manager, so that other
plugin tests (like the lttng2 ones) can re-use it.
Change-Id: I71cffad8f68089f3e88582e436a74bb2ec57c897
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10354
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Wed, 13 Feb 2013 14:10:48 +0000 (09:10 -0500)]
Fix Typos in interface methods of TmfUml2SdSynchLoader
Since this class has already interface changes for 2.0 it was good
time to fix these typos.
Change-Id: Iac9018a5448bb381472d5521be72f922dcfa790a
Reviewed-on: https://git.eclipse.org/r/10336
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Wed, 13 Feb 2013 19:02:45 +0000 (14:02 -0500)]
ctf: Allow the test traces to be used by other plugins
Centralize the management of the CTF test traces by moving the
"TestParams" file to a separate, exported package.
This required fiddling with the plugin type and adding an
activator, to mimic the behavior of "tmf.core.tests" (which
is also a test plugin that exports packages).
Change-Id: Ieeb32eda8099d797999a5803dcdc2b4f8c77a51b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10353
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Wed, 13 Feb 2013 16:59:09 +0000 (11:59 -0500)]
Add support for streaming feature of LTTng Tools 2.1 (part 1)
- Add support for streaming configuration during session creation
- Update import for local traces
- Update JUnit tests
Change-Id: I74e6a44b2bb877203b6837c657cc919feadbe65b
Reviewed-on: https://git.eclipse.org/r/9363
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 12 Feb 2013 22:46:11 +0000 (17:46 -0500)]
ctf: Re-enable the CTF parser unit tests
but skip them, via assumeTrue(), if the test traces cannot be
found.
Right now Eclipse would show skipped tests as "passed" (see
bug 359944), but Maven should report skipped tests correctly.
Change-Id: Ia3a3451d5b5e5999afcbf9dea416ce0e45c9c9ad
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10329
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 7 Feb 2013 22:14:40 +0000 (17:14 -0500)]
tmf: Move some logic outside of HistoryBuilder
Move the input.assignTargetSS() call outside of HistoryBuilder's
constructor. This will allow more flexibility for input/backend
types that need to instantiate their objects in a different
order than the typical "kernel input -> ss -> history tree"
trinity does (for example, partial histories).
Change-Id: I2d07b44e39e55475bd6bdfde8641d2985b7c145f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10280
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 12 Feb 2013 16:37:52 +0000 (11:37 -0500)]
Disable CTF/TMF unit tests that depend on external traces
Temporarily disable the unit tests using CTF traces, at least
until bug 400473 is fixed.
Before re-enabling them, they should be made to run only if the
traces are present, and skipped if they are not. That way it
should not show unit test failures if the download failed.
Change-Id: I87cd4220be36f7b0b853050186b5ca7bd64dd1ed
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10320
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 11 Feb 2013 18:59:31 +0000 (13:59 -0500)]
ctf: Avoid re-downloading the test traces
Do not download the test traces if they are already present
on the file system (skipexisting="true").
The extraction was also moved to a conditional task, so that if
the traces cannot be downloaded for some reason, at least it
doesn't fail the complete build. Some unit tests will probably fail,
but that's the lesser of the two evils.
References bug 400459.
Change-Id: I69d7cb1525005cf6426f7aa42c45ecbb4c92cdff
Reviewed-on: https://git.eclipse.org/r/10286
Tested-by: Hudson CI
Reviewed-by: Alexander Kurtakov <akurtako@redhat.com>
IP-Clean: Alexander Kurtakov <akurtako@redhat.com>
Tested-by: Alexander Kurtakov <akurtako@redhat.com>
Patrick Tasse [Fri, 8 Feb 2013 19:44:54 +0000 (14:44 -0500)]
Show increasing progress for indexing job
Periodically update the job name with the current number of events and
the task name with the current indexing rate.
Change-Id: I229b7ba92b9528a927f79c232d38e2cf62bb41ba
Reviewed-on: https://git.eclipse.org/r/10088
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 7 Feb 2013 19:22:56 +0000 (14:22 -0500)]
tmf: Make CtfLocation extend TmfLocation
We save one field, but more interestingly we don't need to
duplicate the equals() and hashCode() methods.
refs bug 387929
Change-Id: I4c23d6e80cc860470453963a2d559066a811fbc1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10240
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 7 Feb 2013 19:06:01 +0000 (14:06 -0500)]
tmf: Rename CtfLocationData to CtfLocationInfo
to be consistent with the base classes.
Change-Id: I4df517752773d7ceb0d1a5444832ab178464bace
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10239
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 18 Jan 2013 20:21:35 +0000 (15:21 -0500)]
tmf: Make CtfTmfEvent extend TmfEvent
instead of re-implementing the interface.
Part of bug 387929.
For clarity's sake, moved all the instantiation-related code
into a new CtfTmfEventFactory.
Change-Id: Icb3d122acc3a23de3134d8209aa0be5ed4f705f0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10053
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Wed, 6 Feb 2013 16:43:07 +0000 (11:43 -0500)]
tmf: Remove Cloneable from (I)TmfCheckpoint
It was not used anywhere, except in tests, and the object isn't
made to be modified already.
Change-Id: I36330f3bf6b3c20e37ab2be88aa90984cbd2a05f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10215
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 29 Jan 2013 22:02:22 +0000 (17:02 -0500)]
tmf: CtfTmfContext rename
Renamed from CtfTmfLightweighContext (there are no heavyweight
contexts anymore) + fixed the clone() method.
After much experimentation, I gave up trying to not make those
extend TmfContext (sorry bug 387929). It seems the iterator
manager depends on CtfTmfContext.equals() to not be overriden.
Fixing this behavior (by making the manager track the locations
instead of the contexts, for example) works, but then reading
events becomes unbearably slow.
I think it's better to not touch this until a proper iterator
API comes to TMF, at which point we can use that directly.
Change-Id: I57cedac2702d0b70950687bdfa7a681ac7582be8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10194
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexander Kurtakov [Tue, 5 Feb 2013 22:49:32 +0000 (00:49 +0200)]
Remove maven assembly plugin configs.
The plugins are more interconnected now and that results in separate tarballs not being useful separately. CGit also provides tarballs for the the entire project. Noone objected to this on the mailing list.
Change-Id: Idff1e6a380ca1af6116935faaebd79748e8983ee
Reviewed-on: https://git.eclipse.org/r/10190
Tested-by: Hudson CI
Reviewed-by: Camilo Bernal <cabernal@redhat.com>
IP-Clean: Camilo Bernal <cabernal@redhat.com>
Tested-by: Camilo Bernal <cabernal@redhat.com>
Alexandre Montplaisir [Fri, 1 Feb 2013 22:21:19 +0000 (17:21 -0500)]
tmf: Make TmfEvent immutable
The immediate benefit of immutable events is that we can avoid
doing copies in many places in the framework (for indexing,
checkpoints, et al.). It also alleviates many potential
concurrency issues.
For specific sub-classes that need to have mutable (non-final)
fields, the recommended - hopefully transitional - approach is to
re-define the fields in question and override the getters to make
sure the extended class's versions are used.
This was done for CustomEvent in this patch.
Change-Id: I6a9ec635eaa68b03d1c5a6875f60ece7d47cb024
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10123
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 1 Feb 2013 16:46:28 +0000 (11:46 -0500)]
tmf/lttng: Explicitely depend on JUnit4
"org.junit4" shouldn't be used anymore, according to
http://wiki.eclipse.org/Eclipse/Testing/JUnit4_Changes
Change-Id: I4d9c44f603411adafcb6291f2971e77244a454b8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10120
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Tue, 29 Jan 2013 18:20:37 +0000 (13:20 -0500)]
tmf: Port tmf.ui unit tests to JUnit4
Last part of bug 393449.
Split up some Sequence Diagram unit test methods in separate
test cases, now that we can use @BeforeClass.
Change-Id: I7416241ccb82b4825f6c790e655b276b5c1655ef
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10119
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Thu, 31 Jan 2013 20:55:08 +0000 (15:55 -0500)]
tmf: Enable the ctfadaptor and statistics unit tests
The CTF parser tests now download the CTF test traces, so we
should be able to run those on the build server.
In a separate commit, so it's easier to revert in case of
massive breakage...
Change-Id: I663c1cd7e83a7a501da0701dfb1ddd76ad421082
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10118
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 25 Jan 2013 22:25:57 +0000 (17:25 -0500)]
tmf: Update tmf.core unit tests to JUnit4
Refs bug 393449.
Also added missing dispose() calls in TmfExperimentCheckpointIndexTest.
Not doing those would fail subsequent tests in TmfTraceTest (not sure
why this wasn't needed with JUnit3).
Change-Id: Id6bb29067fadf1bee6b30955520ce376b1ac01aa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10117
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Wed, 30 Jan 2013 21:06:12 +0000 (16:06 -0500)]
tmf: Decouple tmf.core unit tests from TmfEvent
Make sure the TMF unit tests use the ITmfEvent interface
as much as possible (this is the behavior we want to have
in the core framework).
Change-Id: I242a5265c716498392f2b1414785db03f302540d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10051
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Francis Giraldeau [Fri, 1 Feb 2013 20:25:03 +0000 (15:25 -0500)]
Register the control flow as selection provider
In order to signal the selection of a task in the control flow view,
register the tree view in the selection service. It allows other
plug-ins to listen for selection change.
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Change-Id: I5294e12c660c60a8e01f1b76c3e993da6e6534af
Reviewed-on: https://git.eclipse.org/r/10115
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Fri, 25 Jan 2013 16:52:04 +0000 (11:52 -0500)]
ctf: Clean up the test suites
* Order the test names alphabetically.
* Enable IOstructgenTest, which was not running.
* Drop the main() methods, probably an artifact from CodePro.
Change-Id: I139351bced74638d702cfb7245db38481545424a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10055
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 30 Jan 2013 21:31:40 +0000 (16:31 -0500)]
Merge entries with same TID in Control Flow view
Separate entries are no longer created when a thread changes its exec
name over time. A single entry is used, and its name is set to the last
exec name of the thread. If the thread is terminated and reused, a
separate entry will be created with a different name and birth time.
Change-Id: I97d06adf8c68f9f56594059bc51a38fa78e36842
Reviewed-on: https://git.eclipse.org/r/10049
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 31 Jan 2013 20:04:03 +0000 (15:04 -0500)]
lttng: Fix control model unit tests for the new API
The .init() and .dispose() were done in the now-unused TestSetup.
Move those the the @Before and @After classes in the tests
themselves.
Change-Id: I9d782a3192e5ced2ee65b916aaa5a1dce50f801d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10081
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 25 Jan 2013 20:05:20 +0000 (15:05 -0500)]
lttng: Port unit tests to JUnit4
Refs bug 393449.
Change-Id: I84d3f62d0e1dd1b8bd1d0ad00f3347cc86df6ad2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10056
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 21 Jan 2013 20:34:26 +0000 (15:34 -0500)]
tmf: Make CtfTmfEventField extend TmfEventField
Part of bug 387929.
Also swapped the (name, value) parameter order in the
constructors to match the superclass.
Change-Id: I71de4d41e6d22cb31262e8b0ccb63a8a910b4dbf
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10054
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Xavier Raynaud [Tue, 29 Jan 2013 11:12:34 +0000 (12:12 +0100)]
o.e.l.tmf.ui: Utils.findEvent no longer return null when previous ITimeEvent has duration=0
Change-Id: Ife4698c556a7e78595115bc4b9a834183d57c82d
Reviewed-on: https://git.eclipse.org/r/9998
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Alexandre Montplaisir [Thu, 17 Jan 2013 20:55:12 +0000 (15:55 -0500)]
tmf: Make TmfEventField immutable
This required some minor adjustment in CustomEventContent.
Those can still extend TmfEventField, but it requires creating
a new Content object if you want to change its values.
Change-Id: I1fe951fe60d505f4ad9564dea559af522a86ac9f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9806
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 28 Jan 2013 21:13:44 +0000 (16:13 -0500)]
lttng: Add missing javadoc comment to LTTngControlService
Change-Id: I2a2f2588bde494f77072f805484291933933765e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9976
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Mon, 28 Jan 2013 21:08:14 +0000 (16:08 -0500)]
tmf: Add missing since tag in
77d30f4
Change-Id: Ia05329a9e19e93df9136b04039209e1086f9d5f1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9975
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 25 Jan 2013 22:58:48 +0000 (17:58 -0500)]
Use Traces folder trace element when creating experiment from editor
When an experiment is created from the TmfEventsEditor.init method from
a FileEditorInput (ie. on platform restart or on open from bookmark),
the trace element from the Traces folder should be used. This is
required so that any plug-in extension that stores a persistent property
on the trace resource can access it when an experiment is created this
way.
Change-Id: I321a2cf3af91a7c898eb9800ce7f03fbbf34b9e4
Reviewed-on: https://git.eclipse.org/r/9940
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 25 Jan 2013 23:06:28 +0000 (18:06 -0500)]
Fix event table selection handling
A SelectionChangedEvent should be fired when the selection changes due
to a Search match.
The selected rank should be updated when the selection changes due to
the gotoMarker() handling.
Change-Id: Iaec404049edf126f43ee6d049cdc8263f4e1c5db
Reviewed-on: https://git.eclipse.org/r/9941
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Fri, 25 Jan 2013 23:14:53 +0000 (18:14 -0500)]
Add trace type property tester
Add a trace type property tested that plug-in extensions can use to
enable/disable commands and menu items based on the specific trace type
of the current selection.
Change-Id: Id23455ed672af6c044b699847428213bd0397970
Reviewed-on: https://git.eclipse.org/r/9939
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Fri, 25 Jan 2013 16:42:04 +0000 (11:42 -0500)]
[TMF] Allow custom iterators by making the traces the iterator factories
Change-Id: Ib744ad63228a1c070f38d4710936481420739d06
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/9931
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 24 Jan 2013 22:09:07 +0000 (17:09 -0500)]
Add entry filter support for TimegraphCombo via dialog
Change-Id: I56d714f5a7bcb1b849fda463821dccb525478745
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6874
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 24 Jan 2013 22:08:48 +0000 (17:08 -0500)]
Add multi-column tree selection dialog
Change-Id: If4e8453b7826ee3777a92a5b82226a8b71860e04
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/6873
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 14 Jan 2013 20:37:55 +0000 (15:37 -0500)]
tmf: Add a new package for state history backends
Added two new simple backends:
- Null backend, which discards all intervals it receives.
- In-memory backend, which is like a full history but keeps
everything in RAM. For use with small state systems only!
Also renamed the existing *.historytree package to
*.backends.historytree.
Change-Id: Ia32285ce2162d5315616dd2546fa18549b38da22
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9594
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 21 Jan 2013 15:53:45 +0000 (10:53 -0500)]
tmf: Update interface name in commit
1433bda1
Change-Id: Ibf732cee48428492774259b2256590dcd1887ebd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/9807
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 21 Jan 2013 15:30:22 +0000 (10:30 -0500)]
tmf: Fix regression in event requests
The following commits introduced a regression, where event
requests for partial ranges would stop working for trace
types that don't define event ranks:
4ca3bebf55c097f872185ac53e18eba4dc88745b
f08203da275a49739af94f6dc1532116d67af593
42eaaef87cf60a5129d64bead5698a84d3d43349
8ed1afa7534fa011991dee35874910f8de01758a
b341bd59ed80f4e848039acc6477ce5711318841
88b2d8d9a2114b2580a1f62c51752754fad39cec
Revert them out of master until they get more testing.
Change-Id: Iee00ba9f1e619737c0406222e607b994301c0ff9
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Thu, 17 Jan 2013 19:16:42 +0000 (14:16 -0500)]
[CTF] fix support for traces with per-event contexts
Change-Id: I11afb20264b6c4a20c4e44132bdc49cec6d653ca
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/9741
Patrick Tasse [Thu, 17 Jan 2013 21:14:44 +0000 (16:14 -0500)]
Fix deadlock in TmfUml2SDSyncLoader
Prevent deadlock in TmfUml2SDSyncLoader between the object's
reentrant lock and request synchronization by moving request
cancellations outside of the reentrant lock's scope.
Change-Id: Idc04b4f1a56904e718841db5a33eafb2970cea8a
Reviewed-on: https://git.eclipse.org/r/9744
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Ansgar Radermacher [Wed, 16 Jan 2013 17:19:54 +0000 (18:19 +0100)]
tmf: Support the model URI of a trace event
Fixes bug 396956.
Change-Id: I03cc2b1b34760fe3d9f9c9139cd4c0dca77a6670
Reviewed-on: https://git.eclipse.org/r/9699
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Ansgar Radermacher <ansgar.radermacher@cea.fr>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Michel Dagenais [Tue, 8 Jan 2013 16:53:35 +0000 (11:53 -0500)]
lttng: State of processes from LTTng kernel traces
Separate WAIT_FOR_CPU and WAIT_BLOCKED states, and display
them in different colors in the Control Flow View.
Change-Id: I327c868841a45b411537d7e4d9e525d30d40ceab
Reviewed-on: https://git.eclipse.org/r/9540
Tested-by: Hudson CI
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
This page took 0.048537 seconds and 5 git commands to generate.