deliverable/tracecompass.git
8 years agoos.linux: Ignore testWriteToTsv swtbot test
Geneviève Bastien [Wed, 26 Oct 2016 19:27:59 +0000 (15:27 -0400)] 
os.linux: Ignore testWriteToTsv swtbot test

This test causes instability in the SWTbot because of a potential race
condition with the update that changes the header column titles that do
not correspond to the system call data. The test should be modified
either to use SystemCall segments, or moved to timing.swtbot

Change-Id: Idea1c43f377ca79efb4bf5a4751f4611e6336891
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83967
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotiming: fix typos in segstore statistics test
Geneviève Bastien [Mon, 24 Oct 2016 20:10:39 +0000 (16:10 -0400)] 
timing: fix typos in segstore statistics test

And update some javadoc for tests

Change-Id: I9e35865a37c4f2b62ec33b895ee2dc8ec8d0e2a1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83823
Reviewed-by: Hudson CI
8 years agotiming.ui: fix typo in id of CallGraphDensityView
Matthew Khouzam [Fri, 21 Oct 2016 20:02:20 +0000 (16:02 -0400)] 
timing.ui: fix typo in id of CallGraphDensityView

The ID was never used, now the view can now be opened
programatically as it matches the plugin.xml

Change-Id: I25ab1ecf9324ef43001fe3a488c7381ff59853a7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83725
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf.ui/timing: Update XY viewers even if there is no data
Genevieve Bastien [Sat, 15 Oct 2016 14:45:05 +0000 (10:45 -0400)] 
tmf.ui/timing: Update XY viewers even if there is no data

The range of the window still changed and the view should follow that
range, even though there is no data to display

Change-Id: Iaa6d180de39f6ee5b109ce5826999c096f170469
Signed-off-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83355
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf.ui: Add a SWTbot condition for XY charts ready
Geneviève Bastien [Thu, 20 Oct 2016 14:03:37 +0000 (10:03 -0400)] 
tmf.ui: Add a SWTbot condition for XY charts ready

bug 500770

Change-Id: If70437ab08871962415a2b954307b58f24460331
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83595
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoreleng: Do not build the testing feature when some tests are skipped
Alexandre Montplaisir [Mon, 24 Oct 2016 23:14:37 +0000 (19:14 -0400)] 
releng: Do not build the testing feature when some tests are skipped

The testing feature, as well as the "alltests" plugin, cannot be built
when -Dskip-automated-ui-tests is on, as they require all SWTBot tests.
This means the the releng-site cannot be built either. All of them
should only be run when the tests are active.

Change-Id: I9d89444818c2373239dbcd04e8749ab6e033038c
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/83830
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
8 years agotiming.core: add testing for less used functions in the segment store
Matthew Khouzam [Sat, 1 Oct 2016 05:42:39 +0000 (01:42 -0400)] 
timing.core: add testing for less used functions in the segment store

Increases code coverage to ~80%. More importantly, makes the contract
automatically tested for new segment stores.

Change-Id: Id7c476a8df3254b01732a44e46227da4280274f2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82310
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf: Mark TmfTraceManager @NonNullByDefault
Alexandre Montplaisir [Thu, 1 Sep 2016 00:34:07 +0000 (20:34 -0400)] 
tmf: Mark TmfTraceManager @NonNullByDefault

Change-Id: Ib7581d4d2b8cb2807882afc62ba0071e7d123f82
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81721
Reviewed-by: Hudson CI
8 years agotiming: Add a generic table view for any segment provider
Geneviève Bastien [Thu, 22 Sep 2016 01:04:53 +0000 (21:04 -0400)] 
timing: Add a generic table view for any segment provider

It uses the analysis ID as the secondary ID of the view, it is thus not
necessary anymore to implement a concrete view for each segment store
analysis.

Change-Id: I9a596ac8217a1ba9233a345ec917d1488f170737
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78803
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotiming.ui: Remove dependency on trace with FlameGraphContentProvider
Matthew Khouzam [Wed, 19 Oct 2016 13:42:05 +0000 (09:42 -0400)] 
timing.ui: Remove dependency on trace with FlameGraphContentProvider

This decouples the flamegraph from the notion of traces.
Also removes dependencies on trace with FlameGraphView and adds
synchronization to refresh so tests will not query in the middle
of a draw.

Change-Id: I58f072cba473a74641b8ca8c364c85bfc0ef5cee
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83598
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agolinux.swtbot: Add more tests to SystemCallLatencyTableAnalysisTest
Matthew Khouzam [Mon, 24 Oct 2016 19:04:01 +0000 (15:04 -0400)] 
linux.swtbot: Add more tests to SystemCallLatencyTableAnalysisTest

All the entries in the TSV to test.

Change-Id: I69e1e11b48ac34b5bc9fc170ac127ef8343d4d08
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83816
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agoreleng: Provide a build property to skip automated UI tests
Alexandre Montplaisir [Sat, 8 Oct 2016 00:02:47 +0000 (20:02 -0400)] 
releng: Provide a build property to skip automated UI tests

Allow passing a `-Dskip-automated-ui-tests` option to skip running
the automated UI tests (like SWTBot and RCPTT modules) during
the Maven build.

Some setups may want to run these longer tests only in certain
conditions, or at a different frequency than the "normal" unit
tests.

Change-Id: Ifb1d6307d8bf4cddaba4e8835ea5d5e7595bbf80
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/83403
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoanalysis.ui: add Export to TSV action test
Matthew Khouzam [Wed, 5 Oct 2016 17:51:38 +0000 (13:51 -0400)] 
analysis.ui: add Export to TSV action test

Change-Id: I4852f270b5af4d1e957285690f271f3f94ad9d5e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82552
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf: make latches synchronized in abstract analysis module [bug 485793]
Matthew Khouzam [Mon, 24 Oct 2016 13:47:55 +0000 (09:47 -0400)] 
tmf: make latches synchronized in abstract analysis module [bug 485793]

Fixes a build instability caused by schedule (by design) spawning a job
that runs asynchronously. This makes cancellation racy since it can occur
before said job starts.

Change-Id: I93617efb80f4eb196ef0aba5cbe72e67917c876c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83786
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agosegstore: introduce sorted iterators
Loïc Prieur-Drevon [Tue, 27 Sep 2016 16:25:40 +0000 (12:25 -0400)] 
segstore: introduce sorted iterators

add a sorted iterator to the segment store interface.
this will be useful for external memory segment stores
for which the intersecting segments cannot be held and sorted
in main memory, and if external memory stores have optimized
sorted iteration.

Change-Id: I02076daf1721cdf8bdd66f5e892f5c5280e46a3b
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/82015
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
8 years agotmf: Automatically sync experiments set up with the same hosts
Alexandre Montplaisir [Tue, 4 Oct 2016 23:56:44 +0000 (19:56 -0400)] 
tmf: Automatically sync experiments set up with the same hosts

Automatically correct the clock offset of traces inside an experiment
who define a custom property "clock_offset", by calculating
the average of those offsets for all concerned traces.

This is useful for LTTng traces coming from different domains.

This behaviour is similar to how Babeltrace handles traces with
clocks with different offsets.

Bug: 484620

Change-Id: Ic30837fd6e9fc8b9a7592a1722f0240145c77d62
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/65330
Reviewed-by: Hudson CI
8 years agodoc: Add documentation for the local statistics
Jean-Christian Kouame [Mon, 24 Oct 2016 15:49:02 +0000 (11:49 -0400)] 
doc: Add documentation for the local statistics

Change-Id: Ifac7e24e2dbaaf911aaa1258f60214f9826a691c
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83795
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
8 years agotmf.ui: bug 505695 fix time graph views with GTK
Geneviève Bastien [Tue, 18 Oct 2016 20:56:02 +0000 (16:56 -0400)] 
tmf.ui: bug 505695 fix time graph views with GTK

Change-Id: Ib7cab31753d19e0a1d5766235dcdf88750f69a96
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83473
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agosegStore: Run benchmarks as a parameterized test
Geneviève Bastien [Thu, 20 Oct 2016 15:53:36 +0000 (11:53 -0400)] 
segStore: Run benchmarks as a parameterized test

It is easier to benchmark only one type of segment store and add new segment
stores

Change-Id: I187c5396a143a3ed6321cfb55e7f13bf73670e09
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83609
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf.ui: Introduce TmfFileDialogFactory
Matthew Khouzam [Mon, 3 Oct 2016 20:20:46 +0000 (16:20 -0400)] 
tmf.ui: Introduce TmfFileDialogFactory

This factory can be used to stub out native FileDialogs in TraceCompass.
This is very useful when it comes to writing SWTBot tests.

Change-Id: I2fbcaa20818b806d6367031aa85f44883d0bc08b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82398
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotiming.core: Add local statistics to the latency statistics
Jean-Christian Kouame [Tue, 6 Sep 2016 17:21:04 +0000 (13:21 -0400)] 
timing.core: Add local statistics to the latency statistics

Add the local statistics in the statistics view and update the general
item tree of the view. The SystemCallLatencyStatisticsTableAnalysisTest
is updated in consequence.

Change-Id: I5209f9c6430ee4658e3cf55ef50f4769b8e28772
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80952
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agodoc: Update event matching developer documentation
Geneviève Bastien [Tue, 18 Oct 2016 13:52:22 +0000 (09:52 -0400)] 
doc: Update event matching developer documentation

It has been outdated for a while now.

Change-Id: I5f5de85e8048a81457fae95ed5198f04b65ddf87
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83439
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agodoc: Modify 'Import mapping file' icon and title for callstack view
Geneviève Bastien [Tue, 20 Sep 2016 01:38:56 +0000 (21:38 -0400)] 
doc: Modify 'Import mapping file' icon and title for callstack view

It also adds a link to source lookup for LTTng-UST traces taken with LTTng 2.8+
(because it does not always work automatically when not in the same computer as
the one the trace was taken on)

Change-Id: If4f191d3e9fa650f852b1a2bed6857cd6e716a74
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/81404
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agosegstore: remove redundancies in deprecated class
Matthew Khouzam [Sat, 15 Oct 2016 19:59:12 +0000 (15:59 -0400)] 
segstore: remove redundancies in deprecated class

Make treemapstore extend the internal treemap store. It removes
a lot of duplication.

Change-Id: I89ccbbe506a3b93201342c16da6aef465034389d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83304
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoss: fix common node header size and check free space
Loïc Prieur-Drevon [Tue, 18 Oct 2016 16:14:30 +0000 (12:14 -0400)] 
ss: fix common node header size and check free space

COMMON_HEADER_SIZE had not been corrected after modifying strings
sections.
Check that node free space is consistent with what is written to
disk.

Change-Id: I9186f8b2e32159d9f2c771358c337aaf0ebb38c3
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/83456
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agotiming.ui: make Scatter chart not update the UI in update data
Matthew Khouzam [Fri, 14 Oct 2016 16:46:52 +0000 (12:46 -0400)] 
timing.ui: make Scatter chart not update the UI in update data

Change-Id: Idaca90c31a1e3fdd32d4922816760c3eaa074e64
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83252
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf.ui: make common line charts display the window range, not their model range
Matthew Khouzam [Fri, 14 Oct 2016 16:45:55 +0000 (12:45 -0400)] 
tmf.ui: make common line charts display the window range, not their model range

Change-Id: Ie6cea17dea1490af724adec1d0743d01cad884f6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83251
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotiming: avoid a division by zero with scatter viewer
Genevieve Bastien [Sat, 15 Oct 2016 13:48:55 +0000 (09:48 -0400)] 
timing: avoid a division by zero with scatter viewer

Change-Id: Iee5bce80f07ae0231801b3be17d5cbad2d665e48
Signed-off-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/83354
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoss: History trees can define their own node types
Geneviève Bastien [Tue, 2 Aug 2016 13:43:08 +0000 (09:43 -0400)] 
ss: History trees can define their own node types

This patch moves the HistoryTreeClassic to its own package and allows each
history tree class to define their own HTNode types.

Change-Id: I800469c12fbcaf21156ed340c94b611b59b70ea1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/78354
Reviewed-by: Hudson CI
8 years agoreleng: Add SWTBot integration tests
Patrick Tasse [Tue, 11 Oct 2016 15:07:28 +0000 (11:07 -0400)] 
releng: Add SWTBot integration tests

Add tests for import wizard opened from workbench menu
Add tests for deleting selected traces and folders
Add tests for clearing Traces folder
Refactor ImportConfirmation supplier
Fix focus on folder/archive combo in util methods
Fix delete project util to succeed if project does not exist

Change-Id: Ief49ebce1a8198517bfbc2faf90e338afc9dc759
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/82955
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoreleng: Change the "-Pbuild-rcp" directive to a "-Dskip-rcp" property
Alexandre Montplaisir [Mon, 17 Oct 2016 21:14:35 +0000 (17:14 -0400)] 
releng: Change the "-Pbuild-rcp" directive to a "-Dskip-rcp" property

<activeByDefault>true</activeByDefault> is very bad and
should not be used. Among other things, it effectively prevents
from defining more than one profile in a given pom.xml.

Change-Id: Id30897025a7df37d14014ef605122416e0b33dc7
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/83402
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Add utility method to delete supplementary files of a trace
Alexandre Montplaisir [Fri, 7 Oct 2016 21:04:51 +0000 (17:04 -0400)] 
tmf: Add utility method to delete supplementary files of a trace

Add the new (and move an existing) test into a separate file, because
the existing test suite uses the same static traces for all the tests.
If we are to delete a trace's supplementary files, the trace should
be regenerated for other tests!

Change-Id: I0727422dd190d9012e6b8ccce0d7d175711e149b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/82778
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf: Fix intermittent fail in ProjectModelOutputTest.testListOutputs
Marc-Andre Laperle [Wed, 12 Oct 2016 17:45:33 +0000 (13:45 -0400)] 
tmf: Fix intermittent fail in ProjectModelOutputTest.testListOutputs

This adds a waitUntil/condition that waits until there is the correct
number of children under the analysis.

To reproduce the issue, in TmfAnalysisElement.refreshChildren, add a
Thread.sleep(1000); at the beginning.

Bug: 491823
Change-Id: Iaae81093d90f26403cc58b7286c8691db7db3644
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83052
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolttng.control: remove useless data assignment
Matthew Khouzam [Sat, 15 Oct 2016 15:43:08 +0000 (11:43 -0400)] 
lttng.control: remove useless data assignment

In an elvis switch ?: a value was assigned in one of the branches.
This fixes the issue.

Change-Id: I4fedee2efdfbe184f8857d37004dc3192235f9f0
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83301
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoMake sure shell is not disposed in closeSecondaryShells
Marc-Andre Laperle [Mon, 17 Oct 2016 00:31:16 +0000 (20:31 -0400)] 
Make sure shell is not disposed in closeSecondaryShells

While running ProjectExplorerTracesFolderTest, it was noticed that
closeSecondaryShells could try to close a disposed shell. This
change fixes this and also makes the test call closeSecondaryShells
after every test.

Change-Id: I5172e676e1ac7d619f11e904c0ca0141102f9c71
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83332
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf: Bug: 499359: Fix deadlock in table when closing trace selection
Bernd Hufmann [Fri, 14 Oct 2016 00:36:46 +0000 (20:36 -0400)] 
tmf: Bug: 499359: Fix deadlock in table when closing trace selection

When closing a trace while a selection range updated signal is handled
in the TmfEventsTable a deadlock can occur because 2 threads are
taking the trace lock and request lock in different order.

The solution is to not use an event request for updating the selection
range in the table.

Change-Id: I67218cd564d97a6fc91226ad56639b2c2c971cea
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83172
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf: Use Apache Common Compress for importing from archive
Marc-Andre Laperle [Wed, 5 Oct 2016 22:22:43 +0000 (18:22 -0400)] 
tmf: Use Apache Common Compress for importing from archive

By using Apache Common Compress instead of the Eclipse classes,
it will allow us to support more formats and have move stability.
We will be able to handle tars with PaxHeaders, XZ and BZip
compression for example.

Change-Id: I2693da15eb38a57b477734f1a0931c30585f2192
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/82567
Reviewed-by: Hudson CI
8 years agoreleng: Add SWTBot integration tests for import wizard
Patrick Tasse [Thu, 6 Oct 2016 20:53:42 +0000 (16:53 -0400)] 
releng: Add SWTBot integration tests for import wizard

Add tests for import from folder preserving folder structure.
Add tests for import from zip archive.
Add tests for import from tar.gz archive.
Programmatically create zip/tar.gz archives of test directory structure.
Add util method to select import items in folder tree and file table.
Add util method to recursively find trace project item.
Add org.apache.commons.compress to target definitions.
Fix project folder element matching regex.
Fix condition failure messages binding string.

Change-Id: Ib97d3bfc14f37edc882f0c6dc9ffafcc02753252
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/82677
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agolttng: Fix ControlViewTest
Patrick Tasse [Tue, 11 Oct 2016 20:16:01 +0000 (16:16 -0400)] 
lttng: Fix ControlViewTest

The regex replacement of the user home in command output are quoted to
avoid stripping backslashes in a Windows path.

The list provider regex patterns are updated to include the new command
options '-j' '-l' and '-p'.

The target node state is only set to CONNECTED after the node
configuration jobs are completed.

The SWTBot test waits for the node configuration jobs to be completed
before continuing with the test scenario.

The UI test is changed to use a wait condition instead of a loop with
delay when waiting for the target node state to be connected.

Change-Id: Ie05f58181119cf46d8cdacb8313856f6b3c4da30
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/82972
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoUpdate to test-traces 1.6.0
Alexandre Montplaisir [Fri, 7 Oct 2016 20:33:05 +0000 (16:33 -0400)] 
Update to test-traces 1.6.0

This contains a new kernel/ust trace set with different clock
offsets.

Change-Id: Ib1fea591b6705ed5253817339cff1fb8ac1a1ed6
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/82777
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf: Add equals/hashCode to TmfConstantTransform
Alexandre Montplaisir [Fri, 7 Oct 2016 22:02:39 +0000 (18:02 -0400)] 
tmf: Add equals/hashCode to TmfConstantTransform

Without that, two equivalent transforms would be considered
different, because the object is serialized every time, causing
it to become a new instance every time a trace is re-opened.

Change-Id: I4f1dcbf503032329cdce7ac5c0ef351545e392e8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/82779
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoreleng: Add script to generate list of plugins for API baseline
Marc-Andre Laperle [Wed, 21 Sep 2016 20:04:21 +0000 (16:04 -0400)] 
releng: Add script to generate list of plugins for API baseline

Add a script to make it easier to list plugins that need to go
in the API baseline. This was meant to be in the commit that adds
the new 2.1.0 API baseline but it was forgotten.

Change-Id: Ic6daa6086dcbe3a7ad12627cdff43038765263d6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81879
Reviewed-by: Hudson CI
8 years agotmf: Add waitUntil / condition to tmf.ui.tests
Marc-Andre Laperle [Wed, 12 Oct 2016 17:00:38 +0000 (13:00 -0400)] 
tmf: Add waitUntil / condition to tmf.ui.tests

This allows us to wait until arbitrary conditions are met, much like
SWTBot but without depending on SWTBot. The waitForJobs utility method
was converted to use this as an example.

Change-Id: Iafa4bb24a1de096dcde25156a4882b8750d7f466
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/83051
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agotmf.ui: Add JUL statements to CommonXLineChart
Geneviève Bastien [Tue, 19 Jul 2016 19:37:54 +0000 (15:37 -0400)] 
tmf.ui: Add JUL statements to CommonXLineChart

Change-Id: I0ad7a2b0304ce19f7e8719d2a0f3998216bb066b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/78275
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoUse snapshot of RCPTT 2.2.0
Marc-Andre Laperle [Mon, 10 Oct 2016 19:11:21 +0000 (15:11 -0400)] 
Use snapshot of RCPTT 2.2.0

This allows us to run tests with Eclipse 4.7 (Staging target)

Change-Id: Iae126c65f0856872906add73aa2089c5761abe95
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82868
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agotmf.ui: Make TmfTimeViewer handlers parameters nullable
Matthew Khouzam [Fri, 23 Sep 2016 18:57:21 +0000 (14:57 -0400)] 
tmf.ui: Make TmfTimeViewer handlers parameters nullable

The signal could be null if used otherwise. This handles those
cases gracefully.

Change-Id: I97abf9edafa37412d8eb990c58e7413551b37616
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81823
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: Log the exception when error occurs while opening a trace
Marc-Andre Laperle [Fri, 26 Aug 2016 03:19:49 +0000 (23:19 -0400)] 
tmf: Log the exception when error occurs while opening a trace

If an exception occurs when opening a trace, the exception message
is displayed but the stack is nowhere to be found. By logging the
exception, the stack trace will be available in the log.

Change-Id: I8085cb46a1657747cc2f2be5736e4b17e0b7040f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/79792
Reviewed-by: Hudson CI
8 years agotmf.ui: Sequence diagram, fix some robustness issues
Matthew Khouzam [Fri, 7 Oct 2016 13:29:59 +0000 (09:29 -0400)] 
tmf.ui: Sequence diagram, fix some robustness issues

* Fix volatile in/decrements
* Use getFieldValue() to make comparisons easier in getSDEvent

Change-Id: I28c4063377cfe8e8966e8f8d187fa32503f6702f
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82736
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agoMake waitForJobs available to non-SWTBot test plugins
Marc-Andre Laperle [Mon, 19 Sep 2016 05:27:43 +0000 (01:27 -0400)] 
Make waitForJobs available to non-SWTBot test plugins

The waitForJobs pattern is used in a few other places that SWTBot but
they do not have timeouts and the ability to print the stack traces
when it times out. By moving the code to the common plugin, all tests
can use it and benefit from it.

Change-Id: I56a19e5da30216d53a40f44dc3302b427985b1ae
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81304
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agosegStore: guard size() in segment stores
Matthew Khouzam [Thu, 6 Oct 2016 21:04:09 +0000 (17:04 -0400)] 
segStore: guard size() in segment stores

This prevents a race condition invalidating the size data.

Change-Id: I0b5e5c9573dc2789f92d5b437fe23c3df23b9f43
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82324
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agoAdd script to convert html download stats to CSV
Marc-Andre Laperle [Mon, 3 Oct 2016 01:07:55 +0000 (21:07 -0400)] 
Add script to convert html download stats to CSV

Useful to see stats of dowloaded RCPs.
Converts results from this page to CSV:
https://dev.eclipse.org/committers/committertools/stats.php

Change-Id: I15c95c4f7dad5486ac0f20182aa400d1ef4d860c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82341
Reviewed-by: Hudson CI
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
8 years agoFix typo in SWTBotUtils
Marc-Andre Laperle [Thu, 6 Oct 2016 19:45:04 +0000 (15:45 -0400)] 
Fix typo in SWTBotUtils

Change-Id: I371e44a712b99db60668ada78c9248199764e796
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82668
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agoss: historyTreeFile can be null
Jonathan Rajotte [Thu, 22 Sep 2016 16:16:51 +0000 (12:16 -0400)] 
ss: historyTreeFile can be null

The HistoryTreeBackend constructor signature does not accept
null values as second argument.

Change-Id: I8772d494966d76f7827d9cbfd37a48d28958dc4c
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81923
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agoAdd utility method to close secondary shells after tests
Marc-Andre Laperle [Mon, 19 Sep 2016 04:47:02 +0000 (00:47 -0400)] 
Add utility method to close secondary shells after tests

When running SWTBot tests, sometimes when one test fails and leave a
shell lingering, it makes all the subsequent tests fail. This change
introduces a utility method to close all the secondary shells
(non-main shell) so that subsequent tests have a better chance of
completing successfully. This will help getting a more representative
account of test failures when things go wrong.

Change-Id: I4fe48c13de8588e9ddb21ae64d2c3b6a9c04b4ae
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81303
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
8 years agoreleng: Change staging target to use platform integration builds
Marc-Andre Laperle [Wed, 5 Oct 2016 22:25:43 +0000 (18:25 -0400)] 
releng: Change staging target to use platform integration builds

- We need a more recent build of the platfom to fix a dependency
problem (Bug 502114)
- We can now use Apache Derby from Orbit instead of the build server
(Bug 494234)
- There is a new spies plugin that does not depend on JDT which we
can now use (bug 481467).
This plugin contains Sleak (Native handle leak detection) and SWT Spy.

Change-Id: I2bbdd4b287f448150758f6ffca877a8177c8a43c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82568
Reviewed-by: Hudson CI
Reviewed-by: Jonathan Rajotte Julien <jonathan.rajotte-julien@efficios.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agosegment store: introduce a Segment Store Factory and centralize segment stores
Loïc Prieur-Drevon [Thu, 15 Sep 2016 15:43:23 +0000 (11:43 -0400)] 
segment store: introduce a Segment Store Factory and centralize segment stores

Usage: SegmentStoreFactory.create(<optional> data[], flags...);
Flags at this moment are "fast, stable and distinct"
More flags will come, examples can be "hybrid" or "aggregate"

Change-Id: I5eccb4393b52c8f1dc9d423eaa3bb9087425b5e6
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81504
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
8 years agotmf: Add ellipses to Synchronize Traces action
Alexandre Montplaisir [Tue, 4 Oct 2016 21:10:05 +0000 (17:10 -0400)] 
tmf: Add ellipses to Synchronize Traces action

Since it opens a new dialog it should have ellispes at the end.

Change-Id: Ia7803224a6c6ed149df344ebcaef1563206882bd
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/82482
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoss: add a wrapper for the state system delete files
Matthew Khouzam [Sun, 18 Sep 2016 03:54:44 +0000 (23:54 -0400)] 
ss: add a wrapper for the state system delete files

This removes the need for the backend to be stored in the analysis

Change-Id: I32f4b1ceb99e4babf5ffe7e25731318ad8faa976
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81298
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoreleng: Update sonar-maven-plugin to latest version
Marc-Andre Laperle [Mon, 3 Oct 2016 03:05:38 +0000 (23:05 -0400)] 
releng: Update sonar-maven-plugin to latest version

Release notes:
https://jira.sonarsource.com/secure/ReleaseNote.jspa?projectId=10977&version=12906
https://jira.sonarsource.com/secure/ReleaseNote.jspa?projectId=10977&version=13397
https://jira.sonarsource.com/secure/ReleaseNote.jspa?projectId=10977&version=13405

Change-Id: I2951bd96616aef6a541a689f536974299c0d2675
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82344
Reviewed-by: Hudson CI
8 years agoxml.ui: add LineChart icons
Matthew Khouzam [Thu, 22 Sep 2016 20:21:20 +0000 (16:21 -0400)] 
xml.ui: add LineChart icons

Add unused reference images so we can change the overlay

Change-Id: I8d5a61bbc1f8aff772ab1e6552cc38d7166da7de
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81739
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
8 years agoxml.ui: add icon for TimeGraphView
Matthew Khouzam [Thu, 22 Sep 2016 20:12:42 +0000 (16:12 -0400)] 
xml.ui: add icon for TimeGraphView

This is a gantt chart icon. Reference icons are added to allow other
overlays at a later date.

Change-Id: Iaacc5f6c7b6910308ecb34efc75452e0c0ff3c69
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81738
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotiming.ui: make export to tsv internal
Matthew Khouzam [Mon, 3 Oct 2016 20:15:52 +0000 (16:15 -0400)] 
timing.ui: make export to tsv internal

Change-Id: Ie8203b609a0ccb68772486631831c8c0ef0df363
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82397
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agoFix warning non externalized string
Jonathan Rajotte [Thu, 22 Sep 2016 16:14:31 +0000 (12:14 -0400)] 
Fix warning non externalized string

Change-Id: Ie0423eab62a68ab56926fadcde88f9b1e87291ca
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81922
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoreleng: Fix Mars build by adding missing gson dependency
Marc-Andre Laperle [Mon, 3 Oct 2016 02:37:06 +0000 (22:37 -0400)] 
releng: Fix Mars build by adding missing gson dependency

Change-Id: I8562acd327e0928af856bc8439a8b339e505a043
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82342
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agolami: synchronize getter for currentReport
Jonathan Rajotte [Wed, 21 Sep 2016 18:55:36 +0000 (14:55 -0400)] 
lami: synchronize getter for currentReport

Fixes CID 112029

Change-Id: If431b049890d6814d318b56d62ce367561d0ea34
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81624
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agolami: getSymbolColors can return null
Jonathan Rajotte [Wed, 21 Sep 2016 19:06:52 +0000 (15:06 -0400)] 
lami: getSymbolColors can return null

Fixes CID 112047

Change-Id: Ib48dc0fdf1b50c0904ba22683de6cf5f7fe331ea
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81625
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agotmf: annotate TmfContext#location as nullable
Matthew Khouzam [Sun, 2 Oct 2016 03:13:21 +0000 (23:13 -0400)] 
tmf: annotate TmfContext#location as nullable

This fixes a potential race condition if the context is changed
after a null check but before a dereference. In the current
implementation, it is extremely unlikely to happen, but this
may save later investigation time.

Change-Id: I9083d16fd8e3728fe829583f4de78384109a91e6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82325
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
8 years agotiming.ui: add Export to TSV to tables and statistics
Matthew Khouzam [Wed, 28 Sep 2016 17:55:51 +0000 (13:55 -0400)] 
timing.ui: add Export to TSV to tables and statistics

This allows exporting to tsv files.

Testing is done with reflection to avoid native dialog issues.

Some issues are present:
* In Linux, an invisible column is added at the end,
while this seems ok, it makes the output inconsistent
between Windows and Linux.
* SWTBot cannot test native windows, therefore, the user actual
actions are untested. All possible logic has been moved
elsewhere to accomodate.
* Tree and Table have no common parents, this will incur code
duplication due to their similarities.
* In Linux, tooltips are not well handled in menu items.

Change-Id: I506d0e7e50bd5ce8ecbd44675a0c404ab2dda431
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82111
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoFix importing an archive containing colons (:) in the names on Windows
Marc-Andre Laperle [Mon, 19 Sep 2016 02:57:19 +0000 (22:57 -0400)] 
Fix importing an archive containing colons (:) in the names on Windows

Bug: 501664
Change-Id: I676f2533c140b52369328e1ef8e922f730b5e6e2
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81302
Reviewed-by: Hudson CI
8 years agotiming: Fix duration of flamegraph view
Geneviève Bastien [Mon, 19 Sep 2016 01:25:05 +0000 (21:25 -0400)] 
timing: Fix duration of flamegraph view

Instead of having a duration of the full length of the trace, it has the
duration of the longest element.

Change-Id: Id56b0d23b8a7619672eb3537dd5ca5d4392708db
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/81301
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotiming.ui: Make doubleclicking on a flame graph event zoom on it
Matthew Khouzam [Tue, 27 Sep 2016 15:46:01 +0000 (11:46 -0400)] 
timing.ui: Make doubleclicking on a flame graph event zoom on it

This aims to bring feature parity between trace compass flame graphs
and the original flame graphs designed by Brendan Gregg.

Change-Id: I6194b1c95b33e258cfcb40991949bbd19a25ce73
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82012
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolinux.core: add Tux Icon to linux core analysis
Matthew Khouzam [Thu, 22 Sep 2016 02:37:31 +0000 (22:37 -0400)] 
linux.core: add Tux Icon to linux core analysis

According to the site : http://isc.tamu.edu/~lewing/linux/

Here are the results of an idea acquired from discussions
on the linux-kernel mailing list, and an initial suggestion
by Alan Cox.

Feel free to do whatever you see fit with the images, you
are encouraged to integrate them into other designs that
fit your need. Comments suggestions are also welcome, so
please tell me what you think of these. I suggest that you
look at some of the other images available with integrated
text.

The backgrounds of these images are random colors (if your
viewer doesn't support transparent gifs). This is because
I want to be able to keep the outline clean (except when
blending into a scene or title bar). Each in-line image is
now also a link to the corresponding gif so that they are
more easily retrieved. The images I actually work from are
tifs which I'll make available if there is interest.

Neal Tucker was kind enough to provide a scalable vector
based postscript version of the black and white penguin.

Permission to use and/or modify this image is granted provided
you acknowledge me lewing@isc.tamu.edu and The GIMP if someone
asks.

This patch will still require a CQ, but it looks safe to push
to gerrit.

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=12011

Change-Id: Ia31cecaf6d2e870e37e8425dca475641c23d90cf
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81654
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoreleng: Update targets with new Neon.1 update sites
Marc-Andre Laperle [Thu, 29 Sep 2016 13:57:42 +0000 (09:57 -0400)] 
releng: Update targets with new Neon.1 update sites

Change-Id: Ia13d48fb7b0d76efd7582b073272557087dea89c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/82177
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agotmf: bug 494698 Add per-event fields to custom parsers
Geneviève Bastien [Tue, 31 May 2016 12:54:29 +0000 (08:54 -0400)] 
tmf: bug 494698 Add per-event fields to custom parsers

Change-Id: I8e2d302ea53319a42f2d84828db41726af321b05
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/76907
Reviewed-by: Hudson CI
8 years agoFix javadoc warning
Jonathan Rajotte [Thu, 22 Sep 2016 16:12:55 +0000 (12:12 -0400)] 
Fix javadoc warning

Change-Id: I94af2b7f6e7d6612b54e150fc17ce481be8e92e4
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81921
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agolami: set the min value when clamping to zero.
Jonathan Rajotte [Wed, 21 Sep 2016 18:44:34 +0000 (14:44 -0400)] 
lami: set the min value when clamping to zero.

Fixes CID 141171

Change-Id: I37827d6bcb6c7b66a65c23c77035728f27f34cad
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81623
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoreleng: Add missing source for tracecompass.common.core
Marc-Andre Laperle [Sat, 17 Sep 2016 19:43:38 +0000 (15:43 -0400)] 
releng: Add missing source for tracecompass.common.core

Change-Id: I1188fe2360e83d7a008dfa01f11596cdfee1218e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81287
Reviewed-by: Hudson CI
8 years agoRemove unneeded API filters
Alexandre Montplaisir [Sun, 25 Sep 2016 23:23:16 +0000 (19:23 -0400)] 
Remove unneeded API filters

Change-Id: I9d296b3e2ad74e468091b273b565136b0421ebab
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81878
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoreleng: Add 2.1.0 baseline and fix API errors
Marc-Andre Laperle [Wed, 21 Sep 2016 20:04:21 +0000 (16:04 -0400)] 
releng: Add 2.1.0 baseline and fix API errors

Change-Id: I794f2670e344bf98d3587abeaf97ea279d2a9b3f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81634
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
8 years agoChange a warning to an error in build.properties
Marc-Andre Laperle [Wed, 7 Sep 2016 20:54:21 +0000 (16:54 -0400)] 
Change a warning to an error in build.properties

A missing java source folder entry in those files result in build
failures if another plugin needs to use a class from this source
folder. So they should be reported as errors. We always want to put
all code in the jars anyway.

Also fix a missing one.

Change-Id: Ibe66733bf835163988a7de78f276e2eeb3ea462d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80632
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agolttng: Rename LttngUiResponseTest to benchmark (it's not a test)
Marc-Andre Laperle [Fri, 23 Sep 2016 20:44:13 +0000 (16:44 -0400)] 
lttng: Rename LttngUiResponseTest to benchmark (it's not a test)

Otherwise, it runs during tests and closes all the views.

Change-Id: Ifa3942e68a4cdd3aad03a7a23da6b83a88db831c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81837
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
8 years agotmf: Allow any object to use TmfSignalThrottler
Alexandre Montplaisir [Wed, 21 Sep 2016 22:19:32 +0000 (18:19 -0400)] 
tmf: Allow any object to use TmfSignalThrottler

Some classes override broadcast(), so we can continue
calling that for subclasses of ITmfComponent.

Change-Id: I2b270fe58349e6206d00c874b84304581c56dce0
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81723
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
8 years agoanalysis: let the soft irq raised state appear in the Resources view
Cédric Biancheri [Sun, 8 May 2016 05:08:14 +0000 (01:08 -0400)] 
analysis: let the soft irq raised state appear in the Resources view

When a soft irq was raised during an irq the view was swhowing nothing between
the end of the irq and the beginning of the soft irq for a cpu entry.

Change-Id: I22d5e3014efc531c7cf3ee9c48ac59af3a772a2e
Signed-off-by: Cédric Biancheri <cdc.biancheri@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72230
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotiming.core: speed up (Lazy)ArrayList queries with binary search
Loïc Prieur-Drevon [Tue, 20 Sep 2016 16:03:05 +0000 (12:03 -0400)] 
timing.core: speed up (Lazy)ArrayList queries with binary search

The getIntersectingElements queries on the (Lazy)ArrayList
SegmentStore would iterate through the entire store with a
stream().filter(), whereas the store is sorted by start time,
then by end time of the segments.

By using a binary search on the store, we can narrow down the
iteration to the relevant sublist thus speeding queries up to 50%
on querying from real analyses.

Change-Id: Idb798f42571d14130acd26c0d126cc7b6cdbf04c
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/81503
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agoxml: add icon for analyses
Matthew Khouzam [Wed, 21 Sep 2016 19:54:20 +0000 (15:54 -0400)] 
xml: add icon for analyses

Change-Id: Ibf173f4b3cd64542b200bc571a33d4000bae46d1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81630
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
8 years agolinux.core: add Memory Usage Icon
Matthew Khouzam [Thu, 22 Sep 2016 02:05:53 +0000 (22:05 -0400)] 
linux.core: add Memory Usage Icon

This is based on the trope that cpus are LQFP, memory is DIP.

Change-Id: Ia6204ab868f549fbf32a490b526cb856d4aa2c36
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81652
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agolinux.core: add IO Analysis icons
Matthew Khouzam [Thu, 22 Sep 2016 01:47:04 +0000 (21:47 -0400)] 
linux.core: add IO Analysis icons

Made fore High-DPI screens.
Inspired by Hitachi Deskstar 80 gb drives. But
every rotary hard drive looks like this.

Change-Id: I3b6f1a18d950590e3a2e3c39267da1ff81598bab
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81651
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agolinux.core: add CPU usage icons
Matthew Khouzam [Thu, 22 Sep 2016 01:34:33 +0000 (21:34 -0400)] 
linux.core: add CPU usage icons

Made with scaling in mind.
Inspired by resource monitor in many oses.

Change-Id: I5bb5f1b063ba0452fa476c06eeae6c6689b781b9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81650
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agograph.core: add Critical Path Icon
Matthew Khouzam [Thu, 22 Sep 2016 18:56:47 +0000 (14:56 -0400)] 
graph.core: add Critical Path Icon

Change-Id: I929b4e29d14cf2e6e3e97544561b8e0a2657bf9b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81727
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agolinux.core: add Context Switch icon
Matthew Khouzam [Thu, 22 Sep 2016 01:20:27 +0000 (21:20 -0400)] 
linux.core: add Context Switch icon

This one was done with high-dpi screens in mind.
Inspiration comes from a real-estate based board game.

Change-Id: I5d1d6f2175fa411c7882ee097f456dbb36d26efa
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81649
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agotmf.core: add statistics icon
Matthew Khouzam [Wed, 21 Sep 2016 19:35:18 +0000 (15:35 -0400)] 
tmf.core: add statistics icon

Change-Id: Ia7dbbb70567b916c0e32a438979b6beab2132455
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81629
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agoust: add icon for debug info analysis
Matthew Khouzam [Wed, 21 Sep 2016 19:59:29 +0000 (15:59 -0400)] 
ust: add icon for debug info analysis

Change-Id: Idf4a64f5650b4191cca65f3b1e55a6e8bb7fca9b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81632
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
8 years agolttng: Document Attribute Tree for UstMemoryStateProvider
Loïc Prieur-Drevon [Thu, 15 Sep 2016 20:25:09 +0000 (16:25 -0400)] 
lttng: Document Attribute Tree for UstMemoryStateProvider

Change-Id: I35594e499ddcdd7d2e4f4969ce83c76320a85600
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/81199
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
8 years agoos.linux: Document Attribute Tree for StateProviders
Loïc Prieur-Drevon [Thu, 15 Sep 2016 20:25:42 +0000 (16:25 -0400)] 
os.linux: Document Attribute Tree for StateProviders

Add documentation to headers for
KernelContextSwitch
KernelCpuUsage
KernelMemory
ActiveTid
InputOutput
Kernel

Change-Id: If95fc67f0a6b765267b4247328e3618b6c000315
Signed-off-by: Loïc Prieur-Drevon <loic.prieurdrevon@gmail.com>
Reviewed-on: https://git.eclipse.org/r/81200
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
8 years agotmf: Replace link icon with png and add 2x version
Marc-Andre Laperle [Thu, 22 Sep 2016 17:25:15 +0000 (13:25 -0400)] 
tmf: Replace link icon with png and add 2x version

Change-Id: I1115aa8da07443ff9e51caa43f6f3c1604059360
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81719
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agotmf.xml: Remove useless parameters in TmfXmlPatternSegmentBuilder
Jean-Christian Kouame [Tue, 12 Jul 2016 19:30:09 +0000 (15:30 -0400)] 
tmf.xml: Remove useless parameters in TmfXmlPatternSegmentBuilder

Change-Id: I1814dfa8fb21b10ee0a6350dcf38ae6f7bb3d519
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/77168
Reviewed-by: Hudson CI
Reviewed-by: Bruno Roy <brusi_roy@hotmail.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
8 years agolinux.core: Update Syscall analysis to use time#toNanos and event#getName
Matthew Khouzam [Mon, 12 Sep 2016 21:27:01 +0000 (17:27 -0400)] 
linux.core: Update Syscall analysis to use time#toNanos and event#getName

Using ITmfTimestamp#toNanos ensure that system calls will be in the same
units if mixed OS traces are used. Using event#getName is faster and simpler
to read than event#getType()#getName.

Change-Id: I70819a28dfdaa257fa6c484c5073f77610605427
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/80967
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
8 years agotmf: Update next input in custom parser wizard when removing input
Patrick Tasse [Tue, 6 Sep 2016 19:21:44 +0000 (15:21 -0400)] 
tmf: Update next input in custom parser wizard when removing input

When removing an input that has a previous input child to the same
parent input, the previous input's next input reference should be
updated to the next input of the removed input. Otherwise the removed
input may remain as a ghost next input and interfere with the previous
input's child inputs. This is only a problem when testing the parsing of
sample trace text from within the custom parser wizard, since the next
input relation is not stored in the XML definition, it is always rebuilt
from the parent-child relations when loading the definition from file
into memory.

Change-Id: I3531d705a46f13ac164325cd875e53d59b95ef1c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/80516
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agolami: possible ressource leak on IntStream
Jonathan Rajotte [Wed, 21 Sep 2016 21:07:34 +0000 (17:07 -0400)] 
lami: possible ressource leak on IntStream

Even if this is a fluke from Coverity using a for loop is simpler.

CID 141163 & 141165

Change-Id: I6087b22cd9ad9beb47f5546d54fd5167bdd66390
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/81638
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
8 years agoanalysis: Add missing icon for Critical Path view
Marc-Andre Laperle [Wed, 21 Sep 2016 14:23:10 +0000 (10:23 -0400)] 
analysis: Add missing icon for Critical Path view

Change-Id: Ie9f845454c2b735d16d4baefc870c4078a29babe
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/81597
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
This page took 0.046249 seconds and 5 git commands to generate.