drtracing.org Git - deliverable/tracecompass.git/log

Remove overloads of NonNullUtils#checkNotNull()

New errors have cropped up with the latest integration build. It seems
JDT is now stricter with regards to annotated generic types vs.
un-annotated ones (where before un-annotated was similar to @Nullable,
now we don't we away with it that easily).

Variants of checkNotNull() method that used to help the compiler now
seem to do more harm than good. Just deferring to the basic "T" one
fixes the new errors. Perhaps this should have been the ideal approach
all along?

Change-Id: If998d5554b5d85ac785d21365dfeeae5d6a48bb8
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60650
Reviewed-by: Hudson CI

tmf: Replace usage of SubProgressMonitor with SubMonitor

SubProgressMonitor is now deprecated, replace its usage with the
recommended SubMonitor instead. This fixes the staging target.

Change-Id: I9ae99c1e8da2da5a98c90ea2f45fbd0207d3b734
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60823
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix for time-alignment bug

SashForm.setWeights() fails and throws runtime exceptions if
the sum of the passed values is 0 or if one of the values is
negative.

In some cases that include switching to a not-yet-initialized
Resource View, this situation could happen. Simply ignore sash
resize for invalid arguments. No need to time-sync an uninitialized
view anyway.

Change-Id: I3b7724795529ee91ae903ba3551491b5e0a7a645
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59881
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

ss: Implement ISegment#getLength() as a default method

Change-Id: I0ab887f8bcecdebc1e66773ef50b63af3125090b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59880
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

common: Add a checkNotNullContents() for arrays

For Collections we can easily go through a Stream and back
to call checkNotNullContents(Stream<T>), for arrays it's slightly
more complicated, so we might as well define a new method
specifically for arrays.

Also add some "tests" (not actual runnable tests, but just snippets
of code that should compile) to make sure the annotations are working
correctly.

Change-Id: I2d18ba912076ea98cfca3628e7c8d6077209f74b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59427
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

common: Introduce a generic Stream flattener utility

This can be used to flatten data structures like trees, without
having to mess with recursive functions or visitor objects.

Change-Id: I3a30484a26f9112c624705c03e49529f5abac26e
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/59293
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ust: fix NPE in memory usage view caused by misplaced closing bracket

Change-Id: I64f1f1f9a087b1da2e44db3f0615b57a771b70ce
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61447
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Remove of unused import

This commit removes the import of TmfXmlReadAndWriteModelFactory in
TmfXmlReadOnlyModelFactory.

Change-Id: Id4dafff6df5dc4c7fdc74dfcf84dc74de5ddd8f7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60752
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Use of Activator.logError() instead of System.out.println()

Change-Id: Ibe562bc26d1fbd150ff40134a1b900e3750dd7ed
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61080
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Remove inefficient new String(String) constructor

Change-Id: I1b55c12a6345f6198beafd750ec666611b6fd54b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61084
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng : Remove inefficient new String(String) constructor

Change-Id: I924a7b75f1fa22b1b45c3bb93b5bafa5b177f7b0
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61088
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: log error before displaying message

Otherwise the error is logged only after the dialog is closed.
This is not a problem for normal use but for automated tests it can be
tricky since we can stop the test before closing the dialog and still look for
errors.

Change-Id: I1579fa166af2fbe5cd55fdb82b92d976171deaf6
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/61066
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix missing dispose of traces in TmfTraceTest and TmfExperimentTest

Change-Id: Iaae97ccb2b953327c35a651dc86b654a87a5de7e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61351
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Bug 477508: Fix wrong event count and ranks in TmfXmlTraceStub

The stub implementation of getNext() was increasing the context rank
twice per event. This would cause a wrong event count in the trace.

The processing of the 'set_aspects' dummy event was also causing the
context rank to be incremented twice. The XML Schema Definition is
changed to extract 'set_aspects' into its own element. The trace stub
now first parses the trace with a custom XML trace definition that only
processes the single 'set_aspects' event, then reinitializes the trace
with a custom XML trace definition that processes 'event' events.

Change-Id: Id1cf2251e364f892ab37511f0a5d99f2bcc2b5c6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61205
Reviewed-by: Hudson CI

tmf: Fix unprocessed custom event content

If the custom event content is read before the event timestamp, it could
be undefined as the event data hasn't be processed yet. This can happen
in test code.

Change-Id: Idab415eb8015f1a7035bee11582d0baad89cad5b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/61204
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Try to make the shell fully visible in SWTBot at start

In certain environments, the workbench shell can be positioned at random
locations. Depending on the size of the display, it is possible that the
shell is not fully visible. This patch adds logic to the start of SWTBot
tests so that if the top shell is not fully visible, it will try to move
it in within the display bounds. If the shell cannot fit the display, it
will be positioned at the top-left corner of the display.

To be able to apply this to all test, a new utility method was
introduced, SWTBotUtils.initialize. More common code that is applicable
to all SWTBot tests could be moved there in the future.

This fix is important to some tests that can depend on whether of not
some controls get painted. For example, a drag listener is only added on
a sash when it gets first painted. If it is never painted,
TmfAlignTimeAxisTest fails when trying to drag this sash to verify the
proper behavior of time alignment.

Change-Id: Ic67739e204fcb0a4b567914e8b6078c286d56bd3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61094
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

lttng: Add a Binary Callsite aspect to the debug-info analysis

If the binary is not available at analysis time, we can still display
the binary file and offset information, which comes from the trace.

This information is also re-used by the source callsite.

Change-Id: I40993abedf7057fe6b27cb5c9e787f23e2331f13
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/60843
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Exclude Sonar rules that are not working with jdt.annotation

Since we have moved to jdt.annotation 2.0, a few Sonar rules (FindBugs)
do not work properly and report false positives. This resulted in
around 460 false issues in Sonar. We can disable those rules for now
until the problem is resolved. A bug report was filled at the FindBugs
project:
http://sourceforge.net/p/findbugs/bugs/1425/

The exclusions are done in the pom.xml so that any Sonar server can
benefit from this fix.

Change-Id: I31db810bc8a38d96870d94d5192139e6d74527b6
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61292
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Avoid concatenating nonliterals in a StringBuilder

Replace the use of StringBuilder with new String()

Change-Id: I64f00a6ef52c3348b361079f0507910b5525f621
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61075
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng : Remove inefficient new String(String) constructor

Change-Id: I964e7798a852e43674ee4eb1d7ad21574dc7bd0f
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61087
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Avoid concatenating nonliterals in a StringBuilder

Change-Id: I0e55afcbb0bc7d8b22dcbc68185971dd043c5249
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61073
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Avoid concatenating nonliterals in a StringBuilder

Change-Id: I78d9c69e192aab744b110909f050b556baa929d9
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61074
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Use of Activator.logError() instead of System.err.println()

Change-Id: Ifbb0cd06f6fb33653a3b9892fb623d1e74c2a387
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61079
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf : Avoid concatenating nonliterals in a StringBuffer

Change-Id: Idc6a9804bc5f2b101a8ada406d7bbd362c1161c5
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61072
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

lttng: additional definitions for lttng 2.7 and 2.8

* New event sched_waking (for upcomming lttng 2.8 and linux > 4.3)
* Modified event names in lttng 2.7 for softirqs
(softirq_entry renamed to irq_softirq_entry)

Change-Id: I0c5acd0e201e41ad7f2cf6749cc2105d41523f3f
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59230
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis: support sched_waking event

Use sched_waking event if available. This change is backward compatible
with previous instrumentation.

Change-Id: I28b07dc5cdfe988db8a1e11656eceac9856b1ae2
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59231
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>

analysis: Clean up AlgorithmManager a bit

Change-Id: I092a78d5899bd742acdd002290f67fab06c3126d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/58290
Reviewed-by: Hudson CI
Reviewed-by: Francis Giraldeau <francis.giraldeau@gmail.com>

tmf: add missing jdt.annotation on tmf.remote.ui.swtbot classpath

Change-Id: I313261c38f39a03f6e4980190e5df17c7c4476a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61095
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

ctf: support event-header-less traces

This fixes a regression caused by overly zealous @NonNull annotations
coupled with many warnings hiding a problem. The trace reader can now
read traces without an event header again.

Change-Id: Ida701b45cd0438cfd2000443a7a725e31d96669b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61090
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

ctf: Support Streamless packet readers

If a stream isn't set, the default one is null. This ensures that streamless
traces work.

Change-Id: Iad06dd965e3ca1173008cec5b8e68ac3bc910cbe
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61089
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf : Remove inefficient new String(String) constructor

Change-Id: I1ee9e4c969042e27219a756daeb9d43c210d23c1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61085
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Use StringBuilder in TmfRawEventViewer

Change-Id: Id144526bf60ed9cf56ea357638b1d28a9b10639b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60558
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Add constant modifier to fields in TimeGraphViewer

Change-Id: I8ca8df586ccfeaf075cd4b1582f1b1d737764756
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61076
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng : Remove inefficient new String(String) constructor

Change-Id: I369520ee58dacb15e40ca9b0262f63e864ba2abd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61086
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

analysis : Add constant modifier to a field

Change-Id: Iea36b92dd2357915c4b1fc11ed544396f2e6ecc7
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61078
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Avoid concatenating nonliterals in StringBuilder

Change-Id: I18b4d61d765f77522cb27cac7bba022d0b6035ad
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61071
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng : Add constant modifier to a field

Change-Id: Ica3bc9006b575aa7a08256a00cfa24da07196e22
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61077
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Avoid concatenating nonliterals in a StringBuilder

Split the append() call in two separates calls

Change-Id: Ib86731f916d76002570aad71f4976f6bfdf163a0
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61070
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf : Avoid concatenating nonliterals in a StringBuilder

Split the append() call in two lines

Change-Id: Icd7b69f793bf8a19b44b89d8506981cfbad38ddb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/61069
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Add annotations for Map.keySet() and .values()

The returned Set and Collection always exist (would be empty
if there are no entries in the map), so can be marked @NonNull.

The generic types K or V keep the same modifiers as the map definition.

Change-Id: If826108fbbd9abb19c7f87f9ef6e27c047425461
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59423
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Annotate Collections.toArray() methods

Both variants return @NonNull array references. The one with the
(T[]) parameter can also e annotated to require a @NonNull array
reference (or else it would just throw an NPE).

Note this covers only the array references themselves. The
contained element types will depend on what is passed in parameter

Change-Id: I31bed98a0b7d1df3486179a9e60cb8c73eb0038d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59421
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Fix SWTBot keyboard failure on headless Mac

Running tests that use the keyboard (AWT) on headless Mac fails with
java.awt.AWTException: headless environment
Setting java.awt.headless=false fixes this.

Change-Id: Ia693d1900a2bd8cfdeaf6816366800a872a45bad
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/55160
Reviewed-by: Hudson CI

Annotate Arrays.stream() methods

They all return a real, possibly empty, Stream which
is effectively @NonNull.

Change-Id: I3602bc1b879dd88e9ab05ff1d734fcc88ff45ae5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59426
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

Annotate StringBuilder.toString()

Always returns a new String, so is effectively @NonNull.

Again, this applies to this class only and not all Object#toString()
implementations!

Change-Id: I748fd7cc6cc627266733632b9e251f87569369db
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59425
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Augment annotation to Map.entrySet()

We already annotated Map.entrySet() to return a

@NonNull Set<Map.Entry<K, V>>

But actually, the returned Set should not contain any null elements,
since then entry objects will always exist, even if the key and/or
value is null. So we could augment the annotation to:

@NonNull Set<@NonNull Map.Entry<K, V>>

K and V in this case need to remain unannotated, their type should
match the Map's declaration.

Change-Id: Id436fd3cfc4f679198070e5efdbb9d2d3ce478ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59422
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Annotate some static Collections methods

Annotate all the following methods to return @NonNull collections:

.singleton*()
.synchronized*()
.unmodifiable*()

Change-Id: Iffa8743784c68611dcd4262c526afce0509ef155
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59328
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: reduce cyclomatic complexity of StreamInputPacketIndexEntry

Change-Id: I8b717fca910b67e1a3150dba5010ca8d062fa5e9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/44609
Reviewed-by: Hudson CI

tmf: Fix remote test failing on Windows

IFileInfo.getSize() returns 0 for directories on Windows. "For
directories, the return value is unspecified" so the right thing to do
is to add an isDirectory check.

Change-Id: I6112287adc6cef8fcd7c609edab5bbdfbd933ba3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60756
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf : Replace String() by an empty string "" in getHelpText

Replace the creation of an empty string using new String() with ""
instead.

Change-Id: Iebbe8dfc48eb5f963dda8d196eaa57e5f32258d3
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60949
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>

tmf : Remove literals duplication in TmfXmlReadWriteStateValue

Change-Id: I4b1a8f7323d6f47344565a0cb3a1f8d9854b4d41
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60831
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Introduce IPacketReader

Introduce the IPacketReader api to allow better decoupling between the
streaminputreader and the packet reader. This allows for more packet
reader types in the future, such as an InMemoryPacketReader for streamed
in RAM traces.

The IPacketReader is currently implemented by 2 classes:
    * a NullPacketReader, if there is no data to read
    * a CTFPacketReader, the typical packet reader

The CTFPacketReader is quite different from the CTFStreamPacketReader. The
SPR holds on to a FileChannel and maps segments as it needs. This results in
a fast but complex sliding window like reader. On the other hand, the
CTFPacketReader will only read one packet of a stream, a new one needs to
be created for each packet. This makes it wrap a single BitBuffer. As
FileChannels are resources but Bit(Byte)Buffers are not, this means a
CTFPacketReader is NOT autoclosable.

It should be noted that ByteBuffers can hold onto a system file handle. They
are released on GC. Also, ByteBuffers as they have their handle, will not
require the fileChannel to be opened all the time, so resources can be
dynamically closed when running low on file handles.

This patch also fixes some bugs in the tests relating to uninitialized traces
and lost event locations that were hidden due to "event.equals" not working as
well as it should.

The reason this patch does two things at the same time is that the interface
required a major re-write of the packet reader. This resulted in several bugs
being highlighted and fixed. To fix them in a separate patch before would
be very time consuming, and fixing them after would mean deliberately writing
a buggy packet reader to fix it in a subsequent patch.

This change will allow the following changes down the road:
    * In memory ctf reading (network streams)
    * Encrypted ctf stream reading
    * Compressed ctf stream reading
    * Multi-threaded stream reading
    * A power set of the previous elements

Change-Id: Id45b69bb0dac7a1f74f50cd732cd92064595f737
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/53284
Reviewed-by: Hudson CI

tmf : Remove duplicate literals in TmfRawEventViewer

Change-Id: I342db238daa4d6ed7579042279548f543b6149d6
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60835
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Refactoring the comments in TmfRawEventViewer

Removing dead code and moving some comments

Change-Id: Ieecd757fca6839019265f03e146d52f36184e4cd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60834
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: log when an error message is displayed in a MessageBox

Provide vital information to external tools such as [1] for testing
purpose. Also allow sharing of error messages a lot more easily.

[1] https://www.eclipse.org/rcptt/

Change-Id: I2dfa6da59c566b0f6a5d55a1d092699c9afcbb26
Signed-off-by: Jonathan Rajotte <jonathan.r.julien@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60860
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : Use Arrays.asList() instead of a loop

Use Arrays.asList() instead of a loop in TraceValidateAndImportOperation

Change-Id: If2ccf771fe6701164c2ee6f402da780fff9875e4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60750
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

lttng: make FileOffsetMapper try-with-resources in #getOutputFromCommand

Change-Id: I8c1dc1e1f81ddd4c4f442af11f91450d73142741
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59055
Reviewed-by: Hudson CI

tmf: Add check for ineffective setters in AbstractTimeGraphView

If these setters are called after the part control has been created,
they have no effect.

Change-Id: I34bab27624a98df122efd08546d1740d5d672fd8
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60940
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make call stack view extend AbstractTimeGraphView

Change-Id: I43c472c0512486e806bc1aa1db034d6268face5e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60667
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Annotate often-used Collectors method

We commonly end a Stream with

.collect(Collectors.toList());

However the returned List is not null-annotated, which means it gives a
warning if we want to save it to a @NonNull List<> reference.

It could be tempting to annotate Stream.collect() directly, however that
would be wrong: there is no guarantee that some shoddy Collector does
not return a null value.

Instead, annotate Collectors.toList(), toSet() and toCollection(), which
should cover for most common use cases.

Change-Id: I8adaf55579bf5b1cc66c5fbb122acc416a4870dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59327
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

common: Add a checkNotNull method to check contents of a Stream

Change-Id: I7473a5df08a20396d7716bd986a1e1f4e1e0ef27
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59325
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Call synchingToTime in AbstractTimeGraphView when switching traces

When switching traces (or opening a trace for the first time) the method
synchingToTime should be called with the selection begin time, to
perform view-specific handling for the new selected time.

Change-Id: Ia1eaa248b7e6d9616bfc20375276dcc83527fb28
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60736
Reviewed-by: Hudson CI

tmf: Allow AbstractTimeGraphView subclass to set filter content provider

Change-Id: I4127bff23d3a76bb0f23758568d1211eaaa1f60f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60666
Reviewed-by: Hudson CI

tmf: Make entry comparator apply recursively in AbstractTimeGraphView

Also update ControlFlowView's comparator so that it applies correctly to
non-root child process entries.

Change-Id: If02011789f53c12ef14e128651fdcaf0daedcc8b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60665
Reviewed-by: Hudson CI

lttng: make the field names compliant with the code style.

Change-Id: I15705a4eb0b4291fd86d09170d1a7aa58215e47a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59056
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: clean up KernelStateProvider

Change-Id: I39273c94aad9454fccbd4b353780863ca431b4ac
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60924
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: simplify search

The search now uses a java binary search instead of a house binary
search. This simplifies code a bit.

Change-Id: I9d9da2fff303f2492df502eeb856936ad94d5206
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/46286
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix wrong time for synchingToTime in AbstractTimeGraphView

It was incorrectly changed to the window start time instead of the
selection begin time in patch https://git.eclipse.org/r/55670.

Change-Id: I083a2e0d7cdc9843e0c2a0e65119a566b5a0ab1b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60664
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

tmf: Increase visibility of startZoomThread in AbstractTimeGraphView

This will allow subclasses to trigger the zoom thread when implementing
their own actions, for example.

Change-Id: I798327e044e786064ae2170ded415c2a2ea2e756
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60663
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI

lttng: add NON-NLS to string

Change-Id: I698429469932fd1412c8a56840a75d0fd77a685c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60925
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI

analysis: Split up KernelStateProvider

Right now, the cpu number and threadid is looked up for each
event, this new architecture will only read the information
as need be. This should accelerate trace reading by about 5%,
also it is more intuitive, as each event has one file
describing what it does.

Change-Id: I0a2c4480b1532536727783e5470acb545f0a705b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/47150
Reviewed-by: Hudson CI

tmf: Introduce resolveIntEventAspectOfClassForEvent

This pattern of getting an integer aspect is used a lot,
it could be moved to one place.

Change-Id: I8ca1cf09c70457ec116f0b46bfba3654f91a013f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60662
Reviewed-by: Hudson CI

Update 4.5 target with Mars.1 update sites

Change-Id: If6208c04c826c8f562eef8eaa0e617f1fa6ae99e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59786
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tmf: move custom parser tests from tmf.ui.tests to tmf.core.tests

Change-Id: Ib1d54ad5ad91fe315a68d77ab41d68802fe98178
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60737
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: enable and fix o.e.tc.tmf.ui.tests.trace test cases

Change-Id: I19aa42577be1d1c7056299d8d29d7e9fa768257f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60733
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Fix some null warnings

Change-Id: Ibb291421d2625ab80151e4f193cc09eb8febe747
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59129
Reviewed-by: Hudson CI

tmf: Make CustomText/Xml test wait until wizard shell is active

Change-Id: I097f47d121613f282d60d057fe1b3a30abd62840
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

ctf: Restore the downloading of the ctf-testsuite

When we migrated to using the tracecompass-test-traces, we also stopped
downloading the ctf-testsuite using git. However those are not part of
tracecompass-test-traces. Oops!

Somehow the tests didn't complain so far, but it'd be better if they
actually ran.

Change-Id: Id6b81698bf8e85d840819db8505a95f57a51685c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59438
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : remove duplicated lines in TimeGraphScale.java

add of the method drawAbsHeader() with a SimpleDateFormat parameter

Change-Id: I0b65c18e5b367e232e221ea3bc5fe1f2a11e3bdb
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60548
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Define some Sonar properties to skip unwanted classes and modules

Those are defined in our Hudson job right now but it's nicer to
have them as a default. For example, when running locally.

Change-Id: I2224a5573162454197be5459bdabcbebb6a8349c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60674
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

tmf: Make Import/Export package test wait until wizard shell is active

Change-Id: I158a2328a4d534eb2a6a861d25c47d586156cc4a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60572
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Annotate Long.valueOf() to return @NonNull

Change-Id: I889546810f6012ea88f34e704bf6d58221f4ac93
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59424
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Fix alignment SWTBot test at low resolution

The test now runs at 640x480.

Make sure the views have enough space otherwise they might not be
painted at all and they won't react to the sash being dragged.

Change-Id: Ib7feb329e9d2fe99fc5ecf02dba122b8324eb950
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60553
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

Annotate parameters of Immutable collections copyOf() of()

Those methods will throw NPEs if null is passed.
Also fix a few warnings that were introduced by these new annotations.

Change-Id: I73efaa5507b1dfcf9da41c86dc93bbd8ea8b3c27
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60568
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>

Annotate Guava Immutable collections

The following methods in Immutable{List|Set|Map} are all used
to create new collections and never return null values:

builder()
Builder.build()
copyOf()
of()

They can all be annotated as @NonNull.

Change-Id: I7149f488d2905c5def7b7b39993e9584642a4b0a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59326
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: add NON-NLS annotations to Lttng27EventLayout

Change-Id: Ieef1cd4c22f5747748e7fc4e69c1bd633e934ce4
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60547
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

gdbtrace : remove occurrences of literals

Change-Id: I337dc2efba794ec3a8b12adec65c76a6c2d1a1e4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60551
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf : use of StringBuilder.append() instead of operator + for strings

Change-Id: Ia0156a18fb2e81db4a375d8c36d34e3ced09d55b
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60536
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>

statesystem: Remove ITmfStateInterval.getViewerEndTime

Nothing calls it and its semantics are not well defined.
Also, it makes little sense that the state system would have knowledge
about what views want.

Change-Id: Idff4d0bf24c4173c8cd8a67ac18753dcd6fb4ff4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/59785
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI

tmf: Fix SWTBot test on Windows related to short temp path

On Windows, the system property for the temorary path looks like this:
java.io.tmpdir=C:\Users\MARC-A~1\AppData\Local\Temp\

Which is a "short path". When used in comparison with full, canonical
paths, it fails.

Change-Id: I3a90f792791e6983c2eab60d54b1e0694ed98dab
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/60273
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI

tmf: Fix trace markers with experiments in AbstractTimeGraphView

The key of the marker event sources map should always be the view trace.

Change-Id: Iecb458fd291c3ae1b62a5fed9f9954306f41a09a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60138
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

ctf: Fix CtfTmfLostEvent time range does not use timestamp transform

When a timestamp transform or trace offset was set on the trace, the
lost event time range end time was not transformed, but the timestamp
and time range start time were.

Change-Id: Ie2e79b5e90e900bdaf2e7e8391868132bd632332
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/60136
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

Add workspace/ to the gitignore

A top-level workspace/ directory gets created by the Maven build now.
It should not be tracked in Git.

Change-Id: If8a7e0bce1c99d36f9727d642dbebf95bb11da90
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59879
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

lttng: Rename orphaned relayd test to TestApplication

This file is a test application that is not intented to be tested as a Junit
test but it is written as such for convenience. We use this while developping
the Live feature.

Change-Id: I705f5a9fdfcb5b01b9478fe5402b48587a4c871c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/59441
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Hudson CI

tmf: Add Lost Events marker event source and factory

A marker event source factory for Lost Events is enabled for all traces.

The marker event source can reuse a previously returned marker list if
the requested parameters are identical to the previous request.

The event types statistics state system is updated to add a new
attribute which is used to compute the time ranges that are covered by
at least one lost event time range.

Change-Id: I2479afc3f07deb363f5847f4816940010bae3e9e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59389
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add TmfTraceAdapterFactory

Base class for a trace adapter factory. The factory creates a single
instance of each adapter type per trace, and disposes the adapter when
the trace is closed, if it is an instance of IDisposableAdapter.

Change-Id: Ieec69d17d0cff037f2df0c8dded14eef91db6f97
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59388
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Support adjustment of time graph window range on range selection

When the selection range is modified and 'ensureVisible' is true, then
the window range will be centered on either the selection begin time (if
it has changed) otherwise on the selection end time, if that time is
outside of the current window.

This adjustment is now enabled in time graph views when the
TmfSelectionRangeUpdatedSignal is received.

Change-Id: I8b5ec885b00009be05222db02acd745218759131
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59758
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: CallStackView sets wrong bounds

Apply the same changes that were done in patch
https://git.eclipse.org/r/#/c/55593 for the AbstractTimeGraphView.

Change-Id: I3f1bf9b8cc8dc017e60d92b079e74c892e3b8530
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59856
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

tmf: Add keyboard shortcuts for Next/Previous Marker

Support '.' for Next Marker and ',' for Previous Marker.

Support Shift key for extending the selection, both with the keyboard
shortcut and with the action button.

Update the status line when Next/Previous Marker changes the selection.

Clarify the marker event source API to indicate that the previous and
next markers should be included in the marker list.

Change-Id: I1f435e9620030809f10f3788eca40521c8a745a9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59512
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>

analysis: Fix missing setItemCount in AbstractSegmentStoreTableViewer

When the last trace is closed, the table viewer input is set to null.
Its item count should also be set to 0. Otherwise this can later cause a
NullPointerException in the TableViewer.

Change-Id: Ic1d482fd5e4ee64f7969375b1fe4d8b626fa31e0
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/59781
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>