Parth Sane [Mon, 21 Mar 2016 23:41:02 +0000 (05:11 +0530)]
staging: rtl8712: Fixed FSF address warning in ethernet.h
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Parth Sane [Mon, 21 Mar 2016 23:41:01 +0000 (05:11 +0530)]
staging: rtl8712: Fixed FSF address warning in drv_types.h
Fixed checkpatch warning after removing FSF address block as per guidelines.
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Parth Sane [Mon, 21 Mar 2016 23:41:00 +0000 (05:11 +0530)]
staging: rtl8712: Fixed FSF address warning in basic_types.h
Fixed checkpatch warning after removing FSF address paragraph as per guidelines.
Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhaktipriya Shridhar [Sun, 20 Mar 2016 20:40:21 +0000 (02:10 +0530)]
staging: rtl8712: rtl871x_ioctl_linux: Clean up tests if NULL returned on failure
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.
This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@
e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhaktipriya Shridhar [Sun, 20 Mar 2016 20:39:49 +0000 (02:09 +0530)]
staging: rtl8712: rtl871x_cmd: Clean up tests if NULL returned on failure
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.
This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@
e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhaktipriya Shridhar [Sun, 20 Mar 2016 20:39:17 +0000 (02:09 +0530)]
staging: rtl8712: rtl871x_mlme: Clean up tests if NULL returned on failure
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.
This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@
e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhaktipriya Shridhar [Sun, 20 Mar 2016 20:38:36 +0000 (02:08 +0530)]
staging: rtl8712: usb_ops_linux: Clean up tests if NULL returned on failure
Some functions like kmalloc/kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.
This was done using Coccinelle:
@@
expression *e;
identifier l1;
@@
e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhaktipriya Shridhar [Sun, 20 Mar 2016 19:53:17 +0000 (01:23 +0530)]
staging: rtl8712: os_intfs: Change form of NULL comparisons
Change null comparisons of the form x == NULL to !x.
This was done using Coccinelle.
@@ expression e;
@@
- e == NULL
+ !e
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhaktipriya Shridhar [Fri, 18 Mar 2016 17:56:18 +0000 (23:26 +0530)]
staging: rtl8712: rtl871x_ioctl_set: Remove unused macro
Removed Unused macro IS_MAC_ADDRESS_BROADCAST.
Grep'd to find occurences.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 19 Mar 2016 05:17:47 +0000 (10:47 +0530)]
Staging: rtl8723au: Remove unnecessary return statement.
Remove unnecessary return statement.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Fri, 18 Mar 2016 03:56:02 +0000 (09:26 +0530)]
Staging: rtl8723au: rtl8723a_rf6052: Remove unnecessary semicolon.
Remove unnecessary semicolon.
Coccinelle sementic patch as follows:
@r_case@
position p;
@@
switch (...)
{
case ...: ...;@p
}
@r_default@
position p;
@@
switch (...)
{
default: ...;@p
}
@r1@
statement S;
position p1;
position p != {r_case.p, r_default.p};
identifier label;
@@
(
label:;
|
S@p1;@p
)
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Edward Lipinsky [Sat, 12 Mar 2016 19:45:44 +0000 (11:45 -0800)]
staging: rtl8723au: Fix line longer than 80 columns.
This patch fixes the checkpatch.pl warning:
WARNING: line over 80 characters
Signed-off-by: Edward Lipinsky <ellipinsky@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nik Nyby [Sun, 20 Mar 2016 19:46:35 +0000 (15:46 -0400)]
staging: rtl8192u: fix typo in debug message
This fixes a mis-spelled word in a few debug statements.
Signed-off-by: Nik Nyby <nikolas@gnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Fri, 18 Mar 2016 03:45:45 +0000 (09:15 +0530)]
Staging: rtl8192u: Remove unnecessary semicolon.
Remove unnecessary semicolon.This issue is found by coccinelle script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ben Marsh [Mon, 14 Mar 2016 16:40:20 +0000 (17:40 +0100)]
Staging: rtl8192u: remove extra blank lines.
This patch removes blank lines in r8192U_wx.c that were flagged by
checkpatch.pl
Signed-off-by: Ben Marsh <bmarsh94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 19 Mar 2016 06:14:05 +0000 (11:44 +0530)]
Staging: netlogic: Remove & from function name.
Remove & from function name,when function name passed as an argument to another function.
Function name is used as pointer without &.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 21 Mar 2016 22:39:53 +0000 (15:39 -0700)]
staging: iio: use kernel preferred block commenting style
Use * on subsequent lines and trailing */ on a separate
line in block comments.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 14:22:44 +0000 (19:52 +0530)]
Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type.
Use sizeof type *pointer instead of sizeof type.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 14:21:12 +0000 (19:51 +0530)]
Staging: lustre: rpc: Use sizeof type *pointer instead of sizeof type.
Use sizeof type *pointer instead of sizeof type.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 13:46:48 +0000 (19:16 +0530)]
Staging: lustre: socklnd: Remove return statement from void function.
Remove return statement from void function.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 13:45:24 +0000 (19:15 +0530)]
Staging: lustre: socklnd_lib: Remove return statement from void function.
Remove return statement from void function.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 12:36:03 +0000 (18:06 +0530)]
Staging: lustre: lib-move: Remove unnecessary space after cast.
Remove unnecessary space after cast.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Fri, 18 Mar 2016 03:15:08 +0000 (08:45 +0530)]
Staging: i4l: pcbit: drv: Remove unnecessary semicolon.
Remove unnecessary semicolon.This issue is detected by coccinelle script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 20 Mar 2016 11:22:35 +0000 (16:52 +0530)]
Staging: i4l: pcbit: capi: Add parentheses to complex macro.
Add parentheses to complex macro.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 20 Mar 2016 11:20:49 +0000 (16:50 +0530)]
Staging: i4l: pcbit: drv: Do not initialise statics to 0.
Do not initialise statics to 0.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 20 Mar 2016 11:19:02 +0000 (16:49 +0530)]
Staging: i4l: pcbit: edss1: Use !x instead of x == NULL.
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 20 Mar 2016 11:17:28 +0000 (16:47 +0530)]
Staging: i4l: pcbit: layer2: Add parentheses to complex macro.
Add parentheses to complex macro.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Fri, 18 Mar 2016 09:32:41 +0000 (15:02 +0530)]
Staging: fbtft: fb_agm1264k-fl: No space is necessary after cast.
No space is necessary after cast.This problem is found by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Fri, 18 Mar 2016 09:29:34 +0000 (14:59 +0530)]
Staging: fbtft: fbtft-io: No space is necessary after cast.
No space is necessary after cast.This patch is found by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Fri, 18 Mar 2016 09:26:31 +0000 (14:56 +0530)]
Staging: fbtft: fbtft_device: No space is necessary after cast.
No space is necessary after cast.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Heena Sirwani [Mon, 14 Mar 2016 11:53:00 +0000 (17:23 +0530)]
staging: media: omap4iss: Match alignment with open parenthesis.
The following patch fixes the following checkpatch.pl warning:
CHECK: Alignment should match open parenthesis
Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Fri, 18 Mar 2016 08:26:00 +0000 (13:56 +0530)]
Staging: emxx_udc: emxx_udc: Add space around operator.
Add space around operator.This patch is found by checkpatch.pl script.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Sun, 13 Mar 2016 21:58:08 +0000 (23:58 +0200)]
Staging: emxx_udc: Add space around '-'
Add space around operator '-'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '-' (ctx:VxV)
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 13 Mar 2016 11:11:23 +0000 (16:41 +0530)]
Staging: gs_fpgaboot: Replace 'int32_t' with 'int'.
Replace 'int32_t' with 'int'.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 13 Mar 2016 10:22:15 +0000 (15:52 +0530)]
Staging: gs_fpgaboot: Add space around '+'.
Add space around '+'.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 13 Mar 2016 10:20:03 +0000 (15:50 +0530)]
Staging: gs_fpgaboot: Remove unnecessary blank lines.
Remove unnecessary blank lines.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sun, 13 Mar 2016 10:18:15 +0000 (15:48 +0530)]
Staging: gs_fpgaboot: Fix alignment to match open parenthesis.
Fix alignment to match open parenthesis.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Dilek Uzulmez [Sun, 13 Mar 2016 21:31:08 +0000 (23:31 +0200)]
Staging: rts5208: Add space around '+'
Add space around operator '+'. Problem found using checkpatch.pl
CHECK: spaces preferred around that '+' (ctx:VxV)
Signed-off-by: Dilek Uzulmez <dilekuzulmez@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Joe Perches [Fri, 18 Mar 2016 20:32:12 +0000 (13:32 -0700)]
staging: skein: threefish_block: Use ror64
Use the inline instead of direct code to improve readability
and shorten the code a little.
Done with perl:
$ perl -p -i -e 's/\((\w+) \>\> (\d+)\) \| \(\1 \<\< \(64 \- \2\)\)/ror64(\1, \2)/g' drivers/staging/skein/threefish_block.c
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sam Horlbeck Olsen [Mon, 14 Mar 2016 07:09:58 +0000 (02:09 -0500)]
staging: dgnc: Add whitespace around OR'd flags ("|")
This patch fixes the checkpatch.pl message:
CHECK: spaces preferred around that '|' (ctx:VxV)
+ writeb((UART_FCR_ENABLE_FIFO|UART_FCR_CLEAR_RCVR|UART_FCR_CLEAR_XMIT),
^ ^
As per the guidelines for coding style in the kernel, I have updated the
digi international driver to include spaces around the OR'd flags; not only
is this formatting issue caught by `checkpatch.pl`, in the next `if` block
the correct formatting is used, leading to both incorrect and inconsistent
code formatting.
This patch puts the line in question at 82 characters---while this is over
the recommended limit, there are no clear locations to break the line and it
barely breaks the cutoff.
Signed-off-by: Sam Horlbeck Olsen <sam.horlsen@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 19 Mar 2016 10:50:25 +0000 (16:20 +0530)]
Staging: rtl8188eu: usb_halinit: Use !x instead of x == NULL.
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 19 Mar 2016 10:48:47 +0000 (16:18 +0530)]
Staging: rtl8188eu: rtl8188e_rxdesc: Use !x instead of x == NULL.
Use !x instead of x == NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 19 Mar 2016 10:46:38 +0000 (16:16 +0530)]
Staging: rtl8188eu: hal_intf: Use x instead of x != NULL.
Use x instead of x != NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Sat, 19 Mar 2016 10:44:30 +0000 (16:14 +0530)]
Staging: rtl8188eu: Hal8188ERateAdaptive: Use x instead of x != NULL.
Use x instead of x != NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Nicholas Sim [Fri, 18 Mar 2016 12:11:07 +0000 (12:11 +0000)]
staging: rtl8188eu: remove return at end of void function call
Remove unnecessary return statement from last line of void function call
Signed-off-by: Nicholas Sim <nicholassimws@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Kyle Kuffermann [Sun, 13 Mar 2016 14:16:27 +0000 (10:16 -0400)]
staging: rtl8188eu: Remove license paragraph with mailing address
This fixes the issue reported by checkpatch.pl:
"Do not include the paragraph about writing to the Free Software
Foundation's mailing address from the sample GPL notice. The FSF
has changed addresses in the past, and may do so again. Linux
already includes a copy of the GPL."
in all files for the rtl8188eu driver.
Signed-off-by: Kyle Kuffermann <kyle.kuffermann@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ben Marsh [Sat, 12 Mar 2016 09:33:00 +0000 (10:33 +0100)]
Staging: rtl8188eu: removes an unnecessary cast on a void pointer.
Patch to rtl8188e_rxdesc.c to remove an unnecessary cast on a void
pointer.
Signed-off-by: Ben Marsh <bmarsg94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Juliana Rodrigues [Sun, 13 Mar 2016 18:30:57 +0000 (15:30 -0300)]
staging: rtl8712: rtl8712_cmd.c: fixed comparison to null
This patch fixes multiple "comparison to NULL"
checkpatch.pl issues:
CHECK: Comparison to NULL could be written "!pcmd"
+ if (pcmd == NULL)
Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Juliana Rodrigues [Sun, 13 Mar 2016 18:07:30 +0000 (15:07 -0300)]
staging: rtl8712: hal_init.c: fix comment block code style
This patch fixes several warnings caused by
malformed comments on hal_init.c and found by
checkpatch.pl.
Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roger H. Newell [Sat, 19 Mar 2016 15:20:52 +0000 (12:50 -0230)]
staging: wilc1000: Replaced comparison to NULL statements
This patch corrects checks generated by checkpatch.pl by
replacing comparison to null statements with equivalent
statements in the form "x" or "!x"
Signed-off-by: Roger H. Newell <newell.roger@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Roger H. Newell [Sat, 19 Mar 2016 15:19:21 +0000 (12:49 -0230)]
staging: wilc1000: Removed braces from single block statements
This patch corrects warnings generated by checkpatch.pl by
removing braces from single block statements.
Signed-ff-by: Roger H. Newell <newell.roger@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 14 Mar 2016 17:35:41 +0000 (10:35 -0700)]
staging: wilc1000: replace sem_test_key_block with a completion
Semaphore sem_test_key_block is used to signal completion of its
host interface message. Since the thread locking this semaphore will
have to wait, completions are the preferred mechanism and will offer
a performance improvement.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 14 Mar 2016 17:35:05 +0000 (10:35 -0700)]
staging: wilc1000: replace sem_test_disconn_block with a completion
Semaphore sem_test_disconn_block is used to signal completion of its
host interface message. Since the thread locking this semaphore will
have to wait, completions are the preferred mechanism and will offer
a performance improvement.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 14 Mar 2016 17:34:39 +0000 (10:34 -0700)]
staging: wilc1000: replace semaphore sem_get_rssi with a completion
Semaphore sem_get_rssi is used to signal completion of its host
interface message. Since the thread locking this semaphore will have
to wait, completions are the preferred mechanism and will offer a
performance improvement.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 14 Mar 2016 17:34:14 +0000 (10:34 -0700)]
staging: wilc1000: replace semaphore sem_inactive_time with a completion
Semaphore sem_inactive_time is used to signal completion of its host
interface message. Since the thread locking this semaphore will have
to wait, completions are the preferred mechanism and will offer a
performance improvement.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anchal Jain [Mon, 14 Mar 2016 12:36:54 +0000 (18:06 +0530)]
staging: wilc1000: Fix lines over 80 characters
Break lines so that they do not exceed 80
characters. Problem found using checkpatch.
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Anchal Jain [Sun, 13 Mar 2016 09:44:38 +0000 (15:14 +0530)]
staging: wilc1000: else is not generally useful after a break or return
Remove else after a break. Because else is
generally not useful after a break or return.
Signed-off-by: Anchal Jain <anchalj109@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Chaehyun Lim [Mon, 14 Mar 2016 00:40:27 +0000 (09:40 +0900)]
staging: wilc1000: use completion instead of struct semaphore hif_sema_wait_response
This patch replaces struct semaphore hif_sema_wait_response with struct
completion hif_wait_response. In case of struct hif_sema_wait_response,
it better to use completion than semaphore.
Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Mar 2016 09:48:14 +0000 (18:48 +0900)]
staging: wilc1000: removes an unnecessary if-condition
This patch removes an unnecessary if-condition.
Regardless of an if-condition is performed unconditionally '_end_' statement.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Mar 2016 09:48:13 +0000 (18:48 +0900)]
staging: wilc1000: removes goto definitions from wilc_wlan_firmware_download
This patch removes goto definitions from wilc_wlan_firmware_download function.
Goto '_fail_1' feature is error return.
It returns error type directly without result variable replacement as well.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Mar 2016 09:48:12 +0000 (18:48 +0900)]
staging: wilc1000: changes an ambiguous debug messages
This patches changes an ambiguous debug messages.
The device types are both SDIO or SPI.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Mar 2016 09:48:11 +0000 (18:48 +0900)]
staging: wilc1000: removes duplicate wilc variable setting
This patches removes duplicate wilc variable setting.
This value has already been set to wl variable previously.
Replace wilc with wl as well.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Mar 2016 09:48:10 +0000 (18:48 +0900)]
staging: wilc1000: removes duplicate vif variable setting
This patches removes duplicate vif variable setting.
This value has already been set previously.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Mar 2016 09:48:09 +0000 (18:48 +0900)]
staging: wilc1000: wilc_spi.c: removes debug print log
This patches removes unnecessary debug print logs.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Leo Kim [Tue, 15 Mar 2016 09:48:08 +0000 (18:48 +0900)]
staging: wilc1000: removes function 'init_tcp_tracking()'
This patch removes function 'init_tcp_tracking()'.
The function is an unnecessary return.
Signed-off-by: Leo Kim <leo.kim@atmel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ben Marsh [Tue, 15 Mar 2016 18:37:54 +0000 (19:37 +0100)]
Staging: nvec: removes a useless cast on a void pointer
Remove an unnecessary cast on a void pointer in nvec_power.c
Signed-off-by: Ben Marsh <bmarsh94@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Garcia Liebana [Sat, 12 Mar 2016 15:19:11 +0000 (16:19 +0100)]
staging: nvec: Fix comparison to NULL
Replace the use of comparison to NULL, use !<expression> instead. Checkpatch detected these issues.
Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Garcia Liebana [Sat, 12 Mar 2016 15:20:04 +0000 (16:20 +0100)]
staging: nvec: Remove space after a cast
No space is required after a cast. Checkpatch detected this issue.
Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Garcia Liebana [Sat, 12 Mar 2016 15:35:30 +0000 (16:35 +0100)]
staging: octeon: Fix alignment with open parenthesis
Alignment should match open parenthesis. Checkpatch detected these
issues.
Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Laura Garcia Liebana [Sat, 12 Mar 2016 15:03:50 +0000 (16:03 +0100)]
staging: octeon: Use type int instead of int32_t
Prefer the use of type int instead of int32_t. Checkpatch detected these
issues.
Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Amitoj Kaur Chawla [Sat, 12 Mar 2016 09:31:04 +0000 (15:01 +0530)]
staging: slicoss: Add error check for pci_map_single
Currently, DMA mapping failure is not detected, causing the hardware
to attempt a DMA from an invalid address.
This patch adds the corresponding error check for pci_map_single i.e.
pci_dma_mapping_error.
Problem found using the following Coccinelle semantic patch:
// <smpl>
@@
expression e1;
identifier x;
@@
x=
(
*dma_map_single(...)
|
*dma_map_page(...)
)
... when != dma_mapping_error(e1,x)
@@
expression e1;
identifier x;
@@
x =
(
*pci_map_single(...)
|
*pci_map_page(...)
)
... when != pci_dma_mapping_error(e1,x)
// </smpl>
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
PrasannaKumar Muralidharan [Sat, 12 Mar 2016 08:33:09 +0000 (14:03 +0530)]
Staging: most: Remove atomic_counter_t typedef
Remove atomic_counter_t typedef, use int instead.
Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 11:49:44 +0000 (17:19 +0530)]
Staging: iio: ad5933: Remove unnecessary space after cast.
Remove unnecessary space after cast.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 07:47:01 +0000 (13:17 +0530)]
Staging: iio:
ade7758: Fix open parentheses alignment issues.
Fix open parentheses alignment issues.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 07:45:13 +0000 (13:15 +0530)]
Staging: iio:
ade7758: Use a blank line after function/struct declarations.
Use a blank line after function/struct declarations.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 07:43:46 +0000 (13:13 +0530)]
Staging: iio: ade7758_core: Remove unnecessary blank line.
Remove unnecessary blank line.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sandhya Bankar [Mon, 21 Mar 2016 07:41:15 +0000 (13:11 +0530)]
Staging: iio: ade7758_core: Fix open parentheses alignment issues.
Fix open parentheses alignment issues.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Thu, 17 Mar 2016 07:00:20 +0000 (00:00 -0700)]
staging: iio: ad5933: remove unused #includes
Remove #includes no longer used in this module.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Thu, 17 Mar 2016 06:59:19 +0000 (23:59 -0700)]
staging: iio: ad5933: move contents of header file to source file
The contents of the header file are used only by this single
source file. Move content into .c and remove .h.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 14 Mar 2016 06:15:51 +0000 (23:15 -0700)]
staging: iio: io-trig-bfin-timer: use dev_get_platdata()
Use dev_get_platdata() for retrieving the platform data instead of
accessing dev->platform_data directly. Move the assignment out of
the declaration (avoid lines over 80 char and put it close to
usage).
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 14 Mar 2016 06:13:49 +0000 (23:13 -0700)]
staging: iio: ad5933: use dev_get_platdata()
Use dev_get_platdata() for retrieving the platform data instead of
accessing dev->platform_data directly.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Alison Schofield [Mon, 14 Mar 2016 06:11:30 +0000 (23:11 -0700)]
staging: iio: meter: remove fixme comment on device remove
This comment was in place in the original drafts of these drivers
when the remove function did a whole lot of work: flushed queues,
unregistered interrupts, uninitialized rings, unconfigured rings,
and a few kfree's.
The remove functions have since been reduced to unregistering and
stopping the device. This is the inverse of what was done during
probe and is correct. Time to remove the comment.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Sat, 12 Mar 2016 08:19:24 +0000 (16:19 +0800)]
staging: iio: tsl2x7x_core: add blank line after struct declaration
Add the missing blank line after struct declaration. Checkpatch found
this issue.
CHECK: Please use a blank line after function/struct/union/enum
declarations
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Sat, 12 Mar 2016 08:19:23 +0000 (16:19 +0800)]
staging: iio: tsl2x7x_core: add spaces around operators
Address the checkpatch check by adding the necessary whitespace around
operators:
CHECK: spaces preferred around that '/' (ctx:VxV)
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Sat, 12 Mar 2016 08:19:22 +0000 (16:19 +0800)]
staging: iio: tsl2x7x_core: remove space after a cast
Delete unneeded space after a cast as suggested by checkpatch.
CHECK: No space is necessary after a cast.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Sat, 12 Mar 2016 08:19:21 +0000 (16:19 +0800)]
staging: iio: tsl2x7x_core: use preferred comment style
Adjust block comments by adding the necessary trailing */ on a separate
line. Checkpatch found this issue.
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Eva Rachel Retuya [Sat, 12 Mar 2016 08:19:20 +0000 (16:19 +0800)]
staging: iio: tsl2x7x_core: adjust alignment to match open parenthesis
Align the parameters to match open parenthesis. Issue detected using
checkpatch.
CHECK: Alignment should match open parenthesis
Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Sun, 13 Mar 2016 02:27:12 +0000 (21:27 -0500)]
staging: unisys: visorbus: rename create_visor_device gotos
Away is ambiguous when specifying error vs success. Make return labels
more meaningful by marking them as error paths.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Sun, 13 Mar 2016 02:27:11 +0000 (21:27 -0500)]
staging: unisys: visorbus: Remove gotos in visorbus_match
Gotos in visorbus_match are not needed.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Sun, 13 Mar 2016 02:27:10 +0000 (21:27 -0500)]
staging: unisys: visorbus: fix up gotos in visorbus_init
This patch fixes the gotos in visorbus_init
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Tim Sell [Sun, 13 Mar 2016 02:27:09 +0000 (21:27 -0500)]
staging: unisys: visorbus: remove unused sysfs attribute devmajorminor/*
The sysfs attribute directory at:
/sys/bus/visorbus/devices/vbus<x>:dev<y>/devmajorminor/*
or
/sys/devices/visorbus<x>/vbus<x>:dev<y>/devmajorminor/*
previously provided a location where a visorbus function driver could
publish information (for usermode use) about possibly-multiple major and
minor device numbers for character devices created for a each visorbus
device, using visorbus_registerdevnode(). This functionality is not
currently used, so it has been removed by this cset.
Signed-off-by: Tim Sell <Timothy.Sell@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Sun, 13 Mar 2016 02:27:08 +0000 (21:27 -0500)]
staging: unisys: visorbus: Fix up visordriver_probe
Fixup the visordriver_probe function. Rearrange the function to avoid
needing gotos and removed unnecessary wmb().
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 11 Mar 2016 22:01:44 +0000 (17:01 -0500)]
staging: unisys: visorbus: fix my_create_device goto statements
Don't use the abmiguous cleanup, make it more meaningful.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 11 Mar 2016 22:01:43 +0000 (17:01 -0500)]
staging: unisys: visorbus: Cleanup bus_epilog goto statements
Cleaned up bus_epilogs vague gotos and in the process discovered
some error paths that could unlock a non locked semaphore.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 11 Mar 2016 22:01:42 +0000 (17:01 -0500)]
staging: unisys: visorbus: Cleanup goto in bus_create
Rename it to what it does instead of the default ambiguous
cleanup.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 11 Mar 2016 22:01:41 +0000 (17:01 -0500)]
staging: unisys: visorbus: chipset_init rename goto
Change the goto label "cleanup" to something more useful like
out_respond.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 11 Mar 2016 22:01:40 +0000 (17:01 -0500)]
staging: unisys: visorbus: cleanup gotos in parser_init_byte_stream
Clean up the goto in parser_init_byte_stream and make the goto section
the error case.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 11 Mar 2016 22:01:39 +0000 (17:01 -0500)]
staging: unisys: visorbus: get rid of gotos in intialize_controlvm_payload_info
Get rid of the gotos in initialize_controlvm_payload_info. The check in
the error path if payload was valid was never called so get rid of that
as well.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
David Kershner [Fri, 11 Mar 2016 22:01:38 +0000 (17:01 -0500)]
staging: unisys: visorbus: cleanup goto in setup_crash_devices_work_queue
If visorbus has registered yet just reschedule and exit. The rest of
the function doesn't need to reschedule so just move it up to the
initial check.
Signed-off-by: David Kershner <david.kershner@unisys.com>
Signed-off-by: Timothy Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
James Simmons [Sat, 12 Mar 2016 18:00:36 +0000 (13:00 -0500)]
staging: lustre: cleanup comment style for lnet selftest
Apply a consistent style for comments in the lnet selftest
code. Realign some of the comments to make it easier to read.
This also fixes a few checkpatch issues as well.
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This page took 0.043693 seconds and 5 git commands to generate.