Alexandre Montplaisir [Wed, 15 Jun 2016 00:33:53 +0000 (20:33 -0400)] 
tmf: Add utility method to search for events matching a Predicate
Add methods in TmfUtils to search for events, forwards or
backwards in the trace, until an event matching the given
Predicate is found.
This will be used to implement a "Go to next/previous event of
current time graph entry" option for time graph views.
Change-Id: I19c78a459f1918cc41b0094f2a16bf0172b34804
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/75325
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Bruno Roy [Tue, 14 Jun 2016 14:15:47 +0000 (10:15 -0400)] 
control: command support for excluding specific events by name
We can add exclusions to UST tracepoints. Events that match any of the
items of the list are not going to be enabled. Even if they match a
wildcard definition of enabled events.
Change-Id: Id1522633046f3a3251605ea9b6664be17c40bc49
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74105
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 10 Jun 2016 21:40:08 +0000 (17:40 -0400)] 
tmf.ui: make XY charts zoom on CTRL-MOUSEWHEEL
This makes the control much more inline with tracecompass as mousewheel
is typically for moving up-down.
Change-Id: I6de6a809e0b15161e6059939d8aedff65f2a596e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75102
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Matthew Khouzam [Wed, 15 Jun 2016 21:39:38 +0000 (17:39 -0400)]
tmf.ui: make Shift-Click extend selection ranges
Change-Id: If2130443830b87d83a3e3e012e1f5b944a323f00
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75359
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bruno Roy [Mon, 16 May 2016 21:01:19 +0000 (17:01 -0400)]
control.test: SWTBot test for enabling specific event type by name
Change-Id: I900b990712423203710f5b73b920d0995f637bad
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73099
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bruno Roy [Mon, 16 May 2016 18:27:52 +0000 (14:27 -0400)]
control: Bug 490322: command support for enabling specific event by name
Change-Id: I14628d04a7546c10f518c84a2b64be4069cd9196
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72838
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Fri, 6 May 2016 03:20:19 +0000 (23:20 -0400)] 
Use 4.6 target by default in Oomph setup
Since we build with 4.6 by default, it makes sense that the Oomph
setup uses 4.6 by default as well.
Change-Id: I63177df57c91eb1c08b806f4b8022dc6c53b0b81
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72177
Reviewed-by: Hudson CI
Bernd Hufmann [Mon, 13 Jun 2016 19:29:46 +0000 (15:29 -0400)] 
control: fix tree item selection in SWTBot tests
Before the all tree node was not selected. The test still was
successful due to default behaviour
Change-Id: I6356def3db40cdd3414185d6df6d3d2c16415a6c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75181
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 13 Jun 2016 20:41:15 +0000 (16:41 -0400)]
Revert "ctf.core: making some classes final"
This reverts commit
266c4d511bd4c26ca6e5063b53715d9c9ecea674.
Change-Id: I21b23499a79084100256591ba59c8af14de06a2e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75196
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 13 Jun 2016 20:41:02 +0000 (16:41 -0400)]
Revert "ust.core: making some classes final"
This reverts commit
ac52feb8c7e7dbc3caa69207c1df59b841a7012d.
Change-Id: I4bbdb49c9f4cecf10e628a8274c8fd0f6ef1ac56
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75195
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 13 Jun 2016 20:42:29 +0000 (16:42 -0400)]
Add Trace Compass 2.0.0 baseline
For now, use RC4 update site. Will switch to final release update
site when it's available.
Change-Id: I5bdb53ffd13875912e1aa87a169bbb7a13759f59
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/75194
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Matthew Khouzam [Fri, 6 May 2016 20:04:54 +0000 (16:04 -0400)]
tmf.ui: hide title and legend in swtcharts by default
Change-Id: Ic4ac8b6ec66732986651a0483fcf3d51a54edc09
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72302
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Wassim [Fri, 10 Jun 2016 19:56:28 +0000 (15:56 -0400)] 
tmf.core: making fInstance private
Private members encapsulate data well in a class and are not used
anywhere else in the code so they can be easily modified or enhanced
without any side-effects.
Change-Id: Ida21a9a5c576f20ee2a5bee29b80ef02de9eb630
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/75095
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bruno Roy [Tue, 3 May 2016 19:46:37 +0000 (15:46 -0400)]
tmf.ui: Remove overriding methods
Change-Id: I4ff9a10a618f14f5a08ce9d46cc15ca6ce94349a
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71943
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bruno Roy [Tue, 3 May 2016 18:00:12 +0000 (14:00 -0400)]
tmf.ui: Change the == operator with the equals() method
Change-Id: I4633d1aa33c49fc7e1da3bb449cb5a25e85870a4
Signed-off-by: Bruno Roy <bruno.roy@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71935
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Michael Jeanson [Mon, 16 May 2016 19:50:29 +0000 (15:50 -0400)] 
analysis.lami: Split axis titles in label and units
The axis titles are now built using the label and units strings,
which makes it easier to override or remove the units of an axis.
Bug: 493941
Change-Id: Icd63f9678084029c6ccaf2a6c51b607ccc71c0ab
Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74092
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Tested-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Geneviève Bastien [Mon, 13 Jun 2016 19:13:10 +0000 (15:13 -0400)] 
tmf: buf 495911 Fix timestamp transform fast for small timestamps
Change-Id: I64f3fc6c113fd240506a6d972430bda94ed05afb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/75187
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Wassim [Mon, 6 Jun 2016 19:58:59 +0000 (15:58 -0400)]
linux.core: making SyscallNameAspect final
This patch is to make a class final in linux.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.
Change-Id: I6df113ac664cb7e11981de84d64460d3c90cacb3
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74715
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Bernd Hufmann [Fri, 1 Apr 2016 13:09:34 +0000 (09:09 -0400)]
control: command support for enabling all tracepoints/syscalls
Change-Id: I68f2783bfa9ff7882f8956a06028c0d63d286e98
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72207
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Fri, 1 Apr 2016 13:12:39 +0000 (09:12 -0400)]
control: allow filters for when enabling events on domain level
Change-Id: I1dcebc5c204f7d906ce5dd723a25153280689d96
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72206
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Cédric Biancheri [Mon, 6 Jun 2016 14:02:39 +0000 (10:02 -0400)] 
lttng: add names of traces in sync algorithm stats
Two lines were added to match traces Ids with traces names so it can be
easier to see which pairs were synchronized.
Change-Id: Iec69283080a12668c02d5886b4bbf95e1440ac00
Signed-off-by: Cédric Biancheri <cdc.biancheri@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74674
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Wed, 8 Jun 2016 16:20:11 +0000 (12:20 -0400)]
Update targets with latest launchbar
Change-Id: Ic67b5dcd47c94cb5da04123f9a330d5400f25d6c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74912
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Wed, 8 Jun 2016 13:10:28 +0000 (09:10 -0400)] 
rcp: Update copyright year in branding files
Change-Id: Id72825366f573b71a4247402a015c7baebc3d74d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74891
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 8 Jun 2016 03:32:44 +0000 (23:32 -0400)]
releng: Update targets for Neon RC4
Also update staging target, I forgot to update it last time.
Change-Id: I1f6846934bd21147a07c6e97e6a715bad816c098
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74847
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Philippe Proulx [Mon, 25 Apr 2016 23:00:55 +0000 (19:00 -0400)] 
doc: Document the external analyses feature
Bug 495211
Change-Id: I323e83b23f3a90591a9d24d0ecd067cb6e34b925
Signed-off-by: Philippe Proulx <pproulx@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74813
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 7 Jun 2016 21:35:13 +0000 (17:35 -0400)]
analysis.lami: Correctly reject lttng-analyses > 0.4
Trace Compass does not currently support the LAMI 1.0 protocol,
which means lttng-analyses 0.5 and up should not be available
and should be striked out.
Correctly update the max version number to make it so.
Change-Id: I65a33db732dba7725284840b2bcd0b2ecaab9d3a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74839
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Tue, 7 Jun 2016 14:04:42 +0000 (10:04 -0400)] 
doc: Bug 495211. Add flat/hierarchical threads presentation user guide
Change-Id: I11a6c4f9293e0118f032e0da01d2984d8bb65fc1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74777
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Thu, 2 Jun 2016 21:10:00 +0000 (17:10 -0400)]
tmf: Bug 495219: Fix NPE in checkpoint indexer seeking on disposed trace
In BTree, if it is disposed (file is null), return -1 (insertion point
0) in the binary search. This will correspond to checkpoint 0 in the
flat array.
In FlatArray, if it is disposed (file is null) return null as checkpoint
in get(long).
In TmfCheckpointIndexer, if the returned checkpoint is null in
restoreCheckpoint(long), return the context given by the trace
implementation of seekEvent((ITmfLocation) null). It should properly
handle a disposed trace.
Change-Id: I3148d2e10118628e387d206054de55d5238a9807
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74474
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Mon, 6 Jun 2016 04:07:36 +0000 (00:07 -0400)]
lttng: Make use of "is_pic" event field in debug info analysis
A field with name "is_pic" is now present in LTTng 2.8 final in
"bin_info" events to indicate if the referred binary is PIC
(position-independent code) or not. We can make use of this
field to identify PIC binaries much more reliably than by just
looking at the file name.
Bug: 495551
Change-Id: Ib553f43e8236c399c56387ff8e20a8428c688fb5
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74616
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Wed, 1 Jun 2016 04:16:55 +0000 (00:16 -0400)]
releng: Update targets for Neon RC3
- launchbar doesn't have a RC3, only RC2.
- Make sure SWTChart 0.7.0 is used, the newer version will not be
used for Neon.
Change-Id: I5bb6195bc79651e5f596ade765e37086794a162a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74160
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Mon, 6 Jun 2016 20:32:50 +0000 (16:32 -0400)]
doc: Bug 495211. Update follow CPU in user guide
Add follow CPU to Resources View user guide and CPU filtering to CPU
Usage View user guide.
Change-Id: Ie0572582f9228b7a4784d612e21fcca07dc9ccba
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74718
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Sonia Farrah [Tue, 3 May 2016 21:54:12 +0000 (17:54 -0400)] 
ust: Simplify conditional in equals()
Change-Id: I66add0ec275904fdc25df899d440041b7fa78882
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71962
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 6 Jun 2016 20:59:42 +0000 (16:59 -0400)]
doc: Bug 495211: Update developer guide for ITmfStateSystem API
Change-Id: I20bad86bfbd2bde033e04b8ea215fe0a6d2ac847
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74725
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 6 Jun 2016 18:10:14 +0000 (14:10 -0400)]
doc: Bug 495211: Update TmfTimestampFormat reference API
Update TmfTimestampFormat.html link to external user guide location.
Update pom.xml to copy the reference directory in deploy-doc profile.
Update external Javadoc links to Java 8.
Change-Id: I6fc2e12ca4c0b8aac8253d0f805ad3c5d76dd8c7
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74716
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 6 Jun 2016 21:17:36 +0000 (17:17 -0400)]
doc: Bug 495211: Update developer guide signal reference
Change-Id: I432fb33f118c39f0011708187b85022996bccd6d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74726
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Mon, 6 Jun 2016 18:05:29 +0000 (14:05 -0400)]
doc: Bug 495211. Update Statistics View user guide
Change-Id: Id266dbb9ba577edea8acafbc196cfbc29f37cfb2
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74704
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Mon, 6 Jun 2016 02:47:03 +0000 (22:47 -0400)]
analysis.lami: Use openResource command to run analyses
Bug: 493941
Change-Id: I628c5f7aef0674f4e83dbd9e611ec3616754f758
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74615
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Fri, 3 Jun 2016 22:43:21 +0000 (18:43 -0400)]
analysis.lami: Use the openResource command to open reports
Instead of defining our own command, we can hook into the
Eclipse-provided org.eclipse.ui.navigate.openResource command,
so that the reports can then be opened using the usual
keybindings to open resources.
Also hook it into OpenAction so that Enter and double-click
opens the report.
Bug: 493941
Change-Id: I4c546b60a77c2d531c8c9f18961984e5962ef56f
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74569
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Wed, 1 Jun 2016 14:57:44 +0000 (10:57 -0400)]
analysis: bug 494786. Clear process selection when switching trace
Clear selection in CPU Usage view and Kernel Memory Usage View when
switching trace.
Change-Id: I57618581048995904fa71a9f24d65453eea9ae94
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74261
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jean-Christian Kouame [Fri, 3 Jun 2016 17:06:30 +0000 (13:06 -0400)]
doc: Bug 495211. Add timing views and viewers developer guide
Change-Id: Icc60e2838c884188fcf314032ff89cde8bbef743
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74544
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jean-Christian Kouame [Thu, 2 Jun 2016 13:56:50 +0000 (09:56 -0400)]
doc: Bug 495211. Update Go to min/max documentation
Change-Id: Ia6817483a4b6c03afcde050026ea218479681ad4
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74380
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Patrick Tasse [Mon, 30 May 2016 21:20:10 +0000 (17:20 -0400)]
tmf: Bug 494952: Remove deadlock in Time Chart view
The handling of signal TmfTraceUpdated is now done in a
ProcessTraceThread. There is only one such thread per trace active at a
time. If an update is requested while a thread is active, the thread is
marked to be restarted after its current iteration completion.
The starting or restarting of a ProcessTraceThread is consolidated in a
method and synchronized.
The ProcessTraceThread now always processes the full time range of the
trace, even when the view is opened with a trace already opened.
A missing synchronization on DecorateThread concurrent access is added.
Method ITimeDataProvider.resetStartFinishTime(boolean) is added to allow
the TimeChartView to reset its window range without notifying listeners.
Change-Id: I0d49d2712af4e5c645bd61bfde46ba37fc42779c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73996
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Mon, 30 May 2016 20:10:00 +0000 (16:10 -0400)]
doc: bug 495211 Add the I/O analysis documentation
Change-Id: I9e790c1b9bfd0e9a0c35f303d9660bb522c6cf93
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73985
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Wassim [Fri, 3 Jun 2016 19:22:09 +0000 (15:22 -0400)]
kernel.core: making some classes final
This patch is to make some classes final in kernel.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.
Change-Id: Ie74fb3a6a36075cd355bdc58f4fe1deb3fc4a82a
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74558
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Geneviève Bastien [Mon, 6 Jun 2016 13:40:36 +0000 (09:40 -0400)]
doc: bug 495211 Update analysis requirement doc
Change-Id: I8fe98347c74de13dbb5786bc2b0654875227b0a1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/74669
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Francis Giraldeau [Fri, 3 Jun 2016 13:39:29 +0000 (09:39 -0400)] 
lttng: bug 495211 document the critical flow view
The documentation introduces the view and the required steps to actually load
and run the wait analysis on a process.
Change-Id: I860ef950ef48381c5b5da3009d0a780970684f94
Signed-off-by: Francis Giraldeau <francis.giraldeau@gmail.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74568
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Bernd Hufmann [Fri, 3 Jun 2016 17:26:43 +0000 (13:26 -0400)]
doc : Bug 495211. Update analysis requirement doc for new API
Change-Id: I1523b873303c8958fe6b91ab5bf1537897ba2373
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74546
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jonathan Rajotte [Wed, 1 Jun 2016 19:50:11 +0000 (15:50 -0400)] 
analysis.lami: merge control flow on ranges equal zero
Even thought it is the expected behaviour Coverity/Sonar flags the two
"if"s as a potential code duplication and infers an error.
Let's comply to Coverity/Sonar.
Note: Patrick Tassé did mention to merge the two "if"s during initial
review [1] and it was simply forgotten.
Coverity ID: 115874
[1] https://git.eclipse.org/r/#/c/73239/7/analysis/org.eclipse.tracecompass.analysis.lami.ui/src/org/eclipse/tracecompass/internal/provisional/analysis/lami/ui/format/LamiTimeStampFormat.java
Change-Id: I22cf9499eb53fd547ae3ebfc73161f21db5cac47
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/74314
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Fri, 3 Jun 2016 14:55:48 +0000 (10:55 -0400)]
xml.ui: Bug 495415: Safely absolute a hashcode
It is possible for a call to hashCode to return
Integer.MIN_VALUE. Take the absolute value of such
a hashcode and you'll still have a negative number.
Since your code is likely to assume that it's a
positive value instead, your results will be unreliable.
Similarly, Integer.MIN_VALUE could be returned from
Random.nextInt() or any object's compareTo method,
and Long.MIN_VALUE could be returned from Random.nextLong().
Calling Math.abs on values returned from these methods
is similarly ill-advised.
Change-Id: I44396a35d3efd046b8a082ebb57c070387d9f90d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74533
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Mon, 11 Apr 2016 00:05:28 +0000 (20:05 -0400)]
doc: Document how to use LTTng-UST 2.8 source lookup
Bug: 495211
Change-Id: I6cd1dda9bb9039ad028ec65cf07447da9ad9e85b
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70716
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 20 May 2016 21:41:43 +0000 (17:41 -0400)]
tmf: Enable address mapping config action for all traces
The Call Stack View only enables the "Configure address mapping"
action for traces that provide function entry/exit info. However,
since this configuration is now used by the generic ISymbolProvider
and can be used by other analyses, the dialog should be accesssible
for all traces, as long as they provide a preference page.
Bug: 494212
Change-Id: Ia9db94e051226fb79adfd502f6081857954042d0
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/73337
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 17 May 2016 02:33:50 +0000 (22:33 -0400)]
tmf.ui: test TmfRawEventViewer using SwtBot
This tests keystrokes too to make sure that there are
no surprise exceptions.
Change-Id: Ia2a325a0a520bde3db56a04ddf1779a095342ecb
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72865
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Tue, 31 May 2016 20:46:13 +0000 (16:46 -0400)]
tmf: Bug 495067: Canceling remote import shows Internal error dialog
The OperationCanceledException is now caught gracefully.
Change-Id: I2da2fd00e50b14d3a215aa2389ea241e51fb698f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74117
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Tue, 31 May 2016 20:58:05 +0000 (16:58 -0400)]
tmf: Bug 494810: SelectionEvent not sent after using vertical slider
The vertical slider used by the TmfVirtualTable is created with the
SWT.NO_FOCUS style. In Linux-GTK, this hint is not respected and the
slider can gain focus. When this happens, give back the focus to the
table.
This allows the SelectionEvent to be sent when extending a selection
using Shift+Click in the event table after using the vertical slider.
Change-Id: I9a8d7083300a5c515c24110d5572d30b6bd9d7d6
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74119
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 4 May 2016 03:31:33 +0000 (23:31 -0400)]
xml: bug 493954: Allow string states to be displayed in time graph views
If a string state value is to be displayed in the time graph, it will add
a new state to the presentation provider with color. This state will be re-used
when the same string is displayed again. This is ideal for time graphs of state
system where there is a fixed number of strings as value, yet impossible to
define with definedValues because specific to a trace.
Change-Id: I2d1fa041e578e0a7dbccc3138153db3fd4684c62
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/71970
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 1 Jun 2016 21:41:34 +0000 (17:41 -0400)]
doc: Bug 495211 Update XML XY view documentation
The kernel analysis was moved.
Change-Id: Ibaf3843b43e15d7fe742e1e9b05b6e40250f5fec
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74326
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 1 Jun 2016 21:37:48 +0000 (17:37 -0400)]
doc: Bug 495211 Update CTF documentation
Change-Id: Iafeacbf118de123d96d54e422e718a0d2a7fff37
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/74325
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Thu, 26 May 2016 17:13:08 +0000 (13:13 -0400)]
segstore.core: Synchronize isEmpty
This avoids race conditions
Change-Id: Ifb252a4011aed88118b2db8abd6c49be49c0d175
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73744
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Jean-Christian Kouame [Wed, 25 May 2016 18:34:27 +0000 (14:34 -0400)]
tmf.xml: Delete existing supplementary files when importing xml analysis
Previously, if we import a file that was previously loaded once, traces
won't be notified that the file changed.
Now, if the file already exist, the supplementary files for the analysis
are deleted and the related traces are closed.
Change-Id: I62ce6e6f4295db5f0c82e4c77ae73b4e5a4c1b85
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73648
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Jean-Christian Kouame [Mon, 9 May 2016 14:57:22 +0000 (10:57 -0400)]
doc : Introduce the data driven XML pattern documentation
Change-Id: Ib00876610f4b93000a3968b20487077fdebe47a1
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72304
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Tue, 10 May 2016 02:45:23 +0000 (22:45 -0400)]
linux.swtbot: Add basic critical flow view test.
This tests runs a true integration test with the control flow view.
It signals the critical path view from a right click on the cfv.
Change-Id: Icc04e03de0b745eb966bb711494eab749b8b08c6
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72360
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Gabriel-Andrew Pollo-Guilbert [Mon, 30 May 2016 19:48:49 +0000 (15:48 -0400)] 
analysis.lami: remove unused font height for error labels
The method setHeight() does not modify the reciever. Thus,
the size of the error label didn't change.
Change-Id: I1cb656429d5a45dff310c8f6fe94aa99760b92fa
Signed-off-by: Gabriel-Andrew Pollo-Guilbert <gabrielpolloguilbert@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73981
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Wassim [Wed, 25 May 2016 21:36:26 +0000 (17:36 -0400)]
pcap.core: making some classes final
This patch is to make some classes final in pcap.core component.
It should be final to improve readability and since you should never extend
it. It also allows the jvm to inline methods and improve performance.
Change-Id: I7288b25324cb343a33cf6536b80cdaae3619211f
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73671
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Wassim [Fri, 27 May 2016 00:30:16 +0000 (20:30 -0400)]
ctf.core: making some classes final
This patch is to make some classes final in ctf.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve performance.
Change-Id: I6e9bef701898716978c6e7b4b20254eabc8cd6c8
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73771
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Wassim [Mon, 30 May 2016 18:37:49 +0000 (14:37 -0400)]
ust.core: making some classes final
This patch is to make some classes final in ust.core component.
It should be final to improve readability and since you should never
extend it. It also allows the jvm to inline methods and improve
performance.
Change-Id: Ifa5d1e667efb3e18f5cd4a9037082469574c16c6
Signed-off-by: Wassim <wassim.nasrallah.36@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73972
Reviewed-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Jonathan Rajotte [Tue, 10 May 2016 22:42:14 +0000 (18:42 -0400)]
analysis.lami: correctly handle Number (double, long etc.) type graphing
LTTng analysis return mostly long values either for the time stamps or
actual measurements. SWTChart, on the other hand, deals only with
"double" numerical values. Casting long to double causes a loss of
precision for big long value (e.g time stamps).
E.g: Loss of precision occurs when time ranges with a big minimal value
(2^62) but with little delta (1 ns) between events exist. Graphs
generated from such time ranges as an axis would result in a single dot
which is a clear problem.
The presented solution uses linear mapping to preserve resolution and
precision when possible.
The linear mapping requires two ranges: the internal range and the
external range.
Each graph is responsible to provide an internal LamiGraphRange. This
range is the internal representation in double in which all raw
(external) value are to be mapped. For now the default internal range is
0 to 1.
The external range [raw values range] is generated by finding the
minimal value and maximal values of aspects to be plotted.
Each point is then mapped to a corresponding value from the internal
range:
eV = external value
eR = external range
iV = internal value
iR = internal range
iV = (( eV - eR.minimum ) * ( iR.delta / eR.delta )) + iR.minimum
Since the default internal range is from 0 to 1 all raw values are
mapped to a value from 0 to 1.
On graph tick generation axis formatter transforms internal
representation to external representation and formats the result.
Other change:
- Aspects now return their numerical values via resolveNumber to ensure
no casting is done.
- Move axis formatter to ui plugin.
Bug: 493941
Change-Id: I289180e10a7f1cbf6ecdd1beba93549b8fbe4c23
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/73239
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Patrick Tasse [Tue, 31 May 2016 17:58:10 +0000 (13:58 -0400)]
tmf: Bug 495054: Importing or exporting custom parsers fails silently
When importing custom parsers from a file that does not contain any
custom parser definition, a message dialog is shown to the user.
When exporting a custom parser to an existing file that is not a valid
custom parser definition file, a message is logged to the Error Log.
Change-Id: I2f0bb781d9d43d8bbaf05da2b7ec06c2a65d47d3
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/74094
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Tue, 31 May 2016 00:19:22 +0000 (20:19 -0400)]
tmf.ui: [bug 494974] Fix left panel click handling in timegraph in Linux
Clicking on the left panel in Linux currently deselects the
entry. This behavior is particularly egregious in the case of
UI unit tests.
Change-Id: I18fbe001c6b7325c6618e46c22f13ad976357abe
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73998
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Mon, 30 May 2016 18:52:44 +0000 (14:52 -0400)]
tmf: Bug 494767: Events in selection not updated in Statistics view
- Make sure the time range created from TmfSelectionRangeUpdatedSignal
always has the earliest time as start time.
- If the events per type map is empty for a time range stats update,
reset all time range event counts.
Change-Id: I2c860bdd0dd9e033933c690f230aaf79e6f60b5e
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73973
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Mon, 30 May 2016 15:17:41 +0000 (11:17 -0400)]
tmf: Bug 494790: Time Chart view does not update when adding bookmarks
The Time Chart view now properly shows the bookmark decorations.
Change-Id: I5e25171f61afea79fdd0e2206ef3254731ecb497
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73956
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Mon, 30 May 2016 14:49:17 +0000 (10:49 -0400)]
tmf: Bug 494589: Event table loses focus when pressing Ctrl+Enter or Esc
This gives back focus to the table after pressing Ctrl+Enter or Esc from
a header row cell editor.
Change-Id: I85fe91739a0b4422de3168dd9ea2fbb197853a6b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73953
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Tue, 31 May 2016 13:21:13 +0000 (09:21 -0400)]
critical path: bug 495020 fix statistics when reopening a trace
Change-Id: Ie67aec3a9ea5c114dd7005817da76daf9b764d5e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/74043
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Geneviève Bastien [Fri, 20 May 2016 20:10:09 +0000 (16:10 -0400)]
critical path: bug 490086 Set start/end time for the trace
Previously, the start and end times of the critical path were set when building
the entries list for each critical path. Each worker had different start/end
times, different from the trace's and when getting a previously calculated
critical path, it would not reset the start/end time so the results were not
displayed correctly.
This patch sets the start and end time of the critical path view with the data
from the main execution graph, not the current worker's critical path.
It also gets the previously computed statistics in the content provider instead
of the analysis start.
Change-Id: I7c08f7776b375b033575bc56c51d1cff36b72068
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73513
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Geneviève Bastien [Fri, 20 May 2016 17:44:46 +0000 (13:44 -0400)]
critical path: bug 494196 reset selection when trace selected
This resets the selection in the parameter provider so that if a thread is
selected again in the control flow view, the selection change is triggered
again.
Change-Id: I92f4203d0181f996efcbc2618c32d35311761003
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73318
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Tue, 24 May 2016 17:37:51 +0000 (13:37 -0400)]
critical path: bug 490085 Always start critical path from head vertex
Previously, the critical path was calculated starting at the start of the
window range, but that behavior was not intuitive to the user and it was not
possible to change that window range once it is calculated.
Now the critical path is calculated for the whole of the worker's lifetime.
Change-Id: Id76192eec04dff6d3c45c1bd1314248d4ea991fb
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/73515
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Thu, 26 May 2016 18:46:33 +0000 (14:46 -0400)]
tmf: Bug 494689: fix failing name conflict handling in trace import
This patch also adds test cases for RENAME_ALL and OVERWRITE_ALL in
the corresponding SWTBot test class.
It also fixes the test cases when overwriting existing resources
without confirmation.
Change-Id: I7b4a7779091d824502ea15a18573f162304d143b
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73759
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Jean-Christian Kouame [Thu, 21 Apr 2016 14:49:37 +0000 (10:49 -0400)]
tmf: Add getDocumentFromFile() to XmlUtils
Change-Id: I318607d8043e6b1925734fff51642d2274b88336
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71783
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Sonia Farrah [Wed, 4 May 2016 19:56:57 +0000 (15:56 -0400)]
tmf: Remove toString on string objects
Change-Id: I87bfd0f41dc50cde994e5d5bed1cf221a6477c05
Signed-off-by: Sonia Farrah <sonia.farrah@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72086
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 30 May 2016 13:44:01 +0000 (09:44 -0400)]
tmf: add sorter to put analysis in a more user-friendly order
fixes bug 494923
Change-Id: I484a731662143591a6e2bddd31c400ea6d0244b7
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73940
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Matthew Khouzam [Wed, 18 May 2016 15:19:28 +0000 (11:19 -0400)]
timing.core: Make ArrayList use the array of segments if possible
Bulk load arrays if possible to speed up the serialized segment store.
Change-Id: I55a389419b7fe3182ee3d0fae90c16d9c6bab5a2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73061
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Thu, 19 May 2016 20:21:44 +0000 (16:21 -0400)]
tmf: Bug 494077: Closing AbstractTimeGraphView should cancel its threads
Change-Id: I6eafdb015e1d5f03def8b692964032b1ce00255f
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/73234
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Hudson CI
Geneviève Bastien [Wed, 4 May 2016 19:55:00 +0000 (15:55 -0400)]
xml: Replace a checkNotNull by a message when state undefined
An error in the XML where the next state defined by the user was undefined
would throw a NullPointerException and make the analysis fail ungracefully.
This logs a message to the user (we still need a way to have debug data on the
XML)
This is one step in solving bug 493155
Change-Id: I53edc74c6e9abcf531df07d17d7fa488c52e9155
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72080
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Fri, 13 May 2016 18:39:28 +0000 (14:39 -0400)]
critical path: bug 489360 Build the critical path in a separate thread
The critical path content provider was waiting for the analysis to be completed
but this often happens in the main thread and the first time, it is the whole
graph that needs to be computed and that can block the main thread for a while.
This patch uses a separate build thread when the input is changed so it does
not block anymore.
Change-Id: I9cb99c0d93524961c5f8b45ada59d8a02db49bb0
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72759
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Tue, 17 May 2016 21:16:18 +0000 (17:16 -0400)]
tmf: bug 493661 Return analyses who apply to experiment
When the requested traceclass is TmfExperiment, the analysis who have
appliesExperiment set to true will be returned.
Change-Id: Icfc3201029d8b04237287c693f8cbe1708827b56
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/72984
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 20 Apr 2016 22:23:37 +0000 (18:23 -0400)]
linux.ui: make Kernel Memory view handle out of range requests
This is a common use case with experiments that have multiple nodes
Change-Id: I3a2bcd583473cb9bd9fa6f5a2d69eecb9e4fb291
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/71105
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Mon, 16 May 2016 23:11:49 +0000 (19:11 -0400)]
linux.ui: make CPU usage view support experiments with kernels.
Time queries now clamped to the range of the state system.
Change-Id: Ifa4750bbfe57d5e2df34cc418553644d3891c377
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72855
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Thu, 26 May 2016 02:39:09 +0000 (22:39 -0400)]
lami: add NLS to Exception message
Change-Id: I8bc41b9590d9955eb87f4f36417c0ff317b07f1e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73687
Reviewed-by: Hudson CI
Reviewed-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Jean-Christian Kouame [Fri, 20 May 2016 15:22:27 +0000 (11:22 -0400)]
tmf: fix bug 489217. Use of ArrayListStore instead of TreeMapStore
Use of ArrayListStore instead of TreeMapStore for the pattern analysis
Change-Id: Ie247297936a4cf89b8bdf7b53b48625ce3cf34cd
Signed-off-by: Jean-Christian Kouame <jean-christian.kouame@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73306
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Wed, 18 May 2016 00:44:05 +0000 (20:44 -0400)]
linux.core: Intern SystemCall name string
This patch makes SystemCall mutable.
This is a tricky situation. This object is serializable.
In order to internalize the string (name) the object needs
to have a custom readObject().
This means we need to either make the name field mutable or
use reflexion to make the field modifyable. If we are using
reflexion, the point of making an object immutable is moot.
Here are the main reasons for an immutable object:
* immutable objects are simpler to construct, test, and use
* truly immutable objects are always thread-safe
* they help to avoid temporal coupling
* their usage is side-effect free (no defensive copies)
* identity mutability problem is avoided
* they always have failure atomicity
* they are much easier to cache
* they prevent NULL references, which are bad
As SystemCall has no setters, and the class is now final,
its fields are in practice immutable.
This begs the question though, would having no "final" keyword
on a field affect performance. Unfortunately no. Final classes
can be inlined, but final fields yield no advantage other than
code clarity.
We should still strive to have final fields whenever it is
possible, but this should not cause ideological objections,
as it breaks clean serialization.
This partially addresses bug 489217
Change-Id: I80a99128dffebe1fb3c0561ab76beabea2cc7775
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72995
Reviewed-by: Hudson CI
Bernd Hufmann [Wed, 25 May 2016 11:26:44 +0000 (07:26 -0400)]
releng: Update targets for Neon RC2
Change-Id: I5050420978f8b3e69e55a6ad7cb7f4586eae00c2
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73581
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Sat, 12 Dec 2015 13:31:09 +0000 (08:31 -0500)]
analysis: add Latency Statistics UI test
This tests the total, the number of distinct syscalls
and tests some random nodes.
Change-Id: Ied0aab3958b75de20eb2368d0beafb1c123c6987
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/62555
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Patrick Tasse [Tue, 17 May 2016 13:10:23 +0000 (09:10 -0400)]
tmf: Bug 494197: Empty event list for CallStackEntry when no process
The three-level deep loop to populate the event list from the build
thread did not reach the third level if a trace did not have processes
or threads. The loops are replaced with a recursive consumer.
Change-Id: Ie7eebb57f562bad0c6620ae08fcde8b585c52ca9
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/72916
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Sat, 9 Apr 2016 21:33:27 +0000 (17:33 -0400)]
ctf: Add test for 8-byte integer sign extension bug
The added test highlights bug 491382.
Change-Id: I1e9c1f458ef64145e4f4a6dc9d9b6c0521b1065d
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/70312
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Fri, 13 May 2016 03:25:12 +0000 (23:25 -0400)]
ctf: fix bug 491382. Properly display bytefields
Display byte arrays as signed or unsigned and
thus properly sign extend them.
Note: the order or precendence for Integer Arrays is:
* Strings
* Byte Arrays
* Other Ints
Change-Id: I6d9537f4866648094f20419de87a64478c17e2c9
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/72672
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Alexandre Montplaisir [Wed, 4 May 2016 21:23:12 +0000 (17:23 -0400)]
analysis.lami: Replace OnDemandAnalysisException with CoreException
We may want to pass additional information to the exceptions thrown
when a LAMI analysis does not complete succesfully, like what
type of error should be displayed.
CoreException and IStatus are made exactly for that, and they hook
nicely into ErrorMessage to display, for example, a command-line
stderr output as additional Details in the dialog.
That way, a message like "no results returned" won't look like
a scary error.
Bug: 493941
Change-Id: Id3e6711ac410c3d993b4928a350dc1bdbcf89f5a
Signed-off-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72242
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Wed, 18 May 2016 19:56:37 +0000 (15:56 -0400)]
Revert "TMF: Fix behavior of XML time graph views with experiments"
This reverts commit
836d7c77cd2daccf7107d52e6e4bb78891a6ecb3.
The code was no longer needed as the experiments now give their
children's analyses.
Bug 494052
Change-Id: Id4c1d6757733938c67a5dd65827a6e09f30dbdc2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73090
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Jonathan Rajotte [Wed, 4 May 2016 21:50:19 +0000 (17:50 -0400)]
analysis.lami: Correctly set axis name if it is defined by one aspect
Bug: 493941
Change-Id: Idc91ef8ff923b1e569ff7e4823ef84c1f94f38b1
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72246
Reviewed-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Jonathan Rajotte [Wed, 4 May 2016 20:49:20 +0000 (16:49 -0400)]
analysis.lami: Fix timestamp label not showing on Y axis
The fix is the same as the custom label since it is the same
problem. Put tick angle to 1.
Bug: 493941
Change-Id: I8b302a24474d47dd3c899d0e05e452cec5663cba
Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Reviewed-on: https://git.eclipse.org/r/72245
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@efficios.com>
Matthew Khouzam [Thu, 19 May 2016 19:37:41 +0000 (15:37 -0400)]
linux.core: fix break in build.
Syscall analysis was internalized before the patch was approved.
Change-Id: I254660d5fa28354d4e5f58c84fea39364077c047
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73225
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Marc-Andre Laperle [Wed, 18 May 2016 21:23:37 +0000 (17:23 -0400)]
releng: Update targets for Neon RC1
launchbar doesn't have a RC1, only M7.
Change-Id: I8d96a17195439797ffad96bf2c822e7d9ca2b39e
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/73098
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
This page took 0.047257 seconds and 5 git commands to generate.
projects / deliverable / tracecompass.git / log
