Simon Marchi [Thu, 11 Dec 2014 20:08:39 +0000 (15:08 -0500)]
Implement TmfRangeSynchSignal toString
I found it sad that TmfTimeSynchSignal had its toString but not
TmfRangeSynchSignal. This commit fixes the injustice.
Example of the result:
TmfRangeSynchSignal [source=\
org.eclipse.tracecompass.tmf.ui.views.histogram.HistogramView@
3a7b058e, \
range=TmfTimeRange [fStartTime=03:02:54.940 166 462, \
fEndTime=03:02:54.977 325 374]]
Change-Id: Ic3accae7610e454736497251c170fbdecb9b83fb
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/38067
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Thu, 11 Dec 2014 16:40:33 +0000 (11:40 -0500)]
Remove unintentional dependency to CTF in TMF feature
Change-Id: Iad0b96e142410072e2758e07035b97fa459e9dfa
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/38059
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Thu, 11 Dec 2014 14:55:38 +0000 (09:55 -0500)]
tmf: Fold ITimeEvent2 into ITimeEvent
Also split the one method in ITimeEvent2 into two separate ones,
since the Pair object was never used, so we can return the two
separate values directly.
Change-Id: Ia711b9cacf803b3afab1982a831478aef0bc38e1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/38039
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Thu, 11 Dec 2014 15:47:53 +0000 (10:47 -0500)]
tmf: Synchronize on a class literal, not on this.getClass()
Change-Id: I4612e842d8494d651c37bc77b4109f03dba4056a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/38051
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Tue, 2 Dec 2014 13:58:28 +0000 (08:58 -0500)]
common: Add utility class for non-null things
These utility methods should help avoid the crufty
@SuppressWarnings("null")
@NonNull ret = ...;
return ret;
pattern we had been using so far.
Change-Id: I8c1aa8469dc466a1b42aae799b24789dc23837cf
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37516
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Wed, 2 Apr 2014 20:11:16 +0000 (16:11 -0400)]
tmf: Update TmfExperiment to new API in ITmfEventProvider
Change-Id: I3ab5f0c8c731921674e693622e5c92265a165ae9
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35970
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Mon, 17 Mar 2014 01:49:38 +0000 (21:49 -0400)]
tmf: only dispatch events to relevant event providers
When coalescing request across event providers (e.g. Experiment and
traces) then the requests done on the traces are not interested
in events from other requests. Before this patch each implementation
of handleData() had to do this.
Change-Id: I1482c79ef3a0359b9b3526212c4555b57c102650
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35969
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Fri, 14 Mar 2014 01:59:40 +0000 (21:59 -0400)]
tmf: add JUnits for coalescing across parent/children providers
Change-Id: I5cbb5a3784962048df5c251cf76912ba1dd6c847
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35968
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 11 Mar 2014 11:44:34 +0000 (07:44 -0400)]
tmf: coalescing across event providers
Change-Id: I971854ba0f062acc0a3480bba90b02ee42082131
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35967
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 11 Mar 2014 20:02:48 +0000 (16:02 -0400)]
tmf: update TmfTraceManager for new API in ITmfEventProvider
Change-Id: I98ff0a37290be4dae1de63ec852beb3d170edd8f
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35966
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 11 Mar 2014 14:09:24 +0000 (10:09 -0400)]
tmf: Add parent/child API to the ITmfEventProvider interface
Change-Id: I2fec1da979033454552c45b52e4e2e3153295cd0
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35965
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 8 Dec 2014 21:10:55 +0000 (16:10 -0500)]
tmf: Fix possible concurrency issue with event request IDs
Protect accesses to the static field with a static lock, to make sure
that all requests really have different IDs. Now that coalesced
requests are put in a Set, the IDs matter.
Change-Id: Iccb226aa6969c8150e0c8cc506b8c68a94e902ee
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37759
Reviewed-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 9 Dec 2014 20:20:18 +0000 (15:20 -0500)]
Re-enable the "unused method paramater" error
Revert of commit
a6503a11.
Now that bug 439750 was fixed, and a new separate "unused exception parameter"
compiler option was added, we can re-enable the previously-used setting of
"unused method parameters".
This should not break existing 4.4 installations, since the old option didn't
check for exception paramaters at all. Only requirement would be for 4.5 users
to update to the latest integration build.
Only one such error slipped in while the option was disabled, which is honestly
not that bad!
Change-Id: I9d14daea3f004ed000ab9f9b72e46b5954579a8d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37892
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 8 Dec 2014 21:38:29 +0000 (16:38 -0500)]
Add BTF feature to update site and RCP
Change-Id: Ia1770a3d35e6bd592f8dc8063b951a4375e4de2b
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37761
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Hudson CI
Alexandre Montplaisir [Tue, 9 Dec 2014 03:11:30 +0000 (22:11 -0500)]
rcp: Avoid deleting the index.php on the server
Only include the tar.gz and zip files, which should cover only
the RCP archives.
Change-Id: I39a635da606265f311fe23de2e52a8d5f2bbb962
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37782
Reviewed-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Marc-Andre Laperle [Mon, 8 Dec 2014 03:52:07 +0000 (22:52 -0500)]
tmf: Fix supplementary files always being imported in trace package
Change-Id: Ia7cb4f8434e1221c9a4c1e49e9ce49895a8ec0e1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37765
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Marc-Andre Laperle [Mon, 8 Dec 2014 03:34:46 +0000 (22:34 -0500)]
Add utility method to open a trace in the editor using SWTBot only
Change-Id: Ia98e7c029b46fdae4489e24ddfc0ee8c41963eb3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37715
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37764
Reviewed-by: Hudson CI
Alexandre Montplaisir [Mon, 8 Dec 2014 21:22:41 +0000 (16:22 -0500)]
Delete extra "linuxtools" image
A o.e.linuxtools plugin sneaked its way into the tree in
80f680b!
The exact same picture is already part of the corresponding tracecompass
plugin, so we can safely delete it.
Change-Id: I45ce43ffd3395aeb0cefa7318c0c953ccb4f5fde
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37760
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 4 Dec 2014 00:07:13 +0000 (19:07 -0500)]
common: Add a new "common" plugin for shared functionality
More and more we're seeing functionality and utils classes duplicated
across plugins. It's making sense to have a central, common plugin that
everybody else can depend on.
Change-Id: I8d98518acb81c43766d1782432180a1eb7a5e12f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37617
Reviewed-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Mon, 8 Dec 2014 19:04:15 +0000 (14:04 -0500)]
tmf: Remove whitespaces in tmf.core/about.html
This plugin is often used as a template when creating new ones, we
should stop copy-pasting those whitespaces!
Change-Id: I382b1a6e75f72dbf144567bf9f39a54ed5fc28db
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37756
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Hudson CI
Bernd Hufmann [Sat, 6 Dec 2014 01:58:53 +0000 (20:58 -0500)]
tmf.ui: fix callsite and model lookup regression
The notion of ITmfCallsite is lost when an event is cached as it is now
an CachedEvent which does not implement ITmfCallsite. This patch checks
if the event is cached, and if so, resolves the parent event to
validate.
Change-Id: I99733958bd1ac797fca32c8b293e709f4ddc3cc5
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37120
Tested-by: Hudson CI
Bernd Hufmann [Fri, 14 Nov 2014 19:19:33 +0000 (14:19 -0500)]
rcp: Add version to splash screen
Change-Id: I00936d216604a8bebd8cc2d4f0c079ea7c31f004
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36514
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 5 Dec 2014 20:23:51 +0000 (15:23 -0500)]
rcp: Remove the symlinks for the nightly downloads
Turns out symlinks don't work on downloads.eclipse.org, probably
for good reasons, so we'll just upload the archives and display
a PHP page that lists them.
Change-Id: I2e337c84ce50e107bed3f05bcb93ab47b54f82dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37693
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Wed, 26 Nov 2014 23:16:07 +0000 (18:16 -0500)]
tmf: Split off TmfFilterMatchesNode in two
Add new TmfFilterMatchesFieldNode and TmfFilterMatchesAspectNode, which
both extend TmfFilterMatchesNode (which is now abstract). This will allow
using filtering on aspects.
The aspect node is not integrated yet in the Filter View, but it could be
eventually.
Change-Id: I7206c0508eed4fbb16cc22fef97900ca31220328
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37123
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 28 Nov 2014 22:05:16 +0000 (17:05 -0500)]
rcp: Add a "deploy-rcp" profile to deploy nightly RCP builds
This can be added to the Hudson job to put nightly RCP builds
on download.eclipse.org.
It can be used locally (by overriding 'rcpDestination') but is not
of much use since it doesn't do much more than just copying files.
So I don't think it's worth documenting in the README.
Change-Id: Ic5db3f2fad8f9baec0e96b5d6c041ac09bd8ad9c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37309
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Wed, 3 Dec 2014 18:25:47 +0000 (13:25 -0500)]
tmf.ui: convert long list of catches to a multi-catch
Change-Id: Ifc29e2d334fa940aa165dd461fbd9c3ff7d5bc8a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37514
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Markus Schorn [Fri, 28 Nov 2014 10:20:01 +0000 (11:20 +0100)]
Bug 453499: Allow for programmatically adding a connection to the
Control UI
Change-Id: I0b0dab26c455c371d7fab8fb0aaedf2f4401c19d
Signed-off-by: Markus Schorn <markus.schorn@windriver.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37481
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Matthew Khouzam [Mon, 1 Dec 2014 19:51:53 +0000 (14:51 -0500)]
ctf: Support changing endianness of a trace, fix bug 453673
The issue is that IOStructGen assumed the endianness of a trace did
not change half way through the tsdl file. Now the elements are progressively
loaded and thus the endinanness is updated as need be.
Change-Id: I8cefbf2f1a841a1decb0722b50cd9ec447bcc2be
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37424
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 2 Dec 2014 11:58:50 +0000 (06:58 -0500)]
tmf: Use full attribute path for default state system aspect names
The full path is much more informative than only the "basename", and
is much less likely to clash if many aspects are created for the
same state system.
Change-Id: Id0ce0cbc598ec0c59301316621c5450bfa8fb924
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37515
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 3 Dec 2014 20:04:22 +0000 (15:04 -0500)]
TMF: Change some constant names to comply with a naming convention
Change-Id: If742b4c47aa421991c53dac17d103f9b81c60f8b
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/37519
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Geneviève Bastien [Wed, 29 Oct 2014 17:06:08 +0000 (13:06 -0400)]
lttng: Add unit tests for the CPU usage analysis
The unit tests make use of the XML development trace.
Also correct the fact that a process that hasn't run yet started at -1 instead
of 0. There probably was a reason in the original implementation, but 0 works
fine now.
Change-Id: I3196155c050db32fd6b954abfd73252c1dc89aa3
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/35647
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Mon, 1 Dec 2014 16:32:02 +0000 (11:32 -0500)]
TMF: Change timestamps scale of TmfXmlTraceStub to nanoseconds
The reason is wasn't so before is that custom XML traces did not support that
input format, but we can convert manually.
Change-Id: I25f1fa1f8a5ad874f87bccfdbe35a883820fbe45
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/37419
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Thu, 20 Nov 2014 18:47:14 +0000 (13:47 -0500)]
TMF: Add support of aspects to TmfXmlStubTrace
Change-Id: Id729a9284477a44fd1e142e6fd19e3bad3b1894a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36803
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Wed, 12 Nov 2014 23:37:24 +0000 (18:37 -0500)]
tmf: Add a "Trace" Event Table column for experiments
Also reworked some internal methods in TmfEventsEditor to not return
a table object directly, but rather just a set of event aspects.
This way we can add this "Trace" column only for experiments.
Change-Id: I21536cd11da28f30b1f822a495cd06a4d922064c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37122
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 27 Nov 2014 23:52:26 +0000 (18:52 -0500)]
rcp: Update picture for the About window
Change-Id: I1c2d27c4c0f4d6b84d10c8f801b093ad9ac3b6fc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37219
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Fri, 21 Nov 2014 20:15:33 +0000 (15:15 -0500)]
TMF: Add some @NonNull annotations to the AbstractTimeGraphView
Change-Id: I772295648eabab3ec3aec16365989478c32e7eff
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/35845
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 5 Nov 2014 17:05:31 +0000 (12:05 -0500)]
TMF: Add a request log message when a request is sent to a provider
Change-Id: Ie2afa3ab84bf393a7de2a6fe46fcee50181b4ac1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/35977
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 2 Jul 2014 19:23:59 +0000 (15:23 -0400)]
TMF: Change event matching key from a list to a plain old java object
This improves performance of the event matching and trace synchronization
Change-Id: Ib8fcb3152e3907d1218bc568bc51f77d7c32c1a1
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36668
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Mon, 3 Nov 2014 20:35:06 +0000 (15:35 -0500)]
tmf xml: Add a few package-info to tmf.analysis.xml.core.model.*
To add NonNullByDefault to classes of the XML model
Change-Id: Ib0e371146aabcc082fcee5d8a61e6b21210abf16
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/35848
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Mon, 1 Dec 2014 22:48:24 +0000 (17:48 -0500)]
tmf: Fix AbstractTracePackageWizardPage tree viewer check integrity
Grayed state did not propagate correctly to parent elements.
Change-Id: I3bab56b7b1d8c1b9906356f8e098e1c6fb006500
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/37432
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Fri, 28 Nov 2014 22:37:11 +0000 (17:37 -0500)]
tmf: Bug 451240: Mouse wheel inactive on time graph scale and scroll bar
- Add a mouse wheel listener to the time graph scale to zoom
- Remove the mouse wheel event filter that was added when time graph
control had focus, and replace it with a listener to prevent horizontal
scrolling on mouse wheel events.
Change-Id: Ib2bb917a8e447929843117e9cf55eadac3ed7e6d
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/37311
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Tue, 18 Nov 2014 20:51:39 +0000 (15:51 -0500)]
TMF: Remove dependency to CtfTmfTrace for TCP event match definitions
And move them out of the API to internal.
Change-Id: I7e0140f0fa6bf68cf741607077b28475f8ad9f67
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36671
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Thu, 30 Oct 2014 12:38:22 +0000 (08:38 -0400)]
lttng-control: fix enable events when filtering in tree (bug 450526)
Change-Id: Ie5f79499fd83131e83067c7a33f54f185f2e1100
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36409
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Markus Schorn [Mon, 24 Nov 2014 08:20:59 +0000 (09:20 +0100)]
Bug 448058: Update lttng user documentation: Using Remote Services
instead of RSE
Change-Id: I2e9e7682ed611d25ff1a463b4460ac93c2915212
Signed-off-by: Markus Schorn <markus.schorn@windriver.com>
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37114
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 14 Nov 2014 19:31:51 +0000 (14:31 -0500)]
tmf: Execute TmfEventTable's request handler only on success
The handler for the TmfTimeSynchSignal in TmfEventsTable sends an event
request to "position" the experiment to the correct timestamp/event. This
request executes a seek() on the experiment itself, and is located in the
handleCompleted() callback.
It should be moved to the handleSuccess() callback instead: this
repositioning of the experiment should only be done when the request
finishes succesfully. It should not be run if the request was cancelled,
for example because the executor was flooded with requests and cancelled
some of them.
Partial fix for bug 451615.
Change-Id: I905bb5d19aa0fe40f9d63bfd2e4f60d90aba3050
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36517
Tested-by: Hudson CI
Geneviève Bastien [Wed, 19 Nov 2014 15:59:30 +0000 (10:59 -0500)]
lttng: Remove dependency to CtfTmfEvent in analyses
Change-Id: I944f49f1bf8d2b9cb3933a3a20c0d4a86d806ae9
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36704
Tested-by: Hudson CI
Geneviève Bastien [Fri, 28 Nov 2014 15:49:58 +0000 (10:49 -0500)]
TMF: Change the return type of the CPU aspect to Integer
Change-Id: I8f58d1d72b9ae984d0833d3f15af9793d4d2057f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/37290
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Marc-Andre Laperle [Mon, 24 Nov 2014 16:28:09 +0000 (11:28 -0500)]
Upgrade to Tycho 0.22
Change-Id: Id5bd57f9dd1197ac6ecbae7720fc18b4e981f73c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36944
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 14 Nov 2014 17:30:14 +0000 (12:30 -0500)]
tmf: Use a CountDownLatch instead of Object.wait() in TmfEventThread
The current way to manage paused requests in TmfEventThread uses
a wait()/notify() on a custom Object. Since this object is not used
for anything else, we can replace its with a CountDownLatch, which
does the same thing without requiring an additional synchronized lock.
Change-Id: Ie69612769e3554d6e71d030230b409d8a0145450
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36516
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Fri, 7 Nov 2014 23:27:28 +0000 (18:27 -0500)]
ctf: test reading all downloaded traces once
Change-Id: I28e5feef958ab974f411d43ee6e98ed74ac0ca9b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36179
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 21 Nov 2014 02:02:50 +0000 (21:02 -0500)]
tmf: Make ITmfTrace.getEventAspects() @NonNull
It's easier to deal with empty collections than dealing with
null/non-null references (for Collection.addAll() and such).
Change-Id: I9e8d0091e099027b5da0c15881b73130b4ef2e9d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37121
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Hudson CI
Matthew Khouzam [Wed, 26 Nov 2014 06:52:19 +0000 (01:52 -0500)]
ss: remove e.printStackTrace()s from HT_IO
Change-Id: Ieab2def800f88e50548d8f94b1a39c41e401247c
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37047
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 12 Nov 2014 18:42:53 +0000 (13:42 -0500)]
tmf.analysis: Restore the "getCPU" for data-driven analyses
XML data-driven analyses used to use ITmfEvent.getSource() to get
the event's CPU. This was misleading, because trace types were free
to define "source" as something other than CPUs.
Now instead use a CpuAspect to get the CPU of an event. This
should restore support for getting the CPU of CTF traces, as it
did before.
Also added a new method to TmfTraceUtils to get the aspects matching
a specific class. The analysis modules will make use of this to get
the "cpu" aspects.
Change-Id: I88437b4a419e81aef36f2aa5298ff54f87242b23
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36366
Tested-by: Hudson CI
Matthew Khouzam [Fri, 7 Nov 2014 22:39:49 +0000 (17:39 -0500)]
ctf: add trace to test ctf
this trace is the one from bug 446190, it contains headers that are 64 bit aligned.
Change-Id: I1ee228ee4f0635b940032f14bf6a080dc8a5c8f2
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36178
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 7 Nov 2014 19:40:45 +0000 (14:40 -0500)]
ctf: make uint_5t and 27t aligned on 1 bit
Change-Id: Idb8d1c96fcf64929f8b49af47910b49e86c2e0c3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36162
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 27 Nov 2014 22:50:20 +0000 (17:50 -0500)]
tmf: Add a TmfTraceUtils class for advanced getter methods
For instance, the various getModuleFromClass() methods should not
be part of the base interface, the trace should only expose a basic
getter. The more fancy functions can however be implemented in a
separate utility class.
Change-Id: I8d957971abfbcc7e3afe81f5db2dba43cbebe84d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37218
Tested-by: Hudson CI
Matthew Khouzam [Fri, 7 Nov 2014 19:30:13 +0000 (14:30 -0500)]
ctf: improve testing of EventHeaderDeclaration
Add more subtle test cases
Change-Id: I5a61426a9f4358af522c84de5ae4a8a4ca0e773e
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36161
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 28 Nov 2014 20:42:26 +0000 (15:42 -0500)]
ctf: add test coverage
Change-Id: I405cded362e408fe50e1871143ba5e07069a62d3
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36160
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 7 Nov 2014 18:52:16 +0000 (13:52 -0500)]
ctf: add isBinaryEquivalent() to IDeclaration
This makes EventHeader substitutions more reliable.
Fixes bug 446190
Change-Id: I06f8c0fc99b6a9d07377d57198985d39fb63bc9b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/35984
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Wed, 19 Nov 2014 22:29:28 +0000 (17:29 -0500)]
rcp: Change workspace directory to .tracecompass
This was supposed to be part of the big patchset of renames,
but got lost somehow.
Also updated the PLUGIN_ID while at it.
Change-Id: I05664f5697fd655b250884a4ed3e985eeed7a2ff
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36726
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Thu, 6 Nov 2014 20:24:16 +0000 (15:24 -0500)]
ctf: add equals and hashcodes to Declarations
Change-Id: I15d8030d2f75979012b87caae4dfc08bbda3ee7a
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36093
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Wed, 26 Nov 2014 08:16:56 +0000 (03:16 -0500)]
tmf.ui: remove duplication in TimeCompressionBar
Change-Id: Ice353af65b57ef71b85082e55fea67a20c61f4af
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37054
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Wed, 5 Nov 2014 20:21:26 +0000 (15:21 -0500)]
TMF: Add automatic execution of module dependencies
Change-Id: I461805133715db09f47293af73e9ef5952797298
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/35991
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Wed, 12 Nov 2014 00:27:45 +0000 (19:27 -0500)]
tmf.ctf: Rework the event aspects of CTF traces
- Move the "channel" aspect from LttngKernel to CtfTmfTrace
(it can apply to any CTF trace).
- Add a CPU aspect for CTF traces.
CTF events know the CPU they were taken on (previously saved in
event.getSource()). Now we can define an aspect to display it
in its own column in the event table.
Change-Id: I603cfd4cc4ca61964ec59ea17293900e7aa1f42a
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36365
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 11 Nov 2014 20:33:28 +0000 (15:33 -0500)]
tmf: Remove the ITmfEventTableColumns extension point
Add a getEventAspects() method in ITmfTrace, which allows trace types
to define which aspects can be relevant for their own events.
This becomes redundant with the ITmfEventTableColumn extension point:
now that we build columns directly from aspects, the TmfEventsEditor
can simply call trace.getEventAspects() instead of reading extension
point data. The trace type is already defined in a core extension point,
so we'll pass the event aspect information through that now.
The combination of careful equals() methods in aspects and the use
of a Set in the TmfEventsEditor will allow "merging" aspects/columns
together, like was already the case.
Change-Id: Ic5b6126a50b1b1fdb4b2d5d23eb6a47a57555594
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36364
Tested-by: Hudson CI
Matthew Khouzam [Fri, 14 Nov 2014 22:30:23 +0000 (17:30 -0500)]
ctf: make Declarations have some NonNull annotations
Change-Id: I2732bad6d7e390223c61fa08af98b3ae649baa79
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36573
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Sebastian Andrzej Siewior [Wed, 26 Nov 2014 17:37:21 +0000 (18:37 +0100)]
LTTng: use tracer_name for perf-CTF traces
Domain will be set to kernel for both, perf and lttng traces. The
tracer_name will be set to perf if the trace is generated by perf and
otherwise lttng-modules if created by thet lttng tool.
Change-Id: I76e0c44efebe8be4e9f3a571884d63b932ac33d3
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37212
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Thu, 20 Nov 2014 21:46:54 +0000 (16:46 -0500)]
TMF: Add an experiment utility class to get data from experiment's traces
Change-Id: Ifbc9e4a773bca227150f136bfcbe2a1410a91de5
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36822
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Thu, 27 Nov 2014 05:19:55 +0000 (00:19 -0500)]
ctf: Correctly handle packet sizes > 2^31 bits
We use long's for packet sizes, so we should be able to handle
those, just need to make sure the value does not get truncated
to Integer.MAX_VALUE (or even worse, becomes negative!)
Change-Id: If3d6d39f765d8baf43297efaed1681473e1ffeaf
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/37129
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Sun, 23 Nov 2014 02:28:50 +0000 (21:28 -0500)]
xml: Remove duplication caused by d2e628
Remove a repeated switch case and create a helper to do this task.
Change-Id: I5ec17a09fd337107cd0e745e3e7d90bb8bba8300
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36936
Tested-by: Hudson CI
Alexandre Montplaisir [Sat, 8 Nov 2014 20:09:36 +0000 (20:09 +0000)]
tmf: Introduce the core concept of event aspects
An "event aspect" is a piece of information that can be extracted,
directly or indirectly, from a trace event. Simple examples could be
timestamp or event fields. But it could also be something indirect,
like a state system request at the timestamp of the given event.
This patch introduces the base ITmfEventAspect interface, some basic
implementations, and simplifies the TmfEventTableColumns to use aspects
instead, since part of it is now redundant.
Fixes bug #451411.
Change-Id: Ib045439d6084a6e6c7c276f1eddccfb13fe01be0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36363
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Wed, 19 Nov 2014 15:45:31 +0000 (10:45 -0500)]
TMF: Call postDrawEvent also for transparent events in time graph control
The color of an event may be transparent, but it may contain data that needs to
be displayed through the postDrawEvent callback, so it should be called before
returning.
Change-Id: Ic672a1aeb781c89b9da2da9670e2b6f4968c3c43
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36702
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Bernd Hufmann [Thu, 18 Sep 2014 14:08:56 +0000 (10:08 -0400)]
rcp: Update Trace Compass RCP branding
Uses the new icons and splash screen.
Happens to fix bug #446385, since we use a splash screen(!)
Change-Id: I3c5cb0f77b00f7c9513ad2161f0185df90a108eb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36500
Tested-by: Hudson CI
Matthew Khouzam [Fri, 21 Nov 2014 22:12:45 +0000 (17:12 -0500)]
tmf.ui clean up CustomXmlTraceDefinition a bit
Change-Id: Ia8c96e588307b892d08f8a5cc8e723f7a723cf53
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36871
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 25 Nov 2014 03:52:08 +0000 (22:52 -0500)]
lttng.control.ui: various cleanup fixes.
Fix empty nested blocks
Fix inner assignments
Fix utility constructor
Fix magic numbers
Try to slightly address complexity
Change-Id: I6f16be7d31d559b2b3f8189bdab5c4c44fded327
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/37013
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Markus Schorn <markus.schorn@windriver.com>
Matthew Khouzam [Fri, 14 Nov 2014 21:25:02 +0000 (16:25 -0500)]
Remove redundant modifiers in Interfaces
Change-Id: Iac7a27f1fa623dd16a8784fad25292356bc16010
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36527
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 12 Nov 2014 16:13:56 +0000 (11:13 -0500)]
TMF: Add some XML basic test cases and fix a bug
A bug where if the previous value was not existent, it was unboxed at -1 while
it should start at 0.
Change-Id: I58fda5925010b675bcab15cf49b69b303e6e9a9e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36344
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 12 Nov 2014 15:21:08 +0000 (10:21 -0500)]
TMF: Rework some test code for XML analysis to make it easier to add test cases
Change-Id: Ica13bc36c1c5312dd588ef87670f435ef01a76f2
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/36343
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Markus Schorn [Wed, 5 Nov 2014 11:31:41 +0000 (12:31 +0100)]
Bug 448058: Replace RSE by org.eclipse.remote
Change-Id: I9ee1b7e572839d66a5bacff8468e7da4dae235b4
Signed-off-by: Markus Schorn <markus.schorn@windriver.com>
Reviewed-on: https://git.eclipse.org/r/36632
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Thu, 6 Nov 2014 19:40:08 +0000 (20:40 +0100)]
tmf: Remove source and reference from ITmfEvent
Those two notions were originally meant to have every trace type give
them a specific meaning, but to have some "common" concepts that
would be shown in the default event table.
Now that we have the possibility to aggregate columns in the event
table from multiple trace types, there is no need for those vague
concepts anymore. Every trace is free to implement and show any
specific item it wants. The base interface should be for the absolute
minimum that is required by the framework.
In fact, the notions of "source" and "reference" already meant different
things for different trace types (the Source of a CTF event was the source
CPU, while the source of a pcap event was the source address). So these
should *not* be aggregated in the same event columns since they do not
represent the same concepts.
Note: For the trace types that did make use of the source and reference
fields, this patch simply adds new fields to those traces, with the
names "source" and "reference" for now. But now that they will be decoupled
from the interface, we will be free to rename them accordingly.
Change-Id: I84f9729edee64233893779ca9c375a0a157bfc84
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36131
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Matthew Khouzam [Thu, 20 Nov 2014 20:30:03 +0000 (15:30 -0500)]
Make colors in SDPrintDialogUI static
Change-Id: I1bf8ebb95bca348884fa7dfe490886208a4afa0d
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36813
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Patrick Tasse [Thu, 30 Oct 2014 17:03:21 +0000 (13:03 -0400)]
tmf: Bug 449206: NullPointerException in HistogramDataModel
- make sure countEvent() isn't interrupted by clear()
- make sure events are not counted after histogram request is cancelled
- fix integer overflow calculating bucket move offset
Change-Id: I9e32032b3efed93a22c69d5cd1e2a99ab5550a11
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/36584
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Fri, 14 Nov 2014 20:58:10 +0000 (15:58 -0500)]
Remove tmf.ui magic numbers
Change-Id: Ia9499f01e3c184b878b19bdfdabb3a265b2a261b
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36525
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Wed, 12 Nov 2014 21:44:40 +0000 (16:44 -0500)]
ctf: make CTFStreamInput no longer autoclosable
This does not hold any resources. A rule of thumb is "if and only if it ends in reader, it is autoclosable"
Change-Id: I5c02a139eeda663f0ef721151cb6cbc4206a0448
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36371
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 18 Nov 2014 19:12:44 +0000 (14:12 -0500)]
CTF: Remove autoclosable from CTFTrace
Metadata is now autoclosable so the trace doesn't have to be.
Change-Id: I376c21f0888d57c55f41e83a15762c786a982b06
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36367
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Tue, 18 Nov 2014 19:02:26 +0000 (14:02 -0500)]
tracecompass: remove duplicate test case
Change-Id: I03a546a5cc1bf436d5dcd5b8883c9ecd1631ab30
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36664
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Fri, 14 Nov 2014 15:54:43 +0000 (10:54 -0500)]
lttng: Fix Resource View for traces without sched_switch events
The Resource View assumes that if the base quark of a resource is
present, the "Status" sub-attribute will always be there. This may
not be the case, for example if the trace does not have sched_switch
events enabled, but has shed_wakeup.
Change-Id: Iaf25cf3d8a5b8ee686281dc3064f241229c2c245
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36492
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Mon, 17 Nov 2014 19:48:00 +0000 (14:48 -0500)]
ctf: Further updates to the CTF-testsuite tests
The stress/metadata/pass directory is now populated with scripts
to generate traces, update the test case accordingly.
Also skip the new regression/stream/pass/integer-large-size test,
we fail it at the moment. Keeps the build working until we can
look into it.
Change-Id: I5b6798de773354dce7abb93d43c649c0ef9fd258
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36596
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Matthew Khouzam [Fri, 14 Nov 2014 20:08:17 +0000 (15:08 -0500)]
Fix magic numbers in BTFTrace
Change-Id: Iea52a720801134faf1ebde2f69ac3c1f6ec71687
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36524
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Sun, 16 Nov 2014 19:54:58 +0000 (14:54 -0500)]
ctf: Update ctf-testsuite test for the new stream stress tests
Won't run anything yet, because the test traces need to be generated
with a Python script. The temerary ones may generate them manually,
then the test suite will run them.
Change-Id: I9db27da958d803eb8b4530ec6fc528d55af85631
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36546
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Sun, 16 Nov 2014 19:46:08 +0000 (14:46 -0500)]
ctf: Port the ctf-testsuite test to java.nio.Files/Path
Allows using some fancy DirectoryStream filter stuff.
Change-Id: I3aeb5259202e8f80da4fefcf6a5efc0c9b153d00
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36545
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Fri, 14 Nov 2014 17:27:42 +0000 (12:27 -0500)]
ctf: Use a ConcurrentHashMap in LexicalScope
The fChildren map in LexicalScope is normally written once, then
read over and over and over by many (possibly concurrent) threads.
For this use case, a ConcurrentHashMap is more appropriate than a
Collections.synchronizedMap(). A synchronized map will require readers
to obtain the lock, while a ConcurrentHashMap won't.
Change-Id: Ib0e826798427e0fc81c70e70aa4211b00a9e55e3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36515
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Matthew Khouzam [Mon, 10 Nov 2014 23:05:00 +0000 (18:05 -0500)]
lttng/live: get last timestamp first
Change-Id: I0c3989ee4a421b0555adc873e44d3771f0a599cc
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36250
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Geneviève Bastien [Wed, 4 Jun 2014 13:55:08 +0000 (09:55 -0400)]
TMF: Synchronize an experiment instead of collection of traces
That will make it compatible with streaming since one full trace does not
have to be read before the others. It will also accelerate the time necessary
to get results, as matches will be found earlier. The overhead of reading the
experiment instead of the traces decreases performance though.
Change-Id: I7c94c21e63781b2cae0faead915be8959170a992
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/35350
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Thu, 30 Oct 2014 16:59:18 +0000 (12:59 -0400)]
tmf: Bug 434646: Control Flow view not cleared when opening UST trace
Change-Id: I691ac18b2c6fb14b3eba5e7719822ecb1fe57698
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/36170
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Fri, 7 Nov 2014 18:21:47 +0000 (13:21 -0500)]
tmf: fix IllegalArgumentException when doing auto-detection
with trace type that doesn't exist (anymore). Since it is determined
during runtime which trace types exists this should not throw
an exception.
Change-Id: I0fa7a01351331b350eb2da85ab9624e96346cb2c
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36228
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Thu, 6 Nov 2014 15:18:13 +0000 (10:18 -0500)]
tmf: add (internal) API for handling name clashes during import
Change-Id: Ice0d488b313f7c3e303e953b80f018f4c906ebf5
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36227
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 12 Nov 2014 22:17:41 +0000 (17:17 -0500)]
tmf: Add missing NonNull import to tmf.ui.tests
Change-Id: Iec621cb9eb70773e71433ebb7498d6329d7842ef
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36374
Tested-by: Hudson CI
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Alexandre Montplaisir [Thu, 6 Nov 2014 16:10:39 +0000 (17:10 +0100)]
tmf: Consolidate constructors in TmfEvent
The default constructor can be used by the ITmfEvent extension
point, so should remain available, but should not be used by
normal code.
Change-Id: Id0e5e6d35d5593852b2a89672efea4fcbcd5b948
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/36130
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Naser Ezzati [Thu, 6 Nov 2014 16:07:27 +0000 (11:07 -0500)]
XML state system: Add "eventName" to the current stateattribute types.
We already have the "eventName" as a type for statevalue, but sometimes we need
it as a valid stateattribute type as well, e.g., in counting the number of each
event type.
Change-Id: Ie699221d71cee1686c6865bcffc3b38a991a0731
Signed-off-by: Naser Ezzati <n.ezzati@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/36059
Tested-by: Hudson CI
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Genevieve Bastien <gbastien+lttng@versatic.net>
This page took 0.044705 seconds and 5 git commands to generate.