Alexandre Montplaisir [Wed, 1 May 2013 15:02:38 +0000 (11:02 -0400)]
tmf: Use the trace manager instead of ITmfTrace.getTraces()
Planned revert of
18991e1, now views can call the trace manager
to get the list of active traces, no matter if it's inside an
experiment or not.
Change-Id: I592de26a5edb4a8b8ed82a4442cb2b59d488f0f1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12424
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 1 May 2013 13:23:10 +0000 (09:23 -0400)]
lttng2: Update lttng2 feature dependency to require RSE feature
The lttng2 feature now requires the feature Remote System Explorer
End-User Runtime (org.eclipse.rse) instead of certain RSE plug-ins.
This causes p2 to automatically install the all necessary RSE
features (e.g. ssh shell) features needed by lttng2. Before this
commit the RSE runtime feature had to be installed manually.
Change-Id: I39dc6baaf161047cbd44b7a87bbd78e8631caad7
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12413
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 30 Apr 2013 19:49:43 +0000 (15:49 -0400)]
Disallow opening of experiments with no traces
This commit considers all 3 open procedures:
- context-sensitive menu
- double-click
- accelerator (CTRL+SHIFT+R)
Change-Id: I3d37155b970425f68208066100dc10d89e65b4eb
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12402
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 29 Apr 2013 15:53:02 +0000 (11:53 -0400)]
tmf: Switch views to the trace manager
Remove getCurrentTime() and getCurrentRange() from ITmfTrace,
and transition its callers to the central trace manager.
Change-Id: Ib5138acb7cd252b40be07d0c0536bc73b60491bd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12354
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Mon, 29 Apr 2013 15:47:15 +0000 (11:47 -0400)]
tmf: Introduce a central trace manager
This manager will track all currently opened traces and their
currently selected timestamps and time ranges.
This will also give both views and *.core analysis plugins
a centralized way to get the current active trace/experiment.
This was not an easy thing to do reliably if you were not an
instance of TmfView.
Basic unit tests are included, more complete tests will be added
later.
Change-Id: Ie0056252908ae8bb9e5da33242c3141665eb161c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12079
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 19 Apr 2013 19:41:31 +0000 (15:41 -0400)]
tmf: Expose the indexTrace() method in the interface
Some trace types could decide to do their indexing manually
and such, so expose the already-existing indexTrace() method
up to the ITmfTrace interface.
Change-Id: I1f9724f3cb20b8bbf19b8a5120cc16155b7de173
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12078
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 30 Apr 2013 17:42:48 +0000 (13:42 -0400)]
tmf: Delete supplementary files when changing trace type
After changing the trace type of a trace the supplementary files
e.g. statistics might have some information that are not
corresponding to the newly selected trace type. By deleting
the supplementary file some stale data will be avoided.
Change-Id: I6672810ea2fa4b363a96f42e26fd8647eba38d71
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12396
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 29 Apr 2013 20:18:22 +0000 (16:18 -0400)]
lttng: Rename CtfKernelTrace to LttngKernelTrace
Change-Id: I8375a32844988e3a1667e3197e112f1ded17a248
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12369
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 26 Apr 2013 21:54:29 +0000 (17:54 -0400)]
tmf: Rename StateSystemManager to TmfStateSystemFactory
After a couple rewrites, this class is now more a factory than
a manager. Now we just need a manager factory...
Change-Id: I22eb4f158e39b1c1ebd86414960e41a3fb8e5707
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12260
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Fri, 26 Apr 2013 21:49:26 +0000 (17:49 -0400)]
tmf: Rename IStateChangeInput to ITmfStateProvider
The nomenclature "state provider" was being used more and more
instead of "state change input", so clarify this before the Kepler
API freeze and use "state provider" everywhere. It just sounds
better anyway.
Change-Id: I88fbc4f8f867754fef41dc35b99a823dbea3683c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12259
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Marc-Andre Laperle [Thu, 25 Apr 2013 21:52:03 +0000 (17:52 -0400)]
Integrate Babeltrace CTF tests and fix parsing problems
Change-Id: I1bde488b99a6e29cfc5bcf4191e00b317d8c737f
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12160
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Thu, 25 Apr 2013 21:05:28 +0000 (17:05 -0400)]
Introduce Call Stack view and state system
Change-Id: I794b6ea9758614e7a595705d9728ca8f5a588975
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12222
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 25 Apr 2013 21:54:02 +0000 (17:54 -0400)]
ctf: Put Antlr-specific exceptions in a separate class
Since CTFReaderException is in the public API, any external
plugin using it would have had to import the antlr-runtime
packages.
By isolating the Antlr-specific stuff in a separate, non-API
class, external plugins can happily continue to use
CTFReaderException without fear of leaking dependencies.
Change-Id: I27cccd60dd0ad1ca51a91c10b067a19b07c24f2e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12224
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Fri, 26 Apr 2013 21:33:50 +0000 (17:33 -0400)]
Update user guide icons
Some icons were converted to PNG but were named with a .gif extension.
On Windows these icons do not display correctly.
Replacing the icons to their original GIF format from the .ui plugin.
Change-Id: If8a9798c3470265609e4a1ebb1e1f57347af0d8a
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12256
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Thu, 25 Apr 2013 21:03:47 +0000 (17:03 -0400)]
Time Graph improvements and bug fixes
- Add NullTimeEvent that inhibits tool tip on mouse hover
- Fix possible ArithmeticException with Zoom In button
- Preserve selected entry in time graph control refresh
- Expose time graph control and scale through time graph viewer API
- Prevent reset of top index on time graph viewer refresh
Change-Id: I438e5848d901656f550ecac0781a44f7148ea919
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12221
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Thu, 25 Apr 2013 20:49:47 +0000 (16:49 -0400)]
Move EventsIterator to timegraph package
Change-Id: I83df2ca0a9a5f74be8814e3c204b5a871629d500
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/12220
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
Alexandre Montplaisir [Fri, 26 Apr 2013 19:50:14 +0000 (15:50 -0400)]
tmf: Remove the serialization logic from TmfStateValue
Serializing the state values is the history backend's job (as in,
each backend could do it differently). Move the existing logic
to HTInterval.
This also fixes a very bad bug where the stringsEntrySize of intervals
containing a Long state value would be incorrectly reported as 0.
This would mean that nodes could try inserting a value that wouldn't
fit, which would end up corrupting the interval data.
Change-Id: I6c54ef905b45b06b69ed21ce59c70d2eaa16b7f8
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12254
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 26 Apr 2013 17:57:48 +0000 (13:57 -0400)]
tmf: Remove ITmfStateSystem#isLastAttribute()
This method was meant to be used as a kind of
"wasThisAttributeJustCreated()". But, if no new attrbiutes are
created, the last attribute would still return true, even if
it has been existing for a while!
So remove this potentially confusing method from the API
completely.
Change-Id: I8ac873ba18193e875806d4645e03dd228acd846c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12250
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 26 Apr 2013 17:52:37 +0000 (13:52 -0400)]
tmf: Insert null values for newly-created attributes
Instead of requiring every state provider to explicitely insert
a value when creating a new attribute, we can have the attribute
tree do it for them. Then, if the provider wants to set it to
something else, it's just changing a variable in memory.
This fixes a potential problem in the LTTng-kernel state provider,
where a value could get reset to null if no new attributes are
created between two sched_switch events.
Change-Id: I600125f560f0362671379848c572359be2f74cc7
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12249
Reviewed-by: Genevieve Bastien <gbastien+lttng@versatic.net>
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Wed, 24 Apr 2013 17:33:15 +0000 (13:33 -0400)]
ctf: Add copyright headers to scripts and properties files
Change-Id: Id15775ed4674cd9e5494c36a20988856d254e8fa
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12161
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 24 Apr 2013 19:45:24 +0000 (15:45 -0400)]
lttng: Refresh the state provider's test values
The order of attributes changed with
456f31e and
5a4f693.
The expected test values had to be updated. Should fix the
recent unit test failures.
Change-Id: I9e0d3c0573825ebdf0923030ec8792a6ada62aa3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12170
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 24 Apr 2013 19:37:12 +0000 (15:37 -0400)]
lttng: Make GenerateTestValues output a valid Java file
This way we can just copy-paste the output on top of the previous
TestValues.java file (which contains expected values for tests).
Java code that writes Java code, what can possibly go wrong...
Change-Id: I234959238d2c645ce40f4a9b5ed49d4399e08d4d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12169
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 24 Apr 2013 17:34:31 +0000 (13:34 -0400)]
gdbtrace: Add copyright headers to properties files
Change-Id: Ie333a85bad6e86666d8f005f65fd568709e90c78
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12162
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 24 Apr 2013 17:35:09 +0000 (13:35 -0400)]
tmf: Add copyright headers to properties files
Change-Id: I3ca1ece1513599fbb8f01614d1ca9f025729538f
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12164
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Wed, 24 Apr 2013 17:34:54 +0000 (13:34 -0400)]
lttng: Add copyright headers to properties files
Change-Id: If65f4920bf2177d135208759d9a6158c9d4d6fd1
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12163
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Alexandre Montplaisir [Tue, 9 Apr 2013 17:06:46 +0000 (13:06 -0400)]
tmf/lttng: Remove unneeded (non-Javadoc) comments
Those comments are not needed anymore. With Java >= 6,
overriding classes marked with @Override also inherit
the Javadoc from the base class.
Also:
- Some auto-formatter actions, to remove those pesky tabs.
- Ran the copyright tool. Might have updated unrelated files.
Change-Id: I93f699efa075a5629f31f478b7045247388f58fe
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12141
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 23 Apr 2013 20:05:41 +0000 (16:05 -0400)]
Fix NLS-related Javadoc warnings
Some new warnings slipped through in
9a9673c.
It was also externalizing strings in a test plugin, which is
not needed.
Change-Id: I8c9b309363c022b2072a701099e1f79c435737a0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/12140
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Tue, 23 Apr 2013 19:10:20 +0000 (15:10 -0400)]
lttng: add support for kernel-only in tracer control (bug406120)
This commit allows the user to connect to a remote LTTng node
where UST is disabled and only the kernel tracer is available.
For LTTng tools 2.0.x, the command lttng list -u causes a
segmentation fault on the remote side. This segmentation fault
makes it impossible to use the kernel-only mode. This bug is fixed
in later versions of LTTng tools starting from 2.1.0.
Change-Id: I2862ccce68c575706722eea89fdd4b450797d5d6
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12139
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Wed, 24 Apr 2013 11:50:35 +0000 (07:50 -0400)]
lttng: Support for port number in lttng control (bug 406122)
Change-Id: I38ce9ea1e84f3a57c28cb9877d2033cf42b0af57
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12135
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 17 Apr 2013 19:17:55 +0000 (15:17 -0400)]
lttng: Handle the sched_wakeup event
This event should put the relevant process (indicated in the
event's payload) in the "wait for cpu" state.
Change-Id: I5cf6a617f0558ff98cfc007fc10a688dab292f6b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11998
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 9 Apr 2013 18:40:59 +0000 (14:40 -0400)]
lttng: Correctly assign syscall state for new processes
If a process is already in kernel mode ("syscall" state) at
the beginning of a trace, all its children created via fork/clone
would be wrongly assigned to a user mode state once they get
scheduled on a CPU. This is because the parent's sycall name was
not set (since we never saw that syscall entry event).
This is actually a common case with LTTng traces: the lttng-consumerd
process is always already in kernel mode at the start of a trace,
and forks another process soon after.
Fixes bug #405221.
Change-Id: Iffdfb3277c1fa3fb9316c2ef9c8e6f04f539bb43
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11756
Tested-by: Hudson CI
Bernd Hufmann [Mon, 22 Apr 2013 19:01:24 +0000 (15:01 -0400)]
lttng2: Use ReadOnlyTextPropertyDescriptor in control model
Change-Id: I78e68d4c4d53ca753c09a807498204676ebb2dc3
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12107
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Mon, 22 Apr 2013 18:57:28 +0000 (14:57 -0400)]
tmf: use ReadOnlyTextPropertyDescriptor in project model
Change-Id: I4edd75e5dd4796e3196105ddb274b15033b0cdfd
Signed-off-by: Bernd Hufmann <Bernd.Hufmann@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/12106
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Matthew Khouzam [Thu, 18 Apr 2013 17:35:48 +0000 (13:35 -0400)]
[Tmf][Ctf] Add descriptive fail to import messages.
This patch proposes a way of showing more error details.
The ctf modifications use reflexion since the parser and lexer are
auto-generated. Now with number format exceptions for ints
Messages.java now have suppress warnings javadoc
Change-Id: I74cbbd4aaff29f458786ffc96e88b5416b49beed
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/11788
Alexandre Montplaisir [Mon, 8 Apr 2013 19:43:23 +0000 (15:43 -0400)]
tmf: Only keep the full constructor in TmfEventField
It's relatively risky to have two methods (in this case constructors)
where one uses 'Object' and the other 'ITmfEventField[]', since
an array is also an Object, so one constructor overloads the other.
We've had problems in the past with CtfTmfEventField, and it was
changed to only keep one constructor with all three arguments.
Propagate this change up to TmfEventField, and fixes all callers.
It's now much clearer what type of field we are constructing.
Change-Id: I3c19b9fffb53905f228f71b67200400c1ccc43ae
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11734
Alexandre Montplaisir [Sat, 13 Apr 2013 00:01:40 +0000 (20:01 -0400)]
tmf: Eliminate lesser constructors in TmfTrace
It's becoming very hard to figure out which exact constructor
is being called, and the resulting program flow. Remove the
intermediate constructors in TmfTrace and redirect implementations
to the full one.
Improved the Javadoc at the same time, to mention which default
values can be used.
Change-Id: Id0d03a976ce6d84e680021bf1634fa15d03942f3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11913
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Bernd Hufmann [Wed, 17 Apr 2013 15:52:03 +0000 (11:52 -0400)]
Use a read-only TextPropertyDescriptor for event properties
Use a custom, read-only TextPropertyDescriptor to use the cursor
in the value column to scroll for long property strings. In the
previous implementation, long value strings couldn't be read properly.
Change-Id: I6469442cb5b8f6779c807e90f8dc569ed3f71b49
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11984
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
IP-Clean: Bernd Hufmann <bernd.hufmann@ericsson.com>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Geneviève Bastien [Thu, 28 Mar 2013 15:59:01 +0000 (11:59 -0400)]
TMF: Add Variant field class to CtfTmfEventField
A variant field class was necessary to not lose the name of the variant
field. The output of a variant field type is now identical to that of
babeltrace.
Modified some comments and added the getFormattedValue to CTFStructField
to correctly handle empty structs.
Removed overriden toString functions that are not overridden anymore.
Change-Id: Iccffc6a2375df54945ff41614628760afcdf147f
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/11550
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
François Rajotte [Wed, 17 Apr 2013 19:22:14 +0000 (15:22 -0400)]
Add newline awareness to filter and search function of the event view
Change-Id: I9d5f03b55931e954f30da8fe36342413b4a2adb1
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/11993
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Wed, 17 Apr 2013 20:04:54 +0000 (16:04 -0400)]
lttng: Use interfaces for constant definitions
Change-Id: I4e42d82d52674bbe8cb1c4391291882c7ecbfdaf
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11997
Tested-by: Hudson CI
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Alexandre Montplaisir [Tue, 16 Apr 2013 13:27:36 +0000 (09:27 -0400)]
tmf: Fix start time of partial history event requests
Change-Id: I187750b8cd781c7e7bed893678f5d9e84e6ce7c3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11946
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Wed, 27 Mar 2013 20:23:29 +0000 (16:23 -0400)]
tmf: Add a state system explorer view
This view displays raw state system information, synchronized with
the currently selected timestamp. This is amazingly useful for
debugging, but could also be useful for end-users trying to get
more low-level information.
For this reason, it's shipped with the runtime plugin, but not
present in the default perspective.
Based on initial implementation by Florian Wininger.
Change-Id: I2dc6b798862039b1c5c18ec5418d7f5913e27dcc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11628
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Fri, 12 Apr 2013 23:05:18 +0000 (19:05 -0400)]
tmf: Add an 'intersects' method to ITmfTimestamp
Trivial implementation, but makes it more simple to check if
a timestamp is part of a given range.
Change-Id: I6ec1cc929f77cd5df5bc95b6b238c235f8b11f55
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11914
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 11 Apr 2013 20:07:42 +0000 (16:07 -0400)]
tmf: Streamline CtfTmfEventField creation
Less LOCs to do the same thing.
Change-Id: Iebfd3331b52012a9e62c16b5a8877e4559b21a6c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11837
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Wed, 27 Mar 2013 19:00:33 +0000 (15:00 -0400)]
tmf: Expose TmfExperiment.getTraces() up to ITmfTrace
When a view should display information about either 1 stand-alone
trace or an experiment, it will be able to call trace.getTraces()
directly, without having to do clunky instanceof checks every
single time.
Change-Id: I2f962a1dc4e6e34bf956aa0e62ba8b42cb234a99
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11531
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Thu, 4 Apr 2013 18:31:30 +0000 (14:31 -0400)]
tmf: Merge the two statesystem-getting methods into one
Use Collections.unmodifiableMap() to return a map directly,
instead of using two separate methods.
Also changed the declared type to a LinkedHashMap, so that
the order of iteration remains constant.
Change-Id: I876be06ea550d1244da87215e58fddee95f6de3d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11659
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Simon Marchi [Fri, 22 Mar 2013 15:16:04 +0000 (11:16 -0400)]
Add "check subtree" feature to TimeGraphFilterDialog
Change-Id: Ib3d9a4c634d506c58524af704f903be685aaf3d1
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/11390
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Geneviève Bastien [Wed, 27 Mar 2013 18:22:10 +0000 (14:22 -0400)]
Ctf: Correct endianness when reading ctf integers
Endianness was not correctly taken into account when reading
integer fields in different endianness.
Also add the tests for endianness reading.
Change-Id: I77d72b75116f8fabcbbdf962afa6ad2903c39c26
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/11528
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Alexandre Montplaisir [Wed, 3 Apr 2013 19:38:00 +0000 (15:38 -0400)]
tmf: Register statistics state systems into the trace
This way they will show up in the State System Explorer, among
other things.
Change-Id: I40c49600b8bac40e5c49f2877cd42d578c1229ea
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11660
Alexandre Montplaisir [Mon, 8 Apr 2013 21:05:32 +0000 (17:05 -0400)]
tmf: Make TmfEventType immutable
Almost no changes needed, nobody was ever modifying the fields,
other than the tests.
Change-Id: Id6319fc46e3df4bee06e357bbe371b20109ebb94
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11736
Alexandre Montplaisir [Tue, 9 Apr 2013 22:12:05 +0000 (18:12 -0400)]
tmf: Fix new Kepler warnings
Mainly null-check warnings, due to the new JDT with improved
null checks.
Change-Id: Ibe47a0e830547d10c9947dd79289a7194ecc9bd0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11761
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Xavier Raynaud [Wed, 3 Apr 2013 11:44:12 +0000 (13:44 +0200)]
o.e.l.tmf.ui: add a ScrolledComposite in TimeGraphLegend.
TimeGraphLegend now handles many states gracefully.
Change-Id: I1bb754b3046584b3b0af6197d618276377411910
Reviewed-on: https://git.eclipse.org/r/11619
Tested-by: Hudson CI
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Patrick Tasse [Wed, 30 Jan 2013 19:05:07 +0000 (14:05 -0500)]
lttng/o.e.l.tmf.ui: disable menu detected event during mouse drag
Change-Id: I432296df9774862f1c56a58f3e8245c6ea226de7
Reviewed-on: https://git.eclipse.org/r/8709
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Alexandre Montplaisir [Fri, 22 Mar 2013 22:09:11 +0000 (18:09 -0400)]
tmf: Remove getFieldType() method from CTF event fields
It's not used anywhere. If we ever need it in the future, it would
be better to use an enum.
Change-Id: I6e6e4b8f4a8598536c4b5d5a762ef41eb2ffb989
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11404
Alexandre Montplaisir [Fri, 15 Mar 2013 22:00:16 +0000 (18:00 -0400)]
ctf: Clean up unit tests
Remove all remaining artifacts from CodePro.
Change-Id: Id313c48e4b00be694340d7cfeb66f40d74c489c2
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11215
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Fri, 15 Mar 2013 21:33:54 +0000 (17:33 -0400)]
ctf: Disable NLS warnings in test plugin
Test plugins are never meant to be shipped to end-users, so
instead of having to put $NON-NLS-1$ and SuppressWarnings
everywhere, just disable those in the project settings instead.
Change-Id: Ifc9d23e4ce9944fb03cb8c019dd5176d2247a70e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11214
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Wed, 27 Mar 2013 18:17:03 +0000 (14:17 -0400)]
tmf: Add a trace-getting method in TmfView
Instead of calling the getSite.getPage.getEditor mantra every
time, if anyone has a reference to a view they can now use this
convenience getActiveTrace() method to get the currently selected
trace.
Kind of replacement for the old TmfExperiment.getCurrentExperiment();
Change-Id: I84783c6e65bb5c9095d4f868e9cb00a80bb246b0
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11530
Alexandre Montplaisir [Tue, 26 Mar 2013 21:49:08 +0000 (17:49 -0400)]
tmf: Improve histogram responsiveness
The Histogram had its own kind of throttling TimeRangeSynch signals,
but simply freezing itself for ~100 ms, which would of course imply
no other time range could be selected.
Replace this with the fancy new signal throttlers. Now the
histogram display gets updated right away, while the background
time range updates and queries only happen after a short time
without any new time range selection.
The user experience should increase a great deal!
Change-Id: I89a872d9d829d5522523912f73dca2c31f48e64c
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11503
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 26 Mar 2013 19:29:28 +0000 (15:29 -0400)]
tmf: Add a TmfSignalThrottler
Components can now decide to use a signal throttler for outgoing
signals. This offers a centralized way of controlling the rate
of signals (TimeRange sync signals come to mind).
Change-Id: Ia26cb12a87c6db2fae23892aff908715fe527755
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11502
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Tue, 26 Mar 2013 19:29:10 +0000 (15:29 -0400)]
tmf: Update formatting in TmfSignalManager
Change-Id: I60812013bd524792024c249369ecd270599f286b
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11501
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
Geneviève Bastien [Wed, 13 Mar 2013 18:57:10 +0000 (14:57 -0400)]
tmf: Use same field format in properties and events views
Change-Id: I5e5e80abd0b2acb83b06e5560db6cf70c2900f8c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/11320
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Fri, 22 Mar 2013 11:27:39 +0000 (07:27 -0400)]
Display exception in message dialog box in TmfEventsTable
Change-Id: Iac0dd768257a020b1db69e4dd39a4709988e7aa9
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11382
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Thu, 21 Mar 2013 16:11:06 +0000 (12:11 -0400)]
tmf: Generalize the support for call sites and model URIs
The support for source code and model element look-up had been
specific to CTF. This commit generalizes the implementation so
that other trace extensions can use it.
Change-Id: Iff663e85e22a69f48258a5057de15b3e10e76863
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11264
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 20 Mar 2013 13:32:21 +0000 (09:32 -0400)]
gdb trace: Update menu item for executable selection
Change menu item from "Select Trace Executable" to
"Select Trace Executable..." to indicate that a dialog box will be
opened.
Change-Id: Ic0e3a267fe6b73e4b0a880b7d4c79803780eee0f
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11335
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Alexandre Montplaisir [Fri, 15 Mar 2013 20:49:03 +0000 (16:49 -0400)]
lttng: Add missing state value type case
Change-Id: I11bc9207698ce7cb50db719c4f32e8826cd496bd
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11209
Geneviève Bastien [Tue, 5 Mar 2013 21:08:35 +0000 (16:08 -0500)]
tmf: Add Variant field handling in CtfTmfEventField
* Also add unit test for variant types
* Move the base-formatting of numeric values to parent class
Change-Id: I863fb57ea34dafd0ed7e02caa3f698b4cb88f65c
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/10872
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Mon, 18 Mar 2013 20:12:40 +0000 (16:12 -0400)]
tmf: Disable NLS warnings in tests
Change-Id: I202b132026aff9339778f4cc5cc7fa13fe3fc995
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11284
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 18 Mar 2013 19:32:29 +0000 (15:32 -0400)]
lttng: Disable NLS warnings in tests
Change-Id: Iec8f1108c0b26f1e3d0b6c3eaa479c00dfa8e6cb
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11283
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Mon, 18 Mar 2013 19:14:50 +0000 (15:14 -0400)]
gdbtrace: Disable NLS warnings in tests
Change-Id: Id30877eddc2b7728e218e1181729fe52a8926570
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11282
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Simon Marchi [Thu, 14 Mar 2013 18:53:05 +0000 (14:53 -0400)]
Add multiple selection in the time graph filter dialog
* Add "(un)check selected" buttons
* Change "(de)select all" to "(un)check all"
* Remove container mode option
Change-Id: Id002dc2f93589f2e8c209c87598476ba3f4006c0
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/11170
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Geneviève Bastien [Tue, 12 Mar 2013 20:21:00 +0000 (16:21 -0400)]
tmf: keep event fields ordering as per ctf metadata
* While there, change the HashMap type of the fields to interface
type map
* Change unit tests with new field ordering
Change-Id: I4fb1fec8b922f01e62573c415ca6f23826ec072a
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/11090
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Patrick Tasse [Wed, 13 Mar 2013 21:25:24 +0000 (17:25 -0400)]
Update GDB Tracepoint Analysis help files
Change-Id: I68053b9522a0c5dc5969f6cd3f0396a125f124cc
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11176
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Wed, 13 Mar 2013 20:36:32 +0000 (16:36 -0400)]
tmf: Enable the partial state system unit tests
Forgot to enable it in the previous patch. It should be working
fine now!
Change-Id: I5ad6198b0ad270e8486a108f2b3b4f1acd25d6e6
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11153
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Thu, 14 Mar 2013 20:12:40 +0000 (16:12 -0400)]
tmf ui: Make UML2SD UI tests independent from each other
This fixes the problem introduced when using JUnit version 4.11
where the order of test execution within a file is not the order
in the file.
Change-Id: I49ac3560c2cb5138c3dc606524a9a741d9827a2a
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11171
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Patrick Tasse [Thu, 14 Mar 2013 15:50:38 +0000 (11:50 -0400)]
Fix for unit test concurrency
Change-Id: Ib98210cb5c691f4da4f67ba78d28c8d31dc4229c
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11156
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
François Rajotte [Tue, 5 Mar 2013 19:43:48 +0000 (14:43 -0500)]
[TMF] Add support for 64-bit integers in the history tree
Change-Id: Ib37fc52bcb3e032bb671ba836023281f4c4f0b01
Signed-off-by: François Rajotte <francois.rajotte@polymtl.ca>
Reviewed-on: https://git.eclipse.org/r/10868
Tested-by: Hudson CI
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 14 Mar 2013 18:32:56 +0000 (14:32 -0400)]
ctf: Make sure CTFTraceTest's are independent
The getClock() tests would use the value set by a previous test.
Remedy that by merging the getter and setter tests. Also cleaned
up the file a bit while a it.
Change-Id: I10df9ae5960ae426e607eb92b5a3956bb90a158d
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11162
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Thu, 14 Mar 2013 12:02:04 +0000 (08:02 -0400)]
gdb trace: fix UI plug-in test
Change-Id: I5cb8c69ab9c5a74c6c224271bf0eee94baed0615
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11147
Tested-by: Hudson CI
Patrick Tasse [Wed, 13 Mar 2013 21:58:29 +0000 (17:58 -0400)]
Update GDB Tracepoint Analysis tests
Also rename package org.eclipse.linuxtools.internal.gdbtrace to
org.eclipse.linuxtools.internal.gdbtrace.core.
Change-Id: I72d623344ebbbcb9c6dcc7afd2e499e9d5495e35
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11139
Tested-by: Hudson CI
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Bernd Hufmann [Wed, 13 Mar 2013 19:56:32 +0000 (15:56 -0400)]
lttng: Fix gdb trace reference in lttng specific releng
Change-Id: I389fd0fd238af6590d85b5aea6409a785976cf52
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11129
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Alexandre Montplaisir [Tue, 5 Mar 2013 16:55:27 +0000 (11:55 -0500)]
tmf: Add support for partial state system history
A partial history is like a shim between a trace's state system
and a "standard" history backend.
In a standard history, all state intervals are inserted into the
backend. With a partial history, only the intervals that cross
pre-determined checkpoints are inserted. To rebuild any state
between checkpoints, we load the previous checkpoint and re-read
the events in the trace between the checkpoint and the time of
the query.
Partial histories do not support single queries. While those
could be implemented by using a full-query, it seemed to cause
problems with range queries, where multiple state/event queries
happen in parallel (which is not so bad, range-query performance
would be absolutely disastrous!).
Change-Id: Iad709a00d630a40bf5a1c2e13d55d901f9a1eaa5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10990
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Wed, 6 Mar 2013 20:04:04 +0000 (15:04 -0500)]
lttng: Add an in-depth test for full state system queries
Also add a small program/script in the 'headless' package to
regenerate those reference values easily, in case we need to
update the test values after we modify the kernel state provider.
Change-Id: I5cf66367a246ca78bb85f4cb3b3ad3c24ea6142e
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10908
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Mon, 11 Mar 2013 21:45:47 +0000 (17:45 -0400)]
tmf: Replace state value types with an enum
Originally, we specified the low-level byte to write to the
history tree file in ITmfStateValue. Now that we have multiple
possible state backends, it's much more convenient to use an
enum in the framework, and define the type<->byte conversion
inside the History Tree only.
Change-Id: I8bd694672256c15737e41813b3146b2f929d8c78
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/11065
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 13 Mar 2013 18:30:41 +0000 (14:30 -0400)]
gdb trace: Improve executable selection
Change-Id: Id7f05a0611b81ffa7802a77c70e2ea8b5bbe6db2
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11111
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Bernd Hufmann [Wed, 13 Mar 2013 17:18:35 +0000 (13:18 -0400)]
gdb trace: Fix shutdown deadlock
Change-Id: I16b822e3bf413d2dae86b95614fb12883d50240f
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11112
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Patrick Tasse [Wed, 6 Mar 2013 19:13:05 +0000 (14:13 -0500)]
Introduce GDB Tracepoint Analysis feature
Change-Id: I0800687b8b55b381fb304b828f57b9cd330c0d4b
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10946
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Tue, 12 Mar 2013 17:49:13 +0000 (13:49 -0400)]
lttng: add command execution timeout preference
Change-Id: Ia3b09ad1260517ead01c53dd21cfa97a0484ad03
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11086
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Hudson CI
Patrick Tasse [Mon, 11 Mar 2013 21:42:29 +0000 (17:42 -0400)]
Fix NullPointerException in TimeChartView
Change-Id: Icdf83a6ee5109a7684ff3450745c028f565dd420
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/11063
Tested-by: Hudson CI
IP-Clean: Xavier Raynaud <xavier.raynaud@kalray.eu>
Tested-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Reviewed-by: Xavier Raynaud <xavier.raynaud@kalray.eu>
Alexandre Montplaisir [Tue, 5 Mar 2013 19:20:20 +0000 (14:20 -0500)]
tmf: Don't access the attribute tree directly
but go through a new StateSystem.getAttributeTree() method that
wraps it. This way, a potential subclass only needs to override
that method to point to a different attribute tree.
Change-Id: I77b306f53095eb7b7423e10ee1ebb97c3ddaf6f5
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10856
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Patrick Tasse [Wed, 6 Mar 2013 18:34:17 +0000 (13:34 -0500)]
Update plug-in and feature descriptions
Change-Id: I6b68175455e2cb27eebcf65f97c2593090d11a61
Signed-off-by: Patrick Tasse <patrick.tasse@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10901
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Hudson CI
Bernd Hufmann [Wed, 6 Mar 2013 18:17:35 +0000 (13:17 -0500)]
lttng ui: fix handling of command output for verbose commands
When executing commands with preference verbose the command output
parsing of certain commands were not correct and caused
ExecutionExceptions in Eclipse even if the command was successfully
executed. This has been corrected with this commit. Also, this
commit contains JUnit tests to verify the updates.
Change-Id: I24196959a28093a292f599f93f6b78f6fd76c69e
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10864
Tested-by: Hudson CI
Reviewed-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
IP-Clean: Matthew Khouzam <matthew.khouzam@ericsson.com>
Tested-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Bernd Hufmann [Tue, 5 Mar 2013 16:09:51 +0000 (11:09 -0500)]
lttng/tmf: update versions and dependencies
Change-Id: I8bce498a0ffa19cbdc097351a13fbee72b84ce4a
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10848
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Thu, 28 Feb 2013 21:04:19 +0000 (16:04 -0500)]
tmf: Move some code to copy/add/remove traces in UI
The "Copy trace", "Select traces..." and "Remove" functionnalities have
some code that can be reused by each other and future features. This
code has been moved to the model element's classes.
Change-Id: Id61914521f41d9c2b2c25fe1268e61be62c1d504
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/10751
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
Tested-by: Patrick Tasse <patrick.tasse@gmail.com>
Geneviève Bastien [Fri, 1 Mar 2013 16:50:39 +0000 (11:50 -0500)]
tmf: Call parent before CtfTmfTrace specific initialization
Some features need to have resources initialized before the CtfTmfTrace
starts fetching its events.
Change-Id: If3d638263713064e8b4be4e651e4e0e33c734e4e
Signed-off-by: Geneviève Bastien <gbastien+lttng@versatic.net>
Reviewed-on: https://git.eclipse.org/r/10783
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Tested-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
IP-Clean: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Alexandre Montplaisir [Thu, 28 Feb 2013 23:01:27 +0000 (18:01 -0500)]
tmf: Add method to replace a statesystem's ongoing state
Replace the vestigial TransientState.changeOngoingStateInfo()
(which was never used so far) with a similar method that can
generate a current state from an array of intervals.
For now, this this potentially dangerous method is only exposed
to classes extending StateSystem.
This will be useful for the partial history, but also for anybody
wanting to do funky stuff with the state system.
Change-Id: Ieebe6dfceb57c1437d81fd9a97c6be10040afeb4
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10760
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 28 Feb 2013 20:59:09 +0000 (15:59 -0500)]
tmf: Add a method to query an ongoing state's start time
We can already query a state system's current state value for
a given attribute. It's trivial to expose a method to also query
the start time of that state.
Change-Id: I4b2610709bb0af33b612514007787b20f941f490
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10757
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 28 Feb 2013 20:47:23 +0000 (15:47 -0500)]
tmf: Add a copy method to state system inputs
This is another requirement for partial histories. It is not a
real "clone" method, since we do not want to copy the assigned
state system at that moment, it's supposed to be assigned later
with another call to assignTargetStateSystem().
Change-Id: I744030084fc968b6426718c2fac5ace7f1a2c6dc
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10756
Tested-by: Hudson CI
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Thu, 28 Feb 2013 20:30:54 +0000 (15:30 -0500)]
lttng: Do not cache attribute tree locations
As a requirement for partial histories, we cannot cache
commonly-used attribute tree locations in the state providers.
Since the partial history's inner state provider will not know
the cached values of the real one, we need to resolve them
every time.
This unfortunately hampers the performance of standard state
system constructions a bit.
Change-Id: I93e104ea1e4fe7159805ff54296d4cfc830444a3
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10755
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Alexandre Montplaisir [Fri, 1 Mar 2013 22:04:56 +0000 (17:04 -0500)]
lttng: Don't throw irrelevant exceptions in state system tests
Some tests expect exceptions, so these have to keep the "throws"
clause. For everything else, handle the excpetion in a try/catch
which will fail() the test if they happen.
This makes it simpler to extend the test cases, since the throws
may or may not be relevant in the subclass.
Change-Id: If71b351ba22bd88377120833eb83e9b78717d579
Signed-off-by: Alexandre Montplaisir <alexmonthy@voxpopuli.im>
Reviewed-on: https://git.eclipse.org/r/10795
Tested-by: Hudson CI
Reviewed-by: Bernd Hufmann <bhufmann@gmail.com>
IP-Clean: Bernd Hufmann <bhufmann@gmail.com>
Tested-by: Bernd Hufmann <bhufmann@gmail.com>
Bernd Hufmann [Fri, 1 Mar 2013 19:47:41 +0000 (14:47 -0500)]
Improved error handling for connection errors in LTTng control
Change-Id: I4c91fd06433a38a30903b82e762284de36486a26
Signed-off-by: Bernd Hufmann <bhufmann@gmail.com>
Reviewed-on: https://git.eclipse.org/r/10784
Tested-by: Hudson CI
Reviewed-by: Patrick Tasse <patrick.tasse@gmail.com>
IP-Clean: Patrick Tasse <patrick.tasse@gmail.com>
This page took 0.047361 seconds and 5 git commands to generate.