From 4b693b304a5d7b81b2f38f08721bee20a35ee9b2 Mon Sep 17 00:00:00 2001 From: Jean-Christian Kouame Date: Wed, 27 Apr 2016 11:12:06 -0400 Subject: [PATCH 1/1] tmf: Replace IllegalStateException with Activator.logError() IllegalStateException was raised when the action cannot be found. This patch avoids to block the UI when the problem happens. Change-Id: Ied85dd924a6fa330b165d5d10027c92f20e2f14d Signed-off-by: Jean-Christian Kouame Reviewed-on: https://git.eclipse.org/r/71529 Reviewed-by: Hudson CI Reviewed-by: Bernd Hufmann Tested-by: Bernd Hufmann --- .../internal/tmf/analysis/xml/core/model/TmfXmlScenario.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/model/TmfXmlScenario.java b/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/model/TmfXmlScenario.java index 2e1f0cdc0e..c4b551f20a 100644 --- a/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/model/TmfXmlScenario.java +++ b/tmf/org.eclipse.tracecompass.tmf.analysis.xml.core/src/org/eclipse/tracecompass/internal/tmf/analysis/xml/core/model/TmfXmlScenario.java @@ -12,6 +12,7 @@ import java.util.List; import org.eclipse.jdt.annotation.NonNull; import org.eclipse.jdt.annotation.Nullable; +import org.eclipse.tracecompass.internal.tmf.analysis.xml.core.Activator; import org.eclipse.tracecompass.internal.tmf.analysis.xml.core.model.TmfXmlScenarioHistoryBuilder.ScenarioStatusType; import org.eclipse.tracecompass.internal.tmf.analysis.xml.core.module.IXmlStateSystemContainer; import org.eclipse.tracecompass.internal.tmf.analysis.xml.core.pattern.stateprovider.XmlPatternStateProvider; @@ -105,7 +106,8 @@ public class TmfXmlScenario { if (action != null) { action.execute(event, fScenarioInfo); } else { - throw new IllegalStateException("Action " + actionId + " cannot be found."); //$NON-NLS-1$ //$NON-NLS-2$ + Activator.logError("Action " + actionId + " cannot be found."); //$NON-NLS-1$ //$NON-NLS-2$ + return; } } -- 2.34.1