From 5707a07af2c282e87af1b060b4463fc083775649 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 22 Feb 2020 13:49:56 -0700 Subject: [PATCH] Make dwarf2_compile_expr_to_ax static I noticed that dwarf2_compile_expr_to_ax can be static. Nothing outside of loc.c calls it. gdb/ChangeLog 2020-02-22 Tom Tromey * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare. * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static. --- gdb/ChangeLog | 5 +++++ gdb/dwarf2/loc.c | 2 +- gdb/dwarf2/loc.h | 20 -------------------- 3 files changed, 6 insertions(+), 21 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 1f604f76ee..0a070dc9bb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-02-22 Tom Tromey + + * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare. + * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static. + 2020-02-22 Tom Tromey * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window. diff --git a/gdb/dwarf2/loc.c b/gdb/dwarf2/loc.c index a9523e9f7e..a5074da8bf 100644 --- a/gdb/dwarf2/loc.c +++ b/gdb/dwarf2/loc.c @@ -2881,7 +2881,7 @@ get_ax_pc (void *baton) example, if the expression cannot be compiled, or if the expression is invalid. */ -void +static void dwarf2_compile_expr_to_ax (struct agent_expr *expr, struct axs_value *loc, unsigned int addr_size, const gdb_byte *op_ptr, const gdb_byte *op_end, diff --git a/gdb/dwarf2/loc.h b/gdb/dwarf2/loc.h index 8fff663ebf..4514fa93c7 100644 --- a/gdb/dwarf2/loc.h +++ b/gdb/dwarf2/loc.h @@ -242,26 +242,6 @@ extern const struct symbol_computed_ops dwarf2_loclist_funcs; extern const struct symbol_block_ops dwarf2_block_frame_base_locexpr_funcs; extern const struct symbol_block_ops dwarf2_block_frame_base_loclist_funcs; -/* Compile a DWARF location expression to an agent expression. - - EXPR is the agent expression we are building. - LOC is the agent value we modify. - ARCH is the architecture. - ADDR_SIZE is the size of addresses, in bytes. - OP_PTR is the start of the location expression. - OP_END is one past the last byte of the location expression. - - This will throw an exception for various kinds of errors -- for - example, if the expression cannot be compiled, or if the expression - is invalid. */ - -extern void dwarf2_compile_expr_to_ax (struct agent_expr *expr, - struct axs_value *loc, - unsigned int addr_size, - const gdb_byte *op_ptr, - const gdb_byte *op_end, - struct dwarf2_per_cu_data *per_cu); - /* Determined tail calls for constructing virtual tail call frames. */ struct call_site_chain -- 2.34.1