From 431e5de3f224e94fb0d061edb3a56d8e3c3f4403 Mon Sep 17 00:00:00 2001 From: Andreas Krebbel Date: Thu, 5 Jan 2017 19:53:14 +0100 Subject: [PATCH] S/390: Issue error for overflowing relocs. Building PIE executable from non-PIC code results in broken binaries. With this patch the problem is detected at link-time. bfd/ChangeLog: 2017-01-07 Andreas Krebbel * elf64-s390.c (elf_s390_relocate_section): Issue error for non-PLT relocs of shared libary symbol in exectuable. --- bfd/elf64-s390.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/bfd/elf64-s390.c b/bfd/elf64-s390.c index bbfcd2e687..edc9b861ea 100644 --- a/bfd/elf64-s390.c +++ b/bfd/elf64-s390.c @@ -2701,6 +2701,18 @@ elf_s390_relocate_section (bfd *output_bfd, case R_390_PC32: case R_390_PC32DBL: case R_390_PC64: + if (h != NULL + && bfd_link_pie (info) + && !h->def_regular) + { + _bfd_error_handler (_("%B: `%s' non-PLT reloc for symbol defined " + "in shared library and accessed " + "from executable " + "(rebuild file with -fPIC ?)"), + input_bfd, h->root.root.string); + bfd_set_error (bfd_error_bad_value); + return FALSE; + } /* The target of these relocs are instruction operands residing in read-only sections. We cannot emit a runtime reloc for it. */ -- 2.34.1