From f33c6cbfe5d16558554b5eda87a10625285b291c Mon Sep 17 00:00:00 2001 From: Andrew Cagney Date: Fri, 1 Mar 2002 06:19:28 +0000 Subject: [PATCH] Add FIXME explaining include problem. --- gdb/ChangeLog | 4 ++++ gdb/tui/ChangeLog | 25 +++++++++++++++++++++++++ gdb/tui/tui-hooks.c | 12 ++++++++++-- gdb/tui/tui.c | 14 ++++++++++++-- gdb/tui/tuiCommand.c | 14 ++++++++++++-- gdb/tui/tuiData.c | 14 ++++++++++++-- gdb/tui/tuiDataWin.c | 14 ++++++++++++-- gdb/tui/tuiDisassem.c | 14 ++++++++++++-- gdb/tui/tuiGeneralWin.c | 14 ++++++++++++-- gdb/tui/tuiIO.c | 14 ++++++++++++-- gdb/tui/tuiLayout.c | 14 ++++++++++++-- gdb/tui/tuiRegs.c | 14 ++++++++++++-- gdb/tui/tuiSource.c | 14 ++++++++++++-- gdb/tui/tuiSourceWin.c | 14 ++++++++++++-- gdb/tui/tuiStack.c | 14 ++++++++++++-- gdb/tui/tuiWin.c | 14 ++++++++++++-- gdb/utils.c | 10 ++++++++-- 17 files changed, 203 insertions(+), 30 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 353eaf9586..0e2c5f06cb 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2002-03-01 Andrew Cagney + + * utils.c: Add FIXME explaining true/false problem. + 2002-02-28 Andrew Cagney * MAINTAINERS (Past Maintainers): Add J.T. Conklin. diff --git a/gdb/tui/ChangeLog b/gdb/tui/ChangeLog index 00a7e12329..2f676a88d1 100644 --- a/gdb/tui/ChangeLog +++ b/gdb/tui/ChangeLog @@ -1,3 +1,28 @@ +2002-03-01 Andrew Cagney + + * tui-hooks.c: Add FIXME to explain true/false problem. Update + copyright. + * tui.c, tuiCommand.c, tuiData.c, tuiDataWin.c: Ditto. + * tuiDisassem.c, tuiGeneralWin.c, tuiIO.c, tuiLayout.c: Ditto. + * tuiRegs.c, tuiSource.c, tuiSourceWin.c, tuiStack.c: Ditto. + * tuiWin.c: Ditto. + + 2002-02-08 Daniel Jacobowitz + * tui-hooks.c: Include before "bfd.h". + * tui.c: Likewise. + * tuiCommand.c: Likewise. + * tuiData.c: Likewise. + * tuiDataWin.c: Likewise. + * tuiDisassem.c: Likewise. + * tuiGeneralWin.c: Likewise. + * tuiIO.c: Likewise. + * tuiLayout.c: Likewise. + * tuiRegs.c: Likewise. + * tuiSource.c: Likewise. + * tuiSourceWin.c: Likewise. + * tuiStack.c: Likewise. + * tuiWin.c: Likewise. + 2002-02-01 Andrew Cagney * tuiWin.c (_initialize_tuiWin): Replace NO_FUNCTION with NULL. diff --git a/gdb/tui/tui-hooks.c b/gdb/tui/tui-hooks.c index 38cfc57218..27556acfd1 100644 --- a/gdb/tui/tui-hooks.c +++ b/gdb/tui/tui-hooks.c @@ -1,5 +1,6 @@ /* GDB hooks for TUI. - Copyright 2001 Free Software Foundation, Inc. + + Copyright 2001, 2002 Free Software Foundation, Inc. This file is part of GDB. @@ -18,7 +19,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tui.c b/gdb/tui/tui.c index 18d706fe25..7912efc876 100644 --- a/gdb/tui/tui.c +++ b/gdb/tui/tui.c @@ -1,5 +1,8 @@ /* General functions for the WDB TUI. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiCommand.c b/gdb/tui/tuiCommand.c index fd868e25a4..ca3d5318ea 100644 --- a/gdb/tui/tuiCommand.c +++ b/gdb/tui/tuiCommand.c @@ -1,5 +1,8 @@ /* Specific command window processing. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiData.c b/gdb/tui/tuiData.c index 256f694e87..30efba8b11 100644 --- a/gdb/tui/tuiData.c +++ b/gdb/tui/tuiData.c @@ -1,5 +1,8 @@ /* TUI data manipulation routines. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiDataWin.c b/gdb/tui/tuiDataWin.c index cb670ed7a2..e729afc7f7 100644 --- a/gdb/tui/tuiDataWin.c +++ b/gdb/tui/tuiDataWin.c @@ -1,5 +1,8 @@ /* Data/register window display. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiDisassem.c b/gdb/tui/tuiDisassem.c index 2cab1be5e8..8e59e68d69 100644 --- a/gdb/tui/tuiDisassem.c +++ b/gdb/tui/tuiDisassem.c @@ -1,5 +1,8 @@ /* Disassembly display. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiGeneralWin.c b/gdb/tui/tuiGeneralWin.c index b6d84e46d9..b3f8b919a5 100644 --- a/gdb/tui/tuiGeneralWin.c +++ b/gdb/tui/tuiGeneralWin.c @@ -1,5 +1,8 @@ /* General window behavior. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiIO.c b/gdb/tui/tuiIO.c index 31e7c23ad2..d664128ebd 100644 --- a/gdb/tui/tuiIO.c +++ b/gdb/tui/tuiIO.c @@ -1,5 +1,8 @@ /* TUI support I/O functions. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiLayout.c b/gdb/tui/tuiLayout.c index 061317855f..aa98882d9d 100644 --- a/gdb/tui/tuiLayout.c +++ b/gdb/tui/tuiLayout.c @@ -1,5 +1,8 @@ /* TUI layout window management. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiRegs.c b/gdb/tui/tuiRegs.c index dc684fd213..d76c67ea8b 100644 --- a/gdb/tui/tuiRegs.c +++ b/gdb/tui/tuiRegs.c @@ -1,5 +1,8 @@ /* TUI display registers in window. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiSource.c b/gdb/tui/tuiSource.c index 3ad71bcc88..1552ac79d0 100644 --- a/gdb/tui/tuiSource.c +++ b/gdb/tui/tuiSource.c @@ -1,5 +1,8 @@ /* TUI display source window. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiSourceWin.c b/gdb/tui/tuiSourceWin.c index 3deac193d9..7563c940de 100644 --- a/gdb/tui/tuiSourceWin.c +++ b/gdb/tui/tuiSourceWin.c @@ -1,5 +1,8 @@ /* TUI display source/assembly window. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiStack.c b/gdb/tui/tuiStack.c index 9b664ed8a3..43d022928f 100644 --- a/gdb/tui/tuiStack.c +++ b/gdb/tui/tuiStack.c @@ -1,5 +1,8 @@ /* TUI display locator. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -19,7 +22,14 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/tui/tuiWin.c b/gdb/tui/tuiWin.c index b5b6d6d076..a33f661360 100644 --- a/gdb/tui/tuiWin.c +++ b/gdb/tui/tuiWin.c @@ -1,5 +1,8 @@ /* TUI window generic functions. - Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc. + + Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation, + Inc. + Contributed by Hewlett-Packard Company. This file is part of GDB. @@ -24,7 +27,14 @@ Author: Susan B. Macchia */ -/* If we need , we must include it before we get "bfd.h". */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" #ifdef HAVE_NCURSES_H #include diff --git a/gdb/utils.c b/gdb/utils.c index af1a103b92..be9dc457b1 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -20,10 +20,16 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ +/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that + "defs.h" should be included first. Unfortunatly some systems + (currently Debian GNU/Linux) include the via + and they clash with "bfd.h"'s definiton of true/false. The correct + fix is to remove true/false from "bfd.h", however, until that + happens, hack around it by including "config.h" and + first. */ + #include "config.h" -/* Include before "bfd.h" so that we get stdbool.h in time, if - brings it in. */ #ifdef HAVE_CURSES_H #include #endif -- 2.34.1