From e395f487b3758b3de99fddd2ef15a799e9fc1203 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 27 Jun 2019 13:39:19 -0700 Subject: [PATCH] i386: Check vector length for scatter/gather prefetch instructions Since not all vector lengths are supported by scatter/gather prefetch instructions, decode them only with supported vector lengths. gas/ PR binutils/24719 * testsuite/gas/i386/disassem.s: Add test for vgatherpf0dps with invalid vector length. * testsuite/gas/i386/x86-64-disassem.s: Likewise. * testsuite/gas/i386/disassem.d: Updated. * testsuite/gas/i386/x86-64-disassem.d: Likewise. opcodes/ PR binutils/24719 * i386-dis-evex-len.h: Add EVEX_LEN_0F38C6_REG_1_PREFIX_2, EVEX_LEN_0F38C6_REG_2_PREFIX_2, EVEX_LEN_0F38C6_REG_5_PREFIX_2, EVEX_LEN_0F38C6_REG_6_PREFIX_2, EVEX_LEN_0F38C7_R_1_P_2_W_0, EVEX_LEN_0F38C7_R_1_P_2_W_1, EVEX_LEN_0F38C7_R_2_P_2_W_0, EVEX_LEN_0F38C7_R_2_P_2_W_1, EVEX_LEN_0F38C7_R_5_P_2_W_0, EVEX_LEN_0F38C7_R_5_P_2_W_1, EVEX_LEN_0F38C7_R_6_P_2_W_0 and EVEX_LEN_0F38C7_R_6_P_2_W_1. * i386-dis-evex-prefix.h: Update PREFIX_EVEX_0F38C6_REG_1, PREFIX_EVEX_0F38C6_REG_2, PREFIX_EVEX_0F38C6_REG_5 and PREFIX_EVEX_0F38C6_REG_6 entries. * i386-dis-evex-w.h: Update EVEX_W_0F38C7_R_1_P_2, EVEX_W_0F38C7_R_2_P_2, EVEX_W_0F38C7_R_5_P_2 and EVEX_W_0F38C7_R_6_P_2 entries. * i386-dis.c: Add EVEX_LEN_0F38C6_REG_1_PREFIX_2, EVEX_LEN_0F38C6_REG_2_PREFIX_2, EVEX_LEN_0F38C6_REG_5_PREFIX_2, EVEX_LEN_0F38C6_REG_6_PREFIX_2, EVEX_LEN_0F38C7_R_1_P_2_W_0, EVEX_LEN_0F38C7_R_1_P_2_W_1, EVEX_LEN_0F38C7_R_2_P_2_W_0, EVEX_LEN_0F38C7_R_2_P_2_W_1, EVEX_LEN_0F38C7_R_5_P_2_W_0, EVEX_LEN_0F38C7_R_5_P_2_W_1, EVEX_LEN_0F38C7_R_6_P_2_W_0 and EVEX_LEN_0F38C7_R_6_P_2_W_1 enums. --- gas/ChangeLog | 9 ++++ opcodes/ChangeLog | 24 ++++++++++ opcodes/i386-dis-evex-len.h | 84 ++++++++++++++++++++++++++++++++++ opcodes/i386-dis-evex-prefix.h | 8 ++-- opcodes/i386-dis-evex-w.h | 16 +++---- opcodes/i386-dis.c | 12 +++++ 6 files changed, 141 insertions(+), 12 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index 98bae969fc..91c4d494ea 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,12 @@ +2019-06-27 H.J. Lu + + PR binutils/24719 + * testsuite/gas/i386/disassem.s: Add test for vgatherpf0dps + with invalid vector length. + * testsuite/gas/i386/x86-64-disassem.s: Likewise. + * testsuite/gas/i386/disassem.d: Updated. + * testsuite/gas/i386/x86-64-disassem.d: Likewise. + 2019-06-27 Barnaby Wilk s * config/tc-arm.c (do_smc): Add range check for immediate operand. diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index abf77bee28..a6eb697c58 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,27 @@ +2019-06-27 H.J. Lu + + PR binutils/24719 + * i386-dis-evex-len.h: Add EVEX_LEN_0F38C6_REG_1_PREFIX_2, + EVEX_LEN_0F38C6_REG_2_PREFIX_2, EVEX_LEN_0F38C6_REG_5_PREFIX_2, + EVEX_LEN_0F38C6_REG_6_PREFIX_2, EVEX_LEN_0F38C7_R_1_P_2_W_0, + EVEX_LEN_0F38C7_R_1_P_2_W_1, EVEX_LEN_0F38C7_R_2_P_2_W_0, + EVEX_LEN_0F38C7_R_2_P_2_W_1, EVEX_LEN_0F38C7_R_5_P_2_W_0, + EVEX_LEN_0F38C7_R_5_P_2_W_1, EVEX_LEN_0F38C7_R_6_P_2_W_0 and + EVEX_LEN_0F38C7_R_6_P_2_W_1. + * i386-dis-evex-prefix.h: Update PREFIX_EVEX_0F38C6_REG_1, + PREFIX_EVEX_0F38C6_REG_2, PREFIX_EVEX_0F38C6_REG_5 and + PREFIX_EVEX_0F38C6_REG_6 entries. + * i386-dis-evex-w.h: Update EVEX_W_0F38C7_R_1_P_2, + EVEX_W_0F38C7_R_2_P_2, EVEX_W_0F38C7_R_5_P_2 and + EVEX_W_0F38C7_R_6_P_2 entries. + * i386-dis.c: Add EVEX_LEN_0F38C6_REG_1_PREFIX_2, + EVEX_LEN_0F38C6_REG_2_PREFIX_2, EVEX_LEN_0F38C6_REG_5_PREFIX_2, + EVEX_LEN_0F38C6_REG_6_PREFIX_2, EVEX_LEN_0F38C7_R_1_P_2_W_0, + EVEX_LEN_0F38C7_R_1_P_2_W_1, EVEX_LEN_0F38C7_R_2_P_2_W_0, + EVEX_LEN_0F38C7_R_2_P_2_W_1, EVEX_LEN_0F38C7_R_5_P_2_W_0, + EVEX_LEN_0F38C7_R_5_P_2_W_1, EVEX_LEN_0F38C7_R_6_P_2_W_0 and + EVEX_LEN_0F38C7_R_6_P_2_W_1 enums. + 2019-06-27 Jan Beulich * i386-dis.c (VEX_LEN_0F2A_P_1, VEX_LEN_0F2A_P_3, diff --git a/opcodes/i386-dis-evex-len.h b/opcodes/i386-dis-evex-len.h index 50b89ebc57..ce58199598 100644 --- a/opcodes/i386-dis-evex-len.h +++ b/opcodes/i386-dis-evex-len.h @@ -89,6 +89,90 @@ static const struct dis386 evex_len_table[][3] = { { "vbroadcasti64x4", { XM, EXymm }, 0 }, }, + /* EVEX_LEN_0F38C6_REG_1_PREFIX_2 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vgatherpf0dp%XW", { MVexVSIBDWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C6_REG_2_PREFIX_2 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vgatherpf1dp%XW", { MVexVSIBDWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C6_REG_5_PREFIX_2 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vscatterpf0dp%XW", { MVexVSIBDWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C6_REG_6_PREFIX_2 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vscatterpf1dp%XW", { MVexVSIBDWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_1_P_2_W_0 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vgatherpf0qps", { MVexVSIBDQWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_1_P_2_W_1 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vgatherpf0qpd", { MVexVSIBQWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_2_P_2_W_0 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vgatherpf1qps", { MVexVSIBDQWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_2_P_2_W_1 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vgatherpf1qpd", { MVexVSIBQWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_5_P_2_W_0 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vscatterpf0qps", { MVexVSIBDQWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_5_P_2_W_1 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vscatterpf0qpd", { MVexVSIBQWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_6_P_2_W_0 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vscatterpf1qps", { MVexVSIBDQWpX }, 0 }, + }, + + /* EVEX_LEN_0F38C7_R_6_P_2_W_1 */ + { + { Bad_Opcode }, + { Bad_Opcode }, + { "vscatterpf1qpd", { MVexVSIBQWpX }, 0 }, + }, + /* EVEX_LEN_0F3A18_P_2_W_0 */ { { Bad_Opcode }, diff --git a/opcodes/i386-dis-evex-prefix.h b/opcodes/i386-dis-evex-prefix.h index 261b01f0f7..248d7a299b 100644 --- a/opcodes/i386-dis-evex-prefix.h +++ b/opcodes/i386-dis-evex-prefix.h @@ -1557,25 +1557,25 @@ { { Bad_Opcode }, { Bad_Opcode }, - { "vgatherpf0dp%XW", { MVexVSIBDWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C6_REG_1_PREFIX_2) }, }, /* PREFIX_EVEX_0F38C6_REG_2 */ { { Bad_Opcode }, { Bad_Opcode }, - { "vgatherpf1dp%XW", { MVexVSIBDWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C6_REG_2_PREFIX_2) }, }, /* PREFIX_EVEX_0F38C6_REG_5 */ { { Bad_Opcode }, { Bad_Opcode }, - { "vscatterpf0dp%XW", { MVexVSIBDWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C6_REG_5_PREFIX_2) }, }, /* PREFIX_EVEX_0F38C6_REG_6 */ { { Bad_Opcode }, { Bad_Opcode }, - { "vscatterpf1dp%XW", { MVexVSIBDWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C6_REG_6_PREFIX_2) }, }, /* PREFIX_EVEX_0F38C7_REG_1 */ { diff --git a/opcodes/i386-dis-evex-w.h b/opcodes/i386-dis-evex-w.h index 2adfde9650..44e4b483e0 100644 --- a/opcodes/i386-dis-evex-w.h +++ b/opcodes/i386-dis-evex-w.h @@ -939,23 +939,23 @@ }, /* EVEX_W_0F38C7_R_1_P_2 */ { - { "vgatherpf0qps", { MVexVSIBDQWpX }, 0 }, - { "vgatherpf0qpd", { MVexVSIBQWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_1_P_2_W_0) }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_1_P_2_W_1) }, }, /* EVEX_W_0F38C7_R_2_P_2 */ { - { "vgatherpf1qps", { MVexVSIBDQWpX }, 0 }, - { "vgatherpf1qpd", { MVexVSIBQWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_2_P_2_W_0) }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_2_P_2_W_1) }, }, /* EVEX_W_0F38C7_R_5_P_2 */ { - { "vscatterpf0qps", { MVexVSIBDQWpX }, 0 }, - { "vscatterpf0qpd", { MVexVSIBQWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_5_P_2_W_0) }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_5_P_2_W_1) }, }, /* EVEX_W_0F38C7_R_6_P_2 */ { - { "vscatterpf1qps", { MVexVSIBDQWpX }, 0 }, - { "vscatterpf1qpd", { MVexVSIBQWpX }, 0 }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_6_P_2_W_0) }, + { EVEX_LEN_TABLE (EVEX_LEN_0F38C7_R_6_P_2_W_1) }, }, /* EVEX_W_0F3A00_P_2 */ { diff --git a/opcodes/i386-dis.c b/opcodes/i386-dis.c index 281d02c7c2..de9946222d 100644 --- a/opcodes/i386-dis.c +++ b/opcodes/i386-dis.c @@ -1939,6 +1939,18 @@ enum EVEX_LEN_0F385A_P_2_W_1, EVEX_LEN_0F385B_P_2_W_0, EVEX_LEN_0F385B_P_2_W_1, + EVEX_LEN_0F38C6_REG_1_PREFIX_2, + EVEX_LEN_0F38C6_REG_2_PREFIX_2, + EVEX_LEN_0F38C6_REG_5_PREFIX_2, + EVEX_LEN_0F38C6_REG_6_PREFIX_2, + EVEX_LEN_0F38C7_R_1_P_2_W_0, + EVEX_LEN_0F38C7_R_1_P_2_W_1, + EVEX_LEN_0F38C7_R_2_P_2_W_0, + EVEX_LEN_0F38C7_R_2_P_2_W_1, + EVEX_LEN_0F38C7_R_5_P_2_W_0, + EVEX_LEN_0F38C7_R_5_P_2_W_1, + EVEX_LEN_0F38C7_R_6_P_2_W_0, + EVEX_LEN_0F38C7_R_6_P_2_W_1, EVEX_LEN_0F3A18_P_2_W_0, EVEX_LEN_0F3A18_P_2_W_1, EVEX_LEN_0F3A19_P_2_W_0, -- 2.34.1