From 73fce654eb027eefa888a36d79097e6acf567fdc Mon Sep 17 00:00:00 2001 From: Alexandre Montplaisir Date: Fri, 14 Nov 2014 14:31:51 -0500 Subject: [PATCH] tmf: Execute TmfEventTable's request handler only on success The handler for the TmfTimeSynchSignal in TmfEventsTable sends an event request to "position" the experiment to the correct timestamp/event. This request executes a seek() on the experiment itself, and is located in the handleCompleted() callback. It should be moved to the handleSuccess() callback instead: this repositioning of the experiment should only be done when the request finishes succesfully. It should not be run if the request was cancelled, for example because the executor was flooded with requests and cancelled some of them. Partial fix for bug 451615. Change-Id: I905bb5d19aa0fe40f9d63bfd2e4f60d90aba3050 Signed-off-by: Alexandre Montplaisir Reviewed-on: https://git.eclipse.org/r/36517 Tested-by: Hudson CI --- .../tracecompass/tmf/ui/viewers/events/TmfEventsTable.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java b/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java index 958ba549b7..e01f4058c3 100644 --- a/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java +++ b/org.eclipse.tracecompass.tmf.ui/src/org/eclipse/tracecompass/tmf/ui/viewers/events/TmfEventsTable.java @@ -2463,8 +2463,8 @@ public class TmfEventsTable extends TmfComponent implements IGotoMarker, IColorS } @Override - public void handleCompleted() { - super.handleCompleted(); + public void handleSuccess() { + super.handleSuccess(); if (fTrace == null) { return; } -- 2.34.1