From 0256b5406e3a87a776df9dd262a7dace0f49e7b0 Mon Sep 17 00:00:00 2001 From: Abdul Hussain Date: Thu, 18 Jun 2015 12:37:00 +0000 Subject: [PATCH] Staging: wilc1000: NULL check before some freeing functions is not needed This patch removes check before freeing the memory since kfree(NULL) is safe Signed-off-by: Abdul Hussain Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/linux_wlan_spi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan_spi.c b/drivers/staging/wilc1000/linux_wlan_spi.c index 1eee1d560bc7..236669cfcd3a 100644 --- a/drivers/staging/wilc1000/linux_wlan_spi.c +++ b/drivers/staging/wilc1000/linux_wlan_spi.c @@ -214,8 +214,7 @@ int linux_spi_write(uint8_t *b, uint32_t len) PRINT_ER("SPI transaction failed\n"); } } - if (r_buffer) - kfree(r_buffer); + kfree(r_buffer); } else { PRINT_ER("can't write data with the following length: %d\n", len); PRINT_ER("FAILED due to NULL buffer or ZERO length check the following length: %d\n", len); @@ -377,8 +376,7 @@ int linux_spi_read(unsigned char *rb, unsigned long rlen) } } - if (t_buffer) - kfree(t_buffer); + kfree(t_buffer); } else { PRINT_ER("can't read data with the following length: %ld\n", rlen); ret = -1; -- 2.34.1