From 02cf60c7a42710ee0364698c436b6ca5e771374b Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 11 Apr 2019 13:00:48 -0600 Subject: [PATCH 1/1] Make "msg" const in internal_vproblem I noticed that the "msg" variable in internal_vproblem could be "const". This seems like an improvement because it can wind up in rodata. Tested by rebuilding. gdb/ChangeLog 2019-04-11 Tom Tromey * utils.c (internal_vproblem): Make "msg" const. --- gdb/ChangeLog | 4 ++++ gdb/utils.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a5cbc89972..7428ed9730 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2019-04-11 Tom Tromey + + * utils.c (internal_vproblem): Make "msg" const. + 2019-04-11 Alan Hayward * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs. diff --git a/gdb/utils.c b/gdb/utils.c index 840779a630..700f54f9ad 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -300,7 +300,7 @@ internal_vproblem (struct internal_problem *problem, /* Don't allow infinite error/warning recursion. */ { - static char msg[] = "Recursive internal problem.\n"; + static const char msg[] = "Recursive internal problem.\n"; switch (dejavu) { -- 2.34.1