From 1194676e0be8d28a2ed631fe2b8d560409240ff0 Mon Sep 17 00:00:00 2001 From: Tankut Baris Aktemur Date: Thu, 22 Apr 2021 17:22:39 +0200 Subject: [PATCH] gdb/continuations: do minor cleanup Inferior continuations are no longer used by the until and finish command. It is used only by the attach command and the remote target upon detecting new inferiors. Update the comment accordingly. Also update another comment about non-existent thread continuations and remove an unused #include. gdb/ChangeLog: 2021-04-22 Tankut Baris Aktemur * continuations.h: Update the general comment. * inferior.h (class inferior) : Update the comment. * interps.c: Do not include "continuations.h". --- gdb/ChangeLog | 6 ++++++ gdb/continuations.h | 4 ++-- gdb/inferior.h | 3 +-- gdb/interps.c | 1 - 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index c3fc5cdd31..55965a7510 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2021-04-22 Tankut Baris Aktemur + + * continuations.h: Update the general comment. + * inferior.h (class inferior) : Update the comment. + * interps.c: Do not include "continuations.h". + 2021-04-22 Tankut Baris Aktemur * continuations.h (do_all_inferior_continuations): Remove the 'err' diff --git a/gdb/continuations.h b/gdb/continuations.h index 7ebe82af1c..39130c65f0 100644 --- a/gdb/continuations.h +++ b/gdb/continuations.h @@ -25,8 +25,8 @@ struct inferior; /* To continue the execution commands when running gdb asynchronously. A continuation structure contains a pointer to a function to be called to finish the command, once the target has stopped. Such mechanism is - used by the finish and until commands, and in the remote protocol - when opening an extended-remote connection. */ + used by the attach command and the remote target when a new inferior + is detected. */ /* Prototype of the continuation callback functions. ARG is the continuation argument registered in the corresponding diff --git a/gdb/inferior.h b/gdb/inferior.h index 66fc180ce5..9ca510e4e6 100644 --- a/gdb/inferior.h +++ b/gdb/inferior.h @@ -509,8 +509,7 @@ public: bool detaching = false; /* What is left to do for an execution command after any thread of - this inferior stops. For continuations associated with a - specific thread, see `struct thread_info'. */ + this inferior stops. */ continuation *continuations = NULL; /* True if setup_inferior wasn't called for this inferior yet. diff --git a/gdb/interps.c b/gdb/interps.c index d15a36a426..ec19822b57 100644 --- a/gdb/interps.c +++ b/gdb/interps.c @@ -37,7 +37,6 @@ #include "interps.h" #include "completer.h" #include "top.h" /* For command_loop. */ -#include "continuations.h" #include "main.h" /* Each UI has its own independent set of interpreters. */ -- 2.34.1