From 220749ca9b3f579c95759559243887199ee12d64 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Genevi=C3=A8ve=20Bastien?= Date: Thu, 27 Oct 2016 12:26:23 -0400 Subject: [PATCH] tmf.core: Throw exception when no state system assigned MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Instead of just logging an error that will happen for each event and willl be very verbose, it should throw an exception. Change-Id: Iaedcf461ffa5e8d9ac8abd4f11e98e9f70f6259e Signed-off-by: Geneviève Bastien Reviewed-on: https://git.eclipse.org/r/84035 Reviewed-by: Hudson CI Reviewed-by: Matthew Khouzam Tested-by: Matthew Khouzam --- .../tmf/core/statesystem/AbstractTmfStateProvider.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/statesystem/AbstractTmfStateProvider.java b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/statesystem/AbstractTmfStateProvider.java index f9d74f948e..1dec0e0047 100644 --- a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/statesystem/AbstractTmfStateProvider.java +++ b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/tmf/core/statesystem/AbstractTmfStateProvider.java @@ -126,8 +126,7 @@ public abstract class AbstractTmfStateProvider implements ITmfStateProvider { public void processEvent(ITmfEvent event) { /* Make sure the target state system has been assigned */ if (!fStateSystemAssigned) { - Activator.logError("Cannot process event without a target state system"); //$NON-NLS-1$ - return; + throw new IllegalStateException("Cannot process event without a target state system. ID: " + getClass().getSimpleName()); //$NON-NLS-1$ } /* Insert the event we're received into the events queue */ -- 2.34.1