From 22aa1d51198689f5f3f01a874b405bf4449cbfb0 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Wed, 17 Jun 2020 07:39:11 -0700 Subject: [PATCH] ld: Require GCC 5 for Build pr25749-1b (-pie -fPIE) Before GCC 5, Build pr25749-1b (-pie -fPIE) won't trigger the expected linker error. * testsuite/ld-elf/linux-x86.exp: Require GCC 5 for Build pr25749-1b (-pie -fPIE). --- ld/ChangeLog | 5 +++++ ld/testsuite/ld-elf/linux-x86.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index ad268c8468..68b463e77d 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,8 @@ +2020-06-17 H.J. Lu + + * testsuite/ld-elf/linux-x86.exp: Require GCC 5 for Build + pr25749-1b (-pie -fPIE). + 2020-06-16 Alan Modra * testsuite/ld-elf/pr23428.c: Define _DEFAULT_SOURCE. diff --git a/ld/testsuite/ld-elf/linux-x86.exp b/ld/testsuite/ld-elf/linux-x86.exp index aae75d443f..7a311ae431 100644 --- a/ld/testsuite/ld-elf/linux-x86.exp +++ b/ld/testsuite/ld-elf/linux-x86.exp @@ -174,7 +174,7 @@ proc check_pr25749a {testname srcfilea srcfileb cflags ldflags lderror} { check_pr25749a "pr25749-1a" "pr25749-1.c" "pr25749-1a.c" "$NOPIE_CFLAGS" "$NOPIE_LDFLAGS" "" check_pr25749a "pr25749-1a" "pr25749-1.c" "pr25749-1a.c" "-fPIE" "-pie" "" check_pr25749a "pr25749-1b" "pr25749-1.c" "pr25749-1b.c" "$NOPIE_CFLAGS" "$NOPIE_LDFLAGS" "" -if { [istarget "i?86-*-linux*"] } { +if { [istarget "i?86-*-linux*"] || ![at_least_gcc_version 5 1] } { check_pr25749a "pr25749-1b" "pr25749-1.c" "pr25749-1b.c" "-fPIE" "-pie" "" } else { check_pr25749a "pr25749-1b" "pr25749-1.c" "pr25749-1b.c" "-fPIE" "-pie" "pr25749-1b.err" -- 2.34.1