From 22c90ac1cd796561ba5e9e7eec0bc16c92f0c7e0 Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Tue, 7 Jan 2014 18:12:21 +0800 Subject: [PATCH] Fix pointer assignment with different signedness MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch fixes these errors below: ../../binutils-gdb/gdb/spu-linux-nat.c: In function ‘spu_symbol_file_add_from_memory’: ../../binutils-gdb/gdb/spu-linux-nat.c:368:3: error: pointer targets in passing argument 2 of ‘spu_proc_xfer_spu’ differ in signedness [-Werror=pointer-sign] ../../binutils-gdb/gdb/spu-linux-nat.c:232:1: note: expected ‘gdb_byte *’ but argument is of type ‘char *’ ../../binutils-gdb/gdb/spu-linux-nat.c: In function ‘spu_xfer_partial’: ../../binutils-gdb/gdb/spu-linux-nat.c:598:7: error: pointer targets in passing argument 1 of ‘strtoulst’ differ in signedness [-Werror=pointer-sign] In file included from ../../binutils-gdb/gdb/defs.h:769:0, from ../../binutils-gdb/gdb/spu-linux-nat.c:21: ../../binutils-gdb/gdb/utils.h:43:15: note: expected ‘const char *’ but argument is of type ‘gdb_byte *’ gdb: 2014-01-08 Yao Qi * spu-linux-nat.c (spu_symbol_file_add_from_memory): Change type of 'id' to gdb_byte. Cast 'id' to 'const char *'. (spu_xfer_partial): Cast 'buf' to 'const char *'. --- gdb/ChangeLog | 6 ++++++ gdb/spu-linux-nat.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e5c7bdce82..01a0c56f59 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-01-08 Yao Qi + + * spu-linux-nat.c (spu_symbol_file_add_from_memory): Change + type of 'id' to gdb_byte. Cast 'id' to 'const char *'. + (spu_xfer_partial): Cast 'buf' to 'const char *'. + 2014-01-08 Yao Qi * spu-linux-nat.c (spu_symbol_file_add_from_memory): Pass diff --git a/gdb/spu-linux-nat.c b/gdb/spu-linux-nat.c index cfd5fd96a9..4c62ec7457 100644 --- a/gdb/spu-linux-nat.c +++ b/gdb/spu-linux-nat.c @@ -359,7 +359,7 @@ spu_symbol_file_add_from_memory (int inferior_fd) ULONGEST addr; struct bfd *nbfd; - char id[128]; + gdb_byte id[128]; char annex[32]; int len; @@ -369,7 +369,7 @@ spu_symbol_file_add_from_memory (int inferior_fd) if (len <= 0 || len >= sizeof id) return; id[len] = 0; - addr = strtoulst (id, NULL, 16); + addr = strtoulst ((const char *) id, NULL, 16); if (!addr) return; @@ -596,7 +596,7 @@ spu_xfer_partial (struct target_ops *ops, if (spu_proc_xfer_spu (lslr_annex, buf, NULL, 0, sizeof buf) <= 0) return ret; - lslr = strtoulst (buf, NULL, 16); + lslr = strtoulst ((const char *) buf, NULL, 16); return spu_proc_xfer_spu (mem_annex, readbuf, writebuf, offset & lslr, len); } -- 2.34.1