From 3015c06465584a437261c65a397fbd8f1a71aae7 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 12 Jan 2017 11:15:01 -0500 Subject: [PATCH] Update comment in remote_can_async_p I find this comment counter intuitive, and it probably predates the always-target-async change. AFAIK, remote will always be async, unless the user explicitly prevents it with "maint set target-async off". gdb/ChangeLog: * remote.c (remote_can_async_p): Update comment. --- gdb/ChangeLog | 4 ++++ gdb/remote.c | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 27aa3941a6..bf0930fa62 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-01-12 Simon Marchi + + * remote.c (remote_can_async_p): Update comment. + 2017-01-12 Simon Marchi * linux-nat.c (linux_nat_can_async_p): Update comment. diff --git a/gdb/remote.c b/gdb/remote.c index 837b9ee512..c73c30aacd 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -13653,8 +13653,9 @@ remote_can_async_p (struct target_ops *ops) { struct remote_state *rs = get_remote_state (); + /* We don't go async if the user has explicitly prevented it with the + "maint set target-async" command. */ if (!target_async_permitted) - /* We only enable async when the user specifically asks for it. */ return 0; /* We're async whenever the serial device is. */ -- 2.34.1