From 4af08f2f47f0ed3c48e557ac47ed2ae616d6866b Mon Sep 17 00:00:00 2001 From: Ingo Molnar Date: Fri, 3 Apr 2015 11:01:36 +0200 Subject: [PATCH] x86/fpu: Add comments to fpu__save() and restrict its export Add an explanation to fpu__save() and also don't export it to random modules - we don't want them to futz around with deep kernel internals. Reviewed-by: Borislav Petkov Cc: Andy Lutomirski Cc: Dave Hansen Cc: Fenghua Yu Cc: H. Peter Anvin Cc: Linus Torvalds Cc: Oleg Nesterov Cc: Peter Zijlstra Cc: Thomas Gleixner Signed-off-by: Ingo Molnar --- arch/x86/kernel/i387.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c index ec1a744eb853..ac47278cde71 100644 --- a/arch/x86/kernel/i387.c +++ b/arch/x86/kernel/i387.c @@ -117,6 +117,9 @@ void __kernel_fpu_end(void) } EXPORT_SYMBOL(__kernel_fpu_end); +/* + * Save the FPU state (initialize it if necessary): + */ void fpu__save(struct task_struct *tsk) { preempt_disable(); @@ -130,7 +133,7 @@ void fpu__save(struct task_struct *tsk) } preempt_enable(); } -EXPORT_SYMBOL(fpu__save); +EXPORT_SYMBOL_GPL(fpu__save); unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu; unsigned int xstate_size; -- 2.34.1