From 5013824590f59374106007d4c9724d5767911d75 Mon Sep 17 00:00:00 2001 From: Alan Hayward Date: Fri, 23 Nov 2018 11:46:34 +0000 Subject: [PATCH] gdbserver: AArch64: Remove cannot_fetch/store_register The cannot store/fetch register functions are only used for checking if a register can be accessed using PEEKUSER/POKEUSER. The AArch64 port doesn't support this method of access, so remove the unused functions. gdb/gdbserver: * linux-aarch64-low.c (aarch64_cannot_store_register): Remove. (aarch64_cannot_fetch_register): Likewise. (struct linux_target_ops): Update references. --- gdb/gdbserver/ChangeLog | 6 ++++++ gdb/gdbserver/linux-aarch64-low.c | 20 ++------------------ 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 1b016d573c..91a62b6228 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,9 @@ +2018-11-23 Alan Hayward + + * linux-aarch64-low.c (aarch64_cannot_store_register): Remove. + (aarch64_cannot_fetch_register): Likewise. + (struct linux_target_ops): Update references. + 2018-10-31 Pedro Franco de Carvalho * linux-ppc-low.c: Include nat/linux-ptrace.h. diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 1d34e319df..181e2666ab 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -84,22 +84,6 @@ is_sve_tdesc (void) return regcache->tdesc->reg_defs.size () == AARCH64_SVE_NUM_REGS; } -/* Implementation of linux_target_ops method "cannot_store_register". */ - -static int -aarch64_cannot_store_register (int regno) -{ - return regno >= AARCH64_NUM_REGS; -} - -/* Implementation of linux_target_ops method "cannot_fetch_register". */ - -static int -aarch64_cannot_fetch_register (int regno) -{ - return regno >= AARCH64_NUM_REGS; -} - static void aarch64_fill_gregset (struct regcache *regcache, void *buf) { @@ -3041,8 +3025,8 @@ struct linux_target_ops the_low_target = { aarch64_arch_setup, aarch64_regs_info, - aarch64_cannot_fetch_register, - aarch64_cannot_store_register, + NULL, /* cannot_fetch_register */ + NULL, /* cannot_store_register */ NULL, /* fetch_register */ aarch64_get_pc, aarch64_set_pc, -- 2.34.1