From 560e259de7a308949b1312d05bfd6c67e3f3f201 Mon Sep 17 00:00:00 2001 From: Jean-Christian Kouame Date: Mon, 23 Nov 2015 16:40:54 -0500 Subject: [PATCH] tmf : Avoid concatenating nonliterals in a StringBuilder Change-Id: I78d9c69e192aab744b110909f050b556baa929d9 Signed-off-by: Jean-Christian Kouame Reviewed-on: https://git.eclipse.org/r/61074 Reviewed-by: Matthew Khouzam Reviewed-by: Hudson CI Reviewed-by: Bernd Hufmann Tested-by: Bernd Hufmann --- .../tmf/core/trace/experiment/TmfLocationArray.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/trace/experiment/TmfLocationArray.java b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/trace/experiment/TmfLocationArray.java index fa5428e6be..82a9dfaa6c 100644 --- a/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/trace/experiment/TmfLocationArray.java +++ b/tmf/org.eclipse.tracecompass.tmf.core/src/org/eclipse/tracecompass/internal/tmf/core/trace/experiment/TmfLocationArray.java @@ -190,14 +190,19 @@ public final class TmfLocationArray implements Comparable { @SuppressWarnings("nls") public String toString() { StringBuilder sb = new StringBuilder(); - sb.append(getClass().getSimpleName() + " ["); + sb.append(getClass().getSimpleName()); + sb.append(" ["); for (int i = 0; i < fLocations.length; i++) { if (i > 0) { sb.append(", "); } - sb.append("[location=" + fLocations[i] + ",rank=" + fRanks[i] + "]"); + sb.append("[location="); + sb.append(fLocations[i]); + sb.append(",rank="); + sb.append(fRanks[i]); + sb.append(']'); } - sb.append("]"); + sb.append(']'); return sb.toString(); } -- 2.34.1