From 68ef50f6cb39b78e0e3e5007d16d644c2f18acab Mon Sep 17 00:00:00 2001 From: H Hartley Sweeten Date: Fri, 7 Mar 2014 17:31:23 -0700 Subject: [PATCH] staging: comedi: comedi_fc: tidy up cfc_bytes_per_scan() This function returns the total number of bytes for a full scan of an async command chanlist. The returned value is an unsigned int. Change all the local variables to unsigned int and use a local variable for the s->async->cmd.chanlist_len. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_fc.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi_fc.h b/drivers/staging/comedi/drivers/comedi_fc.h index 042bf87918c6..b8d125e81a0f 100644 --- a/drivers/staging/comedi/drivers/comedi_fc.h +++ b/drivers/staging/comedi/drivers/comedi_fc.h @@ -47,19 +47,20 @@ unsigned int cfc_handle_events(struct comedi_device *, static inline unsigned int cfc_bytes_per_scan(struct comedi_subdevice *s) { - int num_samples; - int bits_per_sample; + unsigned int chanlist_len = s->async->cmd.chanlist_len; + unsigned int num_samples; + unsigned int bits_per_sample; switch (s->type) { case COMEDI_SUBD_DI: case COMEDI_SUBD_DO: case COMEDI_SUBD_DIO: bits_per_sample = 8 * bytes_per_sample(s); - num_samples = (s->async->cmd.chanlist_len + - bits_per_sample - 1) / bits_per_sample; + num_samples = (chanlist_len + bits_per_sample - 1) / + bits_per_sample; break; default: - num_samples = s->async->cmd.chanlist_len; + num_samples = chanlist_len; break; } return num_samples * bytes_per_sample(s); -- 2.34.1