From 779bc38eca950c7f3b64173e99e25f0c0edfbe3b Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 1 Nov 2017 18:52:30 -0600 Subject: [PATCH] Use gdb::byte_vector in ppc-linux-tdep.c This removes a cleanup from ppc-linux-tdep.c, replacing it with gdb::byte_vector. gdb/ChangeLog 2017-11-04 Tom Tromey * ppc-linux-tdep.c (ppc_linux_get_syscall_number): Use gdb::byte_vector. --- gdb/ChangeLog | 5 +++++ gdb/ppc-linux-tdep.c | 17 ++++------------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6db35dd1e1..d6c4b6f805 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-11-04 Tom Tromey + + * ppc-linux-tdep.c (ppc_linux_get_syscall_number): Use + gdb::byte_vector. + 2017-11-04 Tom Tromey * objfiles.c (do_free_objfile_cleanup): Remove. diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c index 847908a6da..ee80a71c6b 100644 --- a/gdb/ppc-linux-tdep.c +++ b/gdb/ppc-linux-tdep.c @@ -725,28 +725,19 @@ ppc_linux_get_syscall_number (struct gdbarch *gdbarch, struct regcache *regcache = get_thread_regcache (ptid); struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); - struct cleanup *cleanbuf; - /* The content of a register */ - gdb_byte *buf; - /* The result */ - LONGEST ret; /* Make sure we're in a 32- or 64-bit machine */ gdb_assert (tdep->wordsize == 4 || tdep->wordsize == 8); - buf = (gdb_byte *) xmalloc (tdep->wordsize * sizeof (gdb_byte)); - - cleanbuf = make_cleanup (xfree, buf); + /* The content of a register */ + gdb::byte_vector buf (tdep->wordsize); /* Getting the system call number from the register. When dealing with PowerPC architecture, this information is stored at 0th register. */ - regcache_cooked_read (regcache, tdep->ppc_gp0_regnum, buf); - - ret = extract_signed_integer (buf, tdep->wordsize, byte_order); - do_cleanups (cleanbuf); + regcache_cooked_read (regcache, tdep->ppc_gp0_regnum, buf.data ()); - return ret; + return extract_signed_integer (buf.data (), tdep->wordsize, byte_order); } /* PPC process record-replay */ -- 2.34.1