From 811bdca093965e857e4f4473fbf336da2a93518a Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Tue, 17 Nov 2020 14:52:49 +0000 Subject: [PATCH] Fix gdb.trace testcase build failures with Clang 25 gdb.trace tests failed to build on x86 with Clang because the x86_trace_dummy function is optimized out, causing the builds to fail with variations on the following error: gdb compile failed, /usr/bin/ld: /gdbtest/build/gdb/testsuite/outputs/gdb.trace/backtrace/backtrace0.o: in function `main': /gdbtest/src/gdb/testsuite/gdb.trace/actions.c:146: undefined reference to `x86_trace_dummy' clang-12: error: linker command failed with exit code 1 This commit adds __attribute__ ((used)) to x86_trace_dummy to prevent this. gdb/testsuite/ChangeLog: * gdb.trace/trace-common.h (x86_trace_dummy): Add __attribute__ ((used)). --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.trace/trace-common.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 9c326d5243..14b3da5911 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-11-17 Gary Benson + + * gdb.trace/trace-common.h (x86_trace_dummy): Add + __attribute__ ((used)). + 2020-11-17 Andrew Burgess * gdb.gdb/unittest.exp: Spot 'Running...' lines. diff --git a/gdb/testsuite/gdb.trace/trace-common.h b/gdb/testsuite/gdb.trace/trace-common.h index a83f110544..2354c0cd4a 100644 --- a/gdb/testsuite/gdb.trace/trace-common.h +++ b/gdb/testsuite/gdb.trace/trace-common.h @@ -30,7 +30,7 @@ #if (defined __x86_64__ || defined __i386__) -static void +static void __attribute__ ((used)) x86_trace_dummy () { int x = 0; -- 2.34.1