From 87a46909b36ad191352bfb7ac596d2c9c6901ef5 Mon Sep 17 00:00:00 2001 From: Guillaume Morin Date: Sat, 28 Jun 2014 16:54:00 +0100 Subject: [PATCH] staging: iio: ad9850.c: code cleanup checkpath.pl was complaining about value_mask: ERROR: Macros with complex values should be enclosed in parenthesis I fixed this by simply removing it since it's not used (as well as another macro). Got rid of the un-necessary error_ret label as well. Signed-off-by: Guillaume Morin Reported-by: Michael Welling Acked-by: Greg Kroah-Hartman Signed-off-by: Jonathan Cameron --- drivers/staging/iio/frequency/ad9850.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9850.c b/drivers/staging/iio/frequency/ad9850.c index af877ff680e9..8727933cafcf 100644 --- a/drivers/staging/iio/frequency/ad9850.c +++ b/drivers/staging/iio/frequency/ad9850.c @@ -21,9 +21,6 @@ #define DRV_NAME "ad9850" -#define value_mask (u16)0xf000 -#define addr_shift 12 - /* Register format: 4 bits addr + 12 bits value */ struct ad9850_config { u8 control[5]; @@ -50,9 +47,6 @@ static ssize_t ad9850_set_parameter(struct device *dev, mutex_lock(&st->lock); ret = spi_sync_transfer(st->sdev, &xfer, 1); - if (ret) - goto error_ret; -error_ret: mutex_unlock(&st->lock); return ret ? ret : len; -- 2.34.1