From 9a83b7591082fc0007b9aafb8cd85992c32341f4 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Thu, 27 Oct 2022 21:36:05 -0400 Subject: [PATCH 1/1] Handle 0 cb unregister as NOENT error Signed-off-by: Mathieu Desnoyers --- src/side.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/side.c b/src/side.c index 14788d7..5c2dac4 100644 --- a/src/side.c +++ b/src/side.c @@ -179,17 +179,13 @@ int _side_tracer_callback_unregister(struct side_event_description *desc, if (!call) return SIDE_ERROR_INVAL; pthread_mutex_lock(&side_lock); - old_nr_cb = *desc->enabled & SIDE_EVENT_ENABLED_USER_MASK; - if (old_nr_cb == 0) { - ret = SIDE_ERROR_INVAL; - goto unlock; - } - old_cb = (struct side_callback *) desc->callbacks; cb_pos = side_tracer_callback_lookup(desc, call, priv); if (!cb_pos) { ret = SIDE_ERROR_NOENT; goto unlock; } + old_nr_cb = *desc->enabled & SIDE_EVENT_ENABLED_USER_MASK; + old_cb = (struct side_callback *) desc->callbacks; if (old_nr_cb == 1) { new_cb = (struct side_callback *) &side_empty_callback; } else { -- 2.34.1