From abe0b77558e8a3e5ee017ec25a426bf1fd5a0562 Mon Sep 17 00:00:00 2001 From: Giedrius Statkevicius Date: Sat, 29 Nov 2014 00:14:27 +0200 Subject: [PATCH] hp_wireless: Inform the user if hp_wireless_input_setup()/add() fails In hpwl_add() there is a unused variable err to which we assign the result of hp_wireless_input_setup() but we don't do anything depending on the result so print out a message that informs the user if add() (hp_wireless_input_setup()) fails since acpi_device_probe() doesn't print anything in this case. Signed-off-by: Giedrius Statkevicius Signed-off-by: Darren Hart --- drivers/platform/x86/hp-wireless.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/x86/hp-wireless.c index 415348fc1210..4e4cc8bd7557 100644 --- a/drivers/platform/x86/hp-wireless.c +++ b/drivers/platform/x86/hp-wireless.c @@ -85,6 +85,9 @@ static int hpwl_add(struct acpi_device *device) int err; err = hp_wireless_input_setup(); + if (err) + pr_err("Failed to setup hp wireless hotkeys\n"); + return err; } -- 2.34.1