From c802e8a76c4eaa3a8a62d7dcfe7be98bf718a2f0 Mon Sep 17 00:00:00 2001 From: Gary Benson Date: Tue, 16 Jun 2020 12:41:28 +0100 Subject: [PATCH] Add two missing return values in gdb.python/py-nested-maps.c Two functions in gdb.python/py-nested-maps.c are missing return values. This causes clang to fail to compile the file with the following error: warning: control reaches end of non-void function [-Wreturn-type] This commit fixes, by causing the two functions to return pointers to the objects they've just allocated and initialized. I didn't investigate how this test had been passing with other compilers; I'm assuming serendipity, that in each function the value to be returned was already in the register it would need to be in to be the function's return value. gdb/testsuite/ChangeLog: * gdb.python/py-nested-maps.c (create_map): Add missing return value. (create_map_map): Likewise. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/gdb.python/py-nested-maps.c | 2 ++ 2 files changed, 8 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 6fe1877132..d2ed9db4eb 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2020-06-16 Gary Benson + + * gdb.python/py-nested-maps.c (create_map): Add missing return + value. + (create_map_map): Likewise. + 2020-06-15 Tankut Baris Aktemur * gdb.base/jit-elf-so.exp: Refer to the global main_loader_basename diff --git a/gdb/testsuite/gdb.python/py-nested-maps.c b/gdb/testsuite/gdb.python/py-nested-maps.c index 665efa1b5a..860b473ea4 100644 --- a/gdb/testsuite/gdb.python/py-nested-maps.c +++ b/gdb/testsuite/gdb.python/py-nested-maps.c @@ -62,6 +62,7 @@ create_map (const char *name) m->keys = NULL; m->values = NULL; m->show_header = 0; + return m; } void @@ -85,6 +86,7 @@ create_map_map (void) mm->length = 0; mm->values = NULL; mm->show_header = 0; + return mm; } void -- 2.34.1