From c943d9688f4d0453bef47fd6e23907381c595ddb Mon Sep 17 00:00:00 2001 From: Monam Agarwal Date: Thu, 6 Mar 2014 02:25:30 +0530 Subject: [PATCH] Staging: wlags49_h2: Fix Sparse Warning for Static Declarations in dhf.c This patch fixes the following sparse warnings: drivers/staging/wlags49_h2/dhf.c:109:6: warning: symbol 'signature' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:126:25: warning: symbol 'mfi_sup' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:127:25: warning: symbol 'cfi_sup' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:142:17: warning: symbol 'ltv_info' was not declared. Should it be static? drivers/staging/wlags49_h2/dhf.c:173:1: warning: symbol 'check_comp_fw' was not declared. Should it be static? Signed-off-by: Monam Agarwal Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wlags49_h2/dhf.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wlags49_h2/dhf.c b/drivers/staging/wlags49_h2/dhf.c index 13d360fa58ec..4877464f04b0 100644 --- a/drivers/staging/wlags49_h2/dhf.c +++ b/drivers/staging/wlags49_h2/dhf.c @@ -106,7 +106,7 @@ *---------------------------------------------------------------------------*/ /* 12345678901234 */ -char signature[14] = "FUPU7D37dhfwci"; +static char signature[14] = "FUPU7D37dhfwci"; /*----------------------------------------------------------------------------- * @@ -123,8 +123,8 @@ char signature[14] = "FUPU7D37dhfwci"; #define DL_SIZE 2000 /* CFG_IDENTITY_STRCT pri_identity = { LOF(CFG_IDENTITY_STRCT), CFG_PRI_IDENTITY }; */ -CFG_SUP_RANGE_STRCT mfi_sup = { LOF(CFG_SUP_RANGE_STRCT), CFG_NIC_MFI_SUP_RANGE }; -CFG_SUP_RANGE_STRCT cfi_sup = { LOF(CFG_SUP_RANGE_STRCT), CFG_NIC_CFI_SUP_RANGE }; +static CFG_SUP_RANGE_STRCT mfi_sup = { LOF(CFG_SUP_RANGE_STRCT), CFG_NIC_MFI_SUP_RANGE }; +static CFG_SUP_RANGE_STRCT cfi_sup = { LOF(CFG_SUP_RANGE_STRCT), CFG_NIC_CFI_SUP_RANGE }; /* Note: could be used rather than the above explained and defined DL_SIZE if need arises * CFG_DL_BUF_STRCT dl_buf = { LOF(CFG_DL_BUF_STRCT), CFG_DL_BUF }; */ @@ -139,7 +139,7 @@ CFG_SUP_RANGE_STRCT cfi_sup = { LOF(CFG_SUP_RANGE_STRCT), CFG_NIC_CFI_S * This is only relevant if the DHF used without reloading the driver/utility. */ -LTV_INFO_STRUCT ltv_info[] = { +static LTV_INFO_STRUCT ltv_info[] = { { (LTVP)&mfi_sup, LOF(CFG_SUP_RANGE_STRCT) } , { (LTVP)&cfi_sup, LOF(CFG_SUP_RANGE_STRCT) } , { (LTVP) NULL, 0 } @@ -169,7 +169,7 @@ static int check_comp_fw(memimage *fw); * station firmware image to be downloaded is compatible. *.ENDDOC END DOCUMENTATION *************************************************************************************************************/ -int +static int check_comp_fw(memimage *fw) { CFG_RANGE20_STRCT *p; -- 2.34.1