From d42076962798cd2329090cea213e797f4c69c03c Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 20 Sep 2019 11:34:21 -0600 Subject: [PATCH] Fix crash in Ada "catch exception" PR ada/24919 concerns a crash that Tom de Vries noticed when running the "catch_ex" Ada test case. He sent a test executable and tracked this down to commit f21c2bd7b7 ("Fix Fortran regression with variables in nested functions"). Looking at that patch, you can see the obvious error: - return 0; + return true; Oops! This patch fixes the bug. Tested on x86-64 Fedora 29. gdb/ChangeLog 2019-09-20 Tom Tromey PR ada/24919: * block.c (contained_in): Fix final return value. --- gdb/ChangeLog | 5 +++++ gdb/block.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5314b2746b..b1c4db854b 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2019-09-20 Tom Tromey + + PR ada/24919: + * block.c (contained_in): Fix final return value. + 2019-09-20 Alan Modra * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata. diff --git a/gdb/block.c b/gdb/block.c index ca4dc22cf3..5ba44d47ba 100644 --- a/gdb/block.c +++ b/gdb/block.c @@ -86,7 +86,7 @@ contained_in (const struct block *a, const struct block *b, } while (a != NULL); - return true; + return false; } -- 2.34.1