From d4b32646468088323f27a7788ce3b07191015142 Mon Sep 17 00:00:00 2001 From: Vitaly Osipov Date: Thu, 5 Jun 2014 04:07:48 -0300 Subject: [PATCH] [media] staging: omap4iss: copy paste error in iss_get_clocks It makes more sense to return PTR_ERR(iss->iss_ctrlclk) here. The current code looks like an oversight in pasting the block just above this one. Signed-off-by: Vitaly Osipov Acked-by: Laurent Pinchart Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/omap4iss/iss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c index d548371db65a..8a23d164e847 100644 --- a/drivers/staging/media/omap4iss/iss.c +++ b/drivers/staging/media/omap4iss/iss.c @@ -1014,6 +1014,7 @@ static int iss_get_clocks(struct iss_device *iss) iss->iss_ctrlclk = devm_clk_get(iss->dev, "iss_ctrlclk"); if (IS_ERR(iss->iss_ctrlclk)) { dev_err(iss->dev, "Unable to get iss_ctrlclk clock info\n"); + iss_put_clocks(iss); return PTR_ERR(iss->iss_ctrlclk); } -- 2.34.1