From d72314c67b7cc65ae935ad3dd80a6b1840b57d1a Mon Sep 17 00:00:00 2001 From: Vladimir Prus Date: Sat, 26 Jul 2008 10:23:56 +0000 Subject: [PATCH 1/1] Kill cmd_async_ok. * cli/cli-decode.h (CMD_ASYNC_OK, set_cmd_async_ok) (get_cmd_async_ok): Remove. * cli/cli-decode.c (set_cmd_async_ok, get_cmd_async_ok): Remove. * cli/cli-cmds.c (init_cli_cmds): Don't use set_cmd_async_ok. * infcmd.c (_initialize_infcmd): Likewise. * thread.c (_initialize_thread): Likewise. --- gdb/ChangeLog | 10 ++++++++++ gdb/cli/cli-cmds.c | 4 ---- gdb/cli/cli-decode.c | 12 ------------ gdb/cli/cli-decode.h | 10 ---------- gdb/infcmd.c | 2 -- gdb/thread.c | 4 ---- 6 files changed, 10 insertions(+), 32 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index b28693cc2e..d1458ad4bf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,13 @@ +2008-07-26 Vladimir Prus + + Kill cmd_async_ok. + * cli/cli-decode.h (CMD_ASYNC_OK, set_cmd_async_ok) + (get_cmd_async_ok): Remove. + * cli/cli-decode.c (set_cmd_async_ok, get_cmd_async_ok): Remove. + * cli/cli-cmds.c (init_cli_cmds): Don't use set_cmd_async_ok. + * infcmd.c (_initialize_infcmd): Likewise. + * thread.c (_initialize_thread): Likewise. + 2008-07-25 Joseph Myers * mips-tdep.c (mips_n32n64_push_dummy_call): Handle passing diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index efd31376e5..8dc178e83d 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -1244,7 +1244,6 @@ The commands below can be used to select other frames by number or address."), c = add_com ("pwd", class_files, pwd_command, _("\ Print working directory. This is used for your program as well.")); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); c = add_cmd ("cd", class_files, cd_command, _("\ @@ -1286,7 +1285,6 @@ when GDB is started."), gdbinit); c = add_com ("help", class_support, help_command, _("Print list of commands.")); set_cmd_completer (c, command_completer); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); add_com_alias ("q", "quit", class_support, 1); add_com_alias ("h", "help", class_support, 1); @@ -1316,7 +1314,6 @@ Without an argument, history expansion is enabled."), c = add_prefix_cmd ("info", class_info, info_command, _("\ Generic command for showing things about the program being debugged."), &infolist, "info ", 0, &cmdlist); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); add_com_alias ("i", "info", class_info, 1); @@ -1326,7 +1323,6 @@ Generic command for showing things about the program being debugged."), c = add_prefix_cmd ("show", class_info, show_command, _("\ Generic command for showing things about the debugger."), &showlist, "show ", 0, &cmdlist); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); /* Another way to get at the same thing. */ add_info ("set", show_command, _("Show all GDB settings.")); diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c index 07bb5878e2..690831466b 100644 --- a/gdb/cli/cli-decode.c +++ b/gdb/cli/cli-decode.c @@ -105,18 +105,6 @@ get_cmd_context (struct cmd_list_element *cmd) return cmd->context; } -void -set_cmd_async_ok (struct cmd_list_element *cmd) -{ - cmd->flags |= CMD_ASYNC_OK; -} - -int -get_cmd_async_ok (struct cmd_list_element *cmd) -{ - return cmd->flags & CMD_ASYNC_OK; -} - void set_cmd_no_selected_thread_ok (struct cmd_list_element *cmd) { diff --git a/gdb/cli/cli-decode.h b/gdb/cli/cli-decode.h index c7903984f6..4e2dbc159f 100644 --- a/gdb/cli/cli-decode.h +++ b/gdb/cli/cli-decode.h @@ -48,9 +48,6 @@ cmd_types; #define DEPRECATED_WARN_USER 0x2 #define MALLOCED_REPLACEMENT 0x4 -/* This flag is set if the command is allowed during async execution. */ -#define CMD_ASYNC_OK 0x8 - /* This flag is set if the command is allowed to run when the target has execution, but there's no selected thread. */ #define CMD_NO_SELECTED_THREAD_OK 0x10 @@ -250,13 +247,6 @@ extern int cmd_cfunc_eq (struct cmd_list_element *cmd, extern void set_cmd_context (struct cmd_list_element *cmd, void *context); extern void *get_cmd_context (struct cmd_list_element *cmd); -/* Mark command as async-ready; there is no way to disable this once - set. */ -extern void set_cmd_async_ok (struct cmd_list_element *); - -/* Return true if command is async-ok. */ -extern int get_cmd_async_ok (struct cmd_list_element *); - /* Mark command as ok to call when there is no selected thread. There is no way to disable this once set. */ extern void set_cmd_no_selected_thread_ok (struct cmd_list_element *); diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 8184cf04c5..e4198b5018 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -2390,7 +2390,6 @@ continue all stopped threads in non-stop mode, use the -a option.\n\ Specifying -a and an ignore count simultaneously is an error.")); add_com_alias ("c", "cont", class_run, 1); add_com_alias ("fg", "cont", class_run, 1); - set_cmd_async_ok (c); c = add_com ("run", class_run, run_command, _("\ Start debugged program. You may specify arguments to give it.\n\ @@ -2416,7 +2415,6 @@ You may specify arguments to give to your program, just as with the\n\ If non-stop mode is enabled, interrupt only the current thread,\n\ otherwise all the threads in the program are stopped. To \n\ interrupt all running threads in non-stop mode, use the -a option.")); - set_cmd_async_ok (c); add_info ("registers", nofp_registers_info, _("\ List of integer registers and their contents, for selected stack frame.\n\ diff --git a/gdb/thread.c b/gdb/thread.c index 0767aa04b3..f90606ce69 100644 --- a/gdb/thread.c +++ b/gdb/thread.c @@ -1243,25 +1243,21 @@ _initialize_thread (void) c = add_info ("threads", info_threads_command, _("IDs of currently known threads.")); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); c = add_prefix_cmd ("thread", class_run, thread_command, _("\ Use this command to switch between threads.\n\ The new thread ID must be currently known."), &thread_cmd_list, "thread ", 1, &cmdlist); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); c = add_prefix_cmd ("apply", class_run, thread_apply_command, _("Apply a command to a list of threads."), &thread_apply_list, "thread apply ", 1, &thread_cmd_list); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); c = add_cmd ("all", class_run, thread_apply_all_command, _("Apply a command to all threads."), &thread_apply_list); - set_cmd_async_ok (c); set_cmd_no_selected_thread_ok (c); if (!xdb_commands) -- 2.34.1