From da1a4b39d333c503762aaca9571caa6ea7451891 Mon Sep 17 00:00:00 2001 From: Bernd Hufmann Date: Fri, 17 May 2013 15:21:21 -0400 Subject: [PATCH] tmf: fix comments about ITmfTrace.validate() return value Change-Id: Ieb686dd9a776372a84115d79b5f7b5a5000b2bb6 Signed-off-by: Bernd Hufmann Reviewed-on: https://git.eclipse.org/r/12946 Reviewed-by: Alexandre Montplaisir IP-Clean: Alexandre Montplaisir Tested-by: Hudson CI --- .../src/org/eclipse/linuxtools/tmf/core/trace/ITmfTrace.java | 2 +- .../src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/ITmfTrace.java b/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/ITmfTrace.java index 8ee674df2d..24ccaa1a91 100644 --- a/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/ITmfTrace.java +++ b/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/ITmfTrace.java @@ -149,7 +149,7 @@ public interface ITmfTrace extends ITmfDataProvider { * @param project the eclipse project * @param path the trace path * - * @return true if trace is valid + * @return an IStatus object with validation result. Use severity OK to indicate success. * @since 2.0 */ IStatus validate(IProject project, String path); diff --git a/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java b/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java index c24238a365..5a9fd53599 100644 --- a/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java +++ b/org.eclipse.linuxtools.tmf.core/src/org/eclipse/linuxtools/tmf/core/trace/TmfTrace.java @@ -47,7 +47,7 @@ import org.eclipse.linuxtools.tmf.core.timestamp.TmfTimestamp; *
  • public double getLocationRatio(ITmfLocation location) *
  • public ITmfContext seekEvent(ITmfLocation location) *
  • public ITmfContext seekEvent(double ratio) - *
  • public boolean validate(IProject project, String path) + *
  • public IStatus validate(IProject project, String path) * * A concrete trace must provide its corresponding parser. A common way to * accomplish this is by making the concrete class extend TmfTrace and -- 2.34.1