From e4ae357fe8d4a337ae4bdd4cabb8286cb128819c Mon Sep 17 00:00:00 2001 From: Jozef Lawrynowicz Date: Mon, 3 Aug 2020 15:04:58 +0100 Subject: [PATCH] MSP430: Remove unused -md GAS option The MSP430 GAS option "-md" is supposed to indicate that the CRT startup code should copy data from ROM to RAM at startup. However, this option has no effect; GAS handles the related behaviour automatically by looking for the presence of certain symbols in the input file. gas/ChangeLog: * config/tc-msp430.c (OPTION_MOVE_DATA): Remove. (md_parse_option): Remove case for OPTION_MOVE_DATA. (md_longopts): Remove "md" entry. (md_show_usage): Likewise. --- gas/ChangeLog | 7 +++++++ gas/config/tc-msp430.c | 9 --------- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index 8dee8190b0..ea259234b0 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,10 @@ +2020-08-03 Jozef Lawrynowicz + + * config/tc-msp430.c (OPTION_MOVE_DATA): Remove. + (md_parse_option): Remove case for OPTION_MOVE_DATA. + (md_longopts): Remove "md" entry. + (md_show_usage): Likewise. + 2020-07-30 H.J. Lu PR gas/26305 diff --git a/gas/config/tc-msp430.c b/gas/config/tc-msp430.c index 840e5137ae..df03c5d969 100644 --- a/gas/config/tc-msp430.c +++ b/gas/config/tc-msp430.c @@ -685,8 +685,6 @@ static bfd_boolean warn_interrupt_nops = TRUE; #define OPTION_NO_UNKNOWN_INTR_NOPS 'U' static bfd_boolean do_unknown_interrupt_nops = TRUE; #define OPTION_MCPU 'c' -#define OPTION_MOVE_DATA 'd' -static bfd_boolean move_data = FALSE; #define OPTION_DATA_REGION 'r' static bfd_boolean upper_data_region_in_use = FALSE; /* The default is to use the lower region only. */ @@ -1467,10 +1465,6 @@ md_parse_option (int c, const char * arg) do_unknown_interrupt_nops = FALSE; return 1; - case OPTION_MOVE_DATA: - move_data = TRUE; - return 1; - case OPTION_DATA_REGION: if (strcmp (arg, "upper") == 0 || strcmp (arg, "either") == 0) @@ -1756,7 +1750,6 @@ struct option md_longopts[] = {"my", no_argument, NULL, OPTION_WARN_INTR_NOPS}, {"mu", no_argument, NULL, OPTION_UNKNOWN_INTR_NOPS}, {"mU", no_argument, NULL, OPTION_NO_UNKNOWN_INTR_NOPS}, - {"md", no_argument, NULL, OPTION_MOVE_DATA}, {"mdata-region", required_argument, NULL, OPTION_DATA_REGION}, {NULL, no_argument, NULL, 0} }; @@ -1794,8 +1787,6 @@ md_show_usage (FILE * stream) _(" -mu - for an instruction which changes interrupt state, but where it is not\n" " known how the state is changed, warn/insert NOPs (default)\n" " -mn and/or -my are required for this to have any effect\n")); - fprintf (stream, - _(" -md - Force copying of data from ROM to RAM at startup\n")); fprintf (stream, _(" -mdata-region={none|lower|upper|either} - select region data will be\n" " placed in.\n")); -- 2.34.1