From ef3ccaa37f28861a5313e85cec3cfe6c4a59ffc5 Mon Sep 17 00:00:00 2001 From: Marc-Andre Laperle Date: Tue, 12 Apr 2016 10:13:36 -0400 Subject: [PATCH] tmf: Fix CopyToClipboardTest The contextMenu method in SWTBot now throws (properly) a WidgetNotFoundException instead of a TimeoutException Change-Id: I9e7b8e469134ed7836923bbdd2d59ae9cf3eff59 Signed-off-by: Marc-Andre Laperle Reviewed-on: https://git.eclipse.org/r/70478 Reviewed-by: Patrick Tasse Tested-by: Patrick Tasse Reviewed-by: Hudson CI --- .../tracecompass-e4.5.target | 2 +- .../tracecompass-e4.6.target | 2 +- .../tracecompass-eStaging.target | 2 +- .../ui/swtbot/tests/viewers/events/CopyToClipboardTest.java | 6 ++---- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/releng/org.eclipse.tracecompass.target/tracecompass-e4.5.target b/releng/org.eclipse.tracecompass.target/tracecompass-e4.5.target index d0744ee2dd..822c26b2c7 100644 --- a/releng/org.eclipse.tracecompass.target/tracecompass-e4.5.target +++ b/releng/org.eclipse.tracecompass.target/tracecompass-e4.5.target @@ -1,5 +1,5 @@ - + diff --git a/releng/org.eclipse.tracecompass.target/tracecompass-e4.6.target b/releng/org.eclipse.tracecompass.target/tracecompass-e4.6.target index 5c1964a5c7..992e0da0d9 100644 --- a/releng/org.eclipse.tracecompass.target/tracecompass-e4.6.target +++ b/releng/org.eclipse.tracecompass.target/tracecompass-e4.6.target @@ -1,5 +1,5 @@ - + diff --git a/releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target b/releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target index 5e7f5bef11..0cd2acf225 100644 --- a/releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target +++ b/releng/org.eclipse.tracecompass.target/tracecompass-eStaging.target @@ -1,5 +1,5 @@ - + diff --git a/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/viewers/events/CopyToClipboardTest.java b/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/viewers/events/CopyToClipboardTest.java index cccd73bc98..244cb8422a 100644 --- a/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/viewers/events/CopyToClipboardTest.java +++ b/tmf/org.eclipse.tracecompass.tmf.ui.swtbot.tests/src/org/eclipse/tracecompass/tmf/ui/swtbot/tests/viewers/events/CopyToClipboardTest.java @@ -34,6 +34,7 @@ import org.eclipse.swt.dnd.TextTransfer; import org.eclipse.swt.widgets.Display; import org.eclipse.swtbot.eclipse.finder.SWTWorkbenchBot; import org.eclipse.swtbot.eclipse.finder.widgets.SWTBotEditor; +import org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException; import org.eclipse.swtbot.swt.finder.finders.UIThreadRunnable; import org.eclipse.swtbot.swt.finder.junit.SWTBotJunit4ClassRunner; import org.eclipse.swtbot.swt.finder.keyboard.Keyboard; @@ -43,7 +44,6 @@ import org.eclipse.swtbot.swt.finder.results.StringResult; import org.eclipse.swtbot.swt.finder.utils.SWTBotPreferences; import org.eclipse.swtbot.swt.finder.waits.DefaultCondition; import org.eclipse.swtbot.swt.finder.widgets.SWTBotTable; -import org.eclipse.swtbot.swt.finder.widgets.TimeoutException; import org.eclipse.tracecompass.tmf.core.tests.TmfCoreTestPlugin; import org.eclipse.tracecompass.tmf.ui.swtbot.tests.shared.SWTBotUtils; import org.junit.After; @@ -207,10 +207,8 @@ public class CopyToClipboardTest { try { SWTBotPreferences.TIMEOUT = 0; tableBot.contextMenu(text); - } catch (TimeoutException e) { + } catch (WidgetNotFoundException e) { return true; - } catch (IndexOutOfBoundsException e) { - /* remove when Bug 474063 is fixed */ } finally { SWTBotPreferences.TIMEOUT = TIMEOUT; } -- 2.34.1