From f59fe7f8e3e55472e6fcfb06677ff4925dad1f64 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 6 Nov 2016 21:23:31 -0700 Subject: [PATCH] Use gdbpy_ref in gdbpy_inferiors This changes gdbpy_inferiors to use gdbpy_ref. 2017-01-10 Tom Tromey * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref. --- gdb/ChangeLog | 4 ++++ gdb/python/py-inferior.c | 18 +++++------------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dc6ef9ab03..330718af4f 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2017-01-10 Tom Tromey + + * python/py-inferior.c (gdbpy_inferiors): Use gdbpy_ref. + 2017-01-10 Tom Tromey * python/py-function.c (convert_values_to_python, fnpy_init): Use diff --git a/gdb/python/py-inferior.c b/gdb/python/py-inferior.c index f5462a4bbe..995a3df264 100644 --- a/gdb/python/py-inferior.c +++ b/gdb/python/py-inferior.c @@ -477,22 +477,14 @@ build_inferior_list (struct inferior *inf, void *arg) PyObject * gdbpy_inferiors (PyObject *unused, PyObject *unused2) { - PyObject *list, *tuple; - - list = PyList_New (0); - if (!list) + gdbpy_ref list (PyList_New (0)); + if (list == NULL) return NULL; - if (iterate_over_inferiors (build_inferior_list, list)) - { - Py_DECREF (list); - return NULL; - } - - tuple = PyList_AsTuple (list); - Py_DECREF (list); + if (iterate_over_inferiors (build_inferior_list, list.get ())) + return NULL; - return tuple; + return PyList_AsTuple (list.get ()); } /* Membuf and memory manipulation. */ -- 2.34.1