From fd622cadedd7b01ebb740930ddd1273ab2a23f31 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Wed, 13 Mar 2019 16:59:06 -0400 Subject: [PATCH] Update exit points comments Signed-off-by: Mathieu Desnoyers --- include/rseq/rseq-arm.h | 9 +++++---- include/rseq/rseq-arm64.h | 9 +++++---- include/rseq/rseq-mips.h | 9 +++++---- include/rseq/rseq-ppc.h | 18 ++++++++++-------- include/rseq/rseq-s390.h | 18 ++++++++++-------- include/rseq/rseq-x86.h | 18 ++++++++++-------- 6 files changed, 45 insertions(+), 36 deletions(-) diff --git a/include/rseq/rseq-arm.h b/include/rseq/rseq-arm.h index d2c7905..19bc16d 100644 --- a/include/rseq/rseq-arm.h +++ b/include/rseq/rseq-arm.h @@ -48,10 +48,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs section and should not be explicitly - * defined as an additional exit point. Knowing all exit points is useful to - * assist debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ diff --git a/include/rseq/rseq-arm64.h b/include/rseq/rseq-arm64.h index fce8978..b5557e1 100644 --- a/include/rseq/rseq-arm64.h +++ b/include/rseq/rseq-arm64.h @@ -100,10 +100,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs section and should not be explicitly - * defined as an additional exit point. Knowing all exit points is useful to - * assist debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ " .pushsection __rseq_exit_point_array, \"aw\"\n" \ diff --git a/include/rseq/rseq-mips.h b/include/rseq/rseq-mips.h index 0cbef5a..08d778f 100644 --- a/include/rseq/rseq-mips.h +++ b/include/rseq/rseq-mips.h @@ -74,10 +74,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs section and should not be explicitly - * defined as an additional exit point. Knowing all exit points is useful to - * assist debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ diff --git a/include/rseq/rseq-ppc.h b/include/rseq/rseq-ppc.h index e8d6310..d3ec53f 100644 --- a/include/rseq/rseq-ppc.h +++ b/include/rseq/rseq-ppc.h @@ -68,10 +68,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs section and should not be explicitly - * defined as an additional exit point. Knowing all exit points is useful to - * assist debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ @@ -100,10 +101,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs and should not be explicitly defined as - * an additional exit point. Knowing all exit points is useful to assist - * debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ diff --git a/include/rseq/rseq-s390.h b/include/rseq/rseq-s390.h index c5be3ef..37cac12 100644 --- a/include/rseq/rseq-s390.h +++ b/include/rseq/rseq-s390.h @@ -49,10 +49,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs section and should not be explicitly - * defined as an additional exit point. Knowing all exit points is useful to - * assist debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ @@ -75,10 +76,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs and should not be explicitly defined as - * an additional exit point. Knowing all exit points is useful to assist - * debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ diff --git a/include/rseq/rseq-x86.h b/include/rseq/rseq-x86.h index 14ba970..295940a 100644 --- a/include/rseq/rseq-x86.h +++ b/include/rseq/rseq-x86.h @@ -54,10 +54,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs section and should not be explicitly - * defined as an additional exit point. Knowing all exit points is useful to - * assist debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ @@ -581,10 +582,11 @@ do { \ /* * Exit points of a rseq critical section consist of all instructions outside - * of the critical section where a critical section can branch to. The abort IP - * is already part of the __rseq_cs section and should not be explicitly - * defined as an additional exit point. Knowing all exit points is useful to - * assist debuggers stepping over the critical section. + * of the critical section where a critical section can either branch to or + * reach through the normal course of its execution. The abort IP and the + * post-commit IP are already part of the __rseq_cs section and should not be + * explicitly defined as additional exit points. Knowing all exit points is + * useful to assist debuggers stepping over the critical section. */ #define RSEQ_ASM_DEFINE_EXIT_POINT(start_ip, exit_ip) \ ".pushsection __rseq_exit_point_array, \"aw\"\n\t" \ -- 2.34.1