From fe10fe3131e688d528877706db1e98e15434c0dc Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Wed, 16 May 2018 11:39:09 -0600 Subject: [PATCH] Initialize py_type_printers in ext_lang_type_printers When running gdb in the build directory without passing --data-directory, I noticed I could provoke a crash by: $ ./gdb -nx ./gdb (gdb) ptype/o struct dwarf2_per_objfile ... and then trying to "q" out at the pagination prompt. valgrind complained about an uninitialized use of py_type_printers. Initializing this member fixes the bug. I believe this bug can occur even when the gdb Python libraries are available, for example if get_type_recognizers fails. Tested by hand on x86-64 Fedora 26. No test case because it seemed difficult to guarantee failures. gdb/ChangeLog 2018-05-17 Tom Tromey * extension.h (struct ext_lang_type_printers) : Initialize. --- gdb/ChangeLog | 5 +++++ gdb/extension.h | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index eb3c5f772f..4ae46c1ae4 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2018-05-17 Tom Tromey + + * extension.h (struct ext_lang_type_printers) : + Initialize. + 2018-05-16 Maciej W. Rozycki PR gdb/22286 diff --git a/gdb/extension.h b/gdb/extension.h index abde5e54e1..0c8c4ee934 100644 --- a/gdb/extension.h +++ b/gdb/extension.h @@ -152,7 +152,7 @@ struct ext_lang_type_printers DISABLE_COPY_AND_ASSIGN (ext_lang_type_printers); /* Type-printers from Python. */ - void *py_type_printers; + void *py_type_printers = nullptr; }; /* The return code for some API calls. */ -- 2.34.1