projects / deliverable / linux.git / search
? search:
summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next
iommu/arm-smmu: Add support for MSI on SMMUv3
2015-10-15  Marc Zyngieriommu/arm-smmu: Add support for MSI on SMMUv3
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-10-09  Marc Zyngierirqdomain: Add an accessor for the of_node field
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1444402211-1141-1-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-10-02  Marc Zyngierirqchip/gic-v3-its: Count additional LPIs for the aliased...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1443800646-8074-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-10-02  Marc Zyngierirqchip/gic-v3-its: Silence warning when its_lpi_alloc_chunk...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1443800646-8074-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-09-17  Marc Zyngierarm: KVM: Disable virtual timer even if the guest is...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-09-17  Marc Zyngierarm64: KVM: Disable virtual timer even if the guest...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-09-16  Marc Zyngierarm64: KVM: Fix user access for debug registers
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-09-15  Marc Zyngierirqchip/gic-v3-its: Add missing cache flushes
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1442142873-20213-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-09-15  Marc Zyngierirqchip/GIC: Add workaround for aliased GIC400
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1442142873-20213-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-09-15  Marc Zyngierplatform-msi: Do not cache msi_desc in handler_data
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1442147824-20971-1-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-09-01  Marc Zyngierirqchip/GIC: Fix EOImode setting for non-DT/ACPI systems
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1441098533-31523-1-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-08-27  Marc Zyngierarm64: KVM: Fix host crash when injecting a fault into...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-27  Marc Zyngierirqchip/GIC: Don't deactivate interrupts forwarded...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1440604845-28229-5-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-08-27  Marc Zyngierirqchip/GIC: Convert to EOImode == 1
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1440604845-28229-4-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-08-27  Marc Zyngierirqchip/GICv3: Don't deactivate interrupts forwarded...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1440604845-28229-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-08-27  Marc Zyngierirqchip/GICv3: Convert to EOImode == 1
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1440604845-28229-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: timer: Allow the timer to control the...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: vgic: Prevent userspace injection of...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: vgic: Add vgic_{get,set}_phys_irq_active
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: vgic: Allow HW interrupts to be queued...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: vgic: Allow dynamic mapping of physical...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: vgic: Relax vgic_can_sample_irq for...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: vgic: Allow HW irq to be encoded in LR
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc ZyngierKVM: arm/arm64: vgic: Convert struct vgic_lr to use...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc Zyngierarm/arm64: KVM: Move vgic handling to a non-preemptible...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-08-12  Marc Zyngierarm/arm64: KVM: Fix ordering of timer/GIC on guest...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-07-31  Marc Zyngieriommu/arm-smmu: Fix MSI memory attributes to match...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-07-31  Marc Zyngieriommu/arm-smmu: Fix enabling of PRIQ interrupt
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-07-29  Marc ZyngierPCI/MSI: Drop domain field from msi_controller
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-20-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc ZyngierPCI/MSI: pci-xgene-msi: Get rid of struct msi_controller
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-19-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierirqchip/GICv2m: Add platform MSI support
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-18-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierirqchip/GICv2m: Get rid of struct msi_controller
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-17-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierirqchip/gicv3-its: Add platform MSI support
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-16-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierirqchip/gicv3-its: Make the PCI/MSI code standalone
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-15-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierirqchip/gicv3-its: Get rid of struct msi_controller
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-14-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierirqchip/gicv3-its: Register irq domain with NEXUS token
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-13-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierirqchip/gicv3-its: Split PCI/MSI code from the core...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-12-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngiergenirq: Add DOMAIN_BUS_NEXUS irqdomain property
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-11-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierdrivers/base: Add MSI domain support for non-PCI devices
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-10-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierof/platform: Assign MSI domain to platform device
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-9-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc ZyngierPCI/MSI: Let pci_msi_get_domain use struct device:...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-8-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc ZyngierPCI/MSI: Allow msi_domain lookup using the host bridge...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-7-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc ZyngierPCI/MSI: Add support for OF-provided msi_domain
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-6-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc ZyngierPCI/MSI: Add hooks to populate the msi_domain field
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-5-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngierdevice core: Introduce per-device MSI domain pointer
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-4-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc ZyngierPCI/MSI: Register irq domain with specific token
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-29  Marc Zyngiergenirq/irqdomain: Allow irq domain aliasing
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1438091186-10244-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-07-17  Marc Zyngierirqchip/gicv3-its: Fix mapping of LPIs to collections
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1437126402-11677-1-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-06-18  Marc ZyngierKVM: arm/arm64: vgic: Remove useless arm-gic.h #include
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-17  Marc ZyngierKVM: arm/arm64: vgic: Avoid injecting reserved IRQ...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-17  Marc Zyngierarm/arm64: KVM: vgic: Do not save GICH_HCR / ICH_HCR_EL2
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-17  Marc ZyngierKVM: arm: vgic: Drop useless Group0 warning
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-17  Marc Zyngierarm: KVM: force execution of HCPTR access on VM exit
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-12  Marc Zyngierarm64: KVM: Switch vgic save/restore to alternative_insn
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-12  Marc Zyngierarm64: alternative: Introduce feature for GICv3 CPU...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-05  Marc Zyngierarm64: alternative: Work around .inst assembler bugs
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-05  Marc Zyngierarm64: alternative: Merge alternative-asm.h into alternative.h
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-05  Marc Zyngierarm64: alternative: Allow immediate branch as alternative...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-05  Marc Zyngierarm64: Rework alternate sequence for ARM erratum 845719
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-03  Marc Zyngierarm64: insn: Add aarch64_{get,set}_branch_offset
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-06-01  Marc ZyngierARM: exynos: Fix wake-up interrupts for Exynos3250
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-04-24  Marc Zyngierirqchip: gic: Drop support for gic_arch_extn
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-04-08  Marc Zyngierirqchip: GICv3: Add support for irq_[get, set]_irqchip_state()
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426676484-21812-4-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-04-08  Marc Zyngierirqchip: GIC: Add support for irq_[get, set]_irqchip_state()
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426676484-21812-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-04-08  Marc Zyngiergenirq: Allow the irqchip state of an IRQ to be save...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426676484-21812-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-04-08  Marc Zyngiergenirq: MSI: Fix freeing of unallocated MSI
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1422299419-6051-1-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-30  Marc Zyngierarm64: Extract feature parsing code from cpu_errata.c
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-30  Marc Zyngierarm64: alternative: Allow immediate branch as alternative...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-30  Marc Zyngierarm64: insn: Add aarch64_insn_decode_immediate
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-30  Marc ZyngierARM: imx6: Warn when an old DT is detected
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-30  Marc ZyngierARM: imx6: Allow GPC interrupts affinity to be changed
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-30  Marc ZyngierARM: imx6: convert GPC to stacked domains
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-29  Marc Zyngierirqchip: gicv3-its: Use non-cacheable accesses when...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1427465705-17126-5-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-29  Marc Zyngierirqchip: gicv3-its: Fix PROP/PEND and BASE/CBASE confusion
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1427465705-17126-4-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-29  Marc Zyngierirqchip: gicv3-its: Fix encoding of collection's target...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1427465705-17126-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-19  Marc Zyngierarm64: Get rid of struct cpu_table
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-18  Marc ZyngierDT: exynos: update PMU binding
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088693-15724-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-18  Marc ZyngierARM: exynos4/5: convert pmu wakeup to stacked domains
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088693-15724-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: zynq: switch from gic_arch_extn to gic_set_irqchip_flags
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088737-15817-5-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: ux500: switch from gic_arch_extn to gic_set_irqchip_flags
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088737-15817-4-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: shmobile: remove use of gic_arch_extn.irq_set_wake
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088737-15817-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc Zyngierirqchip: gic: Add an entry point to set up irqchip...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088737-15817-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: omap: convert wakeupgen to stacked domains
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088629-15377-8-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierDT: omap4/5: add binding for the wake-up generator
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088629-15377-7-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierDT: arm,gic: kill arm,routable-irqs
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088629-15377-6-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc Zyngierirqchip: gic: Get rid of routable domain
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088629-15377-5-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierDT: update ti,irq-crossbar binding
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088629-15377-4-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc Zyngierirqchip: crossbar: Convert dra7 crossbar to stacked...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088629-15377-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc Zyngiergenirq: Add irqchip_set_wake_parent
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088629-15377-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: tegra: remove old LIC support
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088583-15097-7-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierDT: tegra: add binding for the legacy interrupt controller
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088583-15097-6-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: tegra: update DTs to expose legacy interrupt controller
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088583-15097-5-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: tegra: skip gic_arch_extn setup if DT has a LIC...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088583-15097-4-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc Zyngierirqchip: tegra: Add DT-based support for legacy interrupt...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088583-15097-3-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-15  Marc ZyngierARM: tegra: irq: nuke leftovers from non-DT support
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
...1426088583-15097-2-git-send-email-marc.zyngier@arm.com
 commit | commitdiff | tree
2015-03-12  Marc Zyngierarm/arm64: KVM: Optimize handling of Access Flag faults
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-12  Marc Zyngierarm/arm64: KVM: Implement Stage-2 page aging
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-12  Marc Zyngierarm/arm64: KVM: Allow handle_hva_to_gpa to return a...
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-11  Marc Zyngierarm64: KVM: Fix outdated comment about VTCR_EL2.PS
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
2015-03-11  Marc Zyngierarm64: KVM: Do not use pgd_index to index stage-2 pgd
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
 commit | commitdiff | tree
next
Linux kernel - Deliverables
This page took 1.50098 seconds and 4 git commands to generate.